From ca5e786c65295684b616149208ffa3c536f14d2b Mon Sep 17 00:00:00 2001 From: archmoj Date: Fri, 3 Sep 2021 09:09:34 -0400 Subject: [PATCH 1/2] drop failing npm ls --- .circleci/env_build.sh | 3 +-- package.json | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.circleci/env_build.sh b/.circleci/env_build.sh index 3a0ece86750..be2229e912c 100755 --- a/.circleci/env_build.sh +++ b/.circleci/env_build.sh @@ -2,5 +2,4 @@ export NODE_OPTIONS='--max-old-space-size=4096' && \ echo "node version: $(node --version)" && \ echo "npm version: $(npm --version)" && \ -npm ci && \ -npm ls || true +npm ci diff --git a/package.json b/package.json index 8edc735ffca..9637c01d266 100644 --- a/package.json +++ b/package.json @@ -56,7 +56,7 @@ "start": "node devtools/test_dashboard/server.js", "baseline": "node test/image/make_baseline.js", "noci-baseline": "npm run cibuild && ./tasks/noci_test.sh image && git checkout dist && echo 'Please do not commit unless the change was expected!'", - "preversion": "check-node-version --node 14 --npm 6.14 && npm-link-check && npm ls --prod", + "preversion": "check-node-version --node 14 --npm 6.14 && npm-link-check", "version": "npm run build && npm run no-bad-char && git add -A lib dist build src/version.js", "postversion": "node -e \"console.log('Version bumped and committed. If ok, run: git push && git push --tags')\"", "postpublish": "node tasks/sync_packages.js", From 24c1194c69e389dc70f621eec2de67a588694613 Mon Sep 17 00:00:00 2001 From: archmoj Date: Fri, 3 Sep 2021 10:20:38 -0400 Subject: [PATCH 2/2] mention PR 5921 in 5888 draft log --- draftlogs/5888_add.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draftlogs/5888_add.md b/draftlogs/5888_add.md index fed8e940075..8ff6277a657 100644 --- a/draftlogs/5888_add.md +++ b/draftlogs/5888_add.md @@ -1,2 +1,2 @@ - Add `surface`, `isosurface`, `volume`, `streamtube`, `cone`, `mesh3d`, `scatter3d`, `pointcloud` - and `heatmapgl` to the "strict" bundle by avoid function generation for these traces at runtime [[#5888](https://github.com/plotly/plotly.js/pull/5888)] + and `heatmapgl` to the "strict" bundle by avoid function generation for these traces at runtime [[#5888](https://github.com/plotly/plotly.js/pull/5888), [#5921](https://github.com/plotly/plotly.js/pull/5921)]