From 58b2f64e5f55a2173b32927000461000c7e1f402 Mon Sep 17 00:00:00 2001 From: archmoj Date: Thu, 20 May 2021 19:26:01 -0400 Subject: [PATCH 1/3] adjust parcoords constraintrange valType - validate parcoords mocks --- src/traces/parcoords/attributes.js | 4 ++-- tasks/test_mock.js | 6 ------ .../mocks/gl2d_parcoords_out-of-range_selected-all.json | 6 ++---- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/src/traces/parcoords/attributes.js b/src/traces/parcoords/attributes.js index 38ec6167c94..3dbe1670d09 100644 --- a/src/traces/parcoords/attributes.js +++ b/src/traces/parcoords/attributes.js @@ -96,8 +96,8 @@ module.exports = { freeLength: true, dimensions: '1-2', items: [ - {valType: 'number', editType: 'plot'}, - {valType: 'number', editType: 'plot'} + {valType: 'any', editType: 'plot'}, + {valType: 'any', editType: 'plot'} ], editType: 'plot', description: [ diff --git a/tasks/test_mock.js b/tasks/test_mock.js index 0503ef8796b..82cf6aeabcc 100644 --- a/tasks/test_mock.js +++ b/tasks/test_mock.js @@ -162,12 +162,6 @@ function notBlackListed(name) { 'gl2d_fonts', 'gl2d_layout_image', 'gl2d_marker_coloraxis', - 'gl2d_parcoords_256_colors', - 'gl2d_parcoords_constraints', - 'gl2d_parcoords_out-of-range_selected-above-below', - 'gl2d_parcoords_out-of-range_selected-all', - 'gl2d_parcoords_out-of-range_selected-below', - 'gl2d_parcoords_select_first_last_enum', 'gl2d_pointcloud-basic', 'gl2d_rgb_dont_accept_alpha_scattergl', 'gl2d_scatter-marker-line-colorscales', diff --git a/test/image/mocks/gl2d_parcoords_out-of-range_selected-all.json b/test/image/mocks/gl2d_parcoords_out-of-range_selected-all.json index b98c6d88d82..225d5092e41 100644 --- a/test/image/mocks/gl2d_parcoords_out-of-range_selected-all.json +++ b/test/image/mocks/gl2d_parcoords_out-of-range_selected-all.json @@ -19,10 +19,8 @@ { "label": "A", "constraintrange": [ - [ - 2.5, - 10 - ] + 2.5, + 10 ], "values": [ 1, From a3274c6c9285d6511ceef8a37b386fb09bd7437f Mon Sep 17 00:00:00 2001 From: archmoj Date: Wed, 7 Jul 2021 14:46:35 -0400 Subject: [PATCH 2/3] reflect schema changes --- test/plot-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/plot-schema.json b/test/plot-schema.json index 2066f2ad50c..7d1c2b3857c 100644 --- a/test/plot-schema.json +++ b/test/plot-schema.json @@ -37750,11 +37750,11 @@ "items": [ { "editType": "plot", - "valType": "number" + "valType": "any" }, { "editType": "plot", - "valType": "number" + "valType": "any" } ], "valType": "info_array" From f0ff80d3cd2b98966271d7c69ac70fd06cd2bcb5 Mon Sep 17 00:00:00 2001 From: archmoj Date: Sat, 17 Jul 2021 10:12:30 -0400 Subject: [PATCH 3/3] draft log for PR 5673 --- draftlogs/5673_change.md | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 draftlogs/5673_change.md diff --git a/draftlogs/5673_change.md b/draftlogs/5673_change.md new file mode 100644 index 00000000000..e9a2a968f23 --- /dev/null +++ b/draftlogs/5673_change.md @@ -0,0 +1,2 @@ + - Relax the valType of `constraintrange` in `parcoords` trace [[#5673](https://github.com/plotly/plotly.js/pull/5673)] +