diff --git a/src/plots/cartesian/autorange.js b/src/plots/cartesian/autorange.js index 50a58a401d3..b65a0f2e51f 100644 --- a/src/plots/cartesian/autorange.js +++ b/src/plots/cartesian/autorange.js @@ -223,14 +223,10 @@ function makePadFn(fullLayout, ax, max) { if(axReverse) max = !max; } - var A = 0; - var B = 0; + var zero = 0; if(!isLinked(fullLayout, ax._id)) { - A = padInsideLabelsOnAnchorAxis(ax, max); - B = padInsideLabelsOnThisAxis(ax, max); + zero = padInsideLabelsOnAnchorAxis(ax, max); } - - var zero = Math.max(A, B); extrappad = Math.max(zero, extrappad); // domain-constrained axes: base extrappad on the unconstrained @@ -248,41 +244,6 @@ function makePadFn(fullLayout, ax, max) { var TEXTPAD = 3; -function padInsideLabelsOnThisAxis(ax, max) { - var ticklabelposition = ax.ticklabelposition || ''; - var has = function(str) { - return ticklabelposition.indexOf(str) !== -1; - }; - - if(!has('inside')) return 0; - var isTop = has('top'); - var isLeft = has('left'); - var isRight = has('right'); - var isBottom = has('bottom'); - var isAligned = isBottom || isLeft || isTop || isRight; - - if( - (max && (isLeft || isBottom)) || - (!max && (isRight || isTop)) - ) { - return 0; - } - - // increase padding to make more room for inside tick labels of the axis - var fontSize = ax.tickfont ? ax.tickfont.size : 12; - var isX = ax._id.charAt(0) === 'x'; - var pad = (isX ? 1.2 : 0.6) * fontSize; - - if(isAligned) { - pad *= 2; - pad += (ax.tickwidth || 0) / 2; - } - - pad += TEXTPAD; - - return pad; -} - function padInsideLabelsOnAnchorAxis(ax, max) { var pad = 0; var anchorAxis = ax._anchorAxis || {}; diff --git a/test/image/baselines/ticklabelposition-1.png b/test/image/baselines/ticklabelposition-1.png index 8bd8b4f3757..0f1e12500f1 100644 Binary files a/test/image/baselines/ticklabelposition-1.png and b/test/image/baselines/ticklabelposition-1.png differ diff --git a/test/image/baselines/ticklabelposition-2.png b/test/image/baselines/ticklabelposition-2.png index 92a062241ea..3b1741078e1 100644 Binary files a/test/image/baselines/ticklabelposition-2.png and b/test/image/baselines/ticklabelposition-2.png differ diff --git a/test/image/baselines/ticklabelposition-3.png b/test/image/baselines/ticklabelposition-3.png index a1af77385e1..b611877fc94 100644 Binary files a/test/image/baselines/ticklabelposition-3.png and b/test/image/baselines/ticklabelposition-3.png differ diff --git a/test/image/baselines/ticklabelposition-4.png b/test/image/baselines/ticklabelposition-4.png index a7d009bc280..3ea9821027f 100644 Binary files a/test/image/baselines/ticklabelposition-4.png and b/test/image/baselines/ticklabelposition-4.png differ diff --git a/test/image/baselines/ticklabelposition-5.png b/test/image/baselines/ticklabelposition-5.png index 87dcd501840..63bbb6333b1 100644 Binary files a/test/image/baselines/ticklabelposition-5.png and b/test/image/baselines/ticklabelposition-5.png differ diff --git a/test/image/baselines/ticklabelposition-6.png b/test/image/baselines/ticklabelposition-6.png index ae129c253c8..5c3baa54acb 100644 Binary files a/test/image/baselines/ticklabelposition-6.png and b/test/image/baselines/ticklabelposition-6.png differ diff --git a/test/image/baselines/ticklabelposition-a.png b/test/image/baselines/ticklabelposition-a.png index 231ee71aa4d..e1b33ec3ba6 100644 Binary files a/test/image/baselines/ticklabelposition-a.png and b/test/image/baselines/ticklabelposition-a.png differ diff --git a/test/image/baselines/ticklabelposition-b.png b/test/image/baselines/ticklabelposition-b.png index 8be06c3ae02..7f3e5b73bff 100644 Binary files a/test/image/baselines/ticklabelposition-b.png and b/test/image/baselines/ticklabelposition-b.png differ diff --git a/test/image/baselines/ticklabelposition-c.png b/test/image/baselines/ticklabelposition-c.png index 27df61d8e55..254313adf02 100644 Binary files a/test/image/baselines/ticklabelposition-c.png and b/test/image/baselines/ticklabelposition-c.png differ diff --git a/test/image/baselines/ticklabelposition-d.png b/test/image/baselines/ticklabelposition-d.png index d973e3fb13f..30765e2817a 100644 Binary files a/test/image/baselines/ticklabelposition-d.png and b/test/image/baselines/ticklabelposition-d.png differ