From 5e84bf74b9c63314f3f3f01f07b8fdaea9b39cb2 Mon Sep 17 00:00:00 2001 From: archmoj Date: Thu, 18 Apr 2019 15:19:50 -0400 Subject: [PATCH 1/5] set new eslint rule --- .eslintrc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index c03a5bd58aa..349e641a9e8 100644 --- a/.eslintrc +++ b/.eslintrc @@ -70,6 +70,7 @@ "no-loop-func": [2], "no-console": [0], "no-unused-labels": [2], - "no-useless-escape": [0] + "no-useless-escape": [0], + "func-names": ["error", "never"] } } From 21bdf7832fb60030447f54ff5d2e7eb91d29cc77 Mon Sep 17 00:00:00 2001 From: archmoj Date: Thu, 18 Apr 2019 15:21:32 -0400 Subject: [PATCH 2/5] apply new lint rule in various files --- src/components/annotations/calc_autorange.js | 2 +- src/components/annotations/common_defaults.js | 2 +- src/components/annotations/convert_coords.js | 2 +- src/components/annotations/defaults.js | 2 +- src/components/annotations/draw_arrow_head.js | 2 +- src/components/annotations3d/convert.js | 2 +- src/components/annotations3d/defaults.js | 2 +- src/components/annotations3d/draw.js | 2 +- src/components/colorbar/connect.js | 2 +- src/components/colorbar/defaults.js | 2 +- src/components/colorbar/draw.js | 2 +- src/components/colorbar/has_colorbar.js | 2 +- src/components/colorscale/attributes.js | 2 +- src/components/colorscale/calc.js | 2 +- .../colorscale/cross_trace_defaults.js | 2 +- src/components/colorscale/defaults.js | 2 +- src/components/colorscale/layout_defaults.js | 2 +- src/components/dragelement/align.js | 2 +- src/components/dragelement/cursor.js | 2 +- src/components/dragelement/index.js | 2 +- src/components/dragelement/unhover.js | 2 +- src/components/errorbars/calc.js | 2 +- src/components/errorbars/compute_error.js | 10 +++++----- src/components/errorbars/plot.js | 2 +- src/components/errorbars/style.js | 2 +- src/components/fx/calc.js | 2 +- src/components/fx/click.js | 2 +- src/components/fx/defaults.js | 2 +- src/components/fx/helpers.js | 18 +++++++++--------- src/components/fx/hover.js | 4 ++-- src/components/fx/hoverlabel_defaults.js | 2 +- src/components/fx/layout_defaults.js | 2 +- src/components/fx/layout_global_defaults.js | 2 +- src/components/images/convert_coords.js | 2 +- src/components/images/defaults.js | 2 +- src/components/images/draw.js | 2 +- src/components/legend/anchor_utils.js | 8 ++++---- src/components/legend/defaults.js | 2 +- src/components/legend/draw.js | 2 +- src/components/legend/get_legend_data.js | 2 +- src/components/legend/handle_click.js | 2 +- src/components/legend/helpers.js | 6 +++--- src/components/legend/style.js | 2 +- src/components/modebar/manage.js | 2 +- src/components/rangeselector/defaults.js | 2 +- src/components/rangeselector/draw.js | 2 +- .../rangeselector/get_update_object.js | 2 +- src/components/rangeslider/calc_autorange.js | 2 +- src/components/rangeslider/defaults.js | 2 +- src/components/shapes/calc_autorange.js | 2 +- src/components/shapes/defaults.js | 2 +- src/components/shapes/draw.js | 8 ++++---- src/components/sliders/defaults.js | 2 +- src/components/sliders/draw.js | 2 +- src/components/updatemenus/defaults.js | 2 +- src/components/updatemenus/draw.js | 2 +- src/components/updatemenus/scrollbox.js | 12 ++++++------ src/lib/anchor_utils.js | 12 ++++++------ src/lib/clean_number.js | 2 +- src/lib/clear_gl_canvases.js | 2 +- src/lib/clear_responsive.js | 2 +- src/lib/filter_unique.js | 2 +- src/lib/filter_visible.js | 2 +- src/lib/geometry2d.js | 8 ++++---- src/lib/identity.js | 2 +- src/lib/index.js | 8 ++++---- src/lib/is_plain_object.js | 2 +- src/lib/keyed_container.js | 2 +- src/lib/localize.js | 2 +- src/lib/make_trace_groups.js | 2 +- src/lib/nested_property.js | 2 +- src/lib/noop.js | 2 +- src/lib/override_cursor.js | 2 +- src/lib/polygon.js | 6 +++--- src/lib/prepare_regl.js | 2 +- src/lib/push_unique.js | 2 +- src/lib/queue.js | 4 ++-- src/lib/relink_private.js | 6 ++++-- src/lib/setcursor.js | 2 +- src/lib/show_no_webgl_msg.js | 2 +- src/lib/svg_text_utils.js | 4 ++-- src/lib/throttle.js | 4 ++-- src/lib/to_log_range.js | 2 +- src/plot_api/container_array_match.js | 2 +- src/plot_api/manage_arrays.js | 6 +++--- src/plot_api/plot_api.js | 6 +++--- src/plot_api/validate.js | 2 +- src/plots/array_container_defaults.js | 2 +- src/plots/cartesian/autorange.js | 2 +- src/plots/cartesian/axes.js | 2 +- src/plots/cartesian/axis_autotype.js | 2 +- src/plots/cartesian/axis_defaults.js | 2 +- src/plots/cartesian/axis_ids.js | 8 ++++---- src/plots/cartesian/category_order_defaults.js | 2 +- src/plots/cartesian/constraints.js | 4 ++-- src/plots/cartesian/graph_interact.js | 2 +- src/plots/cartesian/include_components.js | 4 ++-- src/plots/cartesian/layout_defaults.js | 2 +- src/plots/cartesian/line_grid_defaults.js | 2 +- src/plots/cartesian/position_defaults.js | 2 +- src/plots/cartesian/scale_zoom.js | 2 +- src/plots/cartesian/set_convert.js | 2 +- src/plots/cartesian/tick_label_defaults.js | 2 +- src/plots/cartesian/tick_mark_defaults.js | 2 +- src/plots/cartesian/tick_value_defaults.js | 2 +- src/plots/cartesian/transition_axes.js | 2 +- src/plots/cartesian/type_defaults.js | 2 +- src/plots/command.js | 6 +++--- src/plots/geo/geo.js | 2 +- src/plots/geo/layout_defaults.js | 2 +- src/plots/get_data.js | 2 +- src/plots/gl2d/index.js | 2 +- src/plots/gl3d/index.js | 4 ++-- src/plots/gl3d/layout/axis_defaults.js | 2 +- src/plots/gl3d/layout/defaults.js | 2 +- src/plots/gl3d/scene.js | 6 +++--- src/plots/gl3d/zip3.js | 2 +- src/plots/mapbox/convert_text_opts.js | 2 +- src/plots/mapbox/index.js | 2 +- src/plots/mapbox/layers.js | 6 +++--- src/plots/mapbox/layout_defaults.js | 2 +- src/plots/mapbox/mapbox.js | 2 +- src/plots/plots.js | 2 +- src/plots/polar/layout_defaults.js | 2 +- src/plots/polar/legacy/undo_manager.js | 2 +- src/plots/polar/polar.js | 2 +- src/plots/polar/set_convert.js | 2 +- src/plots/subplot_defaults.js | 2 +- src/plots/ternary/index.js | 2 +- src/plots/ternary/layout_defaults.js | 2 +- src/registry.js | 2 +- src/snapshot/cloneplot.js | 2 +- src/snapshot/tosvg.js | 2 +- src/traces/bar/arrays_to_calcdata.js | 2 +- src/traces/bar/calc.js | 2 +- src/traces/bar/plot.js | 2 +- src/traces/bar/select.js | 2 +- src/traces/bar/sieve.js | 6 +++--- src/traces/bar/style_defaults.js | 2 +- src/traces/barpolar/defaults.js | 2 +- src/traces/barpolar/hover.js | 2 +- src/traces/barpolar/plot.js | 2 +- src/traces/box/calc.js | 2 +- src/traces/box/event_data.js | 2 +- src/traces/box/select.js | 2 +- src/traces/candlestick/defaults.js | 2 +- src/traces/carpet/ab_defaults.js | 2 +- src/traces/carpet/axis_defaults.js | 2 +- src/traces/carpet/calc.js | 2 +- src/traces/carpet/calc_clippath.js | 2 +- src/traces/carpet/calc_gridlines.js | 2 +- src/traces/carpet/calc_labels.js | 2 +- src/traces/carpet/catmull_rom.js | 2 +- src/traces/carpet/compute_control_points.js | 2 +- src/traces/carpet/defaults.js | 2 +- src/traces/carpet/makepath.js | 2 +- src/traces/carpet/map_1d_array.js | 2 +- src/traces/carpet/orient_text.js | 2 +- src/traces/carpet/plot.js | 2 +- src/traces/carpet/set_convert.js | 2 +- src/traces/carpet/smooth_fill_2d_array.js | 2 +- src/traces/carpet/smooth_fill_array.js | 2 +- src/traces/carpet/xy_defaults.js | 2 +- src/traces/choropleth/calc.js | 2 +- src/traces/choropleth/defaults.js | 2 +- src/traces/choropleth/event_data.js | 2 +- src/traces/choropleth/hover.js | 2 +- src/traces/choropleth/plot.js | 2 +- src/traces/choropleth/select.js | 2 +- src/traces/cone/calc.js | 2 +- src/traces/cone/defaults.js | 2 +- src/traces/contour/calc.js | 2 +- src/traces/contour/colorbar.js | 2 +- src/traces/contour/constraint_defaults.js | 2 +- src/traces/contour/contours_defaults.js | 2 +- src/traces/contour/defaults.js | 2 +- src/traces/contour/empty_pathinfo.js | 2 +- src/traces/contour/end_plus.js | 2 +- src/traces/contour/find_all_paths.js | 2 +- src/traces/contour/hover.js | 2 +- src/traces/contour/label_defaults.js | 2 +- src/traces/contour/make_color_map.js | 2 +- src/traces/contour/make_crossings.js | 2 +- src/traces/contour/plot.js | 2 +- src/traces/contour/set_contours.js | 2 +- src/traces/contour/style.js | 2 +- src/traces/contour/style_defaults.js | 2 +- src/traces/contourcarpet/calc.js | 2 +- src/traces/contourcarpet/defaults.js | 2 +- src/traces/contourcarpet/join_all_paths.js | 2 +- src/traces/contourcarpet/map_pathinfo.js | 2 +- src/traces/contourcarpet/plot.js | 2 +- src/traces/heatmap/calc.js | 2 +- src/traces/heatmap/clean_2d_array.js | 2 +- src/traces/heatmap/convert_column_xyz.js | 2 +- src/traces/heatmap/defaults.js | 2 +- src/traces/heatmap/find_empties.js | 2 +- src/traces/heatmap/hover.js | 2 +- src/traces/heatmap/interp2d.js | 2 +- src/traces/heatmap/make_bound_array.js | 2 +- src/traces/heatmap/style.js | 2 +- src/traces/heatmap/style_defaults.js | 2 +- src/traces/heatmap/xyz_defaults.js | 2 +- src/traces/histogram/average.js | 2 +- src/traces/histogram/bin_attributes.js | 2 +- src/traces/histogram/bin_label_vals.js | 2 +- src/traces/histogram/calc.js | 2 +- src/traces/histogram/cross_trace_defaults.js | 2 +- src/traces/histogram/defaults.js | 2 +- src/traces/histogram/event_data.js | 2 +- src/traces/histogram/hover.js | 2 +- src/traces/histogram2d/calc.js | 2 +- src/traces/histogram2d/cross_trace_defaults.js | 2 +- src/traces/histogram2d/defaults.js | 2 +- src/traces/histogram2d/hover.js | 2 +- src/traces/histogram2d/sample_defaults.js | 2 +- src/traces/histogram2dcontour/defaults.js | 2 +- src/traces/isosurface/calc.js | 2 +- src/traces/mesh3d/calc.js | 2 +- src/traces/mesh3d/defaults.js | 2 +- src/traces/ohlc/defaults.js | 2 +- src/traces/ohlc/ohlc_defaults.js | 2 +- src/traces/ohlc/plot.js | 2 +- src/traces/ohlc/select.js | 2 +- src/traces/ohlc/style.js | 2 +- src/traces/parcats/calc.js | 2 +- src/traces/parcats/defaults.js | 2 +- src/traces/parcats/plot.js | 2 +- src/traces/parcoords/axisbrush.js | 2 +- src/traces/parcoords/calc.js | 2 +- src/traces/parcoords/defaults.js | 2 +- src/traces/parcoords/plot.js | 4 ++-- src/traces/pie/calc.js | 2 +- src/traces/pie/defaults.js | 2 +- src/traces/pie/event_data.js | 2 +- src/traces/pie/helpers.js | 8 ++++---- src/traces/pie/layout_defaults.js | 2 +- src/traces/pie/style.js | 2 +- src/traces/pie/style_one.js | 2 +- src/traces/pointcloud/defaults.js | 2 +- src/traces/sankey/calc.js | 2 +- src/traces/sankey/defaults.js | 2 +- src/traces/sankey/plot.js | 2 +- src/traces/sankey/render.js | 2 +- src/traces/sankey/select.js | 2 +- src/traces/scatter/arrays_to_calcdata.js | 2 +- src/traces/scatter/calc_selection.js | 2 +- src/traces/scatter/colorscale_calc.js | 2 +- src/traces/scatter/cross_trace_calc.js | 2 +- src/traces/scatter/cross_trace_defaults.js | 2 +- src/traces/scatter/defaults.js | 2 +- src/traces/scatter/fill_hover_text.js | 2 +- src/traces/scatter/fillcolor_defaults.js | 2 +- src/traces/scatter/get_trace_color.js | 2 +- src/traces/scatter/hover.js | 2 +- src/traces/scatter/line_defaults.js | 2 +- src/traces/scatter/line_points.js | 2 +- src/traces/scatter/line_shape_defaults.js | 2 +- src/traces/scatter/link_traces.js | 2 +- src/traces/scatter/make_bubble_size_func.js | 2 +- src/traces/scatter/marker_defaults.js | 2 +- src/traces/scatter/plot.js | 2 +- src/traces/scatter/select.js | 2 +- src/traces/scatter/stack_defaults.js | 2 +- src/traces/scatter/xy_defaults.js | 2 +- src/traces/scatter3d/calc.js | 2 +- src/traces/scatter3d/defaults.js | 2 +- src/traces/scattercarpet/calc.js | 2 +- src/traces/scattercarpet/defaults.js | 2 +- src/traces/scattercarpet/event_data.js | 2 +- src/traces/scattercarpet/hover.js | 2 +- src/traces/scattercarpet/plot.js | 2 +- src/traces/scattergeo/calc.js | 2 +- src/traces/scattergeo/defaults.js | 2 +- src/traces/scattergeo/event_data.js | 2 +- src/traces/scattergeo/hover.js | 2 +- src/traces/scattergeo/plot.js | 2 +- src/traces/scattergeo/select.js | 2 +- src/traces/scattergeo/style.js | 2 +- src/traces/scattergl/defaults.js | 2 +- src/traces/scattergl/index.js | 8 ++++---- src/traces/scattermapbox/convert.js | 2 +- src/traces/scattermapbox/defaults.js | 2 +- src/traces/scattermapbox/event_data.js | 2 +- src/traces/scattermapbox/hover.js | 2 +- src/traces/scattermapbox/plot.js | 6 +++--- src/traces/scattermapbox/select.js | 2 +- src/traces/scatterpolar/calc.js | 2 +- src/traces/scatterpolar/plot.js | 2 +- src/traces/scatterpolargl/defaults.js | 2 +- src/traces/scatterternary/calc.js | 2 +- src/traces/scatterternary/defaults.js | 2 +- src/traces/scatterternary/event_data.js | 2 +- src/traces/scatterternary/hover.js | 2 +- src/traces/scatterternary/plot.js | 2 +- src/traces/splom/defaults.js | 2 +- src/traces/splom/index.js | 4 ++-- src/traces/streamtube/calc.js | 2 +- src/traces/streamtube/defaults.js | 2 +- src/traces/sunburst/defaults.js | 2 +- src/traces/sunburst/layout_defaults.js | 2 +- src/traces/surface/calc.js | 2 +- src/traces/surface/defaults.js | 2 +- src/traces/table/calc.js | 2 +- src/traces/table/data_preparation_helper.js | 2 +- src/traces/table/defaults.js | 2 +- src/traces/table/plot.js | 8 ++++---- src/traces/violin/calc.js | 2 +- src/traces/violin/cross_trace_calc.js | 2 +- src/traces/violin/defaults.js | 2 +- src/traces/violin/hover.js | 2 +- src/traces/violin/layout_defaults.js | 2 +- src/traces/violin/plot.js | 2 +- src/traces/violin/style.js | 2 +- src/traces/volume/defaults.js | 2 +- src/traces/waterfall/calc.js | 2 +- src/traces/waterfall/cross_trace_calc.js | 2 +- src/traces/waterfall/hover.js | 2 +- src/traces/waterfall/plot.js | 2 +- tasks/util/browserify_wrapper.js | 2 +- tasks/util/make_schema.js | 2 +- tasks/util/pull_css.js | 2 +- tasks/util/pull_font_svg.js | 2 +- tasks/util/update_version.js | 2 +- tasks/util/watchified_bundle.js | 2 +- tasks/util/wrap_locale.js | 2 +- test/image/assets/get_image_paths.js | 2 +- test/image/assets/get_image_request_options.js | 2 +- test/image/assets/get_mock_list.js | 2 +- test/jasmine/assets/check_component.js | 2 +- test/jasmine/assets/check_event_data.js | 2 +- test/jasmine/assets/check_overlap.js | 2 +- test/jasmine/assets/click.js | 2 +- test/jasmine/assets/create_graph_div.js | 2 +- test/jasmine/assets/custom_matchers.js | 4 ++-- test/jasmine/assets/delay.js | 2 +- test/jasmine/assets/destroy_graph_div.js | 2 +- test/jasmine/assets/double_click.js | 2 +- test/jasmine/assets/fail_test.js | 2 +- test/jasmine/assets/get_bbox.js | 2 +- test/jasmine/assets/get_client_position.js | 2 +- test/jasmine/assets/get_rect_center.js | 2 +- test/jasmine/assets/hover.js | 2 +- test/jasmine/assets/modebar_button.js | 2 +- test/jasmine/assets/supply_defaults.js | 2 +- test/jasmine/assets/timed_click.js | 2 +- test/jasmine/assets/transitions.js | 2 +- test/jasmine/assets/unpolyfill.js | 4 ++-- 348 files changed, 426 insertions(+), 424 deletions(-) diff --git a/src/components/annotations/calc_autorange.js b/src/components/annotations/calc_autorange.js index 60c5905dc7b..f468be95162 100644 --- a/src/components/annotations/calc_autorange.js +++ b/src/components/annotations/calc_autorange.js @@ -15,7 +15,7 @@ var Axes = require('../../plots/cartesian/axes'); var draw = require('./draw').draw; -module.exports = function calcAutorange(gd) { +module.exports = function(gd) { var fullLayout = gd._fullLayout; var annotationList = Lib.filterVisible(fullLayout.annotations); diff --git a/src/components/annotations/common_defaults.js b/src/components/annotations/common_defaults.js index fa4cd0981d7..3a096c6e06f 100644 --- a/src/components/annotations/common_defaults.js +++ b/src/components/annotations/common_defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var Color = require('../color'); // defaults common to 'annotations' and 'annotations3d' -module.exports = function handleAnnotationCommonDefaults(annIn, annOut, fullLayout, coerce) { +module.exports = function(annIn, annOut, fullLayout, coerce) { coerce('opacity'); var bgColor = coerce('bgcolor'); diff --git a/src/components/annotations/convert_coords.js b/src/components/annotations/convert_coords.js index d64cfad9136..4dbb8af6010 100644 --- a/src/components/annotations/convert_coords.js +++ b/src/components/annotations/convert_coords.js @@ -25,7 +25,7 @@ var toLogRange = require('../../lib/to_log_range'); * Use this to make the changes as it's aware if any other changes in the * same relayout call should override this conversion. */ -module.exports = function convertCoords(gd, ax, newType, doExtra) { +module.exports = function(gd, ax, newType, doExtra) { ax = ax || {}; var toLog = (newType === 'log') && (ax.type === 'linear'); diff --git a/src/components/annotations/defaults.js b/src/components/annotations/defaults.js index c7dac3f64da..746be1519af 100644 --- a/src/components/annotations/defaults.js +++ b/src/components/annotations/defaults.js @@ -17,7 +17,7 @@ var handleAnnotationCommonDefaults = require('./common_defaults'); var attributes = require('./attributes'); -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) { +module.exports = function(layoutIn, layoutOut) { handleArrayContainerDefaults(layoutIn, layoutOut, { name: 'annotations', handleItemDefaults: handleAnnotationDefaults diff --git a/src/components/annotations/draw_arrow_head.js b/src/components/annotations/draw_arrow_head.js index e3f6f71a1e5..9ae2cb2428a 100644 --- a/src/components/annotations/draw_arrow_head.js +++ b/src/components/annotations/draw_arrow_head.js @@ -35,7 +35,7 @@ var ARROWPATHS = require('./arrow_paths'); * of both the line and head has opacity applied to it so there isn't greater opacity * where they overlap. */ -module.exports = function drawArrowHead(el3, ends, options) { +module.exports = function(el3, ends, options) { var el = el3.node(); var headStyle = ARROWPATHS[options.arrowhead || 0]; var startHeadStyle = ARROWPATHS[options.startarrowhead || 0]; diff --git a/src/components/annotations3d/convert.js b/src/components/annotations3d/convert.js index 2f9a7d36213..db27d8e973b 100644 --- a/src/components/annotations3d/convert.js +++ b/src/components/annotations3d/convert.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var Axes = require('../../plots/cartesian/axes'); -module.exports = function convert(scene) { +module.exports = function(scene) { var fullSceneLayout = scene.fullSceneLayout; var anns = fullSceneLayout.annotations; diff --git a/src/components/annotations3d/defaults.js b/src/components/annotations3d/defaults.js index 754695da755..15d2dd02b3a 100644 --- a/src/components/annotations3d/defaults.js +++ b/src/components/annotations3d/defaults.js @@ -14,7 +14,7 @@ var handleArrayContainerDefaults = require('../../plots/array_container_defaults var handleAnnotationCommonDefaults = require('../annotations/common_defaults'); var attributes = require('./attributes'); -module.exports = function handleDefaults(sceneLayoutIn, sceneLayoutOut, opts) { +module.exports = function(sceneLayoutIn, sceneLayoutOut, opts) { handleArrayContainerDefaults(sceneLayoutIn, sceneLayoutOut, { name: 'annotations', handleItemDefaults: handleAnnotationDefaults, diff --git a/src/components/annotations3d/draw.js b/src/components/annotations3d/draw.js index 52e26c3716f..418b03a23e5 100644 --- a/src/components/annotations3d/draw.js +++ b/src/components/annotations3d/draw.js @@ -12,7 +12,7 @@ var drawRaw = require('../annotations/draw').drawRaw; var project = require('../../plots/gl3d/project'); var axLetters = ['x', 'y', 'z']; -module.exports = function draw(scene) { +module.exports = function(scene) { var fullSceneLayout = scene.fullSceneLayout; var dataScale = scene.dataScale; var anns = fullSceneLayout.annotations; diff --git a/src/components/colorbar/connect.js b/src/components/colorbar/connect.js index 7afd261873b..20a834e8b0e 100644 --- a/src/components/colorbar/connect.js +++ b/src/components/colorbar/connect.js @@ -36,7 +36,7 @@ var flipScale = require('../colorscale/helpers').flipScale; * used only if min/max fail. May be omitted if these are always * pre-calculated. */ -module.exports = function connectColorbar(gd, cd, moduleOpts) { +module.exports = function(gd, cd, moduleOpts) { if(typeof moduleOpts === 'function') return moduleOpts(gd, cd); var trace = cd[0].trace; diff --git a/src/components/colorbar/defaults.js b/src/components/colorbar/defaults.js index 4ab08fbad48..58cbaf7d6e7 100644 --- a/src/components/colorbar/defaults.js +++ b/src/components/colorbar/defaults.js @@ -18,7 +18,7 @@ var handleTickLabelDefaults = require('../../plots/cartesian/tick_label_defaults var attributes = require('./attributes'); -module.exports = function colorbarDefaults(containerIn, containerOut, layout) { +module.exports = function(containerIn, containerOut, layout) { var colorbarOut = Template.newContainer(containerOut, 'colorbar'); var colorbarIn = containerIn.colorbar || {}; diff --git a/src/components/colorbar/draw.js b/src/components/colorbar/draw.js index 6354ab471dd..3f2d2f82049 100644 --- a/src/components/colorbar/draw.js +++ b/src/components/colorbar/draw.js @@ -35,7 +35,7 @@ var axisLayoutAttrs = require('../../plots/cartesian/layout_attributes'); var attributes = require('./attributes'); var cn = require('./constants').cn; -module.exports = function draw(gd, id) { +module.exports = function(gd, id) { // opts: options object, containing everything from attributes // plus a few others that are the equivalent of the colorbar "data" var opts = {}; diff --git a/src/components/colorbar/has_colorbar.js b/src/components/colorbar/has_colorbar.js index cf82de864e5..c108e36aa1a 100644 --- a/src/components/colorbar/has_colorbar.js +++ b/src/components/colorbar/has_colorbar.js @@ -12,6 +12,6 @@ var Lib = require('../../lib'); -module.exports = function hasColorbar(container) { +module.exports = function(container) { return Lib.isPlainObject(container.colorbar); }; diff --git a/src/components/colorscale/attributes.js b/src/components/colorscale/attributes.js index 014377c1c91..dfac79b6407 100644 --- a/src/components/colorscale/attributes.js +++ b/src/components/colorscale/attributes.js @@ -58,7 +58,7 @@ function code(s) { * * @return {object} */ -module.exports = function colorScaleAttrs(context, opts) { +module.exports = function(context, opts) { context = context || ''; opts = opts || {}; diff --git a/src/components/colorscale/calc.js b/src/components/colorscale/calc.js index ed2491f9420..e4a9b9c58d4 100644 --- a/src/components/colorscale/calc.js +++ b/src/components/colorscale/calc.js @@ -10,7 +10,7 @@ var Lib = require('../../lib'); -module.exports = function calc(gd, trace, opts) { +module.exports = function(gd, trace, opts) { var fullLayout = gd._fullLayout; var vals = opts.vals; var containerStr = opts.containerStr; diff --git a/src/components/colorscale/cross_trace_defaults.js b/src/components/colorscale/cross_trace_defaults.js index 5933b669166..bbbdfe4b2bd 100644 --- a/src/components/colorscale/cross_trace_defaults.js +++ b/src/components/colorscale/cross_trace_defaults.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var hasColorscale = require('./helpers').hasColorscale; -module.exports = function crossTraceDefaults(fullData) { +module.exports = function(fullData) { function replace(cont, k) { var val = cont['_' + k]; if(val !== undefined) { diff --git a/src/components/colorscale/defaults.js b/src/components/colorscale/defaults.js index 75cd284b2be..aa2ba9c89b1 100644 --- a/src/components/colorscale/defaults.js +++ b/src/components/colorscale/defaults.js @@ -23,7 +23,7 @@ function npMaybe(cont, prefix) { cont; } -module.exports = function colorScaleDefaults(traceIn, traceOut, layout, coerce, opts) { +module.exports = function(traceIn, traceOut, layout, coerce, opts) { var prefix = opts.prefix; var cLetter = opts.cLetter; var containerIn = npMaybe(traceIn, prefix); diff --git a/src/components/colorscale/layout_defaults.js b/src/components/colorscale/layout_defaults.js index b05d56895c0..d8c47573720 100644 --- a/src/components/colorscale/layout_defaults.js +++ b/src/components/colorscale/layout_defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var colorscaleAttrs = require('./layout_attributes'); var Template = require('../../plot_api/plot_template'); -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) { +module.exports = function(layoutIn, layoutOut) { var colorscaleIn = layoutIn.colorscale; var colorscaleOut = Template.newContainer(layoutOut, 'colorscale'); function coerce(attr, dflt) { diff --git a/src/components/dragelement/align.js b/src/components/dragelement/align.js index 7b934a37a8b..7a9e27524ea 100644 --- a/src/components/dragelement/align.js +++ b/src/components/dragelement/align.js @@ -14,7 +14,7 @@ // >2/3 means right, and between is center. Pick the right fraction // based on where you are, and return the fraction corresponding to // that position on the object -module.exports = function align(v, dv, v0, v1, anchor) { +module.exports = function(v, dv, v0, v1, anchor) { var vmin = (v - v0) / (v1 - v0); var vmax = vmin + dv / (v1 - v0); var vc = (vmin + vmax) / 2; diff --git a/src/components/dragelement/cursor.js b/src/components/dragelement/cursor.js index 5a20761f05b..fd9d0f2361b 100644 --- a/src/components/dragelement/cursor.js +++ b/src/components/dragelement/cursor.js @@ -21,7 +21,7 @@ var cursorset = [ ['nw-resize', 'n-resize', 'ne-resize'] ]; -module.exports = function getCursor(x, y, xanchor, yanchor) { +module.exports = function(x, y, xanchor, yanchor) { if(xanchor === 'left') x = 0; else if(xanchor === 'center') x = 1; else if(xanchor === 'right') x = 2; diff --git a/src/components/dragelement/index.js b/src/components/dragelement/index.js index 477edbb99de..43496420b00 100644 --- a/src/components/dragelement/index.js +++ b/src/components/dragelement/index.js @@ -79,7 +79,7 @@ dragElement.unhoverRaw = unhover.raw; * By default, clamping is done using `minDrag` to x and y displacements * independently. */ -dragElement.init = function init(options) { +dragElement.init = function(options) { var gd = options.gd; var numClicks = 1; var DBLCLICKDELAY = interactConstants.DBLCLICKDELAY; diff --git a/src/components/dragelement/unhover.js b/src/components/dragelement/unhover.js index 34b51720032..94417b3dad4 100644 --- a/src/components/dragelement/unhover.js +++ b/src/components/dragelement/unhover.js @@ -32,7 +32,7 @@ unhover.wrapped = function(gd, evt, subplot) { // remove hover effects on mouse out, and emit unhover event -unhover.raw = function unhoverRaw(gd, evt) { +unhover.raw = function(gd, evt) { var fullLayout = gd._fullLayout; var oldhoverdata = gd._hoverdata; diff --git a/src/components/errorbars/calc.js b/src/components/errorbars/calc.js index 5d24a8ffb18..0b1c8823d2a 100644 --- a/src/components/errorbars/calc.js +++ b/src/components/errorbars/calc.js @@ -16,7 +16,7 @@ var Lib = require('../../lib'); var makeComputeError = require('./compute_error'); -module.exports = function calc(gd) { +module.exports = function(gd) { var calcdata = gd.calcdata; for(var i = 0; i < calcdata.length; i++) { diff --git a/src/components/errorbars/compute_error.js b/src/components/errorbars/compute_error.js index ca03c65c45f..e5df34efc2d 100644 --- a/src/components/errorbars/compute_error.js +++ b/src/components/errorbars/compute_error.js @@ -25,7 +25,7 @@ * - error[0] : error magnitude in the negative direction * - error[1] : " " " " positive " */ -module.exports = function makeComputeError(opts) { +module.exports = function(opts) { var type = opts.type; var symmetric = opts.symmetric; @@ -33,13 +33,13 @@ module.exports = function makeComputeError(opts) { var array = opts.array || []; if(symmetric) { - return function computeError(dataPt, index) { + return function(dataPt, index) { var val = +(array[index]); return [val, val]; }; } else { var arrayminus = opts.arrayminus || []; - return function computeError(dataPt, index) { + return function(dataPt, index) { var val = +array[index]; var valMinus = +arrayminus[index]; // in case one is present and the other is missing, fill in 0 @@ -56,12 +56,12 @@ module.exports = function makeComputeError(opts) { var computeErrorValueMinus = makeComputeErrorValue(type, opts.valueminus); if(symmetric || opts.valueminus === undefined) { - return function computeError(dataPt) { + return function(dataPt) { var val = computeErrorValue(dataPt); return [val, val]; }; } else { - return function computeError(dataPt) { + return function(dataPt) { return [ computeErrorValueMinus(dataPt), computeErrorValue(dataPt) diff --git a/src/components/errorbars/plot.js b/src/components/errorbars/plot.js index 5e86fea073f..e25493c4f8e 100644 --- a/src/components/errorbars/plot.js +++ b/src/components/errorbars/plot.js @@ -15,7 +15,7 @@ var isNumeric = require('fast-isnumeric'); var Drawing = require('../drawing'); var subTypes = require('../../traces/scatter/subtypes'); -module.exports = function plot(gd, traces, plotinfo, transitionOpts) { +module.exports = function(gd, traces, plotinfo, transitionOpts) { var isNew; var xa = plotinfo.xaxis; diff --git a/src/components/errorbars/style.js b/src/components/errorbars/style.js index f27ecb7c5f7..24d8f7c8c38 100644 --- a/src/components/errorbars/style.js +++ b/src/components/errorbars/style.js @@ -14,7 +14,7 @@ var d3 = require('d3'); var Color = require('../color'); -module.exports = function style(traces) { +module.exports = function(traces) { traces.each(function(d) { var trace = d[0].trace; var yObj = trace.error_y || {}; diff --git a/src/components/fx/calc.js b/src/components/fx/calc.js index 4d397764e4f..5c0ac7050d6 100644 --- a/src/components/fx/calc.js +++ b/src/components/fx/calc.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var Registry = require('../../registry'); -module.exports = function calc(gd) { +module.exports = function(gd) { var calcdata = gd.calcdata; var fullLayout = gd._fullLayout; diff --git a/src/components/fx/click.js b/src/components/fx/click.js index 4f0955d1771..6a174b9f0de 100644 --- a/src/components/fx/click.js +++ b/src/components/fx/click.js @@ -11,7 +11,7 @@ var Registry = require('../../registry'); var hover = require('./hover').hover; -module.exports = function click(gd, evt, subplot) { +module.exports = function(gd, evt, subplot) { var annotationsDone = Registry.getComponentMethod('annotations', 'onClick')(gd, gd._hoverdata); // fallback to fail-safe in case the plot type's hover method doesn't pass the subplot. diff --git a/src/components/fx/defaults.js b/src/components/fx/defaults.js index 3925371071f..2948d4443f7 100644 --- a/src/components/fx/defaults.js +++ b/src/components/fx/defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var attributes = require('./attributes'); var handleHoverLabelDefaults = require('./hoverlabel_defaults'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/components/fx/helpers.js b/src/components/fx/helpers.js index ef1db6bfc06..020df4ea493 100644 --- a/src/components/fx/helpers.js +++ b/src/components/fx/helpers.js @@ -12,13 +12,13 @@ var Lib = require('../../lib'); // look for either subplot or xaxis and yaxis attributes // does not handle splom case -exports.getSubplot = function getSubplot(trace) { +exports.getSubplot = function(trace) { return trace.subplot || (trace.xaxis + trace.yaxis) || trace.geo; }; // is trace in given list of subplots? // does handle splom case -exports.isTraceInSubplots = function isTraceInSubplot(trace, subplots) { +exports.isTraceInSubplots = function(trace, subplots) { if(trace.type === 'splom') { var xaxes = trace.xaxes || []; var yaxes = trace.yaxes || []; @@ -36,7 +36,7 @@ exports.isTraceInSubplots = function isTraceInSubplot(trace, subplots) { }; // convenience functions for mapping all relevant axes -exports.flat = function flat(subplots, v) { +exports.flat = function(subplots, v) { var out = new Array(subplots.length); for(var i = 0; i < subplots.length; i++) { out[i] = v; @@ -44,7 +44,7 @@ exports.flat = function flat(subplots, v) { return out; }; -exports.p2c = function p2c(axArray, v) { +exports.p2c = function(axArray, v) { var out = new Array(axArray.length); for(var i = 0; i < axArray.length; i++) { out[i] = axArray[i].p2c(v); @@ -52,12 +52,12 @@ exports.p2c = function p2c(axArray, v) { return out; }; -exports.getDistanceFunction = function getDistanceFunction(mode, dx, dy, dxy) { +exports.getDistanceFunction = function(mode, dx, dy, dxy) { if(mode === 'closest') return dxy || exports.quadrature(dx, dy); return mode === 'x' ? dx : dy; }; -exports.getClosest = function getClosest(cd, distfn, pointData) { +exports.getClosest = function(cd, distfn, pointData) { // do we already have a point number? (array mode only) if(pointData.index !== false) { if(pointData.index >= 0 && pointData.index < cd.length) { @@ -87,11 +87,11 @@ exports.getClosest = function getClosest(cd, distfn, pointData) { * @param {number} v1: signed difference between the current position and the right edge * @param {number} passVal: the value to return on success */ -exports.inbox = function inbox(v0, v1, passVal) { +exports.inbox = function(v0, v1, passVal) { return (v0 * v1 < 0 || v0 === 0) ? passVal : Infinity; }; -exports.quadrature = function quadrature(dx, dy) { +exports.quadrature = function(dx, dy) { return function(di) { var x = dx(di); var y = dy(di); @@ -114,7 +114,7 @@ exports.quadrature = function quadrature(dx, dy) { * @param {object} cd * @return {object} */ -exports.makeEventData = function makeEventData(pt, trace, cd) { +exports.makeEventData = function(pt, trace, cd) { // hover uses 'index', select uses 'pointNumber' var pointNumber = 'index' in pt ? pt.index : pt.pointNumber; diff --git a/src/components/fx/hover.js b/src/components/fx/hover.js index e312690a176..11491327ab5 100644 --- a/src/components/fx/hover.js +++ b/src/components/fx/hover.js @@ -66,7 +66,7 @@ var HOVERTEXTPAD = constants.HOVERTEXTPAD; // // We wrap the hovers in a timer, to limit their frequency. // The actual rendering is done by private function _hover. -exports.hover = function hover(gd, evt, subplot, noHoverEvent) { +exports.hover = function(gd, evt, subplot, noHoverEvent) { gd = Lib.getGraphDiv(gd); Lib.throttle( @@ -109,7 +109,7 @@ exports.hover = function hover(gd, evt, subplot, noHoverEvent) { the index of the hover item used as an anchor for positioning. The other hover items will be pushed up or down to prevent overlap. */ -exports.loneHover = function loneHover(hoverItems, opts) { +exports.loneHover = function(hoverItems, opts) { var multiHover = true; if(!Array.isArray(hoverItems)) { multiHover = false; diff --git a/src/components/fx/hoverlabel_defaults.js b/src/components/fx/hoverlabel_defaults.js index cc6d868633b..e32f26f21ae 100644 --- a/src/components/fx/hoverlabel_defaults.js +++ b/src/components/fx/hoverlabel_defaults.js @@ -10,7 +10,7 @@ var Lib = require('../../lib'); -module.exports = function handleHoverLabelDefaults(contIn, contOut, coerce, opts) { +module.exports = function(contIn, contOut, coerce, opts) { opts = opts || {}; coerce('hoverlabel.bgcolor', opts.bgcolor); diff --git a/src/components/fx/layout_defaults.js b/src/components/fx/layout_defaults.js index e0f04bc0f23..2d3ac86d6f8 100644 --- a/src/components/fx/layout_defaults.js +++ b/src/components/fx/layout_defaults.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var layoutAttributes = require('./layout_attributes'); -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { +module.exports = function(layoutIn, layoutOut, fullData) { function coerce(attr, dflt) { return Lib.coerce(layoutIn, layoutOut, layoutAttributes, attr, dflt); } diff --git a/src/components/fx/layout_global_defaults.js b/src/components/fx/layout_global_defaults.js index 93593e98143..f4a6b7617a8 100644 --- a/src/components/fx/layout_global_defaults.js +++ b/src/components/fx/layout_global_defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var handleHoverLabelDefaults = require('./hoverlabel_defaults'); var layoutAttributes = require('./layout_attributes'); -module.exports = function supplyLayoutGlobalDefaults(layoutIn, layoutOut) { +module.exports = function(layoutIn, layoutOut) { function coerce(attr, dflt) { return Lib.coerce(layoutIn, layoutOut, layoutAttributes, attr, dflt); } diff --git a/src/components/images/convert_coords.js b/src/components/images/convert_coords.js index b0be0ce819b..aca26d4a5c5 100644 --- a/src/components/images/convert_coords.js +++ b/src/components/images/convert_coords.js @@ -30,7 +30,7 @@ var toLogRange = require('../../lib/to_log_range'); * Use this to make the changes as it's aware if any other changes in the * same relayout call should override this conversion. */ -module.exports = function convertCoords(gd, ax, newType, doExtra) { +module.exports = function(gd, ax, newType, doExtra) { ax = ax || {}; var toLog = (newType === 'log') && (ax.type === 'linear'); diff --git a/src/components/images/defaults.js b/src/components/images/defaults.js index 09b84ed83a0..605f1608301 100644 --- a/src/components/images/defaults.js +++ b/src/components/images/defaults.js @@ -15,7 +15,7 @@ var handleArrayContainerDefaults = require('../../plots/array_container_defaults var attributes = require('./attributes'); var name = 'images'; -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) { +module.exports = function(layoutIn, layoutOut) { var opts = { name: name, handleItemDefaults: imageDefaults diff --git a/src/components/images/draw.js b/src/components/images/draw.js index 3fe1080fc32..36138d6950d 100644 --- a/src/components/images/draw.js +++ b/src/components/images/draw.js @@ -13,7 +13,7 @@ var Drawing = require('../drawing'); var Axes = require('../../plots/cartesian/axes'); var xmlnsNamespaces = require('../../constants/xmlns_namespaces'); -module.exports = function draw(gd) { +module.exports = function(gd) { var fullLayout = gd._fullLayout; var imageDataAbove = []; var imageDataSubplot = {}; diff --git a/src/components/legend/anchor_utils.js b/src/components/legend/anchor_utils.js index b1bf7e97044..56059c139fb 100644 --- a/src/components/legend/anchor_utils.js +++ b/src/components/legend/anchor_utils.js @@ -18,28 +18,28 @@ * - values > 2/3 align the right at that fraction. */ -exports.isRightAnchor = function isRightAnchor(opts) { +exports.isRightAnchor = function(opts) { return ( opts.xanchor === 'right' || (opts.xanchor === 'auto' && opts.x >= 2 / 3) ); }; -exports.isCenterAnchor = function isCenterAnchor(opts) { +exports.isCenterAnchor = function(opts) { return ( opts.xanchor === 'center' || (opts.xanchor === 'auto' && opts.x > 1 / 3 && opts.x < 2 / 3) ); }; -exports.isBottomAnchor = function isBottomAnchor(opts) { +exports.isBottomAnchor = function(opts) { return ( opts.yanchor === 'bottom' || (opts.yanchor === 'auto' && opts.y <= 1 / 3) ); }; -exports.isMiddleAnchor = function isMiddleAnchor(opts) { +exports.isMiddleAnchor = function(opts) { return ( opts.yanchor === 'middle' || (opts.yanchor === 'auto' && opts.y > 1 / 3 && opts.y < 2 / 3) diff --git a/src/components/legend/defaults.js b/src/components/legend/defaults.js index c56da87077a..b961f1633ab 100644 --- a/src/components/legend/defaults.js +++ b/src/components/legend/defaults.js @@ -18,7 +18,7 @@ var basePlotLayoutAttributes = require('../../plots/layout_attributes'); var helpers = require('./helpers'); -module.exports = function legendDefaults(layoutIn, layoutOut, fullData) { +module.exports = function(layoutIn, layoutOut, fullData) { var containerIn = layoutIn.legend || {}; var legendTraceCount = 0; diff --git a/src/components/legend/draw.js b/src/components/legend/draw.js index 1ded8cba129..05077a80f24 100644 --- a/src/components/legend/draw.js +++ b/src/components/legend/draw.js @@ -33,7 +33,7 @@ var helpers = require('./helpers'); var DBLCLICKDELAY = interactConstants.DBLCLICKDELAY; -module.exports = function draw(gd) { +module.exports = function(gd) { var fullLayout = gd._fullLayout; var clipId = 'legend' + fullLayout._uid; diff --git a/src/components/legend/get_legend_data.js b/src/components/legend/get_legend_data.js index 2c2c7cd1190..1116c1d4399 100644 --- a/src/components/legend/get_legend_data.js +++ b/src/components/legend/get_legend_data.js @@ -13,7 +13,7 @@ var Registry = require('../../registry'); var helpers = require('./helpers'); -module.exports = function getLegendData(calcdata, opts) { +module.exports = function(calcdata, opts) { var lgroupToTraces = {}; var lgroups = []; var hasOneNonBlankGroup = false; diff --git a/src/components/legend/handle_click.js b/src/components/legend/handle_click.js index 45fefc951d7..1fa0cc43e64 100644 --- a/src/components/legend/handle_click.js +++ b/src/components/legend/handle_click.js @@ -13,7 +13,7 @@ var Registry = require('../../registry'); var SHOWISOLATETIP = true; -module.exports = function handleClick(g, gd, numClicks) { +module.exports = function(g, gd, numClicks) { if(gd._dragged || gd._editing) return; var hiddenSlices = gd._fullLayout.hiddenlabels ? diff --git a/src/components/legend/helpers.js b/src/components/legend/helpers.js index d6d3b1a1554..326bd116e5c 100644 --- a/src/components/legend/helpers.js +++ b/src/components/legend/helpers.js @@ -9,14 +9,14 @@ 'use strict'; -exports.isGrouped = function isGrouped(legendLayout) { +exports.isGrouped = function(legendLayout) { return (legendLayout.traceorder || '').indexOf('grouped') !== -1; }; -exports.isVertical = function isVertical(legendLayout) { +exports.isVertical = function(legendLayout) { return legendLayout.orientation !== 'h'; }; -exports.isReversed = function isReversed(legendLayout) { +exports.isReversed = function(legendLayout) { return (legendLayout.traceorder || '').indexOf('reversed') !== -1; }; diff --git a/src/components/legend/style.js b/src/components/legend/style.js index 3b3c3c6c0f7..6a6843ae6ba 100644 --- a/src/components/legend/style.js +++ b/src/components/legend/style.js @@ -25,7 +25,7 @@ var CST_MARKER_LINE_WIDTH = 2; var MAX_LINE_WIDTH = 10; var MAX_MARKER_LINE_WIDTH = 5; -module.exports = function style(s, gd) { +module.exports = function(s, gd) { var fullLayout = gd._fullLayout; var legend = fullLayout.legend; var constantItemSizing = legend.itemsizing === 'constant'; diff --git a/src/components/modebar/manage.js b/src/components/modebar/manage.js index 7a22f8f40a9..728deb42aa0 100644 --- a/src/components/modebar/manage.js +++ b/src/components/modebar/manage.js @@ -24,7 +24,7 @@ var modeBarButtons = require('./buttons'); * @param {object} gd main plot object * */ -module.exports = function manageModeBar(gd) { +module.exports = function(gd) { var fullLayout = gd._fullLayout; var context = gd._context; var modeBar = fullLayout._modeBar; diff --git a/src/components/rangeselector/defaults.js b/src/components/rangeselector/defaults.js index 17cc116c010..df591ede6dd 100644 --- a/src/components/rangeselector/defaults.js +++ b/src/components/rangeselector/defaults.js @@ -17,7 +17,7 @@ var attributes = require('./attributes'); var constants = require('./constants'); -module.exports = function handleDefaults(containerIn, containerOut, layout, counterAxes, calendar) { +module.exports = function(containerIn, containerOut, layout, counterAxes, calendar) { var selectorIn = containerIn.rangeselector || {}; var selectorOut = Template.newContainer(containerOut, 'rangeselector'); diff --git a/src/components/rangeselector/draw.js b/src/components/rangeselector/draw.js index 927e982516b..1e706186eb1 100644 --- a/src/components/rangeselector/draw.js +++ b/src/components/rangeselector/draw.js @@ -26,7 +26,7 @@ var FROM_BR = alignmentConstants.FROM_BR; var constants = require('./constants'); var getUpdateObject = require('./get_update_object'); -module.exports = function draw(gd) { +module.exports = function(gd) { var fullLayout = gd._fullLayout; var selectors = fullLayout._infolayer.selectAll('.rangeselector') diff --git a/src/components/rangeselector/get_update_object.js b/src/components/rangeselector/get_update_object.js index cbc7d4d7254..9cf6cee393e 100644 --- a/src/components/rangeselector/get_update_object.js +++ b/src/components/rangeselector/get_update_object.js @@ -11,7 +11,7 @@ var d3 = require('d3'); -module.exports = function getUpdateObject(axisLayout, buttonLayout) { +module.exports = function(axisLayout, buttonLayout) { var axName = axisLayout._name; var update = {}; diff --git a/src/components/rangeslider/calc_autorange.js b/src/components/rangeslider/calc_autorange.js index 878917d3b19..36825a66631 100644 --- a/src/components/rangeslider/calc_autorange.js +++ b/src/components/rangeslider/calc_autorange.js @@ -12,7 +12,7 @@ var listAxes = require('../../plots/cartesian/axis_ids').list; var getAutoRange = require('../../plots/cartesian/autorange').getAutoRange; var constants = require('./constants'); -module.exports = function calcAutorange(gd) { +module.exports = function(gd) { var axes = listAxes(gd, 'x', true); // Compute new slider range using axis autorange if necessary. diff --git a/src/components/rangeslider/defaults.js b/src/components/rangeslider/defaults.js index f70d732482d..3f2e3b90f26 100644 --- a/src/components/rangeslider/defaults.js +++ b/src/components/rangeslider/defaults.js @@ -15,7 +15,7 @@ var axisIds = require('../../plots/cartesian/axis_ids'); var attributes = require('./attributes'); var oppAxisAttrs = require('./oppaxis_attributes'); -module.exports = function handleDefaults(layoutIn, layoutOut, axName) { +module.exports = function(layoutIn, layoutOut, axName) { var axIn = layoutIn[axName]; var axOut = layoutOut[axName]; diff --git a/src/components/shapes/calc_autorange.js b/src/components/shapes/calc_autorange.js index fd38a2e6f31..9f7c26342e8 100644 --- a/src/components/shapes/calc_autorange.js +++ b/src/components/shapes/calc_autorange.js @@ -15,7 +15,7 @@ var constants = require('./constants'); var helpers = require('./helpers'); -module.exports = function calcAutorange(gd) { +module.exports = function(gd) { var fullLayout = gd._fullLayout; var shapeList = Lib.filterVisible(fullLayout.shapes); diff --git a/src/components/shapes/defaults.js b/src/components/shapes/defaults.js index 1d16342b4bc..11b6106988f 100644 --- a/src/components/shapes/defaults.js +++ b/src/components/shapes/defaults.js @@ -17,7 +17,7 @@ var attributes = require('./attributes'); var helpers = require('./helpers'); -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) { +module.exports = function(layoutIn, layoutOut) { handleArrayContainerDefaults(layoutIn, layoutOut, { name: 'shapes', handleItemDefaults: handleShapeDefaults diff --git a/src/components/shapes/draw.js b/src/components/shapes/draw.js index 556920c80a9..803eb348d96 100644 --- a/src/components/shapes/draw.js +++ b/src/components/shapes/draw.js @@ -316,14 +316,14 @@ function setupDragElement(gd, shapePath, shapeOptions, index, shapeLayer) { if(xPixelSized) { modifyItem('xanchor', shapeOptions.xanchor = p2x(xAnchor + dx)); } else { - moveX = function moveX(x) { return p2x(x2p(x) + dx); }; + moveX = function(x) { return p2x(x2p(x) + dx); }; if(xa && xa.type === 'date') moveX = helpers.encodeDate(moveX); } if(yPixelSized) { modifyItem('yanchor', shapeOptions.yanchor = p2y(yAnchor + dy)); } else { - moveY = function moveY(y) { return p2y(y2p(y) + dy); }; + moveY = function(y) { return p2y(y2p(y) + dy); }; if(ya && ya.type === 'date') moveY = helpers.encodeDate(moveY); } @@ -358,14 +358,14 @@ function setupDragElement(gd, shapePath, shapeOptions, index, shapeLayer) { if(xPixelSized) { modifyItem('xanchor', shapeOptions.xanchor = p2x(xAnchor + dx)); } else { - moveX = function moveX(x) { return p2x(x2p(x) + dx); }; + moveX = function(x) { return p2x(x2p(x) + dx); }; if(xa && xa.type === 'date') moveX = helpers.encodeDate(moveX); } if(yPixelSized) { modifyItem('yanchor', shapeOptions.yanchor = p2y(yAnchor + dy)); } else { - moveY = function moveY(y) { return p2y(y2p(y) + dy); }; + moveY = function(y) { return p2y(y2p(y) + dy); }; if(ya && ya.type === 'date') moveY = helpers.encodeDate(moveY); } diff --git a/src/components/sliders/defaults.js b/src/components/sliders/defaults.js index 099784bf0ae..34484a2ce7c 100644 --- a/src/components/sliders/defaults.js +++ b/src/components/sliders/defaults.js @@ -18,7 +18,7 @@ var name = constants.name; var stepAttrs = attributes.steps; -module.exports = function slidersDefaults(layoutIn, layoutOut) { +module.exports = function(layoutIn, layoutOut) { handleArrayContainerDefaults(layoutIn, layoutOut, { name: name, handleItemDefaults: sliderDefaults diff --git a/src/components/sliders/draw.js b/src/components/sliders/draw.js index f411ce7f909..69867a9c93b 100644 --- a/src/components/sliders/draw.js +++ b/src/components/sliders/draw.js @@ -23,7 +23,7 @@ var LINE_SPACING = alignmentConstants.LINE_SPACING; var FROM_TL = alignmentConstants.FROM_TL; var FROM_BR = alignmentConstants.FROM_BR; -module.exports = function draw(gd) { +module.exports = function(gd) { var fullLayout = gd._fullLayout; var sliderData = makeSliderData(fullLayout, gd); diff --git a/src/components/updatemenus/defaults.js b/src/components/updatemenus/defaults.js index 492b9c911a9..de8cad08d54 100644 --- a/src/components/updatemenus/defaults.js +++ b/src/components/updatemenus/defaults.js @@ -18,7 +18,7 @@ var name = constants.name; var buttonAttrs = attributes.buttons; -module.exports = function updateMenusDefaults(layoutIn, layoutOut) { +module.exports = function(layoutIn, layoutOut) { var opts = { name: name, handleItemDefaults: menuDefaults diff --git a/src/components/updatemenus/draw.js b/src/components/updatemenus/draw.js index d5737704bf2..79ff82ccbed 100644 --- a/src/components/updatemenus/draw.js +++ b/src/components/updatemenus/draw.js @@ -23,7 +23,7 @@ var LINE_SPACING = require('../../constants/alignment').LINE_SPACING; var constants = require('./constants'); var ScrollBox = require('./scrollbox'); -module.exports = function draw(gd) { +module.exports = function(gd) { var fullLayout = gd._fullLayout; var menuData = Lib.filterVisible(fullLayout[constants.name]); diff --git a/src/components/updatemenus/scrollbox.js b/src/components/updatemenus/scrollbox.js index d43b2516608..46c5b224b44 100644 --- a/src/components/updatemenus/scrollbox.js +++ b/src/components/updatemenus/scrollbox.js @@ -78,7 +78,7 @@ ScrollBox.barColor = '#808BA4'; * @param {number} [translateX=0] Horizontal offset (in pixels) * @param {number} [translateY=0] Vertical offset (in pixels) */ -ScrollBox.prototype.enable = function enable(position, translateX, translateY) { +ScrollBox.prototype.enable = function(position, translateX, translateY) { var fullLayout = this.gd._fullLayout; var fullWidth = fullLayout.width; var fullHeight = fullLayout.height; @@ -312,7 +312,7 @@ ScrollBox.prototype.enable = function enable(position, translateX, translateY) { * * @method */ -ScrollBox.prototype.disable = function disable() { +ScrollBox.prototype.disable = function() { if(this.hbar || this.vbar) { this.bg.attr({ width: 0, @@ -347,7 +347,7 @@ ScrollBox.prototype.disable = function disable() { * * @method */ -ScrollBox.prototype._onBoxDrag = function onBarDrag() { +ScrollBox.prototype._onBoxDrag = function() { var translateX = this.translateX; var translateY = this.translateY; @@ -367,7 +367,7 @@ ScrollBox.prototype._onBoxDrag = function onBarDrag() { * * @method */ -ScrollBox.prototype._onBoxWheel = function onBarWheel() { +ScrollBox.prototype._onBoxWheel = function() { var translateX = this.translateX; var translateY = this.translateY; @@ -387,7 +387,7 @@ ScrollBox.prototype._onBoxWheel = function onBarWheel() { * * @method */ -ScrollBox.prototype._onBarDrag = function onBarDrag() { +ScrollBox.prototype._onBarDrag = function() { var translateX = this.translateX; var translateY = this.translateY; @@ -423,7 +423,7 @@ ScrollBox.prototype._onBarDrag = function onBarDrag() { * @param {number} [translateX=0] Horizontal offset (in pixels) * @param {number} [translateY=0] Vertical offset (in pixels) */ -ScrollBox.prototype.setTranslate = function setTranslate(translateX, translateY) { +ScrollBox.prototype.setTranslate = function(translateX, translateY) { // store translateX and translateY (needed by mouse event handlers) var translateXMax = this.position.w - this._box.w; var translateYMax = this.position.h - this._box.h; diff --git a/src/lib/anchor_utils.js b/src/lib/anchor_utils.js index cc88136fb7c..37d6f67b136 100644 --- a/src/lib/anchor_utils.js +++ b/src/lib/anchor_utils.js @@ -19,42 +19,42 @@ */ -exports.isLeftAnchor = function isLeftAnchor(opts) { +exports.isLeftAnchor = function(opts) { return ( opts.xanchor === 'left' || (opts.xanchor === 'auto' && opts.x <= 1 / 3) ); }; -exports.isCenterAnchor = function isCenterAnchor(opts) { +exports.isCenterAnchor = function(opts) { return ( opts.xanchor === 'center' || (opts.xanchor === 'auto' && opts.x > 1 / 3 && opts.x < 2 / 3) ); }; -exports.isRightAnchor = function isRightAnchor(opts) { +exports.isRightAnchor = function(opts) { return ( opts.xanchor === 'right' || (opts.xanchor === 'auto' && opts.x >= 2 / 3) ); }; -exports.isTopAnchor = function isTopAnchor(opts) { +exports.isTopAnchor = function(opts) { return ( opts.yanchor === 'top' || (opts.yanchor === 'auto' && opts.y >= 2 / 3) ); }; -exports.isMiddleAnchor = function isMiddleAnchor(opts) { +exports.isMiddleAnchor = function(opts) { return ( opts.yanchor === 'middle' || (opts.yanchor === 'auto' && opts.y > 1 / 3 && opts.y < 2 / 3) ); }; -exports.isBottomAnchor = function isBottomAnchor(opts) { +exports.isBottomAnchor = function(opts) { return ( opts.yanchor === 'bottom' || (opts.yanchor === 'auto' && opts.y <= 1 / 3) diff --git a/src/lib/clean_number.js b/src/lib/clean_number.js index 845887a994c..9078b1cb668 100644 --- a/src/lib/clean_number.js +++ b/src/lib/clean_number.js @@ -20,7 +20,7 @@ var JUNK = /^['"%,$#\s']+|[, ]|['"%,$#\s']+$/g; * cleanNumber: remove common leading and trailing cruft * Always returns either a number or BADNUM. */ -module.exports = function cleanNumber(v) { +module.exports = function(v) { if(typeof v === 'string') { v = v.replace(JUNK, ''); } diff --git a/src/lib/clear_gl_canvases.js b/src/lib/clear_gl_canvases.js index 393592ed19a..a95c9577829 100644 --- a/src/lib/clear_gl_canvases.js +++ b/src/lib/clear_gl_canvases.js @@ -15,7 +15,7 @@ * * @param {DOM node or object} gd : graph div object */ -module.exports = function clearGlCanvases(gd) { +module.exports = function(gd) { var fullLayout = gd._fullLayout; if(fullLayout._glcanvas && fullLayout._glcanvas.size()) { diff --git a/src/lib/clear_responsive.js b/src/lib/clear_responsive.js index 406aa1f3d0a..5f9f11da259 100644 --- a/src/lib/clear_responsive.js +++ b/src/lib/clear_responsive.js @@ -13,7 +13,7 @@ * * @param {DOM node or object} gd : graph div object */ -module.exports = function clearResponsive(gd) { +module.exports = function(gd) { if(gd._responsiveChartHandler) { window.removeEventListener('resize', gd._responsiveChartHandler); delete gd._responsiveChartHandler; diff --git a/src/lib/filter_unique.js b/src/lib/filter_unique.js index 9be686f12fe..a36b0913fbf 100644 --- a/src/lib/filter_unique.js +++ b/src/lib/filter_unique.js @@ -31,7 +31,7 @@ * @param {array} array base array * @return {array} new filtered array */ -module.exports = function filterUnique(array) { +module.exports = function(array) { var seen = {}; var out = []; var j = 0; diff --git a/src/lib/filter_visible.js b/src/lib/filter_visible.js index 39088029478..e6005b66f9f 100644 --- a/src/lib/filter_visible.js +++ b/src/lib/filter_visible.js @@ -15,7 +15,7 @@ * @return {array of objects} of length <= container * */ -module.exports = function filterVisible(container) { +module.exports = function(container) { var filterFn = isCalcData(container) ? calcDataFilter : baseFilter; var out = []; diff --git a/src/lib/geometry2d.js b/src/lib/geometry2d.js index 2bb298f626b..28fc47797f6 100644 --- a/src/lib/geometry2d.js +++ b/src/lib/geometry2d.js @@ -37,7 +37,7 @@ function segmentsIntersect(x1, y1, x2, y2, x3, y3, x4, y4) { /* * find the minimum distance between two line segments (1->2 and 3->4) */ -exports.segmentDistance = function segmentDistance(x1, y1, x2, y2, x3, y3, x4, y4) { +exports.segmentDistance = function(x1, y1, x2, y2, x3, y3, x4, y4) { if(segmentsIntersect(x1, y1, x2, y2, x3, y3, x4, y4)) return 0; // the two segments and their lengths squared @@ -88,7 +88,7 @@ function perpDistance2(xab, yab, llab, xac, yac) { var locationCache, workingPath, workingTextWidth; // turn a path and position along it into x, y, and angle for the given text -exports.getTextLocation = function getTextLocation(path, totalPathLen, positionOnPath, textWidth) { +exports.getTextLocation = function(path, totalPathLen, positionOnPath, textWidth) { if(path !== workingPath || textWidth !== workingTextWidth) { locationCache = {}; workingPath = path; @@ -143,7 +143,7 @@ exports.clearLocationCache = function() { * the path). Note that if a path enters, exits, and re-enters the plot, we * will not capture this behavior. */ -exports.getVisibleSegment = function getVisibleSegment(path, bounds, buffer) { +exports.getVisibleSegment = function(path, bounds, buffer) { var left = bounds.left; var right = bounds.right; var top = bounds.top; @@ -204,7 +204,7 @@ exports.getVisibleSegment = function getVisibleSegment(path, bounds, buffer) { * - {Number} iterationLimit * @return {SVGPoint} */ -exports.findPointOnPath = function findPointOnPath(path, val, coord, opts) { +exports.findPointOnPath = function(path, val, coord, opts) { opts = opts || {}; var pathLength = opts.pathLength || path.getTotalLength(); diff --git a/src/lib/identity.js b/src/lib/identity.js index 804fc5b30e8..61ab6d60048 100644 --- a/src/lib/identity.js +++ b/src/lib/identity.js @@ -11,4 +11,4 @@ // Simple helper functions // none of these need any external deps -module.exports = function identity(d) { return d; }; +module.exports = function(d) { return d; }; diff --git a/src/lib/index.js b/src/lib/index.js index 772ff06f34b..d5010435528 100644 --- a/src/lib/index.js +++ b/src/lib/index.js @@ -153,7 +153,7 @@ lib.pushUnique = require('./push_unique'); lib.cleanNumber = require('./clean_number'); -lib.ensureNumber = function num(v) { +lib.ensureNumber = function(v) { if(!isNumeric(v)) return BADNUM; v = Number(v); if(v < -FP_SAFE || v > FP_SAFE) return BADNUM; @@ -212,7 +212,7 @@ lib.swapAttrs = function(cont, attrList, part1, part2) { /** * SVG painter's algo worked around with reinsertion */ -lib.raiseToTop = function raiseToTop(elem) { +lib.raiseToTop = function(elem) { elem.parentNode.appendChild(elem); }; @@ -268,7 +268,7 @@ lib.simpleMap = function(array, func, x1, x2) { * @param {int} base * base of string representation, default 16. Should be a power of 2. */ -lib.randstr = function randstr(existing, bits, base, _recursion) { +lib.randstr = function(existing, bits, base, _recursion) { if(!base) base = 16; if(bits === undefined) bits = 24; if(bits <= 0) return '0'; @@ -301,7 +301,7 @@ lib.randstr = function randstr(existing, bits, base, _recursion) { lib.warn('randstr failed uniqueness'); return res; } - return randstr(existing, bits, base, (_recursion || 0) + 1); + return lib.randstr(existing, bits, base, (_recursion || 0) + 1); } else return res; }; diff --git a/src/lib/is_plain_object.js b/src/lib/is_plain_object.js index 8f33cb6d2be..69836d69741 100644 --- a/src/lib/is_plain_object.js +++ b/src/lib/is_plain_object.js @@ -10,7 +10,7 @@ 'use strict'; // more info: http://stackoverflow.com/questions/18531624/isplainobject-thing -module.exports = function isPlainObject(obj) { +module.exports = function(obj) { // We need to be a little less strict in the `imagetest` container because // of how async image requests are handled. // diff --git a/src/lib/keyed_container.js b/src/lib/keyed_container.js index ea46310a17f..dacc58934b7 100644 --- a/src/lib/keyed_container.js +++ b/src/lib/keyed_container.js @@ -30,7 +30,7 @@ var VALUE = 2; var BOTH = 3; var UNSET = 4; -module.exports = function keyedContainer(baseObj, path, keyName, valueName) { +module.exports = function(baseObj, path, keyName, valueName) { keyName = keyName || 'name'; valueName = valueName || 'value'; var i, arr, baseProp; diff --git a/src/lib/localize.js b/src/lib/localize.js index 545dbff7a97..05c9f910ca3 100644 --- a/src/lib/localize.js +++ b/src/lib/localize.js @@ -20,7 +20,7 @@ var Registry = require('../registry'); * gd._context.locales or globally via Plotly.register * @param {string} s: the string to translate */ -module.exports = function localize(gd, s) { +module.exports = function(gd, s) { var locale = gd._context.locale; /* diff --git a/src/lib/make_trace_groups.js b/src/lib/make_trace_groups.js index ddc542fbe7b..7a6868c8788 100644 --- a/src/lib/make_trace_groups.js +++ b/src/lib/make_trace_groups.js @@ -20,7 +20,7 @@ * @param {string} cls: the class attribute to give each trace group * so you can give multiple classes separated by spaces */ -module.exports = function makeTraceGroups(traceLayer, cdModule, cls) { +module.exports = function(traceLayer, cdModule, cls) { var traces = traceLayer.selectAll('g.' + cls.replace(/\s/g, '.')) .data(cdModule, function(cd) { return cd[0].trace.uid; }); diff --git a/src/lib/nested_property.js b/src/lib/nested_property.js index e02cd923de3..aae94fd2fe7 100644 --- a/src/lib/nested_property.js +++ b/src/lib/nested_property.js @@ -26,7 +26,7 @@ var isArrayOrTypedArray = require('./array').isArrayOrTypedArray; * you can't do nestedProperty(obj, 'arr[-1]').set(5) * but you can do nestedProperty(obj, 'arr').set([5, 5, 5]) */ -module.exports = function nestedProperty(container, propStr) { +module.exports = function(container, propStr) { if(isNumeric(propStr)) propStr = String(propStr); else if(typeof propStr !== 'string' || propStr.substr(propStr.length - 4) === '[-1]') { diff --git a/src/lib/noop.js b/src/lib/noop.js index e5e5e66a434..5a33031c0c8 100644 --- a/src/lib/noop.js +++ b/src/lib/noop.js @@ -11,4 +11,4 @@ // Simple helper functions // none of these need any external deps -module.exports = function noop() {}; +module.exports = function() {}; diff --git a/src/lib/override_cursor.js b/src/lib/override_cursor.js index 29933459614..bce10d18cd9 100644 --- a/src/lib/override_cursor.js +++ b/src/lib/override_cursor.js @@ -20,7 +20,7 @@ var NO_CURSOR = '!!'; * by moving the name of the original cursor to the data-savedcursor attr. * omit cursor to revert to the previously set value. */ -module.exports = function overrideCursor(el3, csr) { +module.exports = function(el3, csr) { var savedCursor = el3.attr(STASHATTR); if(csr) { if(!savedCursor) { diff --git a/src/lib/polygon.js b/src/lib/polygon.js index ee28750d2fe..15584c7a255 100644 --- a/src/lib/polygon.js +++ b/src/lib/polygon.js @@ -30,7 +30,7 @@ var polygon = module.exports = {}; * don't double-count the edge where they meet. * returns boolean: is pt inside the polygon (including on its edges) */ -polygon.tester = function tester(ptsIn) { +polygon.tester = function(ptsIn) { var pts = ptsIn.slice(); var xmin = pts[0][0]; var xmax = xmin; @@ -181,7 +181,7 @@ polygon.tester = function tester(ptsIn) { * before the line counts as bent * @returns boolean: true means this segment is bent, false means straight */ -var isBent = polygon.isSegmentBent = function isBent(pts, start, end, tolerance) { +var isBent = polygon.isSegmentBent = function(pts, start, end, tolerance) { var startPt = pts[start]; var segment = [pts[end][0] - startPt[0], pts[end][1] - startPt[1]]; var segmentSquared = dot(segment, segment); @@ -214,7 +214,7 @@ var isBent = polygon.isSegmentBent = function isBent(pts, start, end, tolerance) * raw is all the input points * filtered is the resulting filtered Array of [x, y] pairs */ -polygon.filter = function filter(pts, tolerance) { +polygon.filter = function(pts, tolerance) { var ptsFiltered = [pts[0]]; var doneRawIndex = 0; var doneFilteredIndex = 0; diff --git a/src/lib/prepare_regl.js b/src/lib/prepare_regl.js index f16c33e33ee..aedceeb52ed 100644 --- a/src/lib/prepare_regl.js +++ b/src/lib/prepare_regl.js @@ -26,7 +26,7 @@ var createRegl = require('regl'); * * @return {boolean} true if all createRegl calls succeeded, false otherwise */ -module.exports = function prepareRegl(gd, extensions) { +module.exports = function(gd, extensions) { var fullLayout = gd._fullLayout; var success = true; diff --git a/src/lib/push_unique.js b/src/lib/push_unique.js index 64bcbaeab0c..76fd78c2ee3 100644 --- a/src/lib/push_unique.js +++ b/src/lib/push_unique.js @@ -21,7 +21,7 @@ * ref to array (now possibly containing one more item) * */ -module.exports = function pushUnique(array, item) { +module.exports = function(array, item) { if(item instanceof RegExp) { var itemStr = item.toString(); for(var i = 0; i < array.length; i++) { diff --git a/src/lib/queue.js b/src/lib/queue.js index f86a1c10b93..54b7fc3e217 100644 --- a/src/lib/queue.js +++ b/src/lib/queue.js @@ -123,7 +123,7 @@ queue.stopSequence = function(gd) { * * @param gd */ -queue.undo = function undo(gd) { +queue.undo = function(gd) { var queueObj, i; if(gd.framework && gd.framework.isPolar) { @@ -156,7 +156,7 @@ queue.undo = function undo(gd) { * * @param gd */ -queue.redo = function redo(gd) { +queue.redo = function(gd) { var queueObj, i; if(gd.framework && gd.framework.isPolar) { diff --git a/src/lib/relink_private.js b/src/lib/relink_private.js index 22981cb094f..5ad8930f03c 100644 --- a/src/lib/relink_private.js +++ b/src/lib/relink_private.js @@ -19,7 +19,7 @@ var isPlainObject = require('./is_plain_object'); * if object is pass-by-ref. * This prevents deepCopying massive structures like a webgl context. */ -module.exports = function relinkPrivateKeys(toContainer, fromContainer) { +function relinkPrivateKeys(toContainer, fromContainer) { for(var k in fromContainer) { var fromVal = fromContainer[k]; var toVal = toContainer[k]; @@ -53,4 +53,6 @@ module.exports = function relinkPrivateKeys(toContainer, fromContainer) { if(!Object.keys(toVal).length) delete toContainer[k]; } } -}; +} + +module.exports = relinkPrivateKeys; diff --git a/src/lib/setcursor.js b/src/lib/setcursor.js index 7404b660fc8..7c5167eb0f7 100644 --- a/src/lib/setcursor.js +++ b/src/lib/setcursor.js @@ -12,7 +12,7 @@ // works with our CSS cursor classes (see css/_cursor.scss) // to apply cursors to d3 single-element selections. // omit cursor to revert to the default. -module.exports = function setCursor(el3, csr) { +module.exports = function(el3, csr) { (el3.attr('class') || '').split(' ').forEach(function(cls) { if(cls.indexOf('cursor-') === 0) el3.classed(cls, false); }); diff --git a/src/lib/show_no_webgl_msg.js b/src/lib/show_no_webgl_msg.js index 645f56d6b7e..52af96d166d 100644 --- a/src/lib/show_no_webgl_msg.js +++ b/src/lib/show_no_webgl_msg.js @@ -21,7 +21,7 @@ var noop = function() {}; * Expects 'scene' to have property 'container' * */ -module.exports = function showNoWebGlMsg(scene) { +module.exports = function(scene) { for(var prop in scene) { if(typeof scene[prop] === 'function') scene[prop] = noop; } diff --git a/src/lib/svg_text_utils.js b/src/lib/svg_text_utils.js index 37d8de07458..d60bbcab207 100644 --- a/src/lib/svg_text_utils.js +++ b/src/lib/svg_text_utils.js @@ -624,11 +624,11 @@ function buildSVGText(containerNode, str) { return hasLink; } -exports.lineCount = function lineCount(s) { +exports.lineCount = function(s) { return s.selectAll('tspan.line').size() || 1; }; -exports.positionText = function positionText(s, x, y) { +exports.positionText = function(s, x, y) { return s.each(function() { var text = d3.select(this); diff --git a/src/lib/throttle.js b/src/lib/throttle.js index 1603d3b0812..a59553608f7 100644 --- a/src/lib/throttle.js +++ b/src/lib/throttle.js @@ -24,7 +24,7 @@ var timerCache = {}; * @param {function} callback: the function to throttle. `callback` itself * should be a purely synchronous function. */ -exports.throttle = function throttle(id, minInterval, callback) { +exports.throttle = function(id, minInterval, callback) { var cache = timerCache[id]; var now = Date.now(); @@ -70,7 +70,7 @@ exports.done = function(id) { return new Promise(function(resolve) { var previousOnDone = cache.onDone; - cache.onDone = function onDone() { + cache.onDone = function() { if(previousOnDone) previousOnDone(); resolve(); cache.onDone = null; diff --git a/src/lib/to_log_range.js b/src/lib/to_log_range.js index e130579ecbe..debbdfe1dd1 100644 --- a/src/lib/to_log_range.js +++ b/src/lib/to_log_range.js @@ -14,7 +14,7 @@ var isNumeric = require('fast-isnumeric'); * convert a linear value into a logged value, folding negative numbers into * the given range */ -module.exports = function toLogRange(val, range) { +module.exports = function(val, range) { if(val > 0) return Math.log(val) / Math.LN10; // move a negative value reference to a log axis - just put the diff --git a/src/plot_api/container_array_match.js b/src/plot_api/container_array_match.js index 45e6192d01c..e09ba5c5e85 100644 --- a/src/plot_api/container_array_match.js +++ b/src/plot_api/container_array_match.js @@ -24,7 +24,7 @@ var Registry = require('../registry'); * if the whole array) and the property within that (or '' if the whole array * or the whole object) */ -module.exports = function containerArrayMatch(astr) { +module.exports = function(astr) { var rootContainers = Registry.layoutArrayContainers; var regexpContainers = Registry.layoutArrayRegexes; var rootPart = astr.split('[')[0]; diff --git a/src/plot_api/manage_arrays.js b/src/plot_api/manage_arrays.js index 3bea13ca6a7..93f5e3eea53 100644 --- a/src/plot_api/manage_arrays.js +++ b/src/plot_api/manage_arrays.js @@ -18,11 +18,11 @@ var Registry = require('../registry'); exports.containerArrayMatch = require('./container_array_match'); -var isAddVal = exports.isAddVal = function isAddVal(val) { +var isAddVal = exports.isAddVal = function(val) { return val === 'add' || isPlainObject(val); }; -var isRemoveVal = exports.isRemoveVal = function isRemoveVal(val) { +var isRemoveVal = exports.isRemoveVal = function(val) { return val === null || val === 'remove'; }; @@ -73,7 +73,7 @@ var isRemoveVal = exports.isRemoveVal = function isRemoveVal(val) { * @returns {bool} `true` if it managed to complete drawing of the changes * `false` would mean the parent should replot. */ -exports.applyContainerArrayChanges = function applyContainerArrayChanges(gd, np, edits, flags, _nestedProperty) { +exports.applyContainerArrayChanges = function(gd, np, edits, flags, _nestedProperty) { var componentType = np.astr; var supplyComponentDefaults = Registry.getComponentMethod(componentType, 'supplyLayoutDefaults'); var draw = Registry.getComponentMethod(componentType, 'draw'); diff --git a/src/plot_api/plot_api.js b/src/plot_api/plot_api.js index ad064ee5d7b..f77c82731df 100644 --- a/src/plot_api/plot_api.js +++ b/src/plot_api/plot_api.js @@ -403,7 +403,7 @@ function emitAfterPlot(gd) { } } -exports.setPlotConfig = function setPlotConfig(obj) { +exports.setPlotConfig = function(obj) { return Lib.extendFlat(dfltConfig, obj); }; @@ -2433,7 +2433,7 @@ exports.update = update; * Plotly.react data updates, dependent on uirevision attributes */ function guiEdit(func) { - return function wrappedEdit(gd) { + return function(gd) { gd._fullLayout._guiEditing = true; var p = func.apply(null, arguments); gd._fullLayout._guiEditing = false; @@ -3670,7 +3670,7 @@ exports.deleteFrames = function(gd, frameList) { * @param {string id or DOM element} gd * the id or DOM element of the graph container div */ -exports.purge = function purge(gd) { +exports.purge = function(gd) { gd = Lib.getGraphDiv(gd); var fullLayout = gd._fullLayout || {}; diff --git a/src/plot_api/validate.js b/src/plot_api/validate.js index 9b3164941d4..43432ee414d 100644 --- a/src/plot_api/validate.js +++ b/src/plot_api/validate.js @@ -38,7 +38,7 @@ var isArrayOrTypedArray = Lib.isArrayOrTypedArray; * - {string} msg * error message (shown in console in logger config argument is enable) */ -module.exports = function validate(data, layout) { +module.exports = function(data, layout) { var schema = PlotSchema.get(); var errorList = []; var gd = {_context: Lib.extendFlat({}, dfltConfig)}; diff --git a/src/plots/array_container_defaults.js b/src/plots/array_container_defaults.js index 89581e2045f..29f72862207 100644 --- a/src/plots/array_container_defaults.js +++ b/src/plots/array_container_defaults.js @@ -42,7 +42,7 @@ var Template = require('../plot_api/plot_template'); * links to supplementary data (e.g. fullData for layout components) * */ -module.exports = function handleArrayContainerDefaults(parentObjIn, parentObjOut, opts) { +module.exports = function(parentObjIn, parentObjOut, opts) { var name = opts.name; var inclusionAttr = opts.inclusionAttr || 'visible'; diff --git a/src/plots/cartesian/autorange.js b/src/plots/cartesian/autorange.js index 2b8a176d747..05be6ec59a9 100644 --- a/src/plots/cartesian/autorange.js +++ b/src/plots/cartesian/autorange.js @@ -197,7 +197,7 @@ function makePadFn(ax) { (ax.domain[1] - ax.domain[0]); } - return function getPad(pt) { return pt.pad + (pt.extrapad ? extrappad : 0); }; + return function(pt) { return pt.pad + (pt.extrapad ? extrappad : 0); }; } function concatExtremes(gd, ax) { diff --git a/src/plots/cartesian/axes.js b/src/plots/cartesian/axes.js index e56537802dc..bc41780719d 100644 --- a/src/plots/cartesian/axes.js +++ b/src/plots/cartesian/axes.js @@ -550,7 +550,7 @@ axes.prepTicks = function(ax) { // if ticks are set to automatic, determine the right values (tick0,dtick) // in any case, set tickround to # of digits to round tick labels to, // or codes to this effect for log and date scales -axes.calcTicks = function calcTicks(ax) { +axes.calcTicks = function(ax) { axes.prepTicks(ax); var rng = Lib.simpleMap(ax.range, ax.r2l); diff --git a/src/plots/cartesian/axis_autotype.js b/src/plots/cartesian/axis_autotype.js index eb4c2941d72..e5f5c47ad07 100644 --- a/src/plots/cartesian/axis_autotype.js +++ b/src/plots/cartesian/axis_autotype.js @@ -14,7 +14,7 @@ var isNumeric = require('fast-isnumeric'); var Lib = require('../../lib'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function autoType(array, calendar, opts) { +module.exports = function(array, calendar, opts) { opts = opts || {}; if(!opts.noMultiCategory && multiCategory(array)) return 'multicategory'; diff --git a/src/plots/cartesian/axis_defaults.js b/src/plots/cartesian/axis_defaults.js index 2269152de39..178cf6ac32d 100644 --- a/src/plots/cartesian/axis_defaults.js +++ b/src/plots/cartesian/axis_defaults.js @@ -32,7 +32,7 @@ var setConvert = require('./set_convert'); * data: the plot data, used to manage categories * bgColor: the plot background color, to calculate default gridline colors */ -module.exports = function handleAxisDefaults(containerIn, containerOut, coerce, options, layoutOut) { +module.exports = function(containerIn, containerOut, coerce, options, layoutOut) { var letter = options.letter; var font = options.font || {}; var splomStash = options.splomStash || {}; diff --git a/src/plots/cartesian/axis_ids.js b/src/plots/cartesian/axis_ids.js index 940dc9c2530..29f54cdd83a 100644 --- a/src/plots/cartesian/axis_ids.js +++ b/src/plots/cartesian/axis_ids.js @@ -16,21 +16,21 @@ var constants = require('./constants'); // convert between axis names (xaxis, xaxis2, etc, elements of gd.layout) // and axis id's (x, x2, etc). Would probably have ditched 'xaxis' // completely in favor of just 'x' if it weren't ingrained in the API etc. -exports.id2name = function id2name(id) { +exports.id2name = function(id) { if(typeof id !== 'string' || !id.match(constants.AX_ID_PATTERN)) return; var axNum = id.substr(1); if(axNum === '1') axNum = ''; return id.charAt(0) + 'axis' + axNum; }; -exports.name2id = function name2id(name) { +exports.name2id = function(name) { if(!name.match(constants.AX_NAME_PATTERN)) return; var axNum = name.substr(5); if(axNum === '1') axNum = ''; return name.charAt(0) + axNum; }; -exports.cleanId = function cleanId(id, axLetter) { +exports.cleanId = function(id, axLetter) { if(!id.match(constants.AX_ID_PATTERN)) return; if(axLetter && id.charAt(0) !== axLetter) return; @@ -114,7 +114,7 @@ exports.idSort = function(id1, id2) { return +(id1.substr(1) || 1) - +(id2.substr(1) || 1); }; -exports.getAxisGroup = function getAxisGroup(fullLayout, axId) { +exports.getAxisGroup = function(fullLayout, axId) { var matchGroups = fullLayout._axisMatchGroups; for(var i = 0; i < matchGroups.length; i++) { diff --git a/src/plots/cartesian/category_order_defaults.js b/src/plots/cartesian/category_order_defaults.js index 9980ff0620f..e3680cbe2da 100644 --- a/src/plots/cartesian/category_order_defaults.js +++ b/src/plots/cartesian/category_order_defaults.js @@ -53,7 +53,7 @@ function findCategories(ax, opts) { * - axData {array} : (full) data associated with axis being coerced here * - dataAttr {string} : attribute name corresponding to coordinate array */ -module.exports = function handleCategoryOrderDefaults(containerIn, containerOut, coerce, opts) { +module.exports = function(containerIn, containerOut, coerce, opts) { if(containerOut.type !== 'category') return; var arrayIn = containerIn.categoryarray; diff --git a/src/plots/cartesian/constraints.js b/src/plots/cartesian/constraints.js index a6d31d3dd8f..9f8e55f0c5b 100644 --- a/src/plots/cartesian/constraints.js +++ b/src/plots/cartesian/constraints.js @@ -188,7 +188,7 @@ function updateConstraintGroups(constraintGroups, thisGroup, thisID, scaleanchor thisGroup[scaleanchor] = 1; } -exports.enforce = function enforceAxisConstraints(gd) { +exports.enforce = function(gd) { var fullLayout = gd._fullLayout; var constraintGroups = fullLayout._axisConstraintGroups || []; @@ -346,7 +346,7 @@ exports.enforce = function enforceAxisConstraints(gd) { // For use before autoranging, check if this axis was previously constrained // by domain but no longer is -exports.clean = function cleanConstraints(gd, ax) { +exports.clean = function(gd, ax) { if(ax._inputDomain) { var isConstrained = false; var axId = ax._id; diff --git a/src/plots/cartesian/graph_interact.js b/src/plots/cartesian/graph_interact.js index 716fc1b120d..030b14801c3 100644 --- a/src/plots/cartesian/graph_interact.js +++ b/src/plots/cartesian/graph_interact.js @@ -18,7 +18,7 @@ var setCursor = require('../../lib/setcursor'); var makeDragBox = require('./dragbox').makeDragBox; var DRAGGERSIZE = require('./constants').DRAGGERSIZE; -exports.initInteractions = function initInteractions(gd) { +exports.initInteractions = function(gd) { var fullLayout = gd._fullLayout; if(gd._context.staticPlot) { diff --git a/src/plots/cartesian/include_components.js b/src/plots/cartesian/include_components.js index 11f0b146782..157666708e0 100644 --- a/src/plots/cartesian/include_components.js +++ b/src/plots/cartesian/include_components.js @@ -23,8 +23,8 @@ var Lib = require('../../lib'); * @return {function}: with args layoutIn (gd.layout) and layoutOut (gd._fullLayout) * as expected of a component includeBasePlot method */ -module.exports = function makeIncludeComponents(containerArrayName) { - return function includeComponents(layoutIn, layoutOut) { +module.exports = function(containerArrayName) { + return function(layoutIn, layoutOut) { var array = layoutIn[containerArrayName]; if(!Array.isArray(array)) return; diff --git a/src/plots/cartesian/layout_defaults.js b/src/plots/cartesian/layout_defaults.js index 8a6f6235b10..a0ea93ada85 100644 --- a/src/plots/cartesian/layout_defaults.js +++ b/src/plots/cartesian/layout_defaults.js @@ -33,7 +33,7 @@ function appendList(cont, k, item) { else cont[k] = [item]; } -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { +module.exports = function(layoutIn, layoutOut, fullData) { var ax2traces = {}; var xaCheater = {}; var xaNonCheater = {}; diff --git a/src/plots/cartesian/line_grid_defaults.js b/src/plots/cartesian/line_grid_defaults.js index 1a107efa881..0ec1e49306f 100644 --- a/src/plots/cartesian/line_grid_defaults.js +++ b/src/plots/cartesian/line_grid_defaults.js @@ -22,7 +22,7 @@ var Lib = require('../../lib'); * - noZeroLine {boolean} : don't coerce zeroline* attributes * - attributes {object} : attribute object associated with input containers */ -module.exports = function handleLineGridDefaults(containerIn, containerOut, coerce, opts) { +module.exports = function(containerIn, containerOut, coerce, opts) { opts = opts || {}; var dfltColor = opts.dfltColor; diff --git a/src/plots/cartesian/position_defaults.js b/src/plots/cartesian/position_defaults.js index 41a4ed24ec3..7768073178a 100644 --- a/src/plots/cartesian/position_defaults.js +++ b/src/plots/cartesian/position_defaults.js @@ -14,7 +14,7 @@ var isNumeric = require('fast-isnumeric'); var Lib = require('../../lib'); -module.exports = function handlePositionDefaults(containerIn, containerOut, coerce, options) { +module.exports = function(containerIn, containerOut, coerce, options) { var counterAxes = options.counterAxes || []; var overlayableAxes = options.overlayableAxes || []; var letter = options.letter; diff --git a/src/plots/cartesian/scale_zoom.js b/src/plots/cartesian/scale_zoom.js index cc74c3be0f1..0c3309cfec3 100644 --- a/src/plots/cartesian/scale_zoom.js +++ b/src/plots/cartesian/scale_zoom.js @@ -11,7 +11,7 @@ var FROM_BL = require('../../constants/alignment').FROM_BL; -module.exports = function scaleZoom(ax, factor, centerFraction) { +module.exports = function(ax, factor, centerFraction) { if(centerFraction === undefined) { centerFraction = FROM_BL[ax.constraintoward || 'center']; } diff --git a/src/plots/cartesian/set_convert.js b/src/plots/cartesian/set_convert.js index 55bb4bdcb98..214e5296f0a 100644 --- a/src/plots/cartesian/set_convert.js +++ b/src/plots/cartesian/set_convert.js @@ -59,7 +59,7 @@ function isValidCategory(v) { * * also clears the autotick constraints ._minDtick, ._forceTick0 */ -module.exports = function setConvert(ax, fullLayout) { +module.exports = function(ax, fullLayout) { fullLayout = fullLayout || {}; var axId = (ax._id || 'x'); diff --git a/src/plots/cartesian/tick_label_defaults.js b/src/plots/cartesian/tick_label_defaults.js index 5bbe72765fc..b31621a8b70 100644 --- a/src/plots/cartesian/tick_label_defaults.js +++ b/src/plots/cartesian/tick_label_defaults.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var layoutAttributes = require('./layout_attributes'); var handleArrayContainerDefaults = require('../array_container_defaults'); -module.exports = function handleTickLabelDefaults(containerIn, containerOut, coerce, axType, options) { +module.exports = function(containerIn, containerOut, coerce, axType, options) { var showAttrDflt = getShowAttrDflt(containerIn); var tickPrefix = coerce('tickprefix'); diff --git a/src/plots/cartesian/tick_mark_defaults.js b/src/plots/cartesian/tick_mark_defaults.js index 8667c708cd7..fb44d6d0880 100644 --- a/src/plots/cartesian/tick_mark_defaults.js +++ b/src/plots/cartesian/tick_mark_defaults.js @@ -17,7 +17,7 @@ var layoutAttributes = require('./layout_attributes'); /** * options: inherits outerTicks from axes.handleAxisDefaults */ -module.exports = function handleTickDefaults(containerIn, containerOut, coerce, options) { +module.exports = function(containerIn, containerOut, coerce, options) { var tickLen = Lib.coerce2(containerIn, containerOut, layoutAttributes, 'ticklen'); var tickWidth = Lib.coerce2(containerIn, containerOut, layoutAttributes, 'tickwidth'); var tickColor = Lib.coerce2(containerIn, containerOut, layoutAttributes, 'tickcolor', containerOut.color); diff --git a/src/plots/cartesian/tick_value_defaults.js b/src/plots/cartesian/tick_value_defaults.js index 6f8262f0674..8f7307543c2 100644 --- a/src/plots/cartesian/tick_value_defaults.js +++ b/src/plots/cartesian/tick_value_defaults.js @@ -10,7 +10,7 @@ var cleanTicks = require('./clean_ticks'); -module.exports = function handleTickValueDefaults(containerIn, containerOut, coerce, axType) { +module.exports = function(containerIn, containerOut, coerce, axType) { var tickmode; if(containerIn.tickmode === 'array' && diff --git a/src/plots/cartesian/transition_axes.js b/src/plots/cartesian/transition_axes.js index 46bbdf704cb..c370436fc44 100644 --- a/src/plots/cartesian/transition_axes.js +++ b/src/plots/cartesian/transition_axes.js @@ -30,7 +30,7 @@ var Axes = require('./axes'); * @param {object} transitionOpts * @param {function} makeOnCompleteCallback */ -module.exports = function transitionAxes(gd, edits, transitionOpts, makeOnCompleteCallback) { +module.exports = function(gd, edits, transitionOpts, makeOnCompleteCallback) { var fullLayout = gd._fullLayout; // special case for redraw:false Plotly.animate that relies on this diff --git a/src/plots/cartesian/type_defaults.js b/src/plots/cartesian/type_defaults.js index 16237397bf8..1527e23cb3a 100644 --- a/src/plots/cartesian/type_defaults.js +++ b/src/plots/cartesian/type_defaults.js @@ -15,7 +15,7 @@ var autoType = require('./axis_autotype'); * data: the plot data to use in choosing auto type * name: axis object name (ie 'xaxis') if one should be stored */ -module.exports = function handleTypeDefaults(containerIn, containerOut, coerce, options) { +module.exports = function(containerIn, containerOut, coerce, options) { var axType = coerce('type', (options.splomStash || {}).type); if(axType === '-') { diff --git a/src/plots/command.js b/src/plots/command.js index b04897b4cb4..08ca9ae0982 100644 --- a/src/plots/command.js +++ b/src/plots/command.js @@ -67,7 +67,7 @@ exports.manageCommandObserver = function(gd, container, commandList, onchange) { // Build the cache: bindingValueHasChanged(gd, binding, ret.cache); - ret.check = function check() { + ret.check = function() { if(!enabled) return; var update = bindingValueHasChanged(gd, binding, ret.cache); @@ -117,11 +117,11 @@ exports.manageCommandObserver = function(gd, container, commandList, onchange) { ret.remove = function() {}; } - ret.disable = function disable() { + ret.disable = function() { enabled = false; }; - ret.enable = function enable() { + ret.enable = function() { enabled = true; }; diff --git a/src/plots/geo/geo.js b/src/plots/geo/geo.js index c0aba22e870..fec149bd596 100644 --- a/src/plots/geo/geo.js +++ b/src/plots/geo/geo.js @@ -64,7 +64,7 @@ function Geo(opts) { var proto = Geo.prototype; -module.exports = function createGeo(opts) { +module.exports = function(opts) { return new Geo(opts); }; diff --git a/src/plots/geo/layout_defaults.js b/src/plots/geo/layout_defaults.js index 34da1d42edf..c6e1e1be1d6 100644 --- a/src/plots/geo/layout_defaults.js +++ b/src/plots/geo/layout_defaults.js @@ -15,7 +15,7 @@ var layoutAttributes = require('./layout_attributes'); var axesNames = constants.axesNames; -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { +module.exports = function(layoutIn, layoutOut, fullData) { handleSubplotDefaults(layoutIn, layoutOut, fullData, { type: 'geo', attributes: layoutAttributes, diff --git a/src/plots/get_data.js b/src/plots/get_data.js index b543c2f75bb..b64133242cb 100644 --- a/src/plots/get_data.js +++ b/src/plots/get_data.js @@ -96,7 +96,7 @@ exports.getModuleCalcData = function(calcdata, arg1) { * @return {array} list of trace objects. * */ -exports.getSubplotData = function getSubplotData(data, type, subplotId) { +exports.getSubplotData = function(data, type, subplotId) { if(!Registry.subplotsRegistry[type]) return []; var attr = Registry.subplotsRegistry[type].attr; diff --git a/src/plots/gl2d/index.js b/src/plots/gl2d/index.js index fe240901ef0..89bc362bfeb 100644 --- a/src/plots/gl2d/index.js +++ b/src/plots/gl2d/index.js @@ -52,7 +52,7 @@ exports.baseLayoutAttrOverrides = overrideAll({ // dragmode: fxAttrs.dragmode }, 'plot', 'nested'); -exports.plot = function plotGl2d(gd) { +exports.plot = function(gd) { var fullLayout = gd._fullLayout; var fullData = gd._fullData; var subplotIds = fullLayout._subplots.gl2d; diff --git a/src/plots/gl3d/index.js b/src/plots/gl3d/index.js index 55c390b7619..08a39c56ce8 100644 --- a/src/plots/gl3d/index.js +++ b/src/plots/gl3d/index.js @@ -39,7 +39,7 @@ exports.baseLayoutAttrOverrides = overrideAll({ exports.supplyLayoutDefaults = require('./layout/defaults'); -exports.plot = function plotGl3d(gd) { +exports.plot = function(gd) { var fullLayout = gd._fullLayout; var fullData = gd._fullData; var sceneIds = fullLayout._subplots[GL3D]; @@ -138,7 +138,7 @@ exports.toSVG = function(gd) { }; // clean scene ids, 'scene1' -> 'scene' -exports.cleanId = function cleanId(id) { +exports.cleanId = function(id) { if(!id.match(/^scene[0-9]*$/)) return; var sceneNum = id.substr(5); diff --git a/src/plots/gl3d/layout/axis_defaults.js b/src/plots/gl3d/layout/axis_defaults.js index ff55bdad2e1..5051663b92e 100644 --- a/src/plots/gl3d/layout/axis_defaults.js +++ b/src/plots/gl3d/layout/axis_defaults.js @@ -24,7 +24,7 @@ var axesNames = ['xaxis', 'yaxis', 'zaxis']; // that differ from other subplot types. var gridLightness = 100 * (204 - 0x44) / (255 - 0x44); -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, options) { +module.exports = function(layoutIn, layoutOut, options) { var containerIn, containerOut; function coerce(attr, dflt) { diff --git a/src/plots/gl3d/layout/defaults.js b/src/plots/gl3d/layout/defaults.js index da9a5b2805a..3bef447c12f 100644 --- a/src/plots/gl3d/layout/defaults.js +++ b/src/plots/gl3d/layout/defaults.js @@ -20,7 +20,7 @@ var getSubplotData = require('../../get_data').getSubplotData; var GL3D = 'gl3d'; -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { +module.exports = function(layoutIn, layoutOut, fullData) { var hasNon3D = layoutOut._basePlotModules.length > 1; // some layout-wide attribute are used in all scenes diff --git a/src/plots/gl3d/scene.js b/src/plots/gl3d/scene.js index b15ef824713..ec3be1691de 100644 --- a/src/plots/gl3d/scene.js +++ b/src/plots/gl3d/scene.js @@ -756,13 +756,13 @@ function getLayoutCamera(camera) { } // get camera position in plotly coords from 'orbit-camera' coords -proto.getCamera = function getCamera() { +proto.getCamera = function() { this.glplot.camera.view.recalcMatrix(this.camera.view.lastT()); return getLayoutCamera(this.glplot.camera); }; // set camera position with a set of plotly coords -proto.setCamera = function setCamera(cameraData) { +proto.setCamera = function(cameraData) { this.glplot.camera.lookAt.apply(this, getOrbitCamera(cameraData)); var newOrtho = (cameraData.projection.type === 'orthographic'); @@ -790,7 +790,7 @@ proto.setCamera = function setCamera(cameraData) { }; // save camera to user layout (i.e. gd.layout) -proto.saveCamera = function saveCamera(layout) { +proto.saveCamera = function(layout) { var fullLayout = this.fullLayout; var cameraData = this.getCamera(); var cameraNestedProp = Lib.nestedProperty(layout, this.id + '.camera'); diff --git a/src/plots/gl3d/zip3.js b/src/plots/gl3d/zip3.js index 28a0b1b1d11..b315ce46ebc 100644 --- a/src/plots/gl3d/zip3.js +++ b/src/plots/gl3d/zip3.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function zip3(x, y, z, len) { +module.exports = function(x, y, z, len) { len = len || x.length; var result = new Array(len); diff --git a/src/plots/mapbox/convert_text_opts.js b/src/plots/mapbox/convert_text_opts.js index 52b8e39fada..ba9f838491f 100644 --- a/src/plots/mapbox/convert_text_opts.js +++ b/src/plots/mapbox/convert_text_opts.js @@ -22,7 +22,7 @@ var Lib = require('../../lib'); * - anchor * - offset */ -module.exports = function convertTextOpts(textposition, iconSize) { +module.exports = function(textposition, iconSize) { var parts = textposition.split(' '); var vPos = parts[0]; var hPos = parts[1]; diff --git a/src/plots/mapbox/index.js b/src/plots/mapbox/index.js index 5614173550a..2524b1cfcf6 100644 --- a/src/plots/mapbox/index.js +++ b/src/plots/mapbox/index.js @@ -50,7 +50,7 @@ exports.layoutAttributes = require('./layout_attributes'); exports.supplyLayoutDefaults = require('./layout_defaults'); -exports.plot = function plotMapbox(gd) { +exports.plot = function(gd) { var fullLayout = gd._fullLayout; var calcData = gd.calcdata; var mapboxIds = fullLayout._subplots[MAPBOX]; diff --git a/src/plots/mapbox/layers.js b/src/plots/mapbox/layers.js index 914b30ea3a6..708fe7d26e6 100644 --- a/src/plots/mapbox/layers.js +++ b/src/plots/mapbox/layers.js @@ -32,7 +32,7 @@ function MapboxLayer(mapbox, index) { var proto = MapboxLayer.prototype; -proto.update = function update(opts) { +proto.update = function(opts) { if(!this.visible) { // IMPORTANT: must create source before layer to not cause errors this.updateSource(opts); @@ -120,7 +120,7 @@ proto.removeLayer = function() { } }; -proto.dispose = function dispose() { +proto.dispose = function() { var map = this.map; map.removeLayer(this.idLayer); map.removeSource(this.idSource); @@ -212,7 +212,7 @@ function convertSourceOpts(opts) { return sourceOpts; } -module.exports = function createMapboxLayer(mapbox, index, opts) { +module.exports = function(mapbox, index, opts) { var mapboxLayer = new MapboxLayer(mapbox, index); mapboxLayer.update(opts); diff --git a/src/plots/mapbox/layout_defaults.js b/src/plots/mapbox/layout_defaults.js index b9651e06ba5..6ac2f28563c 100644 --- a/src/plots/mapbox/layout_defaults.js +++ b/src/plots/mapbox/layout_defaults.js @@ -16,7 +16,7 @@ var handleArrayContainerDefaults = require('../array_container_defaults'); var layoutAttributes = require('./layout_attributes'); -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { +module.exports = function(layoutIn, layoutOut, fullData) { handleSubplotDefaults(layoutIn, layoutOut, fullData, { type: 'mapbox', attributes: layoutAttributes, diff --git a/src/plots/mapbox/mapbox.js b/src/plots/mapbox/mapbox.js index 12494985486..a5036c71f23 100644 --- a/src/plots/mapbox/mapbox.js +++ b/src/plots/mapbox/mapbox.js @@ -48,7 +48,7 @@ function Mapbox(opts) { var proto = Mapbox.prototype; -module.exports = function createMapbox(opts) { +module.exports = function(opts) { return new Mapbox(opts); }; diff --git a/src/plots/plots.js b/src/plots/plots.js index 3ac177d31bc..fc4eafc1558 100644 --- a/src/plots/plots.js +++ b/src/plots/plots.js @@ -1463,7 +1463,7 @@ plots.supplyLayoutGlobalDefaults = function(layoutIn, layoutOut, formatObj) { )(layoutIn, layoutOut, coerce); }; -plots.plotAutoSize = function plotAutoSize(gd, layout, fullLayout) { +plots.plotAutoSize = function(gd, layout, fullLayout) { var context = gd._context || {}; var frameMargins = context.frameMargins; var newWidth; diff --git a/src/plots/polar/layout_defaults.js b/src/plots/polar/layout_defaults.js index 6c7fb220dc6..ab928e455e8 100644 --- a/src/plots/polar/layout_defaults.js +++ b/src/plots/polar/layout_defaults.js @@ -218,7 +218,7 @@ function handleAxisTypeDefaults(axIn, axOut, coerce, subplotData, dataAttr) { return axOut.type; } -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { +module.exports = function(layoutIn, layoutOut, fullData) { handleSubplotDefaults(layoutIn, layoutOut, fullData, { type: constants.name, attributes: layoutAttributes, diff --git a/src/plots/polar/legacy/undo_manager.js b/src/plots/polar/legacy/undo_manager.js index f684bdb96a0..ba2ec983007 100644 --- a/src/plots/polar/legacy/undo_manager.js +++ b/src/plots/polar/legacy/undo_manager.js @@ -10,7 +10,7 @@ // Modified from https://github.com/ArthurClemens/Javascript-Undo-Manager // Copyright (c) 2010-2013 Arthur Clemens, arthur@visiblearea.com -module.exports = function UndoManager() { +module.exports = function() { var undoCommands = []; var index = -1; var isExecuting = false; diff --git a/src/plots/polar/polar.js b/src/plots/polar/polar.js index a6f33e2da6c..19cbdefe27d 100644 --- a/src/plots/polar/polar.js +++ b/src/plots/polar/polar.js @@ -72,7 +72,7 @@ function Polar(gd, id) { var proto = Polar.prototype; -module.exports = function createPolar(gd, id) { +module.exports = function(gd, id) { return new Polar(gd, id); }; diff --git a/src/plots/polar/set_convert.js b/src/plots/polar/set_convert.js index bbcc341d1da..316e402377a 100644 --- a/src/plots/polar/set_convert.js +++ b/src/plots/polar/set_convert.js @@ -46,7 +46,7 @@ var rad2deg = Lib.rad2deg; * * Then, 'g'eometric data is ready to be converted to (x,y). */ -module.exports = function setConvert(ax, polarLayout, fullLayout) { +module.exports = function(ax, polarLayout, fullLayout) { setConvertCartesian(ax, fullLayout); switch(ax._id) { diff --git a/src/plots/subplot_defaults.js b/src/plots/subplot_defaults.js index de02e8a5803..9fa1ffea194 100644 --- a/src/plots/subplot_defaults.js +++ b/src/plots/subplot_defaults.js @@ -41,7 +41,7 @@ var handleDomainDefaults = require('./domain').defaults; * additional items needed by this function here as well * } */ -module.exports = function handleSubplotDefaults(layoutIn, layoutOut, fullData, opts) { +module.exports = function(layoutIn, layoutOut, fullData, opts) { var subplotType = opts.type; var subplotAttributes = opts.attributes; var handleDefaults = opts.handleDefaults; diff --git a/src/plots/ternary/index.js b/src/plots/ternary/index.js index 0c6d16169eb..08910bdbbc0 100644 --- a/src/plots/ternary/index.js +++ b/src/plots/ternary/index.js @@ -41,7 +41,7 @@ exports.layoutAttributes = require('./layout_attributes'); exports.supplyLayoutDefaults = require('./layout_defaults'); -exports.plot = function plotTernary(gd) { +exports.plot = function(gd) { var fullLayout = gd._fullLayout; var calcData = gd.calcdata; var ternaryIds = fullLayout._subplots[TERNARY]; diff --git a/src/plots/ternary/layout_defaults.js b/src/plots/ternary/layout_defaults.js index 7ab47dee7ac..06168788550 100644 --- a/src/plots/ternary/layout_defaults.js +++ b/src/plots/ternary/layout_defaults.js @@ -21,7 +21,7 @@ var layoutAttributes = require('./layout_attributes'); var axesNames = ['aaxis', 'baxis', 'caxis']; -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { +module.exports = function(layoutIn, layoutOut, fullData) { handleSubplotDefaults(layoutIn, layoutOut, fullData, { type: 'ternary', attributes: layoutAttributes, diff --git a/src/registry.js b/src/registry.js index 37e17595f0f..232e061fb1e 100644 --- a/src/registry.js +++ b/src/registry.js @@ -72,7 +72,7 @@ exports.collectableSubplotTypes = null; * - fn {function} : the api method called with Register.call(); * */ -exports.register = function register(_modules) { +exports.register = function(_modules) { exports.collectableSubplotTypes = null; if(!_modules) { diff --git a/src/snapshot/cloneplot.js b/src/snapshot/cloneplot.js index 239ad267dc2..038e1430980 100644 --- a/src/snapshot/cloneplot.js +++ b/src/snapshot/cloneplot.js @@ -57,7 +57,7 @@ function keyIsAxis(keyName) { } -module.exports = function clonePlot(graphObj, options) { +module.exports = function(graphObj, options) { // Polar plot compatibility if(graphObj.framework && graphObj.framework.isPolar) { graphObj = graphObj.framework.getConfig(); diff --git a/src/snapshot/tosvg.js b/src/snapshot/tosvg.js index 507bab751fd..37d80f73eaf 100644 --- a/src/snapshot/tosvg.js +++ b/src/snapshot/tosvg.js @@ -36,7 +36,7 @@ function xmlEntityEncode(str) { return str.replace(/&(?!\w+;|\#[0-9]+;| \#x[0-9A-F]+;)/g, '&'); } -module.exports = function toSVG(gd, format, scale) { +module.exports = function(gd, format, scale) { var fullLayout = gd._fullLayout; var svg = fullLayout._paper; var toppaper = fullLayout._toppaper; diff --git a/src/traces/bar/arrays_to_calcdata.js b/src/traces/bar/arrays_to_calcdata.js index a722f3dec04..949ee80e5ad 100644 --- a/src/traces/bar/arrays_to_calcdata.js +++ b/src/traces/bar/arrays_to_calcdata.js @@ -11,7 +11,7 @@ var mergeArray = require('../../lib').mergeArray; // arrayOk attributes, merge them into calcdata array -module.exports = function arraysToCalcdata(cd, trace) { +module.exports = function(cd, trace) { for(var i = 0; i < cd.length; i++) cd[i].i = i; mergeArray(trace.text, cd, 'tx'); diff --git a/src/traces/bar/calc.js b/src/traces/bar/calc.js index 41af79b7b1c..ab9deb782ff 100644 --- a/src/traces/bar/calc.js +++ b/src/traces/bar/calc.js @@ -14,7 +14,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); var arraysToCalcdata = require('./arrays_to_calcdata'); var calcSelection = require('../scatter/calc_selection'); -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var xa = Axes.getFromId(gd, trace.xaxis || 'x'); var ya = Axes.getFromId(gd, trace.yaxis || 'y'); var size, pos; diff --git a/src/traces/bar/plot.js b/src/traces/bar/plot.js index 9466ce9a061..0fdd3acb783 100644 --- a/src/traces/bar/plot.js +++ b/src/traces/bar/plot.js @@ -28,7 +28,7 @@ var style = require('./style'); // padding in pixels around text var TEXTPAD = 3; -module.exports = function plot(gd, plotinfo, cdModule, traceLayer) { +module.exports = function(gd, plotinfo, cdModule, traceLayer) { var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; var fullLayout = gd._fullLayout; diff --git a/src/traces/bar/select.js b/src/traces/bar/select.js index 5d277c95dd2..522e4dd6347 100644 --- a/src/traces/bar/select.js +++ b/src/traces/bar/select.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function selectPoints(searchInfo, selectionTester) { +module.exports = function(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/bar/sieve.js b/src/traces/bar/sieve.js index d9490bd7a7a..7b84f981717 100644 --- a/src/traces/bar/sieve.js +++ b/src/traces/bar/sieve.js @@ -66,7 +66,7 @@ function Sieve(traces, opts) { * @param {number} value * @returns {number} Previous bin value */ -Sieve.prototype.put = function put(position, value) { +Sieve.prototype.put = function(position, value) { var label = this.getLabel(position, value); var oldValue = this.bins[label] || 0; @@ -84,7 +84,7 @@ Sieve.prototype.put = function put(position, value) { * (required if this.sepNegVal is true) * @returns {number} Current bin value */ -Sieve.prototype.get = function put(position, value) { +Sieve.prototype.get = function(position, value) { var label = this.getLabel(position, value); return this.bins[label] || 0; }; @@ -100,7 +100,7 @@ Sieve.prototype.get = function put(position, value) { * (prefixed with a 'v' if value is negative and this.sepNegVal is * true; otherwise prefixed with '^') */ -Sieve.prototype.getLabel = function getLabel(position, value) { +Sieve.prototype.getLabel = function(position, value) { var prefix = (value < 0 && this.sepNegVal) ? 'v' : '^'; var label = (this.overlapNoMerge) ? position : diff --git a/src/traces/bar/style_defaults.js b/src/traces/bar/style_defaults.js index 0fb9bcde988..4a8aea7c703 100644 --- a/src/traces/bar/style_defaults.js +++ b/src/traces/bar/style_defaults.js @@ -12,7 +12,7 @@ var Color = require('../../components/color'); var hasColorscale = require('../../components/colorscale/helpers').hasColorscale; var colorscaleDefaults = require('../../components/colorscale/defaults'); -module.exports = function handleStyleDefaults(traceIn, traceOut, coerce, defaultColor, layout) { +module.exports = function(traceIn, traceOut, coerce, defaultColor, layout) { coerce('marker.color', defaultColor); if(hasColorscale(traceIn, 'marker')) { diff --git a/src/traces/barpolar/defaults.js b/src/traces/barpolar/defaults.js index 4265f46d7ab..773dc61fc59 100644 --- a/src/traces/barpolar/defaults.js +++ b/src/traces/barpolar/defaults.js @@ -14,7 +14,7 @@ var handleRThetaDefaults = require('../scatterpolar/defaults').handleRThetaDefau var handleStyleDefaults = require('../bar/style_defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/barpolar/hover.js b/src/traces/barpolar/hover.js index 2719f16725e..be8579012c9 100644 --- a/src/traces/barpolar/hover.js +++ b/src/traces/barpolar/hover.js @@ -15,7 +15,7 @@ var fillHoverText = require('../scatter/fill_hover_text'); var makeHoverPointText = require('../scatterpolar/hover').makeHoverPointText; var isPtInsidePolygon = require('../../plots/polar/helpers').isPtInsidePolygon; -module.exports = function hoverPoints(pointData, xval, yval) { +module.exports = function(pointData, xval, yval) { var cd = pointData.cd; var trace = cd[0].trace; diff --git a/src/traces/barpolar/plot.js b/src/traces/barpolar/plot.js index a627c07cdfb..692cc85db27 100644 --- a/src/traces/barpolar/plot.js +++ b/src/traces/barpolar/plot.js @@ -15,7 +15,7 @@ var Lib = require('../../lib'); var Drawing = require('../../components/drawing'); var helpers = require('../../plots/polar/helpers'); -module.exports = function plot(gd, subplot, cdbar) { +module.exports = function(gd, subplot, cdbar) { var xa = subplot.xaxis; var ya = subplot.yaxis; var radialAxis = subplot.radialAxis; diff --git a/src/traces/box/calc.js b/src/traces/box/calc.js index 0e424c5223d..a30af4243f0 100644 --- a/src/traces/box/calc.js +++ b/src/traces/box/calc.js @@ -15,7 +15,7 @@ var _ = Lib._; var Axes = require('../../plots/cartesian/axes'); // outlier definition based on http://www.physics.csbsju.edu/stats/box2.html -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var fullLayout = gd._fullLayout; var xa = Axes.getFromId(gd, trace.xaxis || 'x'); var ya = Axes.getFromId(gd, trace.yaxis || 'y'); diff --git a/src/traces/box/event_data.js b/src/traces/box/event_data.js index bd2171a5415..5c13fa11175 100644 --- a/src/traces/box/event_data.js +++ b/src/traces/box/event_data.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function eventData(out, pt) { +module.exports = function(out, pt) { // Note: hoverOnBox property is needed for click-to-select // to ignore when a box was clicked. This is the reason box // implements this custom eventData function. diff --git a/src/traces/box/select.js b/src/traces/box/select.js index 15c014ef10e..adddf7469fb 100644 --- a/src/traces/box/select.js +++ b/src/traces/box/select.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function selectPoints(searchInfo, selectionTester) { +module.exports = function(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/candlestick/defaults.js b/src/traces/candlestick/defaults.js index f4e2f6d64a4..b834a547608 100644 --- a/src/traces/candlestick/defaults.js +++ b/src/traces/candlestick/defaults.js @@ -14,7 +14,7 @@ var Color = require('../../components/color'); var handleOHLC = require('../ohlc/ohlc_defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/carpet/ab_defaults.js b/src/traces/carpet/ab_defaults.js index ed037acdd58..476472f27c9 100644 --- a/src/traces/carpet/ab_defaults.js +++ b/src/traces/carpet/ab_defaults.js @@ -11,7 +11,7 @@ var handleAxisDefaults = require('./axis_defaults'); var Template = require('../../plot_api/plot_template'); -module.exports = function handleABDefaults(traceIn, traceOut, fullLayout, coerce, dfltColor) { +module.exports = function(traceIn, traceOut, fullLayout, coerce, dfltColor) { var a = coerce('a'); if(!a) { diff --git a/src/traces/carpet/axis_defaults.js b/src/traces/carpet/axis_defaults.js index 063b43c1bc1..7efb13e481d 100644 --- a/src/traces/carpet/axis_defaults.js +++ b/src/traces/carpet/axis_defaults.js @@ -31,7 +31,7 @@ var autoType = require('../../plots/cartesian/axis_autotype'); * data: the plot data to use in choosing auto type * bgColor: the plot background color, to calculate default gridline colors */ -module.exports = function handleAxisDefaults(containerIn, containerOut, options) { +module.exports = function(containerIn, containerOut, options) { var letter = options.letter; var font = options.font || {}; var attributes = carpetAttrs[letter + 'axis']; diff --git a/src/traces/carpet/calc.js b/src/traces/carpet/calc.js index 6d488b7e279..81a7f14f733 100644 --- a/src/traces/carpet/calc.js +++ b/src/traces/carpet/calc.js @@ -20,7 +20,7 @@ var smoothFill2dArray = require('./smooth_fill_2d_array'); var convertColumnData = require('../heatmap/convert_column_xyz'); var setConvert = require('./set_convert'); -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var xa = Axes.getFromId(gd, trace.xaxis); var ya = Axes.getFromId(gd, trace.yaxis); var aax = trace.aaxis; diff --git a/src/traces/carpet/calc_clippath.js b/src/traces/carpet/calc_clippath.js index 52a632414f2..e9cfbc1d252 100644 --- a/src/traces/carpet/calc_clippath.js +++ b/src/traces/carpet/calc_clippath.js @@ -9,7 +9,7 @@ 'use strict'; -module.exports = function makeClipPath(xctrl, yctrl, aax, bax) { +module.exports = function(xctrl, yctrl, aax, bax) { var i, x, y; var segments = []; diff --git a/src/traces/carpet/calc_gridlines.js b/src/traces/carpet/calc_gridlines.js index 7d4472e7a33..e79271f7052 100644 --- a/src/traces/carpet/calc_gridlines.js +++ b/src/traces/carpet/calc_gridlines.js @@ -11,7 +11,7 @@ var Axes = require('../../plots/cartesian/axes'); var extendFlat = require('../../lib/extend').extendFlat; -module.exports = function calcGridlines(trace, axisLetter, crossAxisLetter) { +module.exports = function(trace, axisLetter, crossAxisLetter) { var i, j, j0; var eps, bounds, n1, n2, n, value, v; var j1, v0, v1, d; diff --git a/src/traces/carpet/calc_labels.js b/src/traces/carpet/calc_labels.js index 514dd1f1231..dfb1043f5b3 100644 --- a/src/traces/carpet/calc_labels.js +++ b/src/traces/carpet/calc_labels.js @@ -11,7 +11,7 @@ var Axes = require('../../plots/cartesian/axes'); var extendFlat = require('../../lib/extend').extendFlat; -module.exports = function calcLabels(trace, axis) { +module.exports = function(trace, axis) { var i, tobj, prefix, suffix, gridline; var labels = axis._labels = []; diff --git a/src/traces/carpet/catmull_rom.js b/src/traces/carpet/catmull_rom.js index 93ffbb5140c..98ec07cb198 100644 --- a/src/traces/carpet/catmull_rom.js +++ b/src/traces/carpet/catmull_rom.js @@ -19,7 +19,7 @@ * math works out this way if you work through the bezier derivatives) */ var CatmullRomExp = 0.5; -module.exports = function makeControlPoints(p0, p1, p2, smoothness) { +module.exports = function(p0, p1, p2, smoothness) { var d1x = p0[0] - p1[0]; var d1y = p0[1] - p1[1]; var d2x = p2[0] - p1[0]; diff --git a/src/traces/carpet/compute_control_points.js b/src/traces/carpet/compute_control_points.js index 6198ceb5dbd..2afd6314a93 100644 --- a/src/traces/carpet/compute_control_points.js +++ b/src/traces/carpet/compute_control_points.js @@ -127,7 +127,7 @@ function inferCubicControlPoint(p0, p2, p3) { ]; } -module.exports = function computeControlPoints(xe, ye, x, y, asmoothing, bsmoothing) { +module.exports = function(xe, ye, x, y, asmoothing, bsmoothing) { var i, j, ie, je, xej, yej, xj, yj, cp, p1; // At this point, we know these dimensions are correct and representative of // the whole 2D arrays: diff --git a/src/traces/carpet/defaults.js b/src/traces/carpet/defaults.js index 6ef9376d6fa..fc03f98091e 100644 --- a/src/traces/carpet/defaults.js +++ b/src/traces/carpet/defaults.js @@ -15,7 +15,7 @@ var handleABDefaults = require('./ab_defaults'); var attributes = require('./attributes'); var colorAttrs = require('../../components/color/attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, dfltColor, fullLayout) { +module.exports = function(traceIn, traceOut, dfltColor, fullLayout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/carpet/makepath.js b/src/traces/carpet/makepath.js index 500ca4404b0..dfc5d32c0d7 100644 --- a/src/traces/carpet/makepath.js +++ b/src/traces/carpet/makepath.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function makePath(xp, yp, isBicubic) { +module.exports = function(xp, yp, isBicubic) { // Prevent d3 errors that would result otherwise: if(xp.length === 0) return ''; diff --git a/src/traces/carpet/map_1d_array.js b/src/traces/carpet/map_1d_array.js index 3cd79d49337..b807bdf267d 100644 --- a/src/traces/carpet/map_1d_array.js +++ b/src/traces/carpet/map_1d_array.js @@ -15,7 +15,7 @@ var isArrayOrTypedArray = require('../../lib').isArrayOrTypedArray; * The output array is optional, but if provided, it will be reused without * reallocation to the extent possible. */ -module.exports = function mapArray(out, data, func) { +module.exports = function(out, data, func) { var i; if(!isArrayOrTypedArray(out)) { diff --git a/src/traces/carpet/orient_text.js b/src/traces/carpet/orient_text.js index 73a13c93f0a..ca7d8acce4f 100644 --- a/src/traces/carpet/orient_text.js +++ b/src/traces/carpet/orient_text.js @@ -9,7 +9,7 @@ 'use strict'; -module.exports = function orientText(trace, xaxis, yaxis, xy, dxy, refDxy) { +module.exports = function(trace, xaxis, yaxis, xy, dxy, refDxy) { var dx = dxy[0] * trace.dpdx(xaxis); var dy = dxy[1] * trace.dpdy(yaxis); var flip = 1; diff --git a/src/traces/carpet/plot.js b/src/traces/carpet/plot.js index 8d3a5479c14..344cb5da26c 100644 --- a/src/traces/carpet/plot.js +++ b/src/traces/carpet/plot.js @@ -18,7 +18,7 @@ var svgTextUtils = require('../../lib/svg_text_utils'); var Lib = require('../../lib'); var alignmentConstants = require('../../constants/alignment'); -module.exports = function plot(gd, plotinfo, cdcarpet, carpetLayer) { +module.exports = function(gd, plotinfo, cdcarpet, carpetLayer) { var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; var fullLayout = gd._fullLayout; diff --git a/src/traces/carpet/set_convert.js b/src/traces/carpet/set_convert.js index ded81ebcd6a..9c75d6e7faf 100644 --- a/src/traces/carpet/set_convert.js +++ b/src/traces/carpet/set_convert.js @@ -24,7 +24,7 @@ var createJDerivativeEvaluator = require('./create_j_derivative_evaluator'); * c: cartesian x-y coordinates * p: screen-space pixel coordinates */ -module.exports = function setConvert(trace) { +module.exports = function(trace) { var a = trace._a; var b = trace._b; var na = a.length; diff --git a/src/traces/carpet/smooth_fill_2d_array.js b/src/traces/carpet/smooth_fill_2d_array.js index 54b2a04fe4f..baf70f6e5ce 100644 --- a/src/traces/carpet/smooth_fill_2d_array.js +++ b/src/traces/carpet/smooth_fill_2d_array.js @@ -22,7 +22,7 @@ var Lib = require('../../lib'); * - a: array such that a.length === data[0].length * - b: array such that b.length === data.length */ -module.exports = function smoothFill2dArray(data, a, b) { +module.exports = function(data, a, b) { var i, j, k; var ip = []; var jp = []; diff --git a/src/traces/carpet/smooth_fill_array.js b/src/traces/carpet/smooth_fill_array.js index c57eff95d9c..df00de1c05b 100644 --- a/src/traces/carpet/smooth_fill_array.js +++ b/src/traces/carpet/smooth_fill_array.js @@ -14,7 +14,7 @@ * makes this much simpler. Just loop over it and do the best we can to fill * the array. */ -module.exports = function smoothFillArray(data) { +module.exports = function(data) { var i, i0, i1; var n = data.length; diff --git a/src/traces/carpet/xy_defaults.js b/src/traces/carpet/xy_defaults.js index 947c1b096e9..433c15e32dd 100644 --- a/src/traces/carpet/xy_defaults.js +++ b/src/traces/carpet/xy_defaults.js @@ -11,7 +11,7 @@ var isArray1D = require('../../lib').isArray1D; -module.exports = function handleXYDefaults(traceIn, traceOut, coerce) { +module.exports = function(traceIn, traceOut, coerce) { var x = coerce('x'); var hasX = x && x.length; var y = coerce('y'); diff --git a/src/traces/choropleth/calc.js b/src/traces/choropleth/calc.js index fcaa55ebcbd..2d70a559089 100644 --- a/src/traces/choropleth/calc.js +++ b/src/traces/choropleth/calc.js @@ -16,7 +16,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); var arraysToCalcdata = require('../scatter/arrays_to_calcdata'); var calcSelection = require('../scatter/calc_selection'); -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var len = trace._length; var calcTrace = new Array(len); diff --git a/src/traces/choropleth/defaults.js b/src/traces/choropleth/defaults.js index 47d84b91ae0..b9b9d67caa2 100644 --- a/src/traces/choropleth/defaults.js +++ b/src/traces/choropleth/defaults.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/choropleth/event_data.js b/src/traces/choropleth/event_data.js index 1b7781944bc..7c9becd3163 100644 --- a/src/traces/choropleth/event_data.js +++ b/src/traces/choropleth/event_data.js @@ -9,7 +9,7 @@ 'use strict'; -module.exports = function eventData(out, pt) { +module.exports = function(out, pt) { out.location = pt.location; out.z = pt.z; diff --git a/src/traces/choropleth/hover.js b/src/traces/choropleth/hover.js index 70211333f51..c73e3965e49 100644 --- a/src/traces/choropleth/hover.js +++ b/src/traces/choropleth/hover.js @@ -13,7 +13,7 @@ var Axes = require('../../plots/cartesian/axes'); var attributes = require('./attributes'); var fillHoverText = require('../scatter/fill_hover_text'); -module.exports = function hoverPoints(pointData, xval, yval) { +module.exports = function(pointData, xval, yval) { var cd = pointData.cd; var trace = cd[0].trace; var geo = pointData.subplot; diff --git a/src/traces/choropleth/plot.js b/src/traces/choropleth/plot.js index 8a547af8a9a..c6c6ecb7813 100644 --- a/src/traces/choropleth/plot.js +++ b/src/traces/choropleth/plot.js @@ -17,7 +17,7 @@ var getTopojsonFeatures = require('../../lib/topojson_utils').getTopojsonFeature var locationToFeature = require('../../lib/geo_location_utils').locationToFeature; var style = require('./style').style; -module.exports = function plot(gd, geo, calcData) { +module.exports = function(gd, geo, calcData) { for(var i = 0; i < calcData.length; i++) { calcGeoJSON(calcData[i], geo.topojson); } diff --git a/src/traces/choropleth/select.js b/src/traces/choropleth/select.js index 3cd34e21f93..c2cfff5cd19 100644 --- a/src/traces/choropleth/select.js +++ b/src/traces/choropleth/select.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function selectPoints(searchInfo, selectionTester) { +module.exports = function(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/cone/calc.js b/src/traces/cone/calc.js index ac58b23a885..91769d730fa 100644 --- a/src/traces/cone/calc.js +++ b/src/traces/cone/calc.js @@ -10,7 +10,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var u = trace.u; var v = trace.v; var w = trace.w; diff --git a/src/traces/cone/defaults.js b/src/traces/cone/defaults.js index 3b6f1d5fc91..362ef4709e8 100644 --- a/src/traces/cone/defaults.js +++ b/src/traces/cone/defaults.js @@ -14,7 +14,7 @@ var Lib = require('../../lib'); var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/contour/calc.js b/src/traces/contour/calc.js index 5f16e8f312c..ca7f3be5eba 100644 --- a/src/traces/contour/calc.js +++ b/src/traces/contour/calc.js @@ -15,7 +15,7 @@ var setContours = require('./set_contours'); // most is the same as heatmap calc, then adjust it // though a few things inside heatmap calc still look for // contour maps, because the makeBoundArray calls are too entangled -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var cd = heatmapCalc(gd, trace); setContours(trace); return cd; diff --git a/src/traces/contour/colorbar.js b/src/traces/contour/colorbar.js index 0187ed5b7d1..9b01bdad120 100644 --- a/src/traces/contour/colorbar.js +++ b/src/traces/contour/colorbar.js @@ -15,7 +15,7 @@ var makeColorMap = require('./make_color_map'); var endPlus = require('./end_plus'); -module.exports = function colorbar(gd, cd) { +module.exports = function(gd, cd) { var trace = cd[0].trace; var cbId = 'cb' + trace.uid; diff --git a/src/traces/contour/constraint_defaults.js b/src/traces/contour/constraint_defaults.js index 9eba7a16534..098dfac16c1 100644 --- a/src/traces/contour/constraint_defaults.js +++ b/src/traces/contour/constraint_defaults.js @@ -20,7 +20,7 @@ var filterOps = require('../../constants/filter_ops'); var CONSTRAINT_REDUCTION = filterOps.CONSTRAINT_REDUCTION; var COMPARISON_OPS2 = filterOps.COMPARISON_OPS2; -module.exports = function handleConstraintDefaults(traceIn, traceOut, coerce, layout, defaultColor, opts) { +module.exports = function(traceIn, traceOut, coerce, layout, defaultColor, opts) { var contours = traceOut.contours; var showLines, lineColor, fillColor; diff --git a/src/traces/contour/contours_defaults.js b/src/traces/contour/contours_defaults.js index 2b07b42215e..6a757b02b5f 100644 --- a/src/traces/contour/contours_defaults.js +++ b/src/traces/contour/contours_defaults.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function handleContourDefaults(traceIn, traceOut, coerce, coerce2) { +module.exports = function(traceIn, traceOut, coerce, coerce2) { var contourStart = coerce2('contours.start'); var contourEnd = coerce2('contours.end'); var missingEnd = (contourStart === false) || (contourEnd === false); diff --git a/src/traces/contour/defaults.js b/src/traces/contour/defaults.js index 62c904c99a1..04a9767d208 100644 --- a/src/traces/contour/defaults.js +++ b/src/traces/contour/defaults.js @@ -17,7 +17,7 @@ var handleStyleDefaults = require('./style_defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/contour/empty_pathinfo.js b/src/traces/contour/empty_pathinfo.js index d53d7b23835..90f9126ad36 100644 --- a/src/traces/contour/empty_pathinfo.js +++ b/src/traces/contour/empty_pathinfo.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var constraintMapping = require('./constraint_mapping'); var endPlus = require('./end_plus'); -module.exports = function emptyPathinfo(contours, plotinfo, cd0) { +module.exports = function(contours, plotinfo, cd0) { var contoursFinal = (contours.type === 'constraint') ? constraintMapping[contours._operation](contours.value) : contours; diff --git a/src/traces/contour/end_plus.js b/src/traces/contour/end_plus.js index b2ea1b70ae2..7de74640f57 100644 --- a/src/traces/contour/end_plus.js +++ b/src/traces/contour/end_plus.js @@ -13,6 +13,6 @@ * tiny helper to move the end of the contours a little to prevent * losing the last contour to rounding errors */ -module.exports = function endPlus(contours) { +module.exports = function(contours) { return contours.end + contours.size / 1e6; }; diff --git a/src/traces/contour/find_all_paths.js b/src/traces/contour/find_all_paths.js index f6104f28b6f..f95f2026e33 100644 --- a/src/traces/contour/find_all_paths.js +++ b/src/traces/contour/find_all_paths.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var constants = require('./constants'); -module.exports = function findAllPaths(pathinfo, xtol, ytol) { +module.exports = function(pathinfo, xtol, ytol) { var cnt, startLoc, i, diff --git a/src/traces/contour/hover.js b/src/traces/contour/hover.js index aebc36e86eb..799f8f870b3 100644 --- a/src/traces/contour/hover.js +++ b/src/traces/contour/hover.js @@ -13,7 +13,7 @@ var Color = require('../../components/color'); var heatmapHoverPoints = require('../heatmap/hover'); -module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLayer) { +module.exports = function(pointData, xval, yval, hovermode, hoverLayer) { var hoverData = heatmapHoverPoints(pointData, xval, yval, hovermode, hoverLayer, true); if(hoverData) { diff --git a/src/traces/contour/label_defaults.js b/src/traces/contour/label_defaults.js index f60601f7541..07e05e779fd 100644 --- a/src/traces/contour/label_defaults.js +++ b/src/traces/contour/label_defaults.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); -module.exports = function handleLabelDefaults(coerce, layout, lineColor, opts) { +module.exports = function(coerce, layout, lineColor, opts) { if(!opts) opts = {}; var showLabels = coerce('contours.showlabels'); if(showLabels) { diff --git a/src/traces/contour/make_color_map.js b/src/traces/contour/make_color_map.js index 74c1ca90889..ad1c5ff0885 100644 --- a/src/traces/contour/make_color_map.js +++ b/src/traces/contour/make_color_map.js @@ -13,7 +13,7 @@ var d3 = require('d3'); var Colorscale = require('../../components/colorscale'); var endPlus = require('./end_plus'); -module.exports = function makeColorMap(trace) { +module.exports = function(trace) { var contours = trace.contours; var start = contours.start; var end = endPlus(contours); diff --git a/src/traces/contour/make_crossings.js b/src/traces/contour/make_crossings.js index 45b5f79ccd9..f7a57c6c708 100644 --- a/src/traces/contour/make_crossings.js +++ b/src/traces/contour/make_crossings.js @@ -14,7 +14,7 @@ var constants = require('./constants'); // since we want to be exhaustive we'll check for contour crossings // at every intersection, rather than just following a path // TODO: shorten the inner loop to only the relevant levels -module.exports = function makeCrossings(pathinfo) { +module.exports = function(pathinfo) { var z = pathinfo[0].z; var m = z.length; var n = z[0].length; // we already made sure z isn't ragged in interp2d diff --git a/src/traces/contour/plot.js b/src/traces/contour/plot.js index 0411e864695..d137e76727a 100644 --- a/src/traces/contour/plot.js +++ b/src/traces/contour/plot.js @@ -26,7 +26,7 @@ var closeBoundaries = require('./close_boundaries'); var constants = require('./constants'); var costConstants = constants.LABELOPTIMIZER; -exports.plot = function plot(gd, plotinfo, cdcontours, contourLayer) { +exports.plot = function(gd, plotinfo, cdcontours, contourLayer) { var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; diff --git a/src/traces/contour/set_contours.js b/src/traces/contour/set_contours.js index 0804413a4a3..9444d7aa2b2 100644 --- a/src/traces/contour/set_contours.js +++ b/src/traces/contour/set_contours.js @@ -13,7 +13,7 @@ var Axes = require('../../plots/cartesian/axes'); var Lib = require('../../lib'); -module.exports = function setContours(trace) { +module.exports = function(trace) { var contours = trace.contours; // check if we need to auto-choose contour levels diff --git a/src/traces/contour/style.js b/src/traces/contour/style.js index af966873b3f..6fa6282c518 100644 --- a/src/traces/contour/style.js +++ b/src/traces/contour/style.js @@ -17,7 +17,7 @@ var heatmapStyle = require('../heatmap/style'); var makeColorMap = require('./make_color_map'); -module.exports = function style(gd) { +module.exports = function(gd) { var contours = d3.select(gd).selectAll('g.contour'); contours.style('opacity', function(d) { diff --git a/src/traces/contour/style_defaults.js b/src/traces/contour/style_defaults.js index a89f05af40a..7c3f3f37e06 100644 --- a/src/traces/contour/style_defaults.js +++ b/src/traces/contour/style_defaults.js @@ -13,7 +13,7 @@ var colorscaleDefaults = require('../../components/colorscale/defaults'); var handleLabelDefaults = require('./label_defaults'); -module.exports = function handleStyleDefaults(traceIn, traceOut, coerce, layout, opts) { +module.exports = function(traceIn, traceOut, coerce, layout, opts) { var coloring = coerce('contours.coloring'); var showLines; diff --git a/src/traces/contourcarpet/calc.js b/src/traces/contourcarpet/calc.js index 07d5919ab34..f09810c44a9 100644 --- a/src/traces/contourcarpet/calc.js +++ b/src/traces/contourcarpet/calc.js @@ -23,7 +23,7 @@ var setContours = require('../contour/set_contours'); // most is the same as heatmap calc, then adjust it // though a few things inside heatmap calc still look for // contour maps, because the makeBoundArray calls are too entangled -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var carpet = trace._carpetTrace = lookupCarpet(gd, trace); if(!carpet || !carpet.visible || carpet.visible === 'legendonly') return; diff --git a/src/traces/contourcarpet/defaults.js b/src/traces/contourcarpet/defaults.js index 671b9eb3e7a..76bfc1863aa 100644 --- a/src/traces/contourcarpet/defaults.js +++ b/src/traces/contourcarpet/defaults.js @@ -17,7 +17,7 @@ var handleConstraintDefaults = require('../contour/constraint_defaults'); var handleContoursDefaults = require('../contour/contours_defaults'); var handleStyleDefaults = require('../contour/style_defaults'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/contourcarpet/join_all_paths.js b/src/traces/contourcarpet/join_all_paths.js index 6aa1653cde9..eb741deef26 100644 --- a/src/traces/contourcarpet/join_all_paths.js +++ b/src/traces/contourcarpet/join_all_paths.js @@ -12,7 +12,7 @@ var Drawing = require('../../components/drawing'); var axisAlignedLine = require('../carpet/axis_aligned_line'); var Lib = require('../../lib'); -module.exports = function joinAllPaths(trace, pi, perimeter, ab2p, carpet, carpetcd, xa, ya) { +module.exports = function(trace, pi, perimeter, ab2p, carpet, carpetcd, xa, ya) { var i; var fullpath = ''; diff --git a/src/traces/contourcarpet/map_pathinfo.js b/src/traces/contourcarpet/map_pathinfo.js index 16278d1c364..3f9bfdf2612 100644 --- a/src/traces/contourcarpet/map_pathinfo.js +++ b/src/traces/contourcarpet/map_pathinfo.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function mapPathinfo(pathinfo, map) { +module.exports = function(pathinfo, map) { var i, j, k, pi, pedgepaths, ppaths, pedgepath, ppath, path; for(i = 0; i < pathinfo.length; i++) { diff --git a/src/traces/contourcarpet/plot.js b/src/traces/contourcarpet/plot.js index 97b9813d7c5..06e02d2dcba 100644 --- a/src/traces/contourcarpet/plot.js +++ b/src/traces/contourcarpet/plot.js @@ -25,7 +25,7 @@ var mapPathinfo = require('./map_pathinfo'); var lookupCarpet = require('../carpet/lookup_carpetid'); var closeBoundaries = require('../contour/close_boundaries'); -module.exports = function plot(gd, plotinfo, cdcontours, contourcarpetLayer) { +module.exports = function(gd, plotinfo, cdcontours, contourcarpetLayer) { var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; diff --git a/src/traces/heatmap/calc.js b/src/traces/heatmap/calc.js index f86bb23ed37..408d57bb99b 100644 --- a/src/traces/heatmap/calc.js +++ b/src/traces/heatmap/calc.js @@ -22,7 +22,7 @@ var findEmpties = require('./find_empties'); var makeBoundArray = require('./make_bound_array'); -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { // prepare the raw data // run makeCalcdata on x and y even for heatmaps, in case of category mappings var xa = Axes.getFromId(gd, trace.xaxis || 'x'); diff --git a/src/traces/heatmap/clean_2d_array.js b/src/traces/heatmap/clean_2d_array.js index 74d6fa84db4..8c1f31cab54 100644 --- a/src/traces/heatmap/clean_2d_array.js +++ b/src/traces/heatmap/clean_2d_array.js @@ -10,7 +10,7 @@ var isNumeric = require('fast-isnumeric'); -module.exports = function clean2dArray(zOld, transpose) { +module.exports = function(zOld, transpose) { var rowlen, collen, getCollen, old2new, i, j; function cleanZvalue(v) { diff --git a/src/traces/heatmap/convert_column_xyz.js b/src/traces/heatmap/convert_column_xyz.js index ace8224f877..0960fefb5c2 100644 --- a/src/traces/heatmap/convert_column_xyz.js +++ b/src/traces/heatmap/convert_column_xyz.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function convertColumnData(trace, ax1, ax2, var1Name, var2Name, arrayVarNames) { +module.exports = function(trace, ax1, ax2, var1Name, var2Name, arrayVarNames) { var colLen = trace._length; var col1 = ax1.makeCalcdata(trace, var1Name); var col2 = ax2.makeCalcdata(trace, var2Name); diff --git a/src/traces/heatmap/defaults.js b/src/traces/heatmap/defaults.js index a245af88d95..4d7b531a8a6 100644 --- a/src/traces/heatmap/defaults.js +++ b/src/traces/heatmap/defaults.js @@ -17,7 +17,7 @@ var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/heatmap/find_empties.js b/src/traces/heatmap/find_empties.js index 43e010e5dce..c97dcaa2126 100644 --- a/src/traces/heatmap/find_empties.js +++ b/src/traces/heatmap/find_empties.js @@ -17,7 +17,7 @@ var maxRowLength = require('../../lib').maxRowLength; * if no neighbors exist, we iteratively look for neighbors that HAVE * neighbors, and add a fractional neighborCount */ -module.exports = function findEmpties(z) { +module.exports = function(z) { var empties = []; var neighborHash = {}; var noNeighborList = []; diff --git a/src/traces/heatmap/hover.js b/src/traces/heatmap/hover.js index cfc2e72f0c2..498340b35ab 100644 --- a/src/traces/heatmap/hover.js +++ b/src/traces/heatmap/hover.js @@ -13,7 +13,7 @@ var Fx = require('../../components/fx'); var Lib = require('../../lib'); var Axes = require('../../plots/cartesian/axes'); -module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLayer, contour) { +module.exports = function(pointData, xval, yval, hovermode, hoverLayer, contour) { var cd0 = pointData.cd[0]; var trace = cd0.trace; var xa = pointData.xa; diff --git a/src/traces/heatmap/interp2d.js b/src/traces/heatmap/interp2d.js index a3a5e231989..dc17272813a 100644 --- a/src/traces/heatmap/interp2d.js +++ b/src/traces/heatmap/interp2d.js @@ -35,7 +35,7 @@ function correctionOvershoot(maxFractionalChange) { * of neighbors that are *not* missing. Assumed to be sorted from most to * least neighbors, as produced by heatmap/find_empties. */ -module.exports = function interp2d(z, emptyPoints) { +module.exports = function(z, emptyPoints) { var maxFractionalChange = 1; var i; diff --git a/src/traces/heatmap/make_bound_array.js b/src/traces/heatmap/make_bound_array.js index 6a020ae44dc..f587ecc6f7d 100644 --- a/src/traces/heatmap/make_bound_array.js +++ b/src/traces/heatmap/make_bound_array.js @@ -11,7 +11,7 @@ var Registry = require('../../registry'); var isArrayOrTypedArray = require('../../lib').isArrayOrTypedArray; -module.exports = function makeBoundArray(trace, arrayIn, v0In, dvIn, numbricks, ax) { +module.exports = function(trace, arrayIn, v0In, dvIn, numbricks, ax) { var arrayOut = []; var isContour = Registry.traceIs(trace, 'contour'); var isHist = Registry.traceIs(trace, 'histogram'); diff --git a/src/traces/heatmap/style.js b/src/traces/heatmap/style.js index 3e902b13b0d..05cc5ec344f 100644 --- a/src/traces/heatmap/style.js +++ b/src/traces/heatmap/style.js @@ -11,7 +11,7 @@ var d3 = require('d3'); -module.exports = function style(gd) { +module.exports = function(gd) { d3.select(gd).selectAll('.hm image') .style('opacity', function(d) { return d.trace.opacity; diff --git a/src/traces/heatmap/style_defaults.js b/src/traces/heatmap/style_defaults.js index 49d00e63764..d769a4a3ff8 100644 --- a/src/traces/heatmap/style_defaults.js +++ b/src/traces/heatmap/style_defaults.js @@ -9,7 +9,7 @@ 'use strict'; -module.exports = function handleStyleDefaults(traceIn, traceOut, coerce) { +module.exports = function(traceIn, traceOut, coerce) { var zsmooth = coerce('zsmooth'); if(zsmooth === false) { // ensure that xgap and ygap are coerced only when zsmooth allows them to have an effect. diff --git a/src/traces/heatmap/xyz_defaults.js b/src/traces/heatmap/xyz_defaults.js index d84de5861db..ba604066deb 100644 --- a/src/traces/heatmap/xyz_defaults.js +++ b/src/traces/heatmap/xyz_defaults.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var Registry = require('../../registry'); -module.exports = function handleXYZDefaults(traceIn, traceOut, coerce, layout, xName, yName) { +module.exports = function(traceIn, traceOut, coerce, layout, xName, yName) { var z = coerce('z'); xName = xName || 'x'; yName = yName || 'y'; diff --git a/src/traces/histogram/average.js b/src/traces/histogram/average.js index c52617eef0f..dae8d8d709f 100644 --- a/src/traces/histogram/average.js +++ b/src/traces/histogram/average.js @@ -10,7 +10,7 @@ 'use strict'; -module.exports = function doAvg(size, counts) { +module.exports = function(size, counts) { var nMax = size.length; var total = 0; for(var i = 0; i < nMax; i++) { diff --git a/src/traces/histogram/bin_attributes.js b/src/traces/histogram/bin_attributes.js index 33c2a1b475d..832474e8337 100644 --- a/src/traces/histogram/bin_attributes.js +++ b/src/traces/histogram/bin_attributes.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function makeBinAttrs(axLetter, match) { +module.exports = function(axLetter, match) { return { start: { valType: 'any', // for date axes diff --git a/src/traces/histogram/bin_label_vals.js b/src/traces/histogram/bin_label_vals.js index c6422ff62a9..f63c9530250 100644 --- a/src/traces/histogram/bin_label_vals.js +++ b/src/traces/histogram/bin_label_vals.js @@ -30,7 +30,7 @@ var tickIncrement = require('../../plots/cartesian/axes').tickIncrement; * @return {function(v, isRightEdge)}: * find the start (isRightEdge is falsy) or end (truthy) label value for a bin edge `v` */ -module.exports = function getBinSpanLabelRound(leftGap, rightGap, binEdges, pa, calendar) { +module.exports = function(leftGap, rightGap, binEdges, pa, calendar) { // the rounding digit is the largest digit that changes in *all* of 4 regions: // - inside the rightGap before binEdges[0] (shifted 10% to the left) // - inside the leftGap after binEdges[0] (expanded by 10% of rightGap on each end) diff --git a/src/traces/histogram/calc.js b/src/traces/histogram/calc.js index c4388db82e2..4de1d5f3be3 100644 --- a/src/traces/histogram/calc.js +++ b/src/traces/histogram/calc.js @@ -20,7 +20,7 @@ var normFunctions = require('./norm_functions'); var doAvg = require('./average'); var getBinSpanLabelRound = require('./bin_label_vals'); -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { // ignore as much processing as possible (and including in autorange) if not visible if(trace.visible !== true) return; diff --git a/src/traces/histogram/cross_trace_defaults.js b/src/traces/histogram/cross_trace_defaults.js index 0a7663cc43d..47c4e7aaf58 100644 --- a/src/traces/histogram/cross_trace_defaults.js +++ b/src/traces/histogram/cross_trace_defaults.js @@ -31,7 +31,7 @@ var BINATTRS = { }; // handle bin attrs and relink auto-determined values so fullData is complete -module.exports = function crossTraceDefaults(fullData, fullLayout) { +module.exports = function(fullData, fullLayout) { var allBinOpts = fullLayout._histogramBinOpts = {}; var isOverlay = fullLayout.barmode === 'overlay'; var i, j, traceOut, traceIn, binDirection, group, binOpts; diff --git a/src/traces/histogram/defaults.js b/src/traces/histogram/defaults.js index 6a79d02e5ca..a1cbfeeebde 100644 --- a/src/traces/histogram/defaults.js +++ b/src/traces/histogram/defaults.js @@ -15,7 +15,7 @@ var Color = require('../../components/color'); var handleStyleDefaults = require('../bar/style_defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/histogram/event_data.js b/src/traces/histogram/event_data.js index ab5ac4f41a3..06e4f9a779e 100644 --- a/src/traces/histogram/event_data.js +++ b/src/traces/histogram/event_data.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function eventData(out, pt, trace, cd, pointNumber) { +module.exports = function(out, pt, trace, cd, pointNumber) { // standard cartesian event data out.x = 'xVal' in pt ? pt.xVal : pt.x; out.y = 'yVal' in pt ? pt.yVal : pt.y; diff --git a/src/traces/histogram/hover.js b/src/traces/histogram/hover.js index 78990ef98ba..45bd610076e 100644 --- a/src/traces/histogram/hover.js +++ b/src/traces/histogram/hover.js @@ -12,7 +12,7 @@ var barHover = require('../bar/hover').hoverPoints; var hoverLabelText = require('../../plots/cartesian/axes').hoverLabelText; -module.exports = function hoverPoints(pointData, xval, yval, hovermode) { +module.exports = function(pointData, xval, yval, hovermode) { var pts = barHover(pointData, xval, yval, hovermode); if(!pts) return; diff --git a/src/traces/histogram2d/calc.js b/src/traces/histogram2d/calc.js index 4ca78cee96c..d92c59dffd1 100644 --- a/src/traces/histogram2d/calc.js +++ b/src/traces/histogram2d/calc.js @@ -18,7 +18,7 @@ var doAvg = require('../histogram/average'); var getBinSpanLabelRound = require('../histogram/bin_label_vals'); -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var xa = Axes.getFromId(gd, trace.xaxis || 'x'); var x = trace.x ? xa.makeCalcdata(trace, 'x') : []; var ya = Axes.getFromId(gd, trace.yaxis || 'y'); diff --git a/src/traces/histogram2d/cross_trace_defaults.js b/src/traces/histogram2d/cross_trace_defaults.js index 24b78826a0b..c677a77c7c2 100644 --- a/src/traces/histogram2d/cross_trace_defaults.js +++ b/src/traces/histogram2d/cross_trace_defaults.js @@ -23,7 +23,7 @@ var BINDIRECTIONS = ['x', 'y']; // Handle bin attrs and relink auto-determined values so fullData is complete // does not have cross-trace coupling, but moved out here so we have axis types // and relinked trace._autoBin -module.exports = function crossTraceDefaults(fullData, fullLayout) { +module.exports = function(fullData, fullLayout) { var i, j, traceOut, binDirection; function coerce(attr) { diff --git a/src/traces/histogram2d/defaults.js b/src/traces/histogram2d/defaults.js index 3f0ea3f206c..f8aa93fb9a0 100644 --- a/src/traces/histogram2d/defaults.js +++ b/src/traces/histogram2d/defaults.js @@ -17,7 +17,7 @@ var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/histogram2d/hover.js b/src/traces/histogram2d/hover.js index ee9d8c657b6..a470412df91 100644 --- a/src/traces/histogram2d/hover.js +++ b/src/traces/histogram2d/hover.js @@ -12,7 +12,7 @@ var heatmapHover = require('../heatmap/hover'); var hoverLabelText = require('../../plots/cartesian/axes').hoverLabelText; -module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLayer, contour) { +module.exports = function(pointData, xval, yval, hovermode, hoverLayer, contour) { var pts = heatmapHover(pointData, xval, yval, hovermode, hoverLayer, contour); if(!pts) return; diff --git a/src/traces/histogram2d/sample_defaults.js b/src/traces/histogram2d/sample_defaults.js index 9c685c9b04f..ba0d1c71ec4 100644 --- a/src/traces/histogram2d/sample_defaults.js +++ b/src/traces/histogram2d/sample_defaults.js @@ -11,7 +11,7 @@ var Registry = require('../../registry'); var Lib = require('../../lib'); -module.exports = function handleSampleDefaults(traceIn, traceOut, coerce, layout) { +module.exports = function(traceIn, traceOut, coerce, layout) { var x = coerce('x'); var y = coerce('y'); var xlen = Lib.minRowLength(x); diff --git a/src/traces/histogram2dcontour/defaults.js b/src/traces/histogram2dcontour/defaults.js index a4792f149f7..f05b0ce3c8e 100644 --- a/src/traces/histogram2dcontour/defaults.js +++ b/src/traces/histogram2dcontour/defaults.js @@ -17,7 +17,7 @@ var handleStyleDefaults = require('../contour/style_defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/isosurface/calc.js b/src/traces/isosurface/calc.js index 1c428c2ccc9..4cbdfcbb414 100644 --- a/src/traces/isosurface/calc.js +++ b/src/traces/isosurface/calc.js @@ -10,7 +10,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { trace._len = Math.min(trace.x.length, trace.y.length, trace.z.length, trace.value.length); var min = Infinity; diff --git a/src/traces/mesh3d/calc.js b/src/traces/mesh3d/calc.js index 92b6a14d13d..8a299273d67 100644 --- a/src/traces/mesh3d/calc.js +++ b/src/traces/mesh3d/calc.js @@ -10,7 +10,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { if(trace.intensity) { colorscaleCalc(gd, trace, { vals: trace.intensity, diff --git a/src/traces/mesh3d/defaults.js b/src/traces/mesh3d/defaults.js index d4b5c6fcb89..0673b3631e4 100644 --- a/src/traces/mesh3d/defaults.js +++ b/src/traces/mesh3d/defaults.js @@ -14,7 +14,7 @@ var Lib = require('../../lib'); var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/ohlc/defaults.js b/src/traces/ohlc/defaults.js index 32723023ba4..95f63dc861a 100644 --- a/src/traces/ohlc/defaults.js +++ b/src/traces/ohlc/defaults.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var handleOHLC = require('./ohlc_defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/ohlc/ohlc_defaults.js b/src/traces/ohlc/ohlc_defaults.js index a15bed6d30a..765a7f1b502 100644 --- a/src/traces/ohlc/ohlc_defaults.js +++ b/src/traces/ohlc/ohlc_defaults.js @@ -11,7 +11,7 @@ var Registry = require('../../registry'); var Lib = require('../../lib'); -module.exports = function handleOHLC(traceIn, traceOut, coerce, layout) { +module.exports = function(traceIn, traceOut, coerce, layout) { var x = coerce('x'); var open = coerce('open'); var high = coerce('high'); diff --git a/src/traces/ohlc/plot.js b/src/traces/ohlc/plot.js index 80ef9dc048b..5575bb87bf4 100644 --- a/src/traces/ohlc/plot.js +++ b/src/traces/ohlc/plot.js @@ -12,7 +12,7 @@ var d3 = require('d3'); var Lib = require('../../lib'); -module.exports = function plot(gd, plotinfo, cdOHLC, ohlcLayer) { +module.exports = function(gd, plotinfo, cdOHLC, ohlcLayer) { var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; diff --git a/src/traces/ohlc/select.js b/src/traces/ohlc/select.js index 770a187977e..e4be427e52e 100644 --- a/src/traces/ohlc/select.js +++ b/src/traces/ohlc/select.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function selectPoints(searchInfo, selectionTester) { +module.exports = function(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/ohlc/style.js b/src/traces/ohlc/style.js index a708d108b1f..8c46ccb6eda 100644 --- a/src/traces/ohlc/style.js +++ b/src/traces/ohlc/style.js @@ -12,7 +12,7 @@ var d3 = require('d3'); var Drawing = require('../../components/drawing'); var Color = require('../../components/color'); -module.exports = function style(gd, cd) { +module.exports = function(gd, cd) { var s = cd ? cd[0].node3 : d3.select(gd).selectAll('g.ohlclayer').selectAll('g.trace'); s.style('opacity', function(d) { diff --git a/src/traces/parcats/calc.js b/src/traces/parcats/calc.js index 9310e922040..03b0b2c3a02 100644 --- a/src/traces/parcats/calc.js +++ b/src/traces/parcats/calc.js @@ -25,7 +25,7 @@ var Lib = require('../../lib'); * @param {Object} trace * @return {Array.} */ -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var visibleDims = Lib.filterVisible(trace.dimensions); if(visibleDims.length === 0) return []; diff --git a/src/traces/parcats/defaults.js b/src/traces/parcats/defaults.js index a4edf1d82ba..7dd769b4c8c 100644 --- a/src/traces/parcats/defaults.js +++ b/src/traces/parcats/defaults.js @@ -74,7 +74,7 @@ function dimensionDefaults(dimensionIn, dimensionOut) { } } -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/parcats/plot.js b/src/traces/parcats/plot.js index a8730fe0643..4e2412b436d 100644 --- a/src/traces/parcats/plot.js +++ b/src/traces/parcats/plot.js @@ -17,7 +17,7 @@ var parcats = require('./parcats'); * @param {Object} graphDiv * @param {Array.} parcatsModels */ -module.exports = function plot(graphDiv, parcatsModels, transitionOpts, makeOnCompleteCallback) { +module.exports = function(graphDiv, parcatsModels, transitionOpts, makeOnCompleteCallback) { var fullLayout = graphDiv._fullLayout; var svg = fullLayout._paper; var size = fullLayout._size; diff --git a/src/traces/parcoords/axisbrush.js b/src/traces/parcoords/axisbrush.js index e84c53c4438..af8afa36e2f 100644 --- a/src/traces/parcoords/axisbrush.js +++ b/src/traces/parcoords/axisbrush.js @@ -429,7 +429,7 @@ function brushClear(brush) { } function axisBrushMoved(callback) { - return function axisBrushMoved(dimension) { + return function(dimension) { var brush = dimension.brush; var extent = getBrushExtent(brush); var newExtent = extent.slice(); diff --git a/src/traces/parcoords/calc.js b/src/traces/parcoords/calc.js index 8dbdb84d156..b6b2e5c2039 100644 --- a/src/traces/parcoords/calc.js +++ b/src/traces/parcoords/calc.js @@ -13,7 +13,7 @@ var calcColorscale = require('../../components/colorscale/calc'); var Lib = require('../../lib'); var wrap = require('../../lib/gup').wrap; -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { for(var i = 0; i < trace.dimensions.length; i++) { trace.dimensions[i].values = convertTypedArray(trace.dimensions[i].values); } diff --git a/src/traces/parcoords/defaults.js b/src/traces/parcoords/defaults.js index 5d96dd4c8e4..432bf2522d7 100644 --- a/src/traces/parcoords/defaults.js +++ b/src/traces/parcoords/defaults.js @@ -63,7 +63,7 @@ function dimensionDefaults(dimensionIn, dimensionOut) { } } -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/parcoords/plot.js b/src/traces/parcoords/plot.js index 4a30b185fa3..4d716ee41ea 100644 --- a/src/traces/parcoords/plot.js +++ b/src/traces/parcoords/plot.js @@ -11,7 +11,7 @@ var parcoords = require('./parcoords'); var prepareRegl = require('../../lib/prepare_regl'); -module.exports = function plot(gd, cdparcoords) { +module.exports = function(gd, cdparcoords) { var fullLayout = gd._fullLayout; var svg = fullLayout._toppaper; var root = fullLayout._paperdiv; @@ -97,7 +97,7 @@ module.exports = function plot(gd, cdparcoords) { } function sorter(orig) { - return function sorter(d1, d2) { + return function(d1, d2) { var i1 = newIdx(visibleIndices, orig, d1); var i2 = newIdx(visibleIndices, orig, d2); return i1 - i2; diff --git a/src/traces/pie/calc.js b/src/traces/pie/calc.js index f918f51ba30..dd6cd243e65 100644 --- a/src/traces/pie/calc.js +++ b/src/traces/pie/calc.js @@ -112,7 +112,7 @@ function calc(gd, trace) { } function makePullColorFn(colorMap) { - return function pullColor(color, id) { + return function(color, id) { if(!color) return false; color = tinycolor(color); diff --git a/src/traces/pie/defaults.js b/src/traces/pie/defaults.js index 52aea7bfc7b..2bda60aad90 100644 --- a/src/traces/pie/defaults.js +++ b/src/traces/pie/defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var attributes = require('./attributes'); var handleDomainDefaults = require('../../plots/domain').defaults; -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/pie/event_data.js b/src/traces/pie/event_data.js index 2583a24628d..22e5aaf11a3 100644 --- a/src/traces/pie/event_data.js +++ b/src/traces/pie/event_data.js @@ -15,7 +15,7 @@ var appendArrayMultiPointValues = require('../../components/fx/helpers').appendA // Note: like other eventData routines, this creates the data for hover/unhover/click events // but it has a different API and goes through a totally different pathway. // So to ensure it doesn't get misused, it's not attached to the Pie module. -module.exports = function eventData(pt, trace) { +module.exports = function(pt, trace) { var out = { curveNumber: trace.index, pointNumbers: pt.pts, diff --git a/src/traces/pie/helpers.js b/src/traces/pie/helpers.js index 719a385d704..785009d7e31 100644 --- a/src/traces/pie/helpers.js +++ b/src/traces/pie/helpers.js @@ -10,7 +10,7 @@ var Lib = require('../../lib'); -exports.formatPiePercent = function formatPiePercent(v, separators) { +exports.formatPiePercent = function(v, separators) { var vRounded = (v * 100).toPrecision(3); if(vRounded.lastIndexOf('.') !== -1) { vRounded = vRounded.replace(/[.]?0+$/, ''); @@ -18,7 +18,7 @@ exports.formatPiePercent = function formatPiePercent(v, separators) { return Lib.numSeparate(vRounded, separators) + '%'; }; -exports.formatPieValue = function formatPieValue(v, separators) { +exports.formatPieValue = function(v, separators) { var vRounded = v.toPrecision(10); if(vRounded.lastIndexOf('.') !== -1) { vRounded = vRounded.replace(/[.]?0+$/, ''); @@ -26,7 +26,7 @@ exports.formatPieValue = function formatPieValue(v, separators) { return Lib.numSeparate(vRounded, separators); }; -exports.getFirstFilled = function getFirstFilled(array, indices) { +exports.getFirstFilled = function(array, indices) { if(!Array.isArray(array)) return; for(var i = 0; i < indices.length; i++) { var v = array[indices[i]]; @@ -34,7 +34,7 @@ exports.getFirstFilled = function getFirstFilled(array, indices) { } }; -exports.castOption = function castOption(item, indices) { +exports.castOption = function(item, indices) { if(Array.isArray(item)) return exports.getFirstFilled(item, indices); else if(item) return item; }; diff --git a/src/traces/pie/layout_defaults.js b/src/traces/pie/layout_defaults.js index a38ef5890e2..45f34fea769 100644 --- a/src/traces/pie/layout_defaults.js +++ b/src/traces/pie/layout_defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var layoutAttributes = require('./layout_attributes'); -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) { +module.exports = function(layoutIn, layoutOut) { function coerce(attr, dflt) { return Lib.coerce(layoutIn, layoutOut, layoutAttributes, attr, dflt); } diff --git a/src/traces/pie/style.js b/src/traces/pie/style.js index 86b1e46cc0b..4bc3bb89d60 100644 --- a/src/traces/pie/style.js +++ b/src/traces/pie/style.js @@ -12,7 +12,7 @@ var d3 = require('d3'); var styleOne = require('./style_one'); -module.exports = function style(gd) { +module.exports = function(gd) { gd._fullLayout._pielayer.selectAll('.trace').each(function(cd) { var cd0 = cd[0]; var trace = cd0.trace; diff --git a/src/traces/pie/style_one.js b/src/traces/pie/style_one.js index c0bd60d367f..cd6078178e4 100644 --- a/src/traces/pie/style_one.js +++ b/src/traces/pie/style_one.js @@ -11,7 +11,7 @@ var Color = require('../../components/color'); var castOption = require('./helpers').castOption; -module.exports = function styleOne(s, pt, trace) { +module.exports = function(s, pt, trace) { var line = trace.marker.line; var lineColor = castOption(line.color, pt.pts) || Color.defaultLine; var lineWidth = castOption(line.width, pt.pts) || 0; diff --git a/src/traces/pointcloud/defaults.js b/src/traces/pointcloud/defaults.js index ffab33e9a64..ca18f80e2d9 100644 --- a/src/traces/pointcloud/defaults.js +++ b/src/traces/pointcloud/defaults.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor) { +module.exports = function(traceIn, traceOut, defaultColor) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/sankey/calc.js b/src/traces/sankey/calc.js index 319eb8de82d..b1953935b7f 100644 --- a/src/traces/sankey/calc.js +++ b/src/traces/sankey/calc.js @@ -168,7 +168,7 @@ function circularityPresent(nodeLen, sources, targets) { }); } -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var result = convertToD3Sankey(trace); return wrap({ diff --git a/src/traces/sankey/defaults.js b/src/traces/sankey/defaults.js index a82706c3cb4..19fb36d9cf3 100644 --- a/src/traces/sankey/defaults.js +++ b/src/traces/sankey/defaults.js @@ -17,7 +17,7 @@ var handleHoverLabelDefaults = require('../../components/fx/hoverlabel_defaults' var Template = require('../../plot_api/plot_template'); var handleArrayContainerDefaults = require('../../plots/array_container_defaults'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/sankey/plot.js b/src/traces/sankey/plot.js index efca619c727..9fe89dfd7cd 100644 --- a/src/traces/sankey/plot.js +++ b/src/traces/sankey/plot.js @@ -122,7 +122,7 @@ function castHoverOption(trace, attr) { return Array.isArray(val) ? false : val; } -module.exports = function plot(gd, calcData) { +module.exports = function(gd, calcData) { var fullLayout = gd._fullLayout; var svg = fullLayout._paper; var size = fullLayout._size; diff --git a/src/traces/sankey/render.js b/src/traces/sankey/render.js index 4cf93a539fc..e7a0117273b 100644 --- a/src/traces/sankey/render.js +++ b/src/traces/sankey/render.js @@ -722,7 +722,7 @@ function startForce(sankeyNode, sankeyLink, d, forceKey, gd) { } function snappingForce(sankeyNode, forceKey, nodes, d) { - return function _snappingForce() { + return function() { var maxVelocity = 0; for(var i = 0; i < nodes.length; i++) { var n = nodes[i]; diff --git a/src/traces/sankey/select.js b/src/traces/sankey/select.js index f1f6d3beb11..e78e33d690e 100644 --- a/src/traces/sankey/select.js +++ b/src/traces/sankey/select.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function selectPoints(searchInfo, selectionTester) { +module.exports = function(searchInfo, selectionTester) { var cd = searchInfo.cd; var selection = []; var fullData = cd[0].trace; diff --git a/src/traces/scatter/arrays_to_calcdata.js b/src/traces/scatter/arrays_to_calcdata.js index ee83c3aac31..441b3ea2ee7 100644 --- a/src/traces/scatter/arrays_to_calcdata.js +++ b/src/traces/scatter/arrays_to_calcdata.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); // arrayOk attributes, merge them into calcdata array -module.exports = function arraysToCalcdata(cd, trace) { +module.exports = function(cd, trace) { // so each point knows which index it originally came from for(var i = 0; i < cd.length; i++) cd[i].i = i; diff --git a/src/traces/scatter/calc_selection.js b/src/traces/scatter/calc_selection.js index 80d2d99061c..3f3b050277d 100644 --- a/src/traces/scatter/calc_selection.js +++ b/src/traces/scatter/calc_selection.js @@ -10,7 +10,7 @@ var Lib = require('../../lib'); -module.exports = function calcSelection(cd, trace) { +module.exports = function(cd, trace) { if(Lib.isArrayOrTypedArray(trace.selectedpoints)) { Lib.tagSelected(cd, trace); } diff --git a/src/traces/scatter/colorscale_calc.js b/src/traces/scatter/colorscale_calc.js index d103dd09fee..6edad1c07ad 100644 --- a/src/traces/scatter/colorscale_calc.js +++ b/src/traces/scatter/colorscale_calc.js @@ -13,7 +13,7 @@ var calcColorscale = require('../../components/colorscale/calc'); var subTypes = require('./subtypes'); -module.exports = function calcMarkerColorscale(gd, trace) { +module.exports = function(gd, trace) { if(subTypes.hasLines(trace) && hasColorscale(trace, 'line')) { calcColorscale(gd, trace, { vals: trace.line.color, diff --git a/src/traces/scatter/cross_trace_calc.js b/src/traces/scatter/cross_trace_calc.js index 47ac386e9da..c6f93034128 100644 --- a/src/traces/scatter/cross_trace_calc.js +++ b/src/traces/scatter/cross_trace_calc.js @@ -16,7 +16,7 @@ var calc = require('./calc'); * runs per subplot, and can handle multiple stacking groups */ -module.exports = function crossTraceCalc(gd, plotinfo) { +module.exports = function(gd, plotinfo) { var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; var subplot = xa._id + ya._id; diff --git a/src/traces/scatter/cross_trace_defaults.js b/src/traces/scatter/cross_trace_defaults.js index f51f5d73b8c..c9a6b553769 100644 --- a/src/traces/scatter/cross_trace_defaults.js +++ b/src/traces/scatter/cross_trace_defaults.js @@ -11,7 +11,7 @@ // remove opacity for any trace that has a fill or is filled to -module.exports = function crossTraceDefaults(fullData) { +module.exports = function(fullData) { for(var i = 0; i < fullData.length; i++) { var tracei = fullData[i]; if(tracei.type !== 'scatter') continue; diff --git a/src/traces/scatter/defaults.js b/src/traces/scatter/defaults.js index 3ff337d0e57..546a03fee40 100644 --- a/src/traces/scatter/defaults.js +++ b/src/traces/scatter/defaults.js @@ -22,7 +22,7 @@ var handleLineShapeDefaults = require('./line_shape_defaults'); var handleTextDefaults = require('./text_defaults'); var handleFillColorDefaults = require('./fillcolor_defaults'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scatter/fill_hover_text.js b/src/traces/scatter/fill_hover_text.js index ca925844e8e..dc970ea1e9a 100644 --- a/src/traces/scatter/fill_hover_text.js +++ b/src/traces/scatter/fill_hover_text.js @@ -23,7 +23,7 @@ var Lib = require('../../lib'); * @param {object} trace * @param {object || array} contOut (mutated here) */ -module.exports = function fillHoverText(calcPt, trace, contOut) { +module.exports = function(calcPt, trace, contOut) { var fill = Array.isArray(contOut) ? function(v) { contOut.push(v); } : function(v) { contOut.text = v; }; diff --git a/src/traces/scatter/fillcolor_defaults.js b/src/traces/scatter/fillcolor_defaults.js index f3d8cd49c3e..67ec341fd0f 100644 --- a/src/traces/scatter/fillcolor_defaults.js +++ b/src/traces/scatter/fillcolor_defaults.js @@ -12,7 +12,7 @@ var Color = require('../../components/color'); var isArrayOrTypedArray = require('../../lib').isArrayOrTypedArray; -module.exports = function fillColorDefaults(traceIn, traceOut, defaultColor, coerce) { +module.exports = function(traceIn, traceOut, defaultColor, coerce) { var inheritColorFromMarker = false; if(traceOut.marker) { diff --git a/src/traces/scatter/get_trace_color.js b/src/traces/scatter/get_trace_color.js index b51014641a3..79435f07848 100644 --- a/src/traces/scatter/get_trace_color.js +++ b/src/traces/scatter/get_trace_color.js @@ -13,7 +13,7 @@ var Color = require('../../components/color'); var subtypes = require('./subtypes'); -module.exports = function getTraceColor(trace, di) { +module.exports = function(trace, di) { var lc, tc; // TODO: text modes diff --git a/src/traces/scatter/hover.js b/src/traces/scatter/hover.js index f75f5308552..7176abcce04 100644 --- a/src/traces/scatter/hover.js +++ b/src/traces/scatter/hover.js @@ -15,7 +15,7 @@ var getTraceColor = require('./get_trace_color'); var Color = require('../../components/color'); var fillHoverText = require('./fill_hover_text'); -module.exports = function hoverPoints(pointData, xval, yval, hovermode) { +module.exports = function(pointData, xval, yval, hovermode) { var cd = pointData.cd; var trace = cd[0].trace; var xa = pointData.xa; diff --git a/src/traces/scatter/line_defaults.js b/src/traces/scatter/line_defaults.js index 4139af84d5f..e2a3b6645e1 100644 --- a/src/traces/scatter/line_defaults.js +++ b/src/traces/scatter/line_defaults.js @@ -12,7 +12,7 @@ var isArrayOrTypedArray = require('../../lib').isArrayOrTypedArray; var hasColorscale = require('../../components/colorscale/helpers').hasColorscale; var colorscaleDefaults = require('../../components/colorscale/defaults'); -module.exports = function lineDefaults(traceIn, traceOut, defaultColor, layout, coerce, opts) { +module.exports = function(traceIn, traceOut, defaultColor, layout, coerce, opts) { var markerColor = (traceIn.marker || {}).color; coerce('line.color', defaultColor); diff --git a/src/traces/scatter/line_points.js b/src/traces/scatter/line_points.js index 2943f2673bb..4cd9c08e849 100644 --- a/src/traces/scatter/line_points.js +++ b/src/traces/scatter/line_points.js @@ -20,7 +20,7 @@ var constrain = Lib.constrain; var constants = require('./constants'); -module.exports = function linePoints(d, opts) { +module.exports = function(d, opts) { var xa = opts.xaxis; var ya = opts.yaxis; var xLog = xa.type === 'log'; diff --git a/src/traces/scatter/line_shape_defaults.js b/src/traces/scatter/line_shape_defaults.js index e4e34e6d3a4..0eb36aa04d8 100644 --- a/src/traces/scatter/line_shape_defaults.js +++ b/src/traces/scatter/line_shape_defaults.js @@ -11,7 +11,7 @@ // common to 'scatter' and 'scatterternary' -module.exports = function handleLineShapeDefaults(traceIn, traceOut, coerce) { +module.exports = function(traceIn, traceOut, coerce) { var shape = coerce('line.shape'); if(shape === 'spline') coerce('line.smoothing'); }; diff --git a/src/traces/scatter/link_traces.js b/src/traces/scatter/link_traces.js index 00dd070d907..2d048f7d6f5 100644 --- a/src/traces/scatter/link_traces.js +++ b/src/traces/scatter/link_traces.js @@ -10,7 +10,7 @@ var LINKEDFILLS = {tonextx: 1, tonexty: 1, tonext: 1}; -module.exports = function linkTraces(gd, plotinfo, cdscatter) { +module.exports = function(gd, plotinfo, cdscatter) { var trace, i, group, prevtrace, groupIndex; // first sort traces to keep stacks & filled-together groups together diff --git a/src/traces/scatter/make_bubble_size_func.js b/src/traces/scatter/make_bubble_size_func.js index 9263cd9151f..d5536b8f62a 100644 --- a/src/traces/scatter/make_bubble_size_func.js +++ b/src/traces/scatter/make_bubble_size_func.js @@ -14,7 +14,7 @@ var isNumeric = require('fast-isnumeric'); // used in the drawing step for 'scatter' and 'scattegeo' and // in the convert step for 'scatter3d' -module.exports = function makeBubbleSizeFn(trace) { +module.exports = function(trace) { var marker = trace.marker; var sizeRef = marker.sizeref || 1; var sizeMin = marker.sizemin || 0; diff --git a/src/traces/scatter/marker_defaults.js b/src/traces/scatter/marker_defaults.js index 7c894777ff9..1626c888265 100644 --- a/src/traces/scatter/marker_defaults.js +++ b/src/traces/scatter/marker_defaults.js @@ -20,7 +20,7 @@ var subTypes = require('./subtypes'); * gradient: caller supports gradients * noSelect: caller does not support selected/unselected attribute containers */ -module.exports = function markerDefaults(traceIn, traceOut, defaultColor, layout, coerce, opts) { +module.exports = function(traceIn, traceOut, defaultColor, layout, coerce, opts) { var isBubble = subTypes.isBubble(traceIn); var lineColor = (traceIn.line || {}).color; var defaultMLC; diff --git a/src/traces/scatter/plot.js b/src/traces/scatter/plot.js index f0713e03eb8..f1446ae3fb3 100644 --- a/src/traces/scatter/plot.js +++ b/src/traces/scatter/plot.js @@ -22,7 +22,7 @@ var linePoints = require('./line_points'); var linkTraces = require('./link_traces'); var polygonTester = require('../../lib/polygon').tester; -module.exports = function plot(gd, plotinfo, cdscatter, scatterLayer, transitionOpts, makeOnCompleteCallback) { +module.exports = function(gd, plotinfo, cdscatter, scatterLayer, transitionOpts, makeOnCompleteCallback) { var join, onComplete; // If transition config is provided, then it is only a partial replot and traces not diff --git a/src/traces/scatter/select.js b/src/traces/scatter/select.js index 820f13846a3..a966ab5ef38 100644 --- a/src/traces/scatter/select.js +++ b/src/traces/scatter/select.js @@ -11,7 +11,7 @@ var subtypes = require('./subtypes'); -module.exports = function selectPoints(searchInfo, selectionTester) { +module.exports = function(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/scatter/stack_defaults.js b/src/traces/scatter/stack_defaults.js index 1668be2e1ce..6c8a79dc768 100644 --- a/src/traces/scatter/stack_defaults.js +++ b/src/traces/scatter/stack_defaults.js @@ -10,7 +10,7 @@ var perStackAttrs = ['orientation', 'groupnorm', 'stackgaps']; -module.exports = function handleStackDefaults(traceIn, traceOut, layout, coerce) { +module.exports = function(traceIn, traceOut, layout, coerce) { var stackOpts = layout._scatterStackOpts; var stackGroup = coerce('stackgroup'); diff --git a/src/traces/scatter/xy_defaults.js b/src/traces/scatter/xy_defaults.js index d6b09fbd69a..51c7a63a559 100644 --- a/src/traces/scatter/xy_defaults.js +++ b/src/traces/scatter/xy_defaults.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var Registry = require('../../registry'); -module.exports = function handleXYDefaults(traceIn, traceOut, layout, coerce) { +module.exports = function(traceIn, traceOut, layout, coerce) { var x = coerce('x'); var y = coerce('y'); var len; diff --git a/src/traces/scatter3d/calc.js b/src/traces/scatter3d/calc.js index 35bfdbbdf2b..96e4db0608d 100644 --- a/src/traces/scatter3d/calc.js +++ b/src/traces/scatter3d/calc.js @@ -16,7 +16,7 @@ var calcColorscale = require('../scatter/colorscale_calc'); * calcdata the way Scatter.plot does, so that legends and * popovers know what to do with them. */ -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var cd = [{x: false, y: false, trace: trace, t: {}}]; arraysToCalcdata(cd, trace); diff --git a/src/traces/scatter3d/defaults.js b/src/traces/scatter3d/defaults.js index 14de88e49ad..e4bf44102b8 100644 --- a/src/traces/scatter3d/defaults.js +++ b/src/traces/scatter3d/defaults.js @@ -19,7 +19,7 @@ var handleTextDefaults = require('../scatter/text_defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scattercarpet/calc.js b/src/traces/scattercarpet/calc.js index 372c0a653d4..0fa2b1f44f8 100644 --- a/src/traces/scattercarpet/calc.js +++ b/src/traces/scattercarpet/calc.js @@ -17,7 +17,7 @@ var calcSelection = require('../scatter/calc_selection'); var calcMarkerSize = require('../scatter/calc').calcMarkerSize; var lookupCarpet = require('../carpet/lookup_carpetid'); -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var carpet = trace._carpetTrace = lookupCarpet(gd, trace); if(!carpet || !carpet.visible || carpet.visible === 'legendonly') return; var i; diff --git a/src/traces/scattercarpet/defaults.js b/src/traces/scattercarpet/defaults.js index cea51be903d..f31a3dec551 100644 --- a/src/traces/scattercarpet/defaults.js +++ b/src/traces/scattercarpet/defaults.js @@ -21,7 +21,7 @@ var handleFillColorDefaults = require('../scatter/fillcolor_defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scattercarpet/event_data.js b/src/traces/scattercarpet/event_data.js index 7cb05de5ded..1314918fcb9 100644 --- a/src/traces/scattercarpet/event_data.js +++ b/src/traces/scattercarpet/event_data.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function eventData(out, pt, trace, cd, pointNumber) { +module.exports = function(out, pt, trace, cd, pointNumber) { var cdi = cd[pointNumber]; out.a = cdi.a; diff --git a/src/traces/scattercarpet/hover.js b/src/traces/scattercarpet/hover.js index 3f71bd0fbaf..d1b6a31f05f 100644 --- a/src/traces/scattercarpet/hover.js +++ b/src/traces/scattercarpet/hover.js @@ -11,7 +11,7 @@ var scatterHover = require('../scatter/hover'); var fillHoverText = require('../scatter/fill_hover_text'); -module.exports = function hoverPoints(pointData, xval, yval, hovermode) { +module.exports = function(pointData, xval, yval, hovermode) { var scatterPointData = scatterHover(pointData, xval, yval, hovermode); if(!scatterPointData || scatterPointData[0].index === false) return; diff --git a/src/traces/scattercarpet/plot.js b/src/traces/scattercarpet/plot.js index 8cce9fcb98b..fcf9cdf42dc 100644 --- a/src/traces/scattercarpet/plot.js +++ b/src/traces/scattercarpet/plot.js @@ -13,7 +13,7 @@ var scatterPlot = require('../scatter/plot'); var Axes = require('../../plots/cartesian/axes'); var Drawing = require('../../components/drawing'); -module.exports = function plot(gd, plotinfoproxy, data, layer) { +module.exports = function(gd, plotinfoproxy, data, layer) { var i, trace, node; var carpet = data[0][0].carpet; diff --git a/src/traces/scattergeo/calc.js b/src/traces/scattergeo/calc.js index 537b0562307..282fa31e36d 100644 --- a/src/traces/scattergeo/calc.js +++ b/src/traces/scattergeo/calc.js @@ -18,7 +18,7 @@ var calcSelection = require('../scatter/calc_selection'); var _ = require('../../lib')._; -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var hasLocationData = Array.isArray(trace.locations); var len = hasLocationData ? trace.locations.length : trace._length; var calcTrace = new Array(len); diff --git a/src/traces/scattergeo/defaults.js b/src/traces/scattergeo/defaults.js index d2b51fbfeb2..0b985d48ed7 100644 --- a/src/traces/scattergeo/defaults.js +++ b/src/traces/scattergeo/defaults.js @@ -20,7 +20,7 @@ var handleFillColorDefaults = require('../scatter/fillcolor_defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scattergeo/event_data.js b/src/traces/scattergeo/event_data.js index f52decf21ef..1f63be50b0f 100644 --- a/src/traces/scattergeo/event_data.js +++ b/src/traces/scattergeo/event_data.js @@ -10,7 +10,7 @@ 'use strict'; -module.exports = function eventData(out, pt) { +module.exports = function(out, pt) { out.lon = pt.lon; out.lat = pt.lat; out.location = pt.loc ? pt.loc : null; diff --git a/src/traces/scattergeo/hover.js b/src/traces/scattergeo/hover.js index 5aa9ed50c4b..cbfaf760bc1 100644 --- a/src/traces/scattergeo/hover.js +++ b/src/traces/scattergeo/hover.js @@ -17,7 +17,7 @@ var getTraceColor = require('../scatter/get_trace_color'); var fillHoverText = require('../scatter/fill_hover_text'); var attributes = require('./attributes'); -module.exports = function hoverPoints(pointData, xval, yval) { +module.exports = function(pointData, xval, yval) { var cd = pointData.cd; var trace = cd[0].trace; var xa = pointData.xa; diff --git a/src/traces/scattergeo/plot.js b/src/traces/scattergeo/plot.js index aa73745c55b..eeb194cbfed 100644 --- a/src/traces/scattergeo/plot.js +++ b/src/traces/scattergeo/plot.js @@ -19,7 +19,7 @@ var geoJsonUtils = require('../../lib/geojson_utils'); var subTypes = require('../scatter/subtypes'); var style = require('./style'); -module.exports = function plot(gd, geo, calcData) { +module.exports = function(gd, geo, calcData) { for(var i = 0; i < calcData.length; i++) { calcGeoJSON(calcData[i], geo.topojson); } diff --git a/src/traces/scattergeo/select.js b/src/traces/scattergeo/select.js index 299b05765b0..86a9c2711c7 100644 --- a/src/traces/scattergeo/select.js +++ b/src/traces/scattergeo/select.js @@ -11,7 +11,7 @@ var subtypes = require('../scatter/subtypes'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function selectPoints(searchInfo, selectionTester) { +module.exports = function(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/scattergeo/style.js b/src/traces/scattergeo/style.js index 14b13840136..509cafc7f75 100644 --- a/src/traces/scattergeo/style.js +++ b/src/traces/scattergeo/style.js @@ -16,7 +16,7 @@ var scatterStyle = require('../scatter/style'); var stylePoints = scatterStyle.stylePoints; var styleText = scatterStyle.styleText; -module.exports = function style(gd, calcTrace) { +module.exports = function(gd, calcTrace) { if(calcTrace) styleTrace(gd, calcTrace); }; diff --git a/src/traces/scattergl/defaults.js b/src/traces/scattergl/defaults.js index 82a05c4e52f..a4fb2fbccf4 100644 --- a/src/traces/scattergl/defaults.js +++ b/src/traces/scattergl/defaults.js @@ -20,7 +20,7 @@ var handleLineDefaults = require('../scatter/line_defaults'); var handleFillColorDefaults = require('../scatter/fillcolor_defaults'); var handleTextDefaults = require('../scatter/text_defaults'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scattergl/index.js b/src/traces/scattergl/index.js index 407348c588f..b2e083e1ea0 100644 --- a/src/traces/scattergl/index.js +++ b/src/traces/scattergl/index.js @@ -231,14 +231,14 @@ function sceneUpdate(gd, subplot) { if(!subplot._scene) { scene = subplot._scene = {}; - scene.init = function init() { + scene.init = function() { Lib.extendFlat(scene, initOpts, resetOpts); }; scene.init(); // apply new option to all regl components (used on drag) - scene.update = function update(opt) { + scene.update = function(opt) { var opts = Lib.repeat(opt, scene.count); if(scene.fill2d) scene.fill2d.update(opts); @@ -254,7 +254,7 @@ function sceneUpdate(gd, subplot) { }; // draw traces in proper order - scene.draw = function draw() { + scene.draw = function() { var count = scene.count; var fill2d = scene.fill2d; var error2d = scene.error2d; @@ -293,7 +293,7 @@ function sceneUpdate(gd, subplot) { }; // remove scene resources - scene.destroy = function destroy() { + scene.destroy = function() { if(scene.fill2d && scene.fill2d.destroy) scene.fill2d.destroy(); if(scene.scatter2d && scene.scatter2d.destroy) scene.scatter2d.destroy(); if(scene.error2d && scene.error2d.destroy) scene.error2d.destroy(); diff --git a/src/traces/scattermapbox/convert.js b/src/traces/scattermapbox/convert.js index 5dbc94ced6a..941973f4164 100644 --- a/src/traces/scattermapbox/convert.js +++ b/src/traces/scattermapbox/convert.js @@ -20,7 +20,7 @@ var makeBubbleSizeFn = require('../scatter/make_bubble_size_func'); var subTypes = require('../scatter/subtypes'); var convertTextOpts = require('../../plots/mapbox/convert_text_opts'); -module.exports = function convert(calcTrace) { +module.exports = function(calcTrace) { var trace = calcTrace[0].trace; var isVisible = (trace.visible === true); diff --git a/src/traces/scattermapbox/defaults.js b/src/traces/scattermapbox/defaults.js index f3b5b6d084f..afcaee732c9 100644 --- a/src/traces/scattermapbox/defaults.js +++ b/src/traces/scattermapbox/defaults.js @@ -17,7 +17,7 @@ var handleTextDefaults = require('../scatter/text_defaults'); var handleFillColorDefaults = require('../scatter/fillcolor_defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scattermapbox/event_data.js b/src/traces/scattermapbox/event_data.js index de17a9e9c78..f3f8cd12a94 100644 --- a/src/traces/scattermapbox/event_data.js +++ b/src/traces/scattermapbox/event_data.js @@ -10,7 +10,7 @@ 'use strict'; -module.exports = function eventData(out, pt) { +module.exports = function(out, pt) { out.lon = pt.lon; out.lat = pt.lat; diff --git a/src/traces/scattermapbox/hover.js b/src/traces/scattermapbox/hover.js index b1134016b9a..efd148bff0a 100644 --- a/src/traces/scattermapbox/hover.js +++ b/src/traces/scattermapbox/hover.js @@ -15,7 +15,7 @@ var getTraceColor = require('../scatter/get_trace_color'); var fillHoverText = require('../scatter/fill_hover_text'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function hoverPoints(pointData, xval, yval) { +module.exports = function(pointData, xval, yval) { var cd = pointData.cd; var trace = cd[0].trace; var xa = pointData.xa; diff --git a/src/traces/scattermapbox/plot.js b/src/traces/scattermapbox/plot.js index ac32b587ace..75884204137 100644 --- a/src/traces/scattermapbox/plot.js +++ b/src/traces/scattermapbox/plot.js @@ -60,7 +60,7 @@ proto.addLayer = function(k, opts) { }); }; -proto.update = function update(calcTrace) { +proto.update = function(calcTrace) { var subplot = this.subplot; var optsAll = convert(calcTrace); @@ -80,7 +80,7 @@ proto.update = function update(calcTrace) { calcTrace[0].trace._glTrace = this; }; -proto.dispose = function dispose() { +proto.dispose = function() { var map = this.subplot.map; for(var i = 0; i < this.order.length; i++) { @@ -90,7 +90,7 @@ proto.dispose = function dispose() { } }; -module.exports = function createScatterMapbox(subplot, calcTrace) { +module.exports = function(subplot, calcTrace) { var trace = calcTrace[0].trace; var scatterMapbox = new ScatterMapbox(subplot, trace.uid); var optsAll = convert(calcTrace); diff --git a/src/traces/scattermapbox/select.js b/src/traces/scattermapbox/select.js index 29dba6ee3d0..3392fd63c73 100644 --- a/src/traces/scattermapbox/select.js +++ b/src/traces/scattermapbox/select.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var subtypes = require('../scatter/subtypes'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function selectPoints(searchInfo, selectionTester) { +module.exports = function(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/scatterpolar/calc.js b/src/traces/scatterpolar/calc.js index 5338adcf1e1..f4d1f500456 100644 --- a/src/traces/scatterpolar/calc.js +++ b/src/traces/scatterpolar/calc.js @@ -19,7 +19,7 @@ var arraysToCalcdata = require('../scatter/arrays_to_calcdata'); var calcSelection = require('../scatter/calc_selection'); var calcMarkerSize = require('../scatter/calc').calcMarkerSize; -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var fullLayout = gd._fullLayout; var subplotId = trace.subplot; var radialAxis = fullLayout[subplotId].radialaxis; diff --git a/src/traces/scatterpolar/plot.js b/src/traces/scatterpolar/plot.js index 9125627a5a5..54c78e6e04a 100644 --- a/src/traces/scatterpolar/plot.js +++ b/src/traces/scatterpolar/plot.js @@ -11,7 +11,7 @@ var scatterPlot = require('../scatter/plot'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function plot(gd, subplot, moduleCalcData) { +module.exports = function(gd, subplot, moduleCalcData) { var mlayer = subplot.layers.frontplot.select('g.scatterlayer'); var plotinfo = { diff --git a/src/traces/scatterpolargl/defaults.js b/src/traces/scatterpolargl/defaults.js index 3f534d7a207..94005b62ce6 100644 --- a/src/traces/scatterpolargl/defaults.js +++ b/src/traces/scatterpolargl/defaults.js @@ -20,7 +20,7 @@ var PTS_LINESONLY = require('../scatter/constants').PTS_LINESONLY; var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scatterternary/calc.js b/src/traces/scatterternary/calc.js index 471802e7b44..7544f6d04b9 100644 --- a/src/traces/scatterternary/calc.js +++ b/src/traces/scatterternary/calc.js @@ -19,7 +19,7 @@ var calcMarkerSize = require('../scatter/calc').calcMarkerSize; var dataArrays = ['a', 'b', 'c']; var arraysToFill = {a: ['b', 'c'], b: ['a', 'c'], c: ['a', 'b']}; -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var ternary = gd._fullLayout[trace.subplot]; var displaySum = ternary.sum; var normSum = trace.sum || displaySum; diff --git a/src/traces/scatterternary/defaults.js b/src/traces/scatterternary/defaults.js index 920df2a0317..f8bcbf761b5 100644 --- a/src/traces/scatterternary/defaults.js +++ b/src/traces/scatterternary/defaults.js @@ -22,7 +22,7 @@ var handleFillColorDefaults = require('../scatter/fillcolor_defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scatterternary/event_data.js b/src/traces/scatterternary/event_data.js index ab46f69625f..bcd3d35353c 100644 --- a/src/traces/scatterternary/event_data.js +++ b/src/traces/scatterternary/event_data.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function eventData(out, pt, trace, cd, pointNumber) { +module.exports = function(out, pt, trace, cd, pointNumber) { if(pt.xa) out.xaxis = pt.xa; if(pt.ya) out.yaxis = pt.ya; diff --git a/src/traces/scatterternary/hover.js b/src/traces/scatterternary/hover.js index eaf0ad26421..ed510eac055 100644 --- a/src/traces/scatterternary/hover.js +++ b/src/traces/scatterternary/hover.js @@ -13,7 +13,7 @@ var scatterHover = require('../scatter/hover'); var Axes = require('../../plots/cartesian/axes'); -module.exports = function hoverPoints(pointData, xval, yval, hovermode) { +module.exports = function(pointData, xval, yval, hovermode) { var scatterPointData = scatterHover(pointData, xval, yval, hovermode); if(!scatterPointData || scatterPointData[0].index === false) return; diff --git a/src/traces/scatterternary/plot.js b/src/traces/scatterternary/plot.js index 06cd8642195..d9486885ca9 100644 --- a/src/traces/scatterternary/plot.js +++ b/src/traces/scatterternary/plot.js @@ -11,7 +11,7 @@ var scatterPlot = require('../scatter/plot'); -module.exports = function plot(gd, ternary, moduleCalcData) { +module.exports = function(gd, ternary, moduleCalcData) { var plotContainer = ternary.plotContainer; // remove all nodes inside the scatter layer diff --git a/src/traces/splom/defaults.js b/src/traces/splom/defaults.js index 9e7846d99e7..9b302b137dd 100644 --- a/src/traces/splom/defaults.js +++ b/src/traces/splom/defaults.js @@ -17,7 +17,7 @@ var handleMarkerDefaults = require('../scatter/marker_defaults'); var mergeLength = require('../parcoords/merge_length'); var OPEN_RE = /-open/; -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/splom/index.js b/src/traces/splom/index.js index 557c4427fdb..dc8755746ec 100644 --- a/src/traces/splom/index.js +++ b/src/traces/splom/index.js @@ -138,7 +138,7 @@ function sceneUpdate(gd, trace) { if(!scene) { scene = splomScenes[uid] = Lib.extendFlat({}, reset, first); - scene.draw = function draw() { + scene.draw = function() { if(scene.matrix && scene.matrix.draw) { if(scene.selectBatch) { scene.matrix.draw(scene.unselectBatch, scene.selectBatch); @@ -151,7 +151,7 @@ function sceneUpdate(gd, trace) { }; // remove scene resources - scene.destroy = function destroy() { + scene.destroy = function() { if(scene.matrix && scene.matrix.destroy) { scene.matrix.destroy(); } diff --git a/src/traces/streamtube/calc.js b/src/traces/streamtube/calc.js index 9a38f09c89d..62d5e151af8 100644 --- a/src/traces/streamtube/calc.js +++ b/src/traces/streamtube/calc.js @@ -10,7 +10,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var i; var u = trace.u; diff --git a/src/traces/streamtube/defaults.js b/src/traces/streamtube/defaults.js index f118a41f665..9a7b89fc8a5 100644 --- a/src/traces/streamtube/defaults.js +++ b/src/traces/streamtube/defaults.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/sunburst/defaults.js b/src/traces/sunburst/defaults.js index bea2a98da84..91324ee6fd4 100644 --- a/src/traces/sunburst/defaults.js +++ b/src/traces/sunburst/defaults.js @@ -14,7 +14,7 @@ var handleDomainDefaults = require('../../plots/domain').defaults; var coerceFont = Lib.coerceFont; -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/sunburst/layout_defaults.js b/src/traces/sunburst/layout_defaults.js index d54c3bc6919..a710afa0eda 100644 --- a/src/traces/sunburst/layout_defaults.js +++ b/src/traces/sunburst/layout_defaults.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var layoutAttributes = require('./layout_attributes'); -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) { +module.exports = function(layoutIn, layoutOut) { function coerce(attr, dflt) { return Lib.coerce(layoutIn, layoutOut, layoutAttributes, attr, dflt); } diff --git a/src/traces/surface/calc.js b/src/traces/surface/calc.js index 49d2b819196..39b319177b1 100644 --- a/src/traces/surface/calc.js +++ b/src/traces/surface/calc.js @@ -13,7 +13,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); // Compute auto-z and autocolorscale if applicable -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { if(trace.surfacecolor) { colorscaleCalc(gd, trace, { vals: trace.surfacecolor, diff --git a/src/traces/surface/defaults.js b/src/traces/surface/defaults.js index 980d32014bb..ac59bb6e35c 100644 --- a/src/traces/surface/defaults.js +++ b/src/traces/surface/defaults.js @@ -14,7 +14,7 @@ var Lib = require('../../lib'); var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { var i, j; function coerce(attr, dflt) { diff --git a/src/traces/table/calc.js b/src/traces/table/calc.js index 9a30db8f96c..1e88c4a2672 100644 --- a/src/traces/table/calc.js +++ b/src/traces/table/calc.js @@ -10,7 +10,7 @@ var wrap = require('../../lib/gup').wrap; -module.exports = function calc() { +module.exports = function() { // we don't actually need to include the trace here, since that will be added // by Plots.doCalcdata, and that's all we actually need later. return wrap({}); diff --git a/src/traces/table/data_preparation_helper.js b/src/traces/table/data_preparation_helper.js index 271a8424be7..a61d635c285 100644 --- a/src/traces/table/data_preparation_helper.js +++ b/src/traces/table/data_preparation_helper.js @@ -13,7 +13,7 @@ var extendFlat = require('../../lib/extend').extendFlat; var isNumeric = require('fast-isnumeric'); // pure functions, don't alter but passes on `gd` and parts of `trace` without deep copying -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var cellsValues = squareStringMatrix(trace.cells.values); var slicer = function(a) { return a.slice(trace.header.values.length, a.length); diff --git a/src/traces/table/defaults.js b/src/traces/table/defaults.js index 95b3d91b8a3..8cad6dc9e9a 100644 --- a/src/traces/table/defaults.js +++ b/src/traces/table/defaults.js @@ -24,7 +24,7 @@ function defaultColumnOrder(traceOut, coerce) { coerce('columnorder', oneStepped); } -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/table/plot.js b/src/traces/table/plot.js index 10ade457bf5..92bb07a0228 100644 --- a/src/traces/table/plot.js +++ b/src/traces/table/plot.js @@ -19,7 +19,7 @@ var prepareData = require('./data_preparation_helper'); var splitData = require('./data_split_helpers'); var Color = require('../../components/color'); -module.exports = function plot(gd, wrappedTraceHolders) { +module.exports = function(gd, wrappedTraceHolders) { var dynamic = !gd._context.staticPlot; var table = gd._fullLayout._paper.selectAll('.' + c.cn.table) @@ -714,7 +714,7 @@ function updateBlockYPosition(gd, cellsColumnBlock, tableControlView) { } function makeDragRow(gd, allTableControlView, optionalMultiplier, optionalPosition) { - return function dragRow(eventD) { + return function(eventD) { // may come from whichever DOM event target: drag, wheel, bar... eventD corresponds to event target var d = eventD.calcdata ? eventD.calcdata : eventD; var tableControlView = allTableControlView.filter(function(dd) {return d.key === dd.key;}); @@ -747,7 +747,7 @@ function conditionalPanelRerender(gd, tableControlView, cellsColumnBlock, pages, } function wrapTextMaker(columnBlock, element, tableControlView, gd) { - return function wrapText() { + return function() { var cellTextHolder = d3.select(element.parentNode); cellTextHolder .each(function(d) { @@ -790,7 +790,7 @@ function wrapTextMaker(columnBlock, element, tableControlView, gd) { } function updateYPositionMaker(columnBlock, element, tableControlView, gd, d) { - return function updateYPosition() { + return function() { if(d.settledY) return; var cellTextHolder = d3.select(element.parentNode); var l = getBlock(d); diff --git a/src/traces/violin/calc.js b/src/traces/violin/calc.js index fc5308aa1d0..f08eb881170 100644 --- a/src/traces/violin/calc.js +++ b/src/traces/violin/calc.js @@ -14,7 +14,7 @@ var boxCalc = require('../box/calc'); var helpers = require('./helpers'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var cd = boxCalc(gd, trace); if(cd[0].t.empty) return cd; diff --git a/src/traces/violin/cross_trace_calc.js b/src/traces/violin/cross_trace_calc.js index 2463233faf2..8da03b6801b 100644 --- a/src/traces/violin/cross_trace_calc.js +++ b/src/traces/violin/cross_trace_calc.js @@ -11,7 +11,7 @@ var setPositionOffset = require('../box/cross_trace_calc').setPositionOffset; var orientations = ['v', 'h']; -module.exports = function crossTraceCalc(gd, plotinfo) { +module.exports = function(gd, plotinfo) { var calcdata = gd.calcdata; var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; diff --git a/src/traces/violin/defaults.js b/src/traces/violin/defaults.js index 0a0fa8d1a73..641d6f84af2 100644 --- a/src/traces/violin/defaults.js +++ b/src/traces/violin/defaults.js @@ -14,7 +14,7 @@ var Color = require('../../components/color'); var boxDefaults = require('../box/defaults'); var attributes = require('./attributes'); -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/violin/hover.js b/src/traces/violin/hover.js index 184e41744c7..b2a28c897f2 100644 --- a/src/traces/violin/hover.js +++ b/src/traces/violin/hover.js @@ -13,7 +13,7 @@ var Axes = require('../../plots/cartesian/axes'); var boxHoverPoints = require('../box/hover'); var helpers = require('./helpers'); -module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLayer) { +module.exports = function(pointData, xval, yval, hovermode, hoverLayer) { var cd = pointData.cd; var trace = cd[0].trace; var hoveron = trace.hoveron; diff --git a/src/traces/violin/layout_defaults.js b/src/traces/violin/layout_defaults.js index 0bfde91ccaf..4af78efbad5 100644 --- a/src/traces/violin/layout_defaults.js +++ b/src/traces/violin/layout_defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var layoutAttributes = require('./layout_attributes'); var boxLayoutDefaults = require('../box/layout_defaults'); -module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { +module.exports = function(layoutIn, layoutOut, fullData) { function coerce(attr, dflt) { return Lib.coerce(layoutIn, layoutOut, layoutAttributes, attr, dflt); } diff --git a/src/traces/violin/plot.js b/src/traces/violin/plot.js index 1b1b7a148c2..110204b0b63 100644 --- a/src/traces/violin/plot.js +++ b/src/traces/violin/plot.js @@ -16,7 +16,7 @@ var boxPlot = require('../box/plot'); var linePoints = require('../scatter/line_points'); var helpers = require('./helpers'); -module.exports = function plot(gd, plotinfo, cdViolins, violinLayer) { +module.exports = function(gd, plotinfo, cdViolins, violinLayer) { var fullLayout = gd._fullLayout; var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; diff --git a/src/traces/violin/style.js b/src/traces/violin/style.js index 6863dc78dab..5e9addc3e6f 100644 --- a/src/traces/violin/style.js +++ b/src/traces/violin/style.js @@ -12,7 +12,7 @@ var d3 = require('d3'); var Color = require('../../components/color'); var stylePoints = require('../scatter/style').stylePoints; -module.exports = function style(gd, cd) { +module.exports = function(gd, cd) { var s = cd ? cd[0].node3 : d3.select(gd).selectAll('g.trace.violins'); s.style('opacity', function(d) { return d[0].trace.opacity; }); diff --git a/src/traces/volume/defaults.js b/src/traces/volume/defaults.js index dd88ded3257..1505718a188 100644 --- a/src/traces/volume/defaults.js +++ b/src/traces/volume/defaults.js @@ -28,7 +28,7 @@ function createWave(n, minOpacity) { return arr; } -module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { +module.exports = function(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/waterfall/calc.js b/src/traces/waterfall/calc.js index a5c9bcf0d98..799e87536ef 100644 --- a/src/traces/waterfall/calc.js +++ b/src/traces/waterfall/calc.js @@ -21,7 +21,7 @@ function isTotal(a) { return (a === 't' || a === 'total'); } -module.exports = function calc(gd, trace) { +module.exports = function(gd, trace) { var xa = Axes.getFromId(gd, trace.xaxis || 'x'); var ya = Axes.getFromId(gd, trace.yaxis || 'y'); var size, pos; diff --git a/src/traces/waterfall/cross_trace_calc.js b/src/traces/waterfall/cross_trace_calc.js index 229b4792215..4f2322e4dae 100644 --- a/src/traces/waterfall/cross_trace_calc.js +++ b/src/traces/waterfall/cross_trace_calc.js @@ -10,7 +10,7 @@ var setGroupPositions = require('../bar/cross_trace_calc').setGroupPositions; -module.exports = function crossTraceCalc(gd, plotinfo) { +module.exports = function(gd, plotinfo) { var fullLayout = gd._fullLayout; var fullData = gd._fullData; var calcdata = gd.calcdata; diff --git a/src/traces/waterfall/hover.js b/src/traces/waterfall/hover.js index f3bbe18ce83..709fcf64750 100644 --- a/src/traces/waterfall/hover.js +++ b/src/traces/waterfall/hover.js @@ -17,7 +17,7 @@ var DIRSYMBOL = { decreasing: '▼' }; -module.exports = function hoverPoints(pointData, xval, yval, hovermode) { +module.exports = function(pointData, xval, yval, hovermode) { var point = hoverOnBars(pointData, xval, yval, hovermode); if(!point) return; diff --git a/src/traces/waterfall/plot.js b/src/traces/waterfall/plot.js index 8c604727010..e138af25317 100644 --- a/src/traces/waterfall/plot.js +++ b/src/traces/waterfall/plot.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var Drawing = require('../../components/drawing'); var barPlot = require('../bar/plot'); -module.exports = function plot(gd, plotinfo, cdModule, traceLayer) { +module.exports = function(gd, plotinfo, cdModule, traceLayer) { barPlot(gd, plotinfo, cdModule, traceLayer); plotConnectors(gd, plotinfo, cdModule, traceLayer); }; diff --git a/tasks/util/browserify_wrapper.js b/tasks/util/browserify_wrapper.js index 7a4e49113b4..8e3ff152e31 100644 --- a/tasks/util/browserify_wrapper.js +++ b/tasks/util/browserify_wrapper.js @@ -28,7 +28,7 @@ var strictD3 = require('./strict_d3'); * * Logs basename of bundle when completed. */ -module.exports = function _bundle(pathToIndex, pathToBundle, opts, cb) { +module.exports = function(pathToIndex, pathToBundle, opts, cb) { opts = opts || {}; var pathToMinBundle = opts.pathToMinBundle; diff --git a/tasks/util/make_schema.js b/tasks/util/make_schema.js index 6b3537ff829..e95b069f774 100644 --- a/tasks/util/make_schema.js +++ b/tasks/util/make_schema.js @@ -2,7 +2,7 @@ var fs = require('fs'); var path = require('path'); var JSDOM = require('jsdom').JSDOM; -module.exports = function makeSchema(plotlyPath, schemaPath) { +module.exports = function(plotlyPath, schemaPath) { return function() { var plotlyjsCode = fs.readFileSync(plotlyPath, 'utf-8'); diff --git a/tasks/util/pull_css.js b/tasks/util/pull_css.js index 6ac0fc4aa13..c22b3a8ff8f 100644 --- a/tasks/util/pull_css.js +++ b/tasks/util/pull_css.js @@ -1,7 +1,7 @@ var fs = require('fs'); -module.exports = function pullCSS(data, pathOut) { +module.exports = function(data, pathOut) { var rules = {}; data.split(/\s*\}\s*/).forEach(function(chunk) { diff --git a/tasks/util/pull_font_svg.js b/tasks/util/pull_font_svg.js index f0a38d0dded..d9a11564f5f 100644 --- a/tasks/util/pull_font_svg.js +++ b/tasks/util/pull_font_svg.js @@ -4,7 +4,7 @@ var xml2js = require('xml2js'); var parser = new xml2js.Parser(); var builder = new xml2js.Builder({ headless: true, rootName: 'svg', renderOpts: {'newline': ''}}); -module.exports = function pullFontSVG(data, pathOut) { +module.exports = function(data, pathOut) { parser.parseString(data, function(err, result) { if(err) throw err; diff --git a/tasks/util/update_version.js b/tasks/util/update_version.js index 96e36e16d49..254f69be5d1 100644 --- a/tasks/util/update_version.js +++ b/tasks/util/update_version.js @@ -5,7 +5,7 @@ var falafel = require('falafel'); var pkg = require('../../package.json'); -module.exports = function updateVersion(pathToFile) { +module.exports = function(pathToFile) { fs.readFile(pathToFile, 'utf-8', function(err, code) { var out = falafel(code, function(node) { if(isVersionNode(node)) node.update('\'' + pkg.version + '\''); diff --git a/tasks/util/watchified_bundle.js b/tasks/util/watchified_bundle.js index 05fb07c9526..56d4afc52c6 100644 --- a/tasks/util/watchified_bundle.js +++ b/tasks/util/watchified_bundle.js @@ -18,7 +18,7 @@ var strictD3 = require('./strict_d3'); * @param {function} onFirstBundleCallback executed when first bundle is completed * */ -module.exports = function makeWatchifiedBundle(onFirstBundleCallback) { +module.exports = function(onFirstBundleCallback) { var b = browserify(constants.pathToPlotlyIndex, { debug: true, standalone: 'Plotly', diff --git a/tasks/util/wrap_locale.js b/tasks/util/wrap_locale.js index ddad20ba313..fe939d100c0 100644 --- a/tasks/util/wrap_locale.js +++ b/tasks/util/wrap_locale.js @@ -18,7 +18,7 @@ var moduleMarker = 'module.exports = '; * * Logs basename of bundle when completed. */ -module.exports = function wrapLocale(pathToInput, pathToOutput) { +module.exports = function(pathToInput, pathToOutput) { fs.readFile(pathToInput, 'utf8', function(err, data) { var moduleStart = data.indexOf(moduleMarker) + moduleMarker.length; var moduleEnd = data.indexOf(';', moduleStart); diff --git a/test/image/assets/get_image_paths.js b/test/image/assets/get_image_paths.js index 915bce2c2c0..12ec47e7199 100644 --- a/test/image/assets/get_image_paths.js +++ b/test/image/assets/get_image_paths.js @@ -14,7 +14,7 @@ var DEFAULT_FORMAT = 'png'; * test * diff */ -module.exports = function getImagePaths(mockName, format) { +module.exports = function(mockName, format) { format = format || DEFAULT_FORMAT; return { diff --git a/test/image/assets/get_image_request_options.js b/test/image/assets/get_image_request_options.js index 82589f76d16..522b42a8236 100644 --- a/test/image/assets/get_image_request_options.js +++ b/test/image/assets/get_image_request_options.js @@ -13,7 +13,7 @@ var DEFAULT_SCALE = 1; * scale (optional): scale of generated image * url (optional): URL of image server */ -module.exports = function getRequestOpts(specs) { +module.exports = function(specs) { var pathToMock = path.join(constants.pathToTestImageMocks, specs.mockName) + '.json'; var figure = require(pathToMock); diff --git a/test/image/assets/get_mock_list.js b/test/image/assets/get_mock_list.js index e0f4b39a147..c7e325a8762 100644 --- a/test/image/assets/get_mock_list.js +++ b/test/image/assets/get_mock_list.js @@ -10,7 +10,7 @@ var constants = require('../../../tasks/util/constants'); * @param {string} pattern * @return {array} */ -module.exports = function getMocks(pattern) { +module.exports = function(pattern) { // defaults to 'all' pattern = pattern || '*'; diff --git a/test/jasmine/assets/check_component.js b/test/jasmine/assets/check_component.js index dfc2decc2a8..644d8622ac3 100644 --- a/test/jasmine/assets/check_component.js +++ b/test/jasmine/assets/check_component.js @@ -8,7 +8,7 @@ var destroyGraphDiv = require('../assets/destroy_graph_div'); * expects bar, scatter3d, filter, and calendars to be registered * but the test is that they may have been registered in any order */ -module.exports = function checkComponent(Plotly) { +module.exports = function(Plotly) { describe('core (svg 2d, scatter) and registered (bar) traces and transforms', function() { var gd; diff --git a/test/jasmine/assets/check_event_data.js b/test/jasmine/assets/check_event_data.js index 8280491f53e..d17a0ed1c81 100644 --- a/test/jasmine/assets/check_event_data.js +++ b/test/jasmine/assets/check_event_data.js @@ -7,7 +7,7 @@ var hover = require('../assets/hover'); 'use strict'; -module.exports = function checkEventData(mock, x, y, additionalFields) { +module.exports = function(mock, x, y, additionalFields) { var mockCopy = Lib.extendDeep({}, mock); var gd; diff --git a/test/jasmine/assets/check_overlap.js b/test/jasmine/assets/check_overlap.js index 023ab70ae45..073f0f1e624 100644 --- a/test/jasmine/assets/check_overlap.js +++ b/test/jasmine/assets/check_overlap.js @@ -7,7 +7,7 @@ function compare(baseRects, compareRects) { baseRects.bottom > compareRects.top; } -module.exports = function checkOverlap(base, elements) { +module.exports = function(base, elements) { var baseRects = base.getBoundingClientRect(); // handle array as second argument diff --git a/test/jasmine/assets/click.js b/test/jasmine/assets/click.js index 1cf16e80da9..c5472bf1c91 100644 --- a/test/jasmine/assets/click.js +++ b/test/jasmine/assets/click.js @@ -24,7 +24,7 @@ var Lib = require('../../../src/lib'); * @param {array(2)} opts.slop - shift [x, y] between mousedown and mouseup. * Just for testing purposes, to simulate a sloppy click */ -module.exports = function click(x, y, optsIn) { +module.exports = function(x, y, optsIn) { var opts = Lib.extendFlat({}, optsIn || {}); var button = opts.button || 0; if(button && button !== 2) throw new Error('unsupported button: ' + button); diff --git a/test/jasmine/assets/create_graph_div.js b/test/jasmine/assets/create_graph_div.js index 9791d46018c..2c7a21c5486 100644 --- a/test/jasmine/assets/create_graph_div.js +++ b/test/jasmine/assets/create_graph_div.js @@ -1,6 +1,6 @@ 'use strict'; -module.exports = function createGraphDiv() { +module.exports = function() { var gd = document.createElement('div'); gd.id = 'graph'; document.body.appendChild(gd); diff --git a/test/jasmine/assets/custom_matchers.js b/test/jasmine/assets/custom_matchers.js index f1d877d8d51..ca02b9c953b 100644 --- a/test/jasmine/assets/custom_matchers.js +++ b/test/jasmine/assets/custom_matchers.js @@ -204,7 +204,7 @@ function assert2DArray(actual, expected, testFn) { } function makeIsCloseFn(precision) { - return function isClose(actual, expected) { + return function(actual, expected) { if(isNumeric(actual) && isNumeric(expected)) { return Math.abs(actual - expected) < precision; } @@ -216,7 +216,7 @@ function makeIsCloseFn(precision) { } function makeIsWithinFn(tolerance) { - return function isWithin(actual, expected) { + return function(actual, expected) { if(isNumeric(actual) && isNumeric(expected)) { return Math.abs(actual - expected) < tolerance; } diff --git a/test/jasmine/assets/delay.js b/test/jasmine/assets/delay.js index 5e7d8cbf26f..04bffbed374 100644 --- a/test/jasmine/assets/delay.js +++ b/test/jasmine/assets/delay.js @@ -10,7 +10,7 @@ * * delay(50)().then(...); */ -module.exports = function delay(duration) { +module.exports = function(duration) { return function(value) { return new Promise(function(resolve) { setTimeout(function() { diff --git a/test/jasmine/assets/destroy_graph_div.js b/test/jasmine/assets/destroy_graph_div.js index a1bd18b9741..61892695548 100644 --- a/test/jasmine/assets/destroy_graph_div.js +++ b/test/jasmine/assets/destroy_graph_div.js @@ -1,6 +1,6 @@ 'use strict'; -module.exports = function destroyGraphDiv() { +module.exports = function() { var gd = document.getElementById('graph'); if(gd) document.body.removeChild(gd); diff --git a/test/jasmine/assets/double_click.js b/test/jasmine/assets/double_click.js index 222ecd7e5a4..637234d8df8 100644 --- a/test/jasmine/assets/double_click.js +++ b/test/jasmine/assets/double_click.js @@ -11,7 +11,7 @@ var DBLCLICKDELAY = require('../../../src/constants/interactions').DBLCLICKDELAY * to specify modifier keys. See `click` function * for more info. */ -module.exports = function doubleClick(x, y, clickOpts) { +module.exports = function(x, y, clickOpts) { if(typeof x === 'object') { var coords = getNodeCoords(x, y); x = coords.x; diff --git a/test/jasmine/assets/fail_test.js b/test/jasmine/assets/fail_test.js index 32cb8a178f9..094b37f1a9b 100644 --- a/test/jasmine/assets/fail_test.js +++ b/test/jasmine/assets/fail_test.js @@ -17,7 +17,7 @@ * * See ./with_setup_teardown.js for a different example. */ -module.exports = function failTest(error) { +module.exports = function(error) { if(error === undefined) { expect(error).not.toBeUndefined(); } else { diff --git a/test/jasmine/assets/get_bbox.js b/test/jasmine/assets/get_bbox.js index 04064ad35f5..f0fb7a8869c 100644 --- a/test/jasmine/assets/get_bbox.js +++ b/test/jasmine/assets/get_bbox.js @@ -6,7 +6,7 @@ var ATTRS = ['x', 'y', 'width', 'height']; // In-house implementation of SVG getBBox that takes clip paths into account -module.exports = function getBBox(element) { +module.exports = function(element) { var elementBBox = element.getBBox(); var s = d3.select(element); diff --git a/test/jasmine/assets/get_client_position.js b/test/jasmine/assets/get_client_position.js index f9a45cf36a3..697bfb57a82 100644 --- a/test/jasmine/assets/get_client_position.js +++ b/test/jasmine/assets/get_client_position.js @@ -1,4 +1,4 @@ -module.exports = function getClientPosition(selector, index) { +module.exports = function(selector, index) { index = index || 0; var selection = document.querySelectorAll(selector); diff --git a/test/jasmine/assets/get_rect_center.js b/test/jasmine/assets/get_rect_center.js index 1117383354b..ea5911e3e4b 100644 --- a/test/jasmine/assets/get_rect_center.js +++ b/test/jasmine/assets/get_rect_center.js @@ -7,7 +7,7 @@ * * @param {rect} rect svg node */ -module.exports = function getRectCenter(rect) { +module.exports = function(rect) { var corners = getRectScreenCoords(rect); return [ diff --git a/test/jasmine/assets/hover.js b/test/jasmine/assets/hover.js index 0efa6fbb13f..e32fd1a047a 100644 --- a/test/jasmine/assets/hover.js +++ b/test/jasmine/assets/hover.js @@ -1,5 +1,5 @@ var mouseEvent = require('./mouse_event'); -module.exports = function hover(x, y) { +module.exports = function(x, y) { mouseEvent('mousemove', x, y); }; diff --git a/test/jasmine/assets/modebar_button.js b/test/jasmine/assets/modebar_button.js index ba3c1182461..be937c15f32 100644 --- a/test/jasmine/assets/modebar_button.js +++ b/test/jasmine/assets/modebar_button.js @@ -3,7 +3,7 @@ var d3 = require('d3'); var modeBarButtons = require('../../../src/components/modebar/buttons'); -module.exports = function selectButton(modeBar, name) { +module.exports = function(modeBar, name) { var button = {}; var title = modeBarButtons[name].title; diff --git a/test/jasmine/assets/supply_defaults.js b/test/jasmine/assets/supply_defaults.js index 28bba9b870f..f6f0339a95c 100644 --- a/test/jasmine/assets/supply_defaults.js +++ b/test/jasmine/assets/supply_defaults.js @@ -9,7 +9,7 @@ var Plotly = require('@lib'); /** * supplyDefaults that fills in necessary _context */ -module.exports = function supplyDefaults(gd) { +module.exports = function(gd) { if(!gd._context) gd._context = {}; if(!gd._context.locale) gd._context.locale = 'en'; if(!gd._context.locales) gd._context.locales = {}; diff --git a/test/jasmine/assets/timed_click.js b/test/jasmine/assets/timed_click.js index f9f4036673c..0d62d9d186a 100644 --- a/test/jasmine/assets/timed_click.js +++ b/test/jasmine/assets/timed_click.js @@ -1,6 +1,6 @@ var mouseEvent = require('./mouse_event'); -module.exports = function click(x, y) { +module.exports = function(x, y) { mouseEvent('mousemove', x, y, {buttons: 0}); window.setTimeout(function() { diff --git a/test/jasmine/assets/transitions.js b/test/jasmine/assets/transitions.js index cf1be579d51..26a03e5f3b1 100644 --- a/test/jasmine/assets/transitions.js +++ b/test/jasmine/assets/transitions.js @@ -5,7 +5,7 @@ * a sequence of indices such that you efficiently execute each transition * from any state to any other state. */ -module.exports = function transitions(n) { +module.exports = function(n) { var out = [0]; var nextStates = []; var i; diff --git a/test/jasmine/assets/unpolyfill.js b/test/jasmine/assets/unpolyfill.js index 15bf14ff3a8..d90ec6ec98a 100644 --- a/test/jasmine/assets/unpolyfill.js +++ b/test/jasmine/assets/unpolyfill.js @@ -11,7 +11,7 @@ configurable: true, enumerable: true, writable: true, - value: function remove() { + value: function() { throw Error([ 'test/jasmine/assets/unpolyfill.js error: calling ChildNode.remove()', 'which is not available in IE.' @@ -23,7 +23,7 @@ configurable: true, enumerable: true, writable: true, - value: function remove() { + value: function() { throw Error([ 'test/jasmine/assets/unpolyfill.js error: calling ChildNode.prepend()', 'which is not available in IE.' From b9947a9dd18fe56d72f2e2207cbe70efb9f554f4 Mon Sep 17 00:00:00 2001 From: archmoj Date: Thu, 18 Apr 2019 20:49:54 -0400 Subject: [PATCH 3/5] Revert "apply new lint rule in various files" This reverts commit 21bdf7832fb60030447f54ff5d2e7eb91d29cc77. --- src/components/annotations/calc_autorange.js | 2 +- src/components/annotations/common_defaults.js | 2 +- src/components/annotations/convert_coords.js | 2 +- src/components/annotations/defaults.js | 2 +- src/components/annotations/draw_arrow_head.js | 2 +- src/components/annotations3d/convert.js | 2 +- src/components/annotations3d/defaults.js | 2 +- src/components/annotations3d/draw.js | 2 +- src/components/colorbar/connect.js | 2 +- src/components/colorbar/defaults.js | 2 +- src/components/colorbar/draw.js | 2 +- src/components/colorbar/has_colorbar.js | 2 +- src/components/colorscale/attributes.js | 2 +- src/components/colorscale/calc.js | 2 +- .../colorscale/cross_trace_defaults.js | 2 +- src/components/colorscale/defaults.js | 2 +- src/components/colorscale/layout_defaults.js | 2 +- src/components/dragelement/align.js | 2 +- src/components/dragelement/cursor.js | 2 +- src/components/dragelement/index.js | 2 +- src/components/dragelement/unhover.js | 2 +- src/components/errorbars/calc.js | 2 +- src/components/errorbars/compute_error.js | 10 +++++----- src/components/errorbars/plot.js | 2 +- src/components/errorbars/style.js | 2 +- src/components/fx/calc.js | 2 +- src/components/fx/click.js | 2 +- src/components/fx/defaults.js | 2 +- src/components/fx/helpers.js | 18 +++++++++--------- src/components/fx/hover.js | 4 ++-- src/components/fx/hoverlabel_defaults.js | 2 +- src/components/fx/layout_defaults.js | 2 +- src/components/fx/layout_global_defaults.js | 2 +- src/components/images/convert_coords.js | 2 +- src/components/images/defaults.js | 2 +- src/components/images/draw.js | 2 +- src/components/legend/anchor_utils.js | 8 ++++---- src/components/legend/defaults.js | 2 +- src/components/legend/draw.js | 2 +- src/components/legend/get_legend_data.js | 2 +- src/components/legend/handle_click.js | 2 +- src/components/legend/helpers.js | 6 +++--- src/components/legend/style.js | 2 +- src/components/modebar/manage.js | 2 +- src/components/rangeselector/defaults.js | 2 +- src/components/rangeselector/draw.js | 2 +- .../rangeselector/get_update_object.js | 2 +- src/components/rangeslider/calc_autorange.js | 2 +- src/components/rangeslider/defaults.js | 2 +- src/components/shapes/calc_autorange.js | 2 +- src/components/shapes/defaults.js | 2 +- src/components/shapes/draw.js | 8 ++++---- src/components/sliders/defaults.js | 2 +- src/components/sliders/draw.js | 2 +- src/components/updatemenus/defaults.js | 2 +- src/components/updatemenus/draw.js | 2 +- src/components/updatemenus/scrollbox.js | 12 ++++++------ src/lib/anchor_utils.js | 12 ++++++------ src/lib/clean_number.js | 2 +- src/lib/clear_gl_canvases.js | 2 +- src/lib/clear_responsive.js | 2 +- src/lib/filter_unique.js | 2 +- src/lib/filter_visible.js | 2 +- src/lib/geometry2d.js | 8 ++++---- src/lib/identity.js | 2 +- src/lib/index.js | 8 ++++---- src/lib/is_plain_object.js | 2 +- src/lib/keyed_container.js | 2 +- src/lib/localize.js | 2 +- src/lib/make_trace_groups.js | 2 +- src/lib/nested_property.js | 2 +- src/lib/noop.js | 2 +- src/lib/override_cursor.js | 2 +- src/lib/polygon.js | 6 +++--- src/lib/prepare_regl.js | 2 +- src/lib/push_unique.js | 2 +- src/lib/queue.js | 4 ++-- src/lib/relink_private.js | 6 ++---- src/lib/setcursor.js | 2 +- src/lib/show_no_webgl_msg.js | 2 +- src/lib/svg_text_utils.js | 4 ++-- src/lib/throttle.js | 4 ++-- src/lib/to_log_range.js | 2 +- src/plot_api/container_array_match.js | 2 +- src/plot_api/manage_arrays.js | 6 +++--- src/plot_api/plot_api.js | 6 +++--- src/plot_api/validate.js | 2 +- src/plots/array_container_defaults.js | 2 +- src/plots/cartesian/autorange.js | 2 +- src/plots/cartesian/axes.js | 2 +- src/plots/cartesian/axis_autotype.js | 2 +- src/plots/cartesian/axis_defaults.js | 2 +- src/plots/cartesian/axis_ids.js | 8 ++++---- src/plots/cartesian/category_order_defaults.js | 2 +- src/plots/cartesian/constraints.js | 4 ++-- src/plots/cartesian/graph_interact.js | 2 +- src/plots/cartesian/include_components.js | 4 ++-- src/plots/cartesian/layout_defaults.js | 2 +- src/plots/cartesian/line_grid_defaults.js | 2 +- src/plots/cartesian/position_defaults.js | 2 +- src/plots/cartesian/scale_zoom.js | 2 +- src/plots/cartesian/set_convert.js | 2 +- src/plots/cartesian/tick_label_defaults.js | 2 +- src/plots/cartesian/tick_mark_defaults.js | 2 +- src/plots/cartesian/tick_value_defaults.js | 2 +- src/plots/cartesian/transition_axes.js | 2 +- src/plots/cartesian/type_defaults.js | 2 +- src/plots/command.js | 6 +++--- src/plots/geo/geo.js | 2 +- src/plots/geo/layout_defaults.js | 2 +- src/plots/get_data.js | 2 +- src/plots/gl2d/index.js | 2 +- src/plots/gl3d/index.js | 4 ++-- src/plots/gl3d/layout/axis_defaults.js | 2 +- src/plots/gl3d/layout/defaults.js | 2 +- src/plots/gl3d/scene.js | 6 +++--- src/plots/gl3d/zip3.js | 2 +- src/plots/mapbox/convert_text_opts.js | 2 +- src/plots/mapbox/index.js | 2 +- src/plots/mapbox/layers.js | 6 +++--- src/plots/mapbox/layout_defaults.js | 2 +- src/plots/mapbox/mapbox.js | 2 +- src/plots/plots.js | 2 +- src/plots/polar/layout_defaults.js | 2 +- src/plots/polar/legacy/undo_manager.js | 2 +- src/plots/polar/polar.js | 2 +- src/plots/polar/set_convert.js | 2 +- src/plots/subplot_defaults.js | 2 +- src/plots/ternary/index.js | 2 +- src/plots/ternary/layout_defaults.js | 2 +- src/registry.js | 2 +- src/snapshot/cloneplot.js | 2 +- src/snapshot/tosvg.js | 2 +- src/traces/bar/arrays_to_calcdata.js | 2 +- src/traces/bar/calc.js | 2 +- src/traces/bar/plot.js | 2 +- src/traces/bar/select.js | 2 +- src/traces/bar/sieve.js | 6 +++--- src/traces/bar/style_defaults.js | 2 +- src/traces/barpolar/defaults.js | 2 +- src/traces/barpolar/hover.js | 2 +- src/traces/barpolar/plot.js | 2 +- src/traces/box/calc.js | 2 +- src/traces/box/event_data.js | 2 +- src/traces/box/select.js | 2 +- src/traces/candlestick/defaults.js | 2 +- src/traces/carpet/ab_defaults.js | 2 +- src/traces/carpet/axis_defaults.js | 2 +- src/traces/carpet/calc.js | 2 +- src/traces/carpet/calc_clippath.js | 2 +- src/traces/carpet/calc_gridlines.js | 2 +- src/traces/carpet/calc_labels.js | 2 +- src/traces/carpet/catmull_rom.js | 2 +- src/traces/carpet/compute_control_points.js | 2 +- src/traces/carpet/defaults.js | 2 +- src/traces/carpet/makepath.js | 2 +- src/traces/carpet/map_1d_array.js | 2 +- src/traces/carpet/orient_text.js | 2 +- src/traces/carpet/plot.js | 2 +- src/traces/carpet/set_convert.js | 2 +- src/traces/carpet/smooth_fill_2d_array.js | 2 +- src/traces/carpet/smooth_fill_array.js | 2 +- src/traces/carpet/xy_defaults.js | 2 +- src/traces/choropleth/calc.js | 2 +- src/traces/choropleth/defaults.js | 2 +- src/traces/choropleth/event_data.js | 2 +- src/traces/choropleth/hover.js | 2 +- src/traces/choropleth/plot.js | 2 +- src/traces/choropleth/select.js | 2 +- src/traces/cone/calc.js | 2 +- src/traces/cone/defaults.js | 2 +- src/traces/contour/calc.js | 2 +- src/traces/contour/colorbar.js | 2 +- src/traces/contour/constraint_defaults.js | 2 +- src/traces/contour/contours_defaults.js | 2 +- src/traces/contour/defaults.js | 2 +- src/traces/contour/empty_pathinfo.js | 2 +- src/traces/contour/end_plus.js | 2 +- src/traces/contour/find_all_paths.js | 2 +- src/traces/contour/hover.js | 2 +- src/traces/contour/label_defaults.js | 2 +- src/traces/contour/make_color_map.js | 2 +- src/traces/contour/make_crossings.js | 2 +- src/traces/contour/plot.js | 2 +- src/traces/contour/set_contours.js | 2 +- src/traces/contour/style.js | 2 +- src/traces/contour/style_defaults.js | 2 +- src/traces/contourcarpet/calc.js | 2 +- src/traces/contourcarpet/defaults.js | 2 +- src/traces/contourcarpet/join_all_paths.js | 2 +- src/traces/contourcarpet/map_pathinfo.js | 2 +- src/traces/contourcarpet/plot.js | 2 +- src/traces/heatmap/calc.js | 2 +- src/traces/heatmap/clean_2d_array.js | 2 +- src/traces/heatmap/convert_column_xyz.js | 2 +- src/traces/heatmap/defaults.js | 2 +- src/traces/heatmap/find_empties.js | 2 +- src/traces/heatmap/hover.js | 2 +- src/traces/heatmap/interp2d.js | 2 +- src/traces/heatmap/make_bound_array.js | 2 +- src/traces/heatmap/style.js | 2 +- src/traces/heatmap/style_defaults.js | 2 +- src/traces/heatmap/xyz_defaults.js | 2 +- src/traces/histogram/average.js | 2 +- src/traces/histogram/bin_attributes.js | 2 +- src/traces/histogram/bin_label_vals.js | 2 +- src/traces/histogram/calc.js | 2 +- src/traces/histogram/cross_trace_defaults.js | 2 +- src/traces/histogram/defaults.js | 2 +- src/traces/histogram/event_data.js | 2 +- src/traces/histogram/hover.js | 2 +- src/traces/histogram2d/calc.js | 2 +- src/traces/histogram2d/cross_trace_defaults.js | 2 +- src/traces/histogram2d/defaults.js | 2 +- src/traces/histogram2d/hover.js | 2 +- src/traces/histogram2d/sample_defaults.js | 2 +- src/traces/histogram2dcontour/defaults.js | 2 +- src/traces/isosurface/calc.js | 2 +- src/traces/mesh3d/calc.js | 2 +- src/traces/mesh3d/defaults.js | 2 +- src/traces/ohlc/defaults.js | 2 +- src/traces/ohlc/ohlc_defaults.js | 2 +- src/traces/ohlc/plot.js | 2 +- src/traces/ohlc/select.js | 2 +- src/traces/ohlc/style.js | 2 +- src/traces/parcats/calc.js | 2 +- src/traces/parcats/defaults.js | 2 +- src/traces/parcats/plot.js | 2 +- src/traces/parcoords/axisbrush.js | 2 +- src/traces/parcoords/calc.js | 2 +- src/traces/parcoords/defaults.js | 2 +- src/traces/parcoords/plot.js | 4 ++-- src/traces/pie/calc.js | 2 +- src/traces/pie/defaults.js | 2 +- src/traces/pie/event_data.js | 2 +- src/traces/pie/helpers.js | 8 ++++---- src/traces/pie/layout_defaults.js | 2 +- src/traces/pie/style.js | 2 +- src/traces/pie/style_one.js | 2 +- src/traces/pointcloud/defaults.js | 2 +- src/traces/sankey/calc.js | 2 +- src/traces/sankey/defaults.js | 2 +- src/traces/sankey/plot.js | 2 +- src/traces/sankey/render.js | 2 +- src/traces/sankey/select.js | 2 +- src/traces/scatter/arrays_to_calcdata.js | 2 +- src/traces/scatter/calc_selection.js | 2 +- src/traces/scatter/colorscale_calc.js | 2 +- src/traces/scatter/cross_trace_calc.js | 2 +- src/traces/scatter/cross_trace_defaults.js | 2 +- src/traces/scatter/defaults.js | 2 +- src/traces/scatter/fill_hover_text.js | 2 +- src/traces/scatter/fillcolor_defaults.js | 2 +- src/traces/scatter/get_trace_color.js | 2 +- src/traces/scatter/hover.js | 2 +- src/traces/scatter/line_defaults.js | 2 +- src/traces/scatter/line_points.js | 2 +- src/traces/scatter/line_shape_defaults.js | 2 +- src/traces/scatter/link_traces.js | 2 +- src/traces/scatter/make_bubble_size_func.js | 2 +- src/traces/scatter/marker_defaults.js | 2 +- src/traces/scatter/plot.js | 2 +- src/traces/scatter/select.js | 2 +- src/traces/scatter/stack_defaults.js | 2 +- src/traces/scatter/xy_defaults.js | 2 +- src/traces/scatter3d/calc.js | 2 +- src/traces/scatter3d/defaults.js | 2 +- src/traces/scattercarpet/calc.js | 2 +- src/traces/scattercarpet/defaults.js | 2 +- src/traces/scattercarpet/event_data.js | 2 +- src/traces/scattercarpet/hover.js | 2 +- src/traces/scattercarpet/plot.js | 2 +- src/traces/scattergeo/calc.js | 2 +- src/traces/scattergeo/defaults.js | 2 +- src/traces/scattergeo/event_data.js | 2 +- src/traces/scattergeo/hover.js | 2 +- src/traces/scattergeo/plot.js | 2 +- src/traces/scattergeo/select.js | 2 +- src/traces/scattergeo/style.js | 2 +- src/traces/scattergl/defaults.js | 2 +- src/traces/scattergl/index.js | 8 ++++---- src/traces/scattermapbox/convert.js | 2 +- src/traces/scattermapbox/defaults.js | 2 +- src/traces/scattermapbox/event_data.js | 2 +- src/traces/scattermapbox/hover.js | 2 +- src/traces/scattermapbox/plot.js | 6 +++--- src/traces/scattermapbox/select.js | 2 +- src/traces/scatterpolar/calc.js | 2 +- src/traces/scatterpolar/plot.js | 2 +- src/traces/scatterpolargl/defaults.js | 2 +- src/traces/scatterternary/calc.js | 2 +- src/traces/scatterternary/defaults.js | 2 +- src/traces/scatterternary/event_data.js | 2 +- src/traces/scatterternary/hover.js | 2 +- src/traces/scatterternary/plot.js | 2 +- src/traces/splom/defaults.js | 2 +- src/traces/splom/index.js | 4 ++-- src/traces/streamtube/calc.js | 2 +- src/traces/streamtube/defaults.js | 2 +- src/traces/sunburst/defaults.js | 2 +- src/traces/sunburst/layout_defaults.js | 2 +- src/traces/surface/calc.js | 2 +- src/traces/surface/defaults.js | 2 +- src/traces/table/calc.js | 2 +- src/traces/table/data_preparation_helper.js | 2 +- src/traces/table/defaults.js | 2 +- src/traces/table/plot.js | 8 ++++---- src/traces/violin/calc.js | 2 +- src/traces/violin/cross_trace_calc.js | 2 +- src/traces/violin/defaults.js | 2 +- src/traces/violin/hover.js | 2 +- src/traces/violin/layout_defaults.js | 2 +- src/traces/violin/plot.js | 2 +- src/traces/violin/style.js | 2 +- src/traces/volume/defaults.js | 2 +- src/traces/waterfall/calc.js | 2 +- src/traces/waterfall/cross_trace_calc.js | 2 +- src/traces/waterfall/hover.js | 2 +- src/traces/waterfall/plot.js | 2 +- tasks/util/browserify_wrapper.js | 2 +- tasks/util/make_schema.js | 2 +- tasks/util/pull_css.js | 2 +- tasks/util/pull_font_svg.js | 2 +- tasks/util/update_version.js | 2 +- tasks/util/watchified_bundle.js | 2 +- tasks/util/wrap_locale.js | 2 +- test/image/assets/get_image_paths.js | 2 +- test/image/assets/get_image_request_options.js | 2 +- test/image/assets/get_mock_list.js | 2 +- test/jasmine/assets/check_component.js | 2 +- test/jasmine/assets/check_event_data.js | 2 +- test/jasmine/assets/check_overlap.js | 2 +- test/jasmine/assets/click.js | 2 +- test/jasmine/assets/create_graph_div.js | 2 +- test/jasmine/assets/custom_matchers.js | 4 ++-- test/jasmine/assets/delay.js | 2 +- test/jasmine/assets/destroy_graph_div.js | 2 +- test/jasmine/assets/double_click.js | 2 +- test/jasmine/assets/fail_test.js | 2 +- test/jasmine/assets/get_bbox.js | 2 +- test/jasmine/assets/get_client_position.js | 2 +- test/jasmine/assets/get_rect_center.js | 2 +- test/jasmine/assets/hover.js | 2 +- test/jasmine/assets/modebar_button.js | 2 +- test/jasmine/assets/supply_defaults.js | 2 +- test/jasmine/assets/timed_click.js | 2 +- test/jasmine/assets/transitions.js | 2 +- test/jasmine/assets/unpolyfill.js | 4 ++-- 348 files changed, 424 insertions(+), 426 deletions(-) diff --git a/src/components/annotations/calc_autorange.js b/src/components/annotations/calc_autorange.js index f468be95162..60c5905dc7b 100644 --- a/src/components/annotations/calc_autorange.js +++ b/src/components/annotations/calc_autorange.js @@ -15,7 +15,7 @@ var Axes = require('../../plots/cartesian/axes'); var draw = require('./draw').draw; -module.exports = function(gd) { +module.exports = function calcAutorange(gd) { var fullLayout = gd._fullLayout; var annotationList = Lib.filterVisible(fullLayout.annotations); diff --git a/src/components/annotations/common_defaults.js b/src/components/annotations/common_defaults.js index 3a096c6e06f..fa4cd0981d7 100644 --- a/src/components/annotations/common_defaults.js +++ b/src/components/annotations/common_defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var Color = require('../color'); // defaults common to 'annotations' and 'annotations3d' -module.exports = function(annIn, annOut, fullLayout, coerce) { +module.exports = function handleAnnotationCommonDefaults(annIn, annOut, fullLayout, coerce) { coerce('opacity'); var bgColor = coerce('bgcolor'); diff --git a/src/components/annotations/convert_coords.js b/src/components/annotations/convert_coords.js index 4dbb8af6010..d64cfad9136 100644 --- a/src/components/annotations/convert_coords.js +++ b/src/components/annotations/convert_coords.js @@ -25,7 +25,7 @@ var toLogRange = require('../../lib/to_log_range'); * Use this to make the changes as it's aware if any other changes in the * same relayout call should override this conversion. */ -module.exports = function(gd, ax, newType, doExtra) { +module.exports = function convertCoords(gd, ax, newType, doExtra) { ax = ax || {}; var toLog = (newType === 'log') && (ax.type === 'linear'); diff --git a/src/components/annotations/defaults.js b/src/components/annotations/defaults.js index 746be1519af..c7dac3f64da 100644 --- a/src/components/annotations/defaults.js +++ b/src/components/annotations/defaults.js @@ -17,7 +17,7 @@ var handleAnnotationCommonDefaults = require('./common_defaults'); var attributes = require('./attributes'); -module.exports = function(layoutIn, layoutOut) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) { handleArrayContainerDefaults(layoutIn, layoutOut, { name: 'annotations', handleItemDefaults: handleAnnotationDefaults diff --git a/src/components/annotations/draw_arrow_head.js b/src/components/annotations/draw_arrow_head.js index 9ae2cb2428a..e3f6f71a1e5 100644 --- a/src/components/annotations/draw_arrow_head.js +++ b/src/components/annotations/draw_arrow_head.js @@ -35,7 +35,7 @@ var ARROWPATHS = require('./arrow_paths'); * of both the line and head has opacity applied to it so there isn't greater opacity * where they overlap. */ -module.exports = function(el3, ends, options) { +module.exports = function drawArrowHead(el3, ends, options) { var el = el3.node(); var headStyle = ARROWPATHS[options.arrowhead || 0]; var startHeadStyle = ARROWPATHS[options.startarrowhead || 0]; diff --git a/src/components/annotations3d/convert.js b/src/components/annotations3d/convert.js index db27d8e973b..2f9a7d36213 100644 --- a/src/components/annotations3d/convert.js +++ b/src/components/annotations3d/convert.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var Axes = require('../../plots/cartesian/axes'); -module.exports = function(scene) { +module.exports = function convert(scene) { var fullSceneLayout = scene.fullSceneLayout; var anns = fullSceneLayout.annotations; diff --git a/src/components/annotations3d/defaults.js b/src/components/annotations3d/defaults.js index 15d2dd02b3a..754695da755 100644 --- a/src/components/annotations3d/defaults.js +++ b/src/components/annotations3d/defaults.js @@ -14,7 +14,7 @@ var handleArrayContainerDefaults = require('../../plots/array_container_defaults var handleAnnotationCommonDefaults = require('../annotations/common_defaults'); var attributes = require('./attributes'); -module.exports = function(sceneLayoutIn, sceneLayoutOut, opts) { +module.exports = function handleDefaults(sceneLayoutIn, sceneLayoutOut, opts) { handleArrayContainerDefaults(sceneLayoutIn, sceneLayoutOut, { name: 'annotations', handleItemDefaults: handleAnnotationDefaults, diff --git a/src/components/annotations3d/draw.js b/src/components/annotations3d/draw.js index 418b03a23e5..52e26c3716f 100644 --- a/src/components/annotations3d/draw.js +++ b/src/components/annotations3d/draw.js @@ -12,7 +12,7 @@ var drawRaw = require('../annotations/draw').drawRaw; var project = require('../../plots/gl3d/project'); var axLetters = ['x', 'y', 'z']; -module.exports = function(scene) { +module.exports = function draw(scene) { var fullSceneLayout = scene.fullSceneLayout; var dataScale = scene.dataScale; var anns = fullSceneLayout.annotations; diff --git a/src/components/colorbar/connect.js b/src/components/colorbar/connect.js index 20a834e8b0e..7afd261873b 100644 --- a/src/components/colorbar/connect.js +++ b/src/components/colorbar/connect.js @@ -36,7 +36,7 @@ var flipScale = require('../colorscale/helpers').flipScale; * used only if min/max fail. May be omitted if these are always * pre-calculated. */ -module.exports = function(gd, cd, moduleOpts) { +module.exports = function connectColorbar(gd, cd, moduleOpts) { if(typeof moduleOpts === 'function') return moduleOpts(gd, cd); var trace = cd[0].trace; diff --git a/src/components/colorbar/defaults.js b/src/components/colorbar/defaults.js index 58cbaf7d6e7..4ab08fbad48 100644 --- a/src/components/colorbar/defaults.js +++ b/src/components/colorbar/defaults.js @@ -18,7 +18,7 @@ var handleTickLabelDefaults = require('../../plots/cartesian/tick_label_defaults var attributes = require('./attributes'); -module.exports = function(containerIn, containerOut, layout) { +module.exports = function colorbarDefaults(containerIn, containerOut, layout) { var colorbarOut = Template.newContainer(containerOut, 'colorbar'); var colorbarIn = containerIn.colorbar || {}; diff --git a/src/components/colorbar/draw.js b/src/components/colorbar/draw.js index 3f2d2f82049..6354ab471dd 100644 --- a/src/components/colorbar/draw.js +++ b/src/components/colorbar/draw.js @@ -35,7 +35,7 @@ var axisLayoutAttrs = require('../../plots/cartesian/layout_attributes'); var attributes = require('./attributes'); var cn = require('./constants').cn; -module.exports = function(gd, id) { +module.exports = function draw(gd, id) { // opts: options object, containing everything from attributes // plus a few others that are the equivalent of the colorbar "data" var opts = {}; diff --git a/src/components/colorbar/has_colorbar.js b/src/components/colorbar/has_colorbar.js index c108e36aa1a..cf82de864e5 100644 --- a/src/components/colorbar/has_colorbar.js +++ b/src/components/colorbar/has_colorbar.js @@ -12,6 +12,6 @@ var Lib = require('../../lib'); -module.exports = function(container) { +module.exports = function hasColorbar(container) { return Lib.isPlainObject(container.colorbar); }; diff --git a/src/components/colorscale/attributes.js b/src/components/colorscale/attributes.js index dfac79b6407..014377c1c91 100644 --- a/src/components/colorscale/attributes.js +++ b/src/components/colorscale/attributes.js @@ -58,7 +58,7 @@ function code(s) { * * @return {object} */ -module.exports = function(context, opts) { +module.exports = function colorScaleAttrs(context, opts) { context = context || ''; opts = opts || {}; diff --git a/src/components/colorscale/calc.js b/src/components/colorscale/calc.js index e4a9b9c58d4..ed2491f9420 100644 --- a/src/components/colorscale/calc.js +++ b/src/components/colorscale/calc.js @@ -10,7 +10,7 @@ var Lib = require('../../lib'); -module.exports = function(gd, trace, opts) { +module.exports = function calc(gd, trace, opts) { var fullLayout = gd._fullLayout; var vals = opts.vals; var containerStr = opts.containerStr; diff --git a/src/components/colorscale/cross_trace_defaults.js b/src/components/colorscale/cross_trace_defaults.js index bbbdfe4b2bd..5933b669166 100644 --- a/src/components/colorscale/cross_trace_defaults.js +++ b/src/components/colorscale/cross_trace_defaults.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var hasColorscale = require('./helpers').hasColorscale; -module.exports = function(fullData) { +module.exports = function crossTraceDefaults(fullData) { function replace(cont, k) { var val = cont['_' + k]; if(val !== undefined) { diff --git a/src/components/colorscale/defaults.js b/src/components/colorscale/defaults.js index aa2ba9c89b1..75cd284b2be 100644 --- a/src/components/colorscale/defaults.js +++ b/src/components/colorscale/defaults.js @@ -23,7 +23,7 @@ function npMaybe(cont, prefix) { cont; } -module.exports = function(traceIn, traceOut, layout, coerce, opts) { +module.exports = function colorScaleDefaults(traceIn, traceOut, layout, coerce, opts) { var prefix = opts.prefix; var cLetter = opts.cLetter; var containerIn = npMaybe(traceIn, prefix); diff --git a/src/components/colorscale/layout_defaults.js b/src/components/colorscale/layout_defaults.js index d8c47573720..b05d56895c0 100644 --- a/src/components/colorscale/layout_defaults.js +++ b/src/components/colorscale/layout_defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var colorscaleAttrs = require('./layout_attributes'); var Template = require('../../plot_api/plot_template'); -module.exports = function(layoutIn, layoutOut) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) { var colorscaleIn = layoutIn.colorscale; var colorscaleOut = Template.newContainer(layoutOut, 'colorscale'); function coerce(attr, dflt) { diff --git a/src/components/dragelement/align.js b/src/components/dragelement/align.js index 7a9e27524ea..7b934a37a8b 100644 --- a/src/components/dragelement/align.js +++ b/src/components/dragelement/align.js @@ -14,7 +14,7 @@ // >2/3 means right, and between is center. Pick the right fraction // based on where you are, and return the fraction corresponding to // that position on the object -module.exports = function(v, dv, v0, v1, anchor) { +module.exports = function align(v, dv, v0, v1, anchor) { var vmin = (v - v0) / (v1 - v0); var vmax = vmin + dv / (v1 - v0); var vc = (vmin + vmax) / 2; diff --git a/src/components/dragelement/cursor.js b/src/components/dragelement/cursor.js index fd9d0f2361b..5a20761f05b 100644 --- a/src/components/dragelement/cursor.js +++ b/src/components/dragelement/cursor.js @@ -21,7 +21,7 @@ var cursorset = [ ['nw-resize', 'n-resize', 'ne-resize'] ]; -module.exports = function(x, y, xanchor, yanchor) { +module.exports = function getCursor(x, y, xanchor, yanchor) { if(xanchor === 'left') x = 0; else if(xanchor === 'center') x = 1; else if(xanchor === 'right') x = 2; diff --git a/src/components/dragelement/index.js b/src/components/dragelement/index.js index 43496420b00..477edbb99de 100644 --- a/src/components/dragelement/index.js +++ b/src/components/dragelement/index.js @@ -79,7 +79,7 @@ dragElement.unhoverRaw = unhover.raw; * By default, clamping is done using `minDrag` to x and y displacements * independently. */ -dragElement.init = function(options) { +dragElement.init = function init(options) { var gd = options.gd; var numClicks = 1; var DBLCLICKDELAY = interactConstants.DBLCLICKDELAY; diff --git a/src/components/dragelement/unhover.js b/src/components/dragelement/unhover.js index 94417b3dad4..34b51720032 100644 --- a/src/components/dragelement/unhover.js +++ b/src/components/dragelement/unhover.js @@ -32,7 +32,7 @@ unhover.wrapped = function(gd, evt, subplot) { // remove hover effects on mouse out, and emit unhover event -unhover.raw = function(gd, evt) { +unhover.raw = function unhoverRaw(gd, evt) { var fullLayout = gd._fullLayout; var oldhoverdata = gd._hoverdata; diff --git a/src/components/errorbars/calc.js b/src/components/errorbars/calc.js index 0b1c8823d2a..5d24a8ffb18 100644 --- a/src/components/errorbars/calc.js +++ b/src/components/errorbars/calc.js @@ -16,7 +16,7 @@ var Lib = require('../../lib'); var makeComputeError = require('./compute_error'); -module.exports = function(gd) { +module.exports = function calc(gd) { var calcdata = gd.calcdata; for(var i = 0; i < calcdata.length; i++) { diff --git a/src/components/errorbars/compute_error.js b/src/components/errorbars/compute_error.js index e5df34efc2d..ca03c65c45f 100644 --- a/src/components/errorbars/compute_error.js +++ b/src/components/errorbars/compute_error.js @@ -25,7 +25,7 @@ * - error[0] : error magnitude in the negative direction * - error[1] : " " " " positive " */ -module.exports = function(opts) { +module.exports = function makeComputeError(opts) { var type = opts.type; var symmetric = opts.symmetric; @@ -33,13 +33,13 @@ module.exports = function(opts) { var array = opts.array || []; if(symmetric) { - return function(dataPt, index) { + return function computeError(dataPt, index) { var val = +(array[index]); return [val, val]; }; } else { var arrayminus = opts.arrayminus || []; - return function(dataPt, index) { + return function computeError(dataPt, index) { var val = +array[index]; var valMinus = +arrayminus[index]; // in case one is present and the other is missing, fill in 0 @@ -56,12 +56,12 @@ module.exports = function(opts) { var computeErrorValueMinus = makeComputeErrorValue(type, opts.valueminus); if(symmetric || opts.valueminus === undefined) { - return function(dataPt) { + return function computeError(dataPt) { var val = computeErrorValue(dataPt); return [val, val]; }; } else { - return function(dataPt) { + return function computeError(dataPt) { return [ computeErrorValueMinus(dataPt), computeErrorValue(dataPt) diff --git a/src/components/errorbars/plot.js b/src/components/errorbars/plot.js index e25493c4f8e..5e86fea073f 100644 --- a/src/components/errorbars/plot.js +++ b/src/components/errorbars/plot.js @@ -15,7 +15,7 @@ var isNumeric = require('fast-isnumeric'); var Drawing = require('../drawing'); var subTypes = require('../../traces/scatter/subtypes'); -module.exports = function(gd, traces, plotinfo, transitionOpts) { +module.exports = function plot(gd, traces, plotinfo, transitionOpts) { var isNew; var xa = plotinfo.xaxis; diff --git a/src/components/errorbars/style.js b/src/components/errorbars/style.js index 24d8f7c8c38..f27ecb7c5f7 100644 --- a/src/components/errorbars/style.js +++ b/src/components/errorbars/style.js @@ -14,7 +14,7 @@ var d3 = require('d3'); var Color = require('../color'); -module.exports = function(traces) { +module.exports = function style(traces) { traces.each(function(d) { var trace = d[0].trace; var yObj = trace.error_y || {}; diff --git a/src/components/fx/calc.js b/src/components/fx/calc.js index 5c0ac7050d6..4d397764e4f 100644 --- a/src/components/fx/calc.js +++ b/src/components/fx/calc.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var Registry = require('../../registry'); -module.exports = function(gd) { +module.exports = function calc(gd) { var calcdata = gd.calcdata; var fullLayout = gd._fullLayout; diff --git a/src/components/fx/click.js b/src/components/fx/click.js index 6a174b9f0de..4f0955d1771 100644 --- a/src/components/fx/click.js +++ b/src/components/fx/click.js @@ -11,7 +11,7 @@ var Registry = require('../../registry'); var hover = require('./hover').hover; -module.exports = function(gd, evt, subplot) { +module.exports = function click(gd, evt, subplot) { var annotationsDone = Registry.getComponentMethod('annotations', 'onClick')(gd, gd._hoverdata); // fallback to fail-safe in case the plot type's hover method doesn't pass the subplot. diff --git a/src/components/fx/defaults.js b/src/components/fx/defaults.js index 2948d4443f7..3925371071f 100644 --- a/src/components/fx/defaults.js +++ b/src/components/fx/defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var attributes = require('./attributes'); var handleHoverLabelDefaults = require('./hoverlabel_defaults'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/components/fx/helpers.js b/src/components/fx/helpers.js index 020df4ea493..ef1db6bfc06 100644 --- a/src/components/fx/helpers.js +++ b/src/components/fx/helpers.js @@ -12,13 +12,13 @@ var Lib = require('../../lib'); // look for either subplot or xaxis and yaxis attributes // does not handle splom case -exports.getSubplot = function(trace) { +exports.getSubplot = function getSubplot(trace) { return trace.subplot || (trace.xaxis + trace.yaxis) || trace.geo; }; // is trace in given list of subplots? // does handle splom case -exports.isTraceInSubplots = function(trace, subplots) { +exports.isTraceInSubplots = function isTraceInSubplot(trace, subplots) { if(trace.type === 'splom') { var xaxes = trace.xaxes || []; var yaxes = trace.yaxes || []; @@ -36,7 +36,7 @@ exports.isTraceInSubplots = function(trace, subplots) { }; // convenience functions for mapping all relevant axes -exports.flat = function(subplots, v) { +exports.flat = function flat(subplots, v) { var out = new Array(subplots.length); for(var i = 0; i < subplots.length; i++) { out[i] = v; @@ -44,7 +44,7 @@ exports.flat = function(subplots, v) { return out; }; -exports.p2c = function(axArray, v) { +exports.p2c = function p2c(axArray, v) { var out = new Array(axArray.length); for(var i = 0; i < axArray.length; i++) { out[i] = axArray[i].p2c(v); @@ -52,12 +52,12 @@ exports.p2c = function(axArray, v) { return out; }; -exports.getDistanceFunction = function(mode, dx, dy, dxy) { +exports.getDistanceFunction = function getDistanceFunction(mode, dx, dy, dxy) { if(mode === 'closest') return dxy || exports.quadrature(dx, dy); return mode === 'x' ? dx : dy; }; -exports.getClosest = function(cd, distfn, pointData) { +exports.getClosest = function getClosest(cd, distfn, pointData) { // do we already have a point number? (array mode only) if(pointData.index !== false) { if(pointData.index >= 0 && pointData.index < cd.length) { @@ -87,11 +87,11 @@ exports.getClosest = function(cd, distfn, pointData) { * @param {number} v1: signed difference between the current position and the right edge * @param {number} passVal: the value to return on success */ -exports.inbox = function(v0, v1, passVal) { +exports.inbox = function inbox(v0, v1, passVal) { return (v0 * v1 < 0 || v0 === 0) ? passVal : Infinity; }; -exports.quadrature = function(dx, dy) { +exports.quadrature = function quadrature(dx, dy) { return function(di) { var x = dx(di); var y = dy(di); @@ -114,7 +114,7 @@ exports.quadrature = function(dx, dy) { * @param {object} cd * @return {object} */ -exports.makeEventData = function(pt, trace, cd) { +exports.makeEventData = function makeEventData(pt, trace, cd) { // hover uses 'index', select uses 'pointNumber' var pointNumber = 'index' in pt ? pt.index : pt.pointNumber; diff --git a/src/components/fx/hover.js b/src/components/fx/hover.js index 11491327ab5..e312690a176 100644 --- a/src/components/fx/hover.js +++ b/src/components/fx/hover.js @@ -66,7 +66,7 @@ var HOVERTEXTPAD = constants.HOVERTEXTPAD; // // We wrap the hovers in a timer, to limit their frequency. // The actual rendering is done by private function _hover. -exports.hover = function(gd, evt, subplot, noHoverEvent) { +exports.hover = function hover(gd, evt, subplot, noHoverEvent) { gd = Lib.getGraphDiv(gd); Lib.throttle( @@ -109,7 +109,7 @@ exports.hover = function(gd, evt, subplot, noHoverEvent) { the index of the hover item used as an anchor for positioning. The other hover items will be pushed up or down to prevent overlap. */ -exports.loneHover = function(hoverItems, opts) { +exports.loneHover = function loneHover(hoverItems, opts) { var multiHover = true; if(!Array.isArray(hoverItems)) { multiHover = false; diff --git a/src/components/fx/hoverlabel_defaults.js b/src/components/fx/hoverlabel_defaults.js index e32f26f21ae..cc6d868633b 100644 --- a/src/components/fx/hoverlabel_defaults.js +++ b/src/components/fx/hoverlabel_defaults.js @@ -10,7 +10,7 @@ var Lib = require('../../lib'); -module.exports = function(contIn, contOut, coerce, opts) { +module.exports = function handleHoverLabelDefaults(contIn, contOut, coerce, opts) { opts = opts || {}; coerce('hoverlabel.bgcolor', opts.bgcolor); diff --git a/src/components/fx/layout_defaults.js b/src/components/fx/layout_defaults.js index 2d3ac86d6f8..e0f04bc0f23 100644 --- a/src/components/fx/layout_defaults.js +++ b/src/components/fx/layout_defaults.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var layoutAttributes = require('./layout_attributes'); -module.exports = function(layoutIn, layoutOut, fullData) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { function coerce(attr, dflt) { return Lib.coerce(layoutIn, layoutOut, layoutAttributes, attr, dflt); } diff --git a/src/components/fx/layout_global_defaults.js b/src/components/fx/layout_global_defaults.js index f4a6b7617a8..93593e98143 100644 --- a/src/components/fx/layout_global_defaults.js +++ b/src/components/fx/layout_global_defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var handleHoverLabelDefaults = require('./hoverlabel_defaults'); var layoutAttributes = require('./layout_attributes'); -module.exports = function(layoutIn, layoutOut) { +module.exports = function supplyLayoutGlobalDefaults(layoutIn, layoutOut) { function coerce(attr, dflt) { return Lib.coerce(layoutIn, layoutOut, layoutAttributes, attr, dflt); } diff --git a/src/components/images/convert_coords.js b/src/components/images/convert_coords.js index aca26d4a5c5..b0be0ce819b 100644 --- a/src/components/images/convert_coords.js +++ b/src/components/images/convert_coords.js @@ -30,7 +30,7 @@ var toLogRange = require('../../lib/to_log_range'); * Use this to make the changes as it's aware if any other changes in the * same relayout call should override this conversion. */ -module.exports = function(gd, ax, newType, doExtra) { +module.exports = function convertCoords(gd, ax, newType, doExtra) { ax = ax || {}; var toLog = (newType === 'log') && (ax.type === 'linear'); diff --git a/src/components/images/defaults.js b/src/components/images/defaults.js index 605f1608301..09b84ed83a0 100644 --- a/src/components/images/defaults.js +++ b/src/components/images/defaults.js @@ -15,7 +15,7 @@ var handleArrayContainerDefaults = require('../../plots/array_container_defaults var attributes = require('./attributes'); var name = 'images'; -module.exports = function(layoutIn, layoutOut) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) { var opts = { name: name, handleItemDefaults: imageDefaults diff --git a/src/components/images/draw.js b/src/components/images/draw.js index 36138d6950d..3fe1080fc32 100644 --- a/src/components/images/draw.js +++ b/src/components/images/draw.js @@ -13,7 +13,7 @@ var Drawing = require('../drawing'); var Axes = require('../../plots/cartesian/axes'); var xmlnsNamespaces = require('../../constants/xmlns_namespaces'); -module.exports = function(gd) { +module.exports = function draw(gd) { var fullLayout = gd._fullLayout; var imageDataAbove = []; var imageDataSubplot = {}; diff --git a/src/components/legend/anchor_utils.js b/src/components/legend/anchor_utils.js index 56059c139fb..b1bf7e97044 100644 --- a/src/components/legend/anchor_utils.js +++ b/src/components/legend/anchor_utils.js @@ -18,28 +18,28 @@ * - values > 2/3 align the right at that fraction. */ -exports.isRightAnchor = function(opts) { +exports.isRightAnchor = function isRightAnchor(opts) { return ( opts.xanchor === 'right' || (opts.xanchor === 'auto' && opts.x >= 2 / 3) ); }; -exports.isCenterAnchor = function(opts) { +exports.isCenterAnchor = function isCenterAnchor(opts) { return ( opts.xanchor === 'center' || (opts.xanchor === 'auto' && opts.x > 1 / 3 && opts.x < 2 / 3) ); }; -exports.isBottomAnchor = function(opts) { +exports.isBottomAnchor = function isBottomAnchor(opts) { return ( opts.yanchor === 'bottom' || (opts.yanchor === 'auto' && opts.y <= 1 / 3) ); }; -exports.isMiddleAnchor = function(opts) { +exports.isMiddleAnchor = function isMiddleAnchor(opts) { return ( opts.yanchor === 'middle' || (opts.yanchor === 'auto' && opts.y > 1 / 3 && opts.y < 2 / 3) diff --git a/src/components/legend/defaults.js b/src/components/legend/defaults.js index b961f1633ab..c56da87077a 100644 --- a/src/components/legend/defaults.js +++ b/src/components/legend/defaults.js @@ -18,7 +18,7 @@ var basePlotLayoutAttributes = require('../../plots/layout_attributes'); var helpers = require('./helpers'); -module.exports = function(layoutIn, layoutOut, fullData) { +module.exports = function legendDefaults(layoutIn, layoutOut, fullData) { var containerIn = layoutIn.legend || {}; var legendTraceCount = 0; diff --git a/src/components/legend/draw.js b/src/components/legend/draw.js index 05077a80f24..1ded8cba129 100644 --- a/src/components/legend/draw.js +++ b/src/components/legend/draw.js @@ -33,7 +33,7 @@ var helpers = require('./helpers'); var DBLCLICKDELAY = interactConstants.DBLCLICKDELAY; -module.exports = function(gd) { +module.exports = function draw(gd) { var fullLayout = gd._fullLayout; var clipId = 'legend' + fullLayout._uid; diff --git a/src/components/legend/get_legend_data.js b/src/components/legend/get_legend_data.js index 1116c1d4399..2c2c7cd1190 100644 --- a/src/components/legend/get_legend_data.js +++ b/src/components/legend/get_legend_data.js @@ -13,7 +13,7 @@ var Registry = require('../../registry'); var helpers = require('./helpers'); -module.exports = function(calcdata, opts) { +module.exports = function getLegendData(calcdata, opts) { var lgroupToTraces = {}; var lgroups = []; var hasOneNonBlankGroup = false; diff --git a/src/components/legend/handle_click.js b/src/components/legend/handle_click.js index 1fa0cc43e64..45fefc951d7 100644 --- a/src/components/legend/handle_click.js +++ b/src/components/legend/handle_click.js @@ -13,7 +13,7 @@ var Registry = require('../../registry'); var SHOWISOLATETIP = true; -module.exports = function(g, gd, numClicks) { +module.exports = function handleClick(g, gd, numClicks) { if(gd._dragged || gd._editing) return; var hiddenSlices = gd._fullLayout.hiddenlabels ? diff --git a/src/components/legend/helpers.js b/src/components/legend/helpers.js index 326bd116e5c..d6d3b1a1554 100644 --- a/src/components/legend/helpers.js +++ b/src/components/legend/helpers.js @@ -9,14 +9,14 @@ 'use strict'; -exports.isGrouped = function(legendLayout) { +exports.isGrouped = function isGrouped(legendLayout) { return (legendLayout.traceorder || '').indexOf('grouped') !== -1; }; -exports.isVertical = function(legendLayout) { +exports.isVertical = function isVertical(legendLayout) { return legendLayout.orientation !== 'h'; }; -exports.isReversed = function(legendLayout) { +exports.isReversed = function isReversed(legendLayout) { return (legendLayout.traceorder || '').indexOf('reversed') !== -1; }; diff --git a/src/components/legend/style.js b/src/components/legend/style.js index 6a6843ae6ba..3b3c3c6c0f7 100644 --- a/src/components/legend/style.js +++ b/src/components/legend/style.js @@ -25,7 +25,7 @@ var CST_MARKER_LINE_WIDTH = 2; var MAX_LINE_WIDTH = 10; var MAX_MARKER_LINE_WIDTH = 5; -module.exports = function(s, gd) { +module.exports = function style(s, gd) { var fullLayout = gd._fullLayout; var legend = fullLayout.legend; var constantItemSizing = legend.itemsizing === 'constant'; diff --git a/src/components/modebar/manage.js b/src/components/modebar/manage.js index 728deb42aa0..7a22f8f40a9 100644 --- a/src/components/modebar/manage.js +++ b/src/components/modebar/manage.js @@ -24,7 +24,7 @@ var modeBarButtons = require('./buttons'); * @param {object} gd main plot object * */ -module.exports = function(gd) { +module.exports = function manageModeBar(gd) { var fullLayout = gd._fullLayout; var context = gd._context; var modeBar = fullLayout._modeBar; diff --git a/src/components/rangeselector/defaults.js b/src/components/rangeselector/defaults.js index df591ede6dd..17cc116c010 100644 --- a/src/components/rangeselector/defaults.js +++ b/src/components/rangeselector/defaults.js @@ -17,7 +17,7 @@ var attributes = require('./attributes'); var constants = require('./constants'); -module.exports = function(containerIn, containerOut, layout, counterAxes, calendar) { +module.exports = function handleDefaults(containerIn, containerOut, layout, counterAxes, calendar) { var selectorIn = containerIn.rangeselector || {}; var selectorOut = Template.newContainer(containerOut, 'rangeselector'); diff --git a/src/components/rangeselector/draw.js b/src/components/rangeselector/draw.js index 1e706186eb1..927e982516b 100644 --- a/src/components/rangeselector/draw.js +++ b/src/components/rangeselector/draw.js @@ -26,7 +26,7 @@ var FROM_BR = alignmentConstants.FROM_BR; var constants = require('./constants'); var getUpdateObject = require('./get_update_object'); -module.exports = function(gd) { +module.exports = function draw(gd) { var fullLayout = gd._fullLayout; var selectors = fullLayout._infolayer.selectAll('.rangeselector') diff --git a/src/components/rangeselector/get_update_object.js b/src/components/rangeselector/get_update_object.js index 9cf6cee393e..cbc7d4d7254 100644 --- a/src/components/rangeselector/get_update_object.js +++ b/src/components/rangeselector/get_update_object.js @@ -11,7 +11,7 @@ var d3 = require('d3'); -module.exports = function(axisLayout, buttonLayout) { +module.exports = function getUpdateObject(axisLayout, buttonLayout) { var axName = axisLayout._name; var update = {}; diff --git a/src/components/rangeslider/calc_autorange.js b/src/components/rangeslider/calc_autorange.js index 36825a66631..878917d3b19 100644 --- a/src/components/rangeslider/calc_autorange.js +++ b/src/components/rangeslider/calc_autorange.js @@ -12,7 +12,7 @@ var listAxes = require('../../plots/cartesian/axis_ids').list; var getAutoRange = require('../../plots/cartesian/autorange').getAutoRange; var constants = require('./constants'); -module.exports = function(gd) { +module.exports = function calcAutorange(gd) { var axes = listAxes(gd, 'x', true); // Compute new slider range using axis autorange if necessary. diff --git a/src/components/rangeslider/defaults.js b/src/components/rangeslider/defaults.js index 3f2e3b90f26..f70d732482d 100644 --- a/src/components/rangeslider/defaults.js +++ b/src/components/rangeslider/defaults.js @@ -15,7 +15,7 @@ var axisIds = require('../../plots/cartesian/axis_ids'); var attributes = require('./attributes'); var oppAxisAttrs = require('./oppaxis_attributes'); -module.exports = function(layoutIn, layoutOut, axName) { +module.exports = function handleDefaults(layoutIn, layoutOut, axName) { var axIn = layoutIn[axName]; var axOut = layoutOut[axName]; diff --git a/src/components/shapes/calc_autorange.js b/src/components/shapes/calc_autorange.js index 9f7c26342e8..fd38a2e6f31 100644 --- a/src/components/shapes/calc_autorange.js +++ b/src/components/shapes/calc_autorange.js @@ -15,7 +15,7 @@ var constants = require('./constants'); var helpers = require('./helpers'); -module.exports = function(gd) { +module.exports = function calcAutorange(gd) { var fullLayout = gd._fullLayout; var shapeList = Lib.filterVisible(fullLayout.shapes); diff --git a/src/components/shapes/defaults.js b/src/components/shapes/defaults.js index 11b6106988f..1d16342b4bc 100644 --- a/src/components/shapes/defaults.js +++ b/src/components/shapes/defaults.js @@ -17,7 +17,7 @@ var attributes = require('./attributes'); var helpers = require('./helpers'); -module.exports = function(layoutIn, layoutOut) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) { handleArrayContainerDefaults(layoutIn, layoutOut, { name: 'shapes', handleItemDefaults: handleShapeDefaults diff --git a/src/components/shapes/draw.js b/src/components/shapes/draw.js index 803eb348d96..556920c80a9 100644 --- a/src/components/shapes/draw.js +++ b/src/components/shapes/draw.js @@ -316,14 +316,14 @@ function setupDragElement(gd, shapePath, shapeOptions, index, shapeLayer) { if(xPixelSized) { modifyItem('xanchor', shapeOptions.xanchor = p2x(xAnchor + dx)); } else { - moveX = function(x) { return p2x(x2p(x) + dx); }; + moveX = function moveX(x) { return p2x(x2p(x) + dx); }; if(xa && xa.type === 'date') moveX = helpers.encodeDate(moveX); } if(yPixelSized) { modifyItem('yanchor', shapeOptions.yanchor = p2y(yAnchor + dy)); } else { - moveY = function(y) { return p2y(y2p(y) + dy); }; + moveY = function moveY(y) { return p2y(y2p(y) + dy); }; if(ya && ya.type === 'date') moveY = helpers.encodeDate(moveY); } @@ -358,14 +358,14 @@ function setupDragElement(gd, shapePath, shapeOptions, index, shapeLayer) { if(xPixelSized) { modifyItem('xanchor', shapeOptions.xanchor = p2x(xAnchor + dx)); } else { - moveX = function(x) { return p2x(x2p(x) + dx); }; + moveX = function moveX(x) { return p2x(x2p(x) + dx); }; if(xa && xa.type === 'date') moveX = helpers.encodeDate(moveX); } if(yPixelSized) { modifyItem('yanchor', shapeOptions.yanchor = p2y(yAnchor + dy)); } else { - moveY = function(y) { return p2y(y2p(y) + dy); }; + moveY = function moveY(y) { return p2y(y2p(y) + dy); }; if(ya && ya.type === 'date') moveY = helpers.encodeDate(moveY); } diff --git a/src/components/sliders/defaults.js b/src/components/sliders/defaults.js index 34484a2ce7c..099784bf0ae 100644 --- a/src/components/sliders/defaults.js +++ b/src/components/sliders/defaults.js @@ -18,7 +18,7 @@ var name = constants.name; var stepAttrs = attributes.steps; -module.exports = function(layoutIn, layoutOut) { +module.exports = function slidersDefaults(layoutIn, layoutOut) { handleArrayContainerDefaults(layoutIn, layoutOut, { name: name, handleItemDefaults: sliderDefaults diff --git a/src/components/sliders/draw.js b/src/components/sliders/draw.js index 69867a9c93b..f411ce7f909 100644 --- a/src/components/sliders/draw.js +++ b/src/components/sliders/draw.js @@ -23,7 +23,7 @@ var LINE_SPACING = alignmentConstants.LINE_SPACING; var FROM_TL = alignmentConstants.FROM_TL; var FROM_BR = alignmentConstants.FROM_BR; -module.exports = function(gd) { +module.exports = function draw(gd) { var fullLayout = gd._fullLayout; var sliderData = makeSliderData(fullLayout, gd); diff --git a/src/components/updatemenus/defaults.js b/src/components/updatemenus/defaults.js index de8cad08d54..492b9c911a9 100644 --- a/src/components/updatemenus/defaults.js +++ b/src/components/updatemenus/defaults.js @@ -18,7 +18,7 @@ var name = constants.name; var buttonAttrs = attributes.buttons; -module.exports = function(layoutIn, layoutOut) { +module.exports = function updateMenusDefaults(layoutIn, layoutOut) { var opts = { name: name, handleItemDefaults: menuDefaults diff --git a/src/components/updatemenus/draw.js b/src/components/updatemenus/draw.js index 79ff82ccbed..d5737704bf2 100644 --- a/src/components/updatemenus/draw.js +++ b/src/components/updatemenus/draw.js @@ -23,7 +23,7 @@ var LINE_SPACING = require('../../constants/alignment').LINE_SPACING; var constants = require('./constants'); var ScrollBox = require('./scrollbox'); -module.exports = function(gd) { +module.exports = function draw(gd) { var fullLayout = gd._fullLayout; var menuData = Lib.filterVisible(fullLayout[constants.name]); diff --git a/src/components/updatemenus/scrollbox.js b/src/components/updatemenus/scrollbox.js index 46c5b224b44..d43b2516608 100644 --- a/src/components/updatemenus/scrollbox.js +++ b/src/components/updatemenus/scrollbox.js @@ -78,7 +78,7 @@ ScrollBox.barColor = '#808BA4'; * @param {number} [translateX=0] Horizontal offset (in pixels) * @param {number} [translateY=0] Vertical offset (in pixels) */ -ScrollBox.prototype.enable = function(position, translateX, translateY) { +ScrollBox.prototype.enable = function enable(position, translateX, translateY) { var fullLayout = this.gd._fullLayout; var fullWidth = fullLayout.width; var fullHeight = fullLayout.height; @@ -312,7 +312,7 @@ ScrollBox.prototype.enable = function(position, translateX, translateY) { * * @method */ -ScrollBox.prototype.disable = function() { +ScrollBox.prototype.disable = function disable() { if(this.hbar || this.vbar) { this.bg.attr({ width: 0, @@ -347,7 +347,7 @@ ScrollBox.prototype.disable = function() { * * @method */ -ScrollBox.prototype._onBoxDrag = function() { +ScrollBox.prototype._onBoxDrag = function onBarDrag() { var translateX = this.translateX; var translateY = this.translateY; @@ -367,7 +367,7 @@ ScrollBox.prototype._onBoxDrag = function() { * * @method */ -ScrollBox.prototype._onBoxWheel = function() { +ScrollBox.prototype._onBoxWheel = function onBarWheel() { var translateX = this.translateX; var translateY = this.translateY; @@ -387,7 +387,7 @@ ScrollBox.prototype._onBoxWheel = function() { * * @method */ -ScrollBox.prototype._onBarDrag = function() { +ScrollBox.prototype._onBarDrag = function onBarDrag() { var translateX = this.translateX; var translateY = this.translateY; @@ -423,7 +423,7 @@ ScrollBox.prototype._onBarDrag = function() { * @param {number} [translateX=0] Horizontal offset (in pixels) * @param {number} [translateY=0] Vertical offset (in pixels) */ -ScrollBox.prototype.setTranslate = function(translateX, translateY) { +ScrollBox.prototype.setTranslate = function setTranslate(translateX, translateY) { // store translateX and translateY (needed by mouse event handlers) var translateXMax = this.position.w - this._box.w; var translateYMax = this.position.h - this._box.h; diff --git a/src/lib/anchor_utils.js b/src/lib/anchor_utils.js index 37d6f67b136..cc88136fb7c 100644 --- a/src/lib/anchor_utils.js +++ b/src/lib/anchor_utils.js @@ -19,42 +19,42 @@ */ -exports.isLeftAnchor = function(opts) { +exports.isLeftAnchor = function isLeftAnchor(opts) { return ( opts.xanchor === 'left' || (opts.xanchor === 'auto' && opts.x <= 1 / 3) ); }; -exports.isCenterAnchor = function(opts) { +exports.isCenterAnchor = function isCenterAnchor(opts) { return ( opts.xanchor === 'center' || (opts.xanchor === 'auto' && opts.x > 1 / 3 && opts.x < 2 / 3) ); }; -exports.isRightAnchor = function(opts) { +exports.isRightAnchor = function isRightAnchor(opts) { return ( opts.xanchor === 'right' || (opts.xanchor === 'auto' && opts.x >= 2 / 3) ); }; -exports.isTopAnchor = function(opts) { +exports.isTopAnchor = function isTopAnchor(opts) { return ( opts.yanchor === 'top' || (opts.yanchor === 'auto' && opts.y >= 2 / 3) ); }; -exports.isMiddleAnchor = function(opts) { +exports.isMiddleAnchor = function isMiddleAnchor(opts) { return ( opts.yanchor === 'middle' || (opts.yanchor === 'auto' && opts.y > 1 / 3 && opts.y < 2 / 3) ); }; -exports.isBottomAnchor = function(opts) { +exports.isBottomAnchor = function isBottomAnchor(opts) { return ( opts.yanchor === 'bottom' || (opts.yanchor === 'auto' && opts.y <= 1 / 3) diff --git a/src/lib/clean_number.js b/src/lib/clean_number.js index 9078b1cb668..845887a994c 100644 --- a/src/lib/clean_number.js +++ b/src/lib/clean_number.js @@ -20,7 +20,7 @@ var JUNK = /^['"%,$#\s']+|[, ]|['"%,$#\s']+$/g; * cleanNumber: remove common leading and trailing cruft * Always returns either a number or BADNUM. */ -module.exports = function(v) { +module.exports = function cleanNumber(v) { if(typeof v === 'string') { v = v.replace(JUNK, ''); } diff --git a/src/lib/clear_gl_canvases.js b/src/lib/clear_gl_canvases.js index a95c9577829..393592ed19a 100644 --- a/src/lib/clear_gl_canvases.js +++ b/src/lib/clear_gl_canvases.js @@ -15,7 +15,7 @@ * * @param {DOM node or object} gd : graph div object */ -module.exports = function(gd) { +module.exports = function clearGlCanvases(gd) { var fullLayout = gd._fullLayout; if(fullLayout._glcanvas && fullLayout._glcanvas.size()) { diff --git a/src/lib/clear_responsive.js b/src/lib/clear_responsive.js index 5f9f11da259..406aa1f3d0a 100644 --- a/src/lib/clear_responsive.js +++ b/src/lib/clear_responsive.js @@ -13,7 +13,7 @@ * * @param {DOM node or object} gd : graph div object */ -module.exports = function(gd) { +module.exports = function clearResponsive(gd) { if(gd._responsiveChartHandler) { window.removeEventListener('resize', gd._responsiveChartHandler); delete gd._responsiveChartHandler; diff --git a/src/lib/filter_unique.js b/src/lib/filter_unique.js index a36b0913fbf..9be686f12fe 100644 --- a/src/lib/filter_unique.js +++ b/src/lib/filter_unique.js @@ -31,7 +31,7 @@ * @param {array} array base array * @return {array} new filtered array */ -module.exports = function(array) { +module.exports = function filterUnique(array) { var seen = {}; var out = []; var j = 0; diff --git a/src/lib/filter_visible.js b/src/lib/filter_visible.js index e6005b66f9f..39088029478 100644 --- a/src/lib/filter_visible.js +++ b/src/lib/filter_visible.js @@ -15,7 +15,7 @@ * @return {array of objects} of length <= container * */ -module.exports = function(container) { +module.exports = function filterVisible(container) { var filterFn = isCalcData(container) ? calcDataFilter : baseFilter; var out = []; diff --git a/src/lib/geometry2d.js b/src/lib/geometry2d.js index 28fc47797f6..2bb298f626b 100644 --- a/src/lib/geometry2d.js +++ b/src/lib/geometry2d.js @@ -37,7 +37,7 @@ function segmentsIntersect(x1, y1, x2, y2, x3, y3, x4, y4) { /* * find the minimum distance between two line segments (1->2 and 3->4) */ -exports.segmentDistance = function(x1, y1, x2, y2, x3, y3, x4, y4) { +exports.segmentDistance = function segmentDistance(x1, y1, x2, y2, x3, y3, x4, y4) { if(segmentsIntersect(x1, y1, x2, y2, x3, y3, x4, y4)) return 0; // the two segments and their lengths squared @@ -88,7 +88,7 @@ function perpDistance2(xab, yab, llab, xac, yac) { var locationCache, workingPath, workingTextWidth; // turn a path and position along it into x, y, and angle for the given text -exports.getTextLocation = function(path, totalPathLen, positionOnPath, textWidth) { +exports.getTextLocation = function getTextLocation(path, totalPathLen, positionOnPath, textWidth) { if(path !== workingPath || textWidth !== workingTextWidth) { locationCache = {}; workingPath = path; @@ -143,7 +143,7 @@ exports.clearLocationCache = function() { * the path). Note that if a path enters, exits, and re-enters the plot, we * will not capture this behavior. */ -exports.getVisibleSegment = function(path, bounds, buffer) { +exports.getVisibleSegment = function getVisibleSegment(path, bounds, buffer) { var left = bounds.left; var right = bounds.right; var top = bounds.top; @@ -204,7 +204,7 @@ exports.getVisibleSegment = function(path, bounds, buffer) { * - {Number} iterationLimit * @return {SVGPoint} */ -exports.findPointOnPath = function(path, val, coord, opts) { +exports.findPointOnPath = function findPointOnPath(path, val, coord, opts) { opts = opts || {}; var pathLength = opts.pathLength || path.getTotalLength(); diff --git a/src/lib/identity.js b/src/lib/identity.js index 61ab6d60048..804fc5b30e8 100644 --- a/src/lib/identity.js +++ b/src/lib/identity.js @@ -11,4 +11,4 @@ // Simple helper functions // none of these need any external deps -module.exports = function(d) { return d; }; +module.exports = function identity(d) { return d; }; diff --git a/src/lib/index.js b/src/lib/index.js index d5010435528..772ff06f34b 100644 --- a/src/lib/index.js +++ b/src/lib/index.js @@ -153,7 +153,7 @@ lib.pushUnique = require('./push_unique'); lib.cleanNumber = require('./clean_number'); -lib.ensureNumber = function(v) { +lib.ensureNumber = function num(v) { if(!isNumeric(v)) return BADNUM; v = Number(v); if(v < -FP_SAFE || v > FP_SAFE) return BADNUM; @@ -212,7 +212,7 @@ lib.swapAttrs = function(cont, attrList, part1, part2) { /** * SVG painter's algo worked around with reinsertion */ -lib.raiseToTop = function(elem) { +lib.raiseToTop = function raiseToTop(elem) { elem.parentNode.appendChild(elem); }; @@ -268,7 +268,7 @@ lib.simpleMap = function(array, func, x1, x2) { * @param {int} base * base of string representation, default 16. Should be a power of 2. */ -lib.randstr = function(existing, bits, base, _recursion) { +lib.randstr = function randstr(existing, bits, base, _recursion) { if(!base) base = 16; if(bits === undefined) bits = 24; if(bits <= 0) return '0'; @@ -301,7 +301,7 @@ lib.randstr = function(existing, bits, base, _recursion) { lib.warn('randstr failed uniqueness'); return res; } - return lib.randstr(existing, bits, base, (_recursion || 0) + 1); + return randstr(existing, bits, base, (_recursion || 0) + 1); } else return res; }; diff --git a/src/lib/is_plain_object.js b/src/lib/is_plain_object.js index 69836d69741..8f33cb6d2be 100644 --- a/src/lib/is_plain_object.js +++ b/src/lib/is_plain_object.js @@ -10,7 +10,7 @@ 'use strict'; // more info: http://stackoverflow.com/questions/18531624/isplainobject-thing -module.exports = function(obj) { +module.exports = function isPlainObject(obj) { // We need to be a little less strict in the `imagetest` container because // of how async image requests are handled. // diff --git a/src/lib/keyed_container.js b/src/lib/keyed_container.js index dacc58934b7..ea46310a17f 100644 --- a/src/lib/keyed_container.js +++ b/src/lib/keyed_container.js @@ -30,7 +30,7 @@ var VALUE = 2; var BOTH = 3; var UNSET = 4; -module.exports = function(baseObj, path, keyName, valueName) { +module.exports = function keyedContainer(baseObj, path, keyName, valueName) { keyName = keyName || 'name'; valueName = valueName || 'value'; var i, arr, baseProp; diff --git a/src/lib/localize.js b/src/lib/localize.js index 05c9f910ca3..545dbff7a97 100644 --- a/src/lib/localize.js +++ b/src/lib/localize.js @@ -20,7 +20,7 @@ var Registry = require('../registry'); * gd._context.locales or globally via Plotly.register * @param {string} s: the string to translate */ -module.exports = function(gd, s) { +module.exports = function localize(gd, s) { var locale = gd._context.locale; /* diff --git a/src/lib/make_trace_groups.js b/src/lib/make_trace_groups.js index 7a6868c8788..ddc542fbe7b 100644 --- a/src/lib/make_trace_groups.js +++ b/src/lib/make_trace_groups.js @@ -20,7 +20,7 @@ * @param {string} cls: the class attribute to give each trace group * so you can give multiple classes separated by spaces */ -module.exports = function(traceLayer, cdModule, cls) { +module.exports = function makeTraceGroups(traceLayer, cdModule, cls) { var traces = traceLayer.selectAll('g.' + cls.replace(/\s/g, '.')) .data(cdModule, function(cd) { return cd[0].trace.uid; }); diff --git a/src/lib/nested_property.js b/src/lib/nested_property.js index aae94fd2fe7..e02cd923de3 100644 --- a/src/lib/nested_property.js +++ b/src/lib/nested_property.js @@ -26,7 +26,7 @@ var isArrayOrTypedArray = require('./array').isArrayOrTypedArray; * you can't do nestedProperty(obj, 'arr[-1]').set(5) * but you can do nestedProperty(obj, 'arr').set([5, 5, 5]) */ -module.exports = function(container, propStr) { +module.exports = function nestedProperty(container, propStr) { if(isNumeric(propStr)) propStr = String(propStr); else if(typeof propStr !== 'string' || propStr.substr(propStr.length - 4) === '[-1]') { diff --git a/src/lib/noop.js b/src/lib/noop.js index 5a33031c0c8..e5e5e66a434 100644 --- a/src/lib/noop.js +++ b/src/lib/noop.js @@ -11,4 +11,4 @@ // Simple helper functions // none of these need any external deps -module.exports = function() {}; +module.exports = function noop() {}; diff --git a/src/lib/override_cursor.js b/src/lib/override_cursor.js index bce10d18cd9..29933459614 100644 --- a/src/lib/override_cursor.js +++ b/src/lib/override_cursor.js @@ -20,7 +20,7 @@ var NO_CURSOR = '!!'; * by moving the name of the original cursor to the data-savedcursor attr. * omit cursor to revert to the previously set value. */ -module.exports = function(el3, csr) { +module.exports = function overrideCursor(el3, csr) { var savedCursor = el3.attr(STASHATTR); if(csr) { if(!savedCursor) { diff --git a/src/lib/polygon.js b/src/lib/polygon.js index 15584c7a255..ee28750d2fe 100644 --- a/src/lib/polygon.js +++ b/src/lib/polygon.js @@ -30,7 +30,7 @@ var polygon = module.exports = {}; * don't double-count the edge where they meet. * returns boolean: is pt inside the polygon (including on its edges) */ -polygon.tester = function(ptsIn) { +polygon.tester = function tester(ptsIn) { var pts = ptsIn.slice(); var xmin = pts[0][0]; var xmax = xmin; @@ -181,7 +181,7 @@ polygon.tester = function(ptsIn) { * before the line counts as bent * @returns boolean: true means this segment is bent, false means straight */ -var isBent = polygon.isSegmentBent = function(pts, start, end, tolerance) { +var isBent = polygon.isSegmentBent = function isBent(pts, start, end, tolerance) { var startPt = pts[start]; var segment = [pts[end][0] - startPt[0], pts[end][1] - startPt[1]]; var segmentSquared = dot(segment, segment); @@ -214,7 +214,7 @@ var isBent = polygon.isSegmentBent = function(pts, start, end, tolerance) { * raw is all the input points * filtered is the resulting filtered Array of [x, y] pairs */ -polygon.filter = function(pts, tolerance) { +polygon.filter = function filter(pts, tolerance) { var ptsFiltered = [pts[0]]; var doneRawIndex = 0; var doneFilteredIndex = 0; diff --git a/src/lib/prepare_regl.js b/src/lib/prepare_regl.js index aedceeb52ed..f16c33e33ee 100644 --- a/src/lib/prepare_regl.js +++ b/src/lib/prepare_regl.js @@ -26,7 +26,7 @@ var createRegl = require('regl'); * * @return {boolean} true if all createRegl calls succeeded, false otherwise */ -module.exports = function(gd, extensions) { +module.exports = function prepareRegl(gd, extensions) { var fullLayout = gd._fullLayout; var success = true; diff --git a/src/lib/push_unique.js b/src/lib/push_unique.js index 76fd78c2ee3..64bcbaeab0c 100644 --- a/src/lib/push_unique.js +++ b/src/lib/push_unique.js @@ -21,7 +21,7 @@ * ref to array (now possibly containing one more item) * */ -module.exports = function(array, item) { +module.exports = function pushUnique(array, item) { if(item instanceof RegExp) { var itemStr = item.toString(); for(var i = 0; i < array.length; i++) { diff --git a/src/lib/queue.js b/src/lib/queue.js index 54b7fc3e217..f86a1c10b93 100644 --- a/src/lib/queue.js +++ b/src/lib/queue.js @@ -123,7 +123,7 @@ queue.stopSequence = function(gd) { * * @param gd */ -queue.undo = function(gd) { +queue.undo = function undo(gd) { var queueObj, i; if(gd.framework && gd.framework.isPolar) { @@ -156,7 +156,7 @@ queue.undo = function(gd) { * * @param gd */ -queue.redo = function(gd) { +queue.redo = function redo(gd) { var queueObj, i; if(gd.framework && gd.framework.isPolar) { diff --git a/src/lib/relink_private.js b/src/lib/relink_private.js index 5ad8930f03c..22981cb094f 100644 --- a/src/lib/relink_private.js +++ b/src/lib/relink_private.js @@ -19,7 +19,7 @@ var isPlainObject = require('./is_plain_object'); * if object is pass-by-ref. * This prevents deepCopying massive structures like a webgl context. */ -function relinkPrivateKeys(toContainer, fromContainer) { +module.exports = function relinkPrivateKeys(toContainer, fromContainer) { for(var k in fromContainer) { var fromVal = fromContainer[k]; var toVal = toContainer[k]; @@ -53,6 +53,4 @@ function relinkPrivateKeys(toContainer, fromContainer) { if(!Object.keys(toVal).length) delete toContainer[k]; } } -} - -module.exports = relinkPrivateKeys; +}; diff --git a/src/lib/setcursor.js b/src/lib/setcursor.js index 7c5167eb0f7..7404b660fc8 100644 --- a/src/lib/setcursor.js +++ b/src/lib/setcursor.js @@ -12,7 +12,7 @@ // works with our CSS cursor classes (see css/_cursor.scss) // to apply cursors to d3 single-element selections. // omit cursor to revert to the default. -module.exports = function(el3, csr) { +module.exports = function setCursor(el3, csr) { (el3.attr('class') || '').split(' ').forEach(function(cls) { if(cls.indexOf('cursor-') === 0) el3.classed(cls, false); }); diff --git a/src/lib/show_no_webgl_msg.js b/src/lib/show_no_webgl_msg.js index 52af96d166d..645f56d6b7e 100644 --- a/src/lib/show_no_webgl_msg.js +++ b/src/lib/show_no_webgl_msg.js @@ -21,7 +21,7 @@ var noop = function() {}; * Expects 'scene' to have property 'container' * */ -module.exports = function(scene) { +module.exports = function showNoWebGlMsg(scene) { for(var prop in scene) { if(typeof scene[prop] === 'function') scene[prop] = noop; } diff --git a/src/lib/svg_text_utils.js b/src/lib/svg_text_utils.js index d60bbcab207..37d8de07458 100644 --- a/src/lib/svg_text_utils.js +++ b/src/lib/svg_text_utils.js @@ -624,11 +624,11 @@ function buildSVGText(containerNode, str) { return hasLink; } -exports.lineCount = function(s) { +exports.lineCount = function lineCount(s) { return s.selectAll('tspan.line').size() || 1; }; -exports.positionText = function(s, x, y) { +exports.positionText = function positionText(s, x, y) { return s.each(function() { var text = d3.select(this); diff --git a/src/lib/throttle.js b/src/lib/throttle.js index a59553608f7..1603d3b0812 100644 --- a/src/lib/throttle.js +++ b/src/lib/throttle.js @@ -24,7 +24,7 @@ var timerCache = {}; * @param {function} callback: the function to throttle. `callback` itself * should be a purely synchronous function. */ -exports.throttle = function(id, minInterval, callback) { +exports.throttle = function throttle(id, minInterval, callback) { var cache = timerCache[id]; var now = Date.now(); @@ -70,7 +70,7 @@ exports.done = function(id) { return new Promise(function(resolve) { var previousOnDone = cache.onDone; - cache.onDone = function() { + cache.onDone = function onDone() { if(previousOnDone) previousOnDone(); resolve(); cache.onDone = null; diff --git a/src/lib/to_log_range.js b/src/lib/to_log_range.js index debbdfe1dd1..e130579ecbe 100644 --- a/src/lib/to_log_range.js +++ b/src/lib/to_log_range.js @@ -14,7 +14,7 @@ var isNumeric = require('fast-isnumeric'); * convert a linear value into a logged value, folding negative numbers into * the given range */ -module.exports = function(val, range) { +module.exports = function toLogRange(val, range) { if(val > 0) return Math.log(val) / Math.LN10; // move a negative value reference to a log axis - just put the diff --git a/src/plot_api/container_array_match.js b/src/plot_api/container_array_match.js index e09ba5c5e85..45e6192d01c 100644 --- a/src/plot_api/container_array_match.js +++ b/src/plot_api/container_array_match.js @@ -24,7 +24,7 @@ var Registry = require('../registry'); * if the whole array) and the property within that (or '' if the whole array * or the whole object) */ -module.exports = function(astr) { +module.exports = function containerArrayMatch(astr) { var rootContainers = Registry.layoutArrayContainers; var regexpContainers = Registry.layoutArrayRegexes; var rootPart = astr.split('[')[0]; diff --git a/src/plot_api/manage_arrays.js b/src/plot_api/manage_arrays.js index 93f5e3eea53..3bea13ca6a7 100644 --- a/src/plot_api/manage_arrays.js +++ b/src/plot_api/manage_arrays.js @@ -18,11 +18,11 @@ var Registry = require('../registry'); exports.containerArrayMatch = require('./container_array_match'); -var isAddVal = exports.isAddVal = function(val) { +var isAddVal = exports.isAddVal = function isAddVal(val) { return val === 'add' || isPlainObject(val); }; -var isRemoveVal = exports.isRemoveVal = function(val) { +var isRemoveVal = exports.isRemoveVal = function isRemoveVal(val) { return val === null || val === 'remove'; }; @@ -73,7 +73,7 @@ var isRemoveVal = exports.isRemoveVal = function(val) { * @returns {bool} `true` if it managed to complete drawing of the changes * `false` would mean the parent should replot. */ -exports.applyContainerArrayChanges = function(gd, np, edits, flags, _nestedProperty) { +exports.applyContainerArrayChanges = function applyContainerArrayChanges(gd, np, edits, flags, _nestedProperty) { var componentType = np.astr; var supplyComponentDefaults = Registry.getComponentMethod(componentType, 'supplyLayoutDefaults'); var draw = Registry.getComponentMethod(componentType, 'draw'); diff --git a/src/plot_api/plot_api.js b/src/plot_api/plot_api.js index f77c82731df..ad064ee5d7b 100644 --- a/src/plot_api/plot_api.js +++ b/src/plot_api/plot_api.js @@ -403,7 +403,7 @@ function emitAfterPlot(gd) { } } -exports.setPlotConfig = function(obj) { +exports.setPlotConfig = function setPlotConfig(obj) { return Lib.extendFlat(dfltConfig, obj); }; @@ -2433,7 +2433,7 @@ exports.update = update; * Plotly.react data updates, dependent on uirevision attributes */ function guiEdit(func) { - return function(gd) { + return function wrappedEdit(gd) { gd._fullLayout._guiEditing = true; var p = func.apply(null, arguments); gd._fullLayout._guiEditing = false; @@ -3670,7 +3670,7 @@ exports.deleteFrames = function(gd, frameList) { * @param {string id or DOM element} gd * the id or DOM element of the graph container div */ -exports.purge = function(gd) { +exports.purge = function purge(gd) { gd = Lib.getGraphDiv(gd); var fullLayout = gd._fullLayout || {}; diff --git a/src/plot_api/validate.js b/src/plot_api/validate.js index 43432ee414d..9b3164941d4 100644 --- a/src/plot_api/validate.js +++ b/src/plot_api/validate.js @@ -38,7 +38,7 @@ var isArrayOrTypedArray = Lib.isArrayOrTypedArray; * - {string} msg * error message (shown in console in logger config argument is enable) */ -module.exports = function(data, layout) { +module.exports = function validate(data, layout) { var schema = PlotSchema.get(); var errorList = []; var gd = {_context: Lib.extendFlat({}, dfltConfig)}; diff --git a/src/plots/array_container_defaults.js b/src/plots/array_container_defaults.js index 29f72862207..89581e2045f 100644 --- a/src/plots/array_container_defaults.js +++ b/src/plots/array_container_defaults.js @@ -42,7 +42,7 @@ var Template = require('../plot_api/plot_template'); * links to supplementary data (e.g. fullData for layout components) * */ -module.exports = function(parentObjIn, parentObjOut, opts) { +module.exports = function handleArrayContainerDefaults(parentObjIn, parentObjOut, opts) { var name = opts.name; var inclusionAttr = opts.inclusionAttr || 'visible'; diff --git a/src/plots/cartesian/autorange.js b/src/plots/cartesian/autorange.js index 05be6ec59a9..2b8a176d747 100644 --- a/src/plots/cartesian/autorange.js +++ b/src/plots/cartesian/autorange.js @@ -197,7 +197,7 @@ function makePadFn(ax) { (ax.domain[1] - ax.domain[0]); } - return function(pt) { return pt.pad + (pt.extrapad ? extrappad : 0); }; + return function getPad(pt) { return pt.pad + (pt.extrapad ? extrappad : 0); }; } function concatExtremes(gd, ax) { diff --git a/src/plots/cartesian/axes.js b/src/plots/cartesian/axes.js index bc41780719d..e56537802dc 100644 --- a/src/plots/cartesian/axes.js +++ b/src/plots/cartesian/axes.js @@ -550,7 +550,7 @@ axes.prepTicks = function(ax) { // if ticks are set to automatic, determine the right values (tick0,dtick) // in any case, set tickround to # of digits to round tick labels to, // or codes to this effect for log and date scales -axes.calcTicks = function(ax) { +axes.calcTicks = function calcTicks(ax) { axes.prepTicks(ax); var rng = Lib.simpleMap(ax.range, ax.r2l); diff --git a/src/plots/cartesian/axis_autotype.js b/src/plots/cartesian/axis_autotype.js index e5f5c47ad07..eb4c2941d72 100644 --- a/src/plots/cartesian/axis_autotype.js +++ b/src/plots/cartesian/axis_autotype.js @@ -14,7 +14,7 @@ var isNumeric = require('fast-isnumeric'); var Lib = require('../../lib'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function(array, calendar, opts) { +module.exports = function autoType(array, calendar, opts) { opts = opts || {}; if(!opts.noMultiCategory && multiCategory(array)) return 'multicategory'; diff --git a/src/plots/cartesian/axis_defaults.js b/src/plots/cartesian/axis_defaults.js index 178cf6ac32d..2269152de39 100644 --- a/src/plots/cartesian/axis_defaults.js +++ b/src/plots/cartesian/axis_defaults.js @@ -32,7 +32,7 @@ var setConvert = require('./set_convert'); * data: the plot data, used to manage categories * bgColor: the plot background color, to calculate default gridline colors */ -module.exports = function(containerIn, containerOut, coerce, options, layoutOut) { +module.exports = function handleAxisDefaults(containerIn, containerOut, coerce, options, layoutOut) { var letter = options.letter; var font = options.font || {}; var splomStash = options.splomStash || {}; diff --git a/src/plots/cartesian/axis_ids.js b/src/plots/cartesian/axis_ids.js index 29f54cdd83a..940dc9c2530 100644 --- a/src/plots/cartesian/axis_ids.js +++ b/src/plots/cartesian/axis_ids.js @@ -16,21 +16,21 @@ var constants = require('./constants'); // convert between axis names (xaxis, xaxis2, etc, elements of gd.layout) // and axis id's (x, x2, etc). Would probably have ditched 'xaxis' // completely in favor of just 'x' if it weren't ingrained in the API etc. -exports.id2name = function(id) { +exports.id2name = function id2name(id) { if(typeof id !== 'string' || !id.match(constants.AX_ID_PATTERN)) return; var axNum = id.substr(1); if(axNum === '1') axNum = ''; return id.charAt(0) + 'axis' + axNum; }; -exports.name2id = function(name) { +exports.name2id = function name2id(name) { if(!name.match(constants.AX_NAME_PATTERN)) return; var axNum = name.substr(5); if(axNum === '1') axNum = ''; return name.charAt(0) + axNum; }; -exports.cleanId = function(id, axLetter) { +exports.cleanId = function cleanId(id, axLetter) { if(!id.match(constants.AX_ID_PATTERN)) return; if(axLetter && id.charAt(0) !== axLetter) return; @@ -114,7 +114,7 @@ exports.idSort = function(id1, id2) { return +(id1.substr(1) || 1) - +(id2.substr(1) || 1); }; -exports.getAxisGroup = function(fullLayout, axId) { +exports.getAxisGroup = function getAxisGroup(fullLayout, axId) { var matchGroups = fullLayout._axisMatchGroups; for(var i = 0; i < matchGroups.length; i++) { diff --git a/src/plots/cartesian/category_order_defaults.js b/src/plots/cartesian/category_order_defaults.js index e3680cbe2da..9980ff0620f 100644 --- a/src/plots/cartesian/category_order_defaults.js +++ b/src/plots/cartesian/category_order_defaults.js @@ -53,7 +53,7 @@ function findCategories(ax, opts) { * - axData {array} : (full) data associated with axis being coerced here * - dataAttr {string} : attribute name corresponding to coordinate array */ -module.exports = function(containerIn, containerOut, coerce, opts) { +module.exports = function handleCategoryOrderDefaults(containerIn, containerOut, coerce, opts) { if(containerOut.type !== 'category') return; var arrayIn = containerIn.categoryarray; diff --git a/src/plots/cartesian/constraints.js b/src/plots/cartesian/constraints.js index 9f8e55f0c5b..a6d31d3dd8f 100644 --- a/src/plots/cartesian/constraints.js +++ b/src/plots/cartesian/constraints.js @@ -188,7 +188,7 @@ function updateConstraintGroups(constraintGroups, thisGroup, thisID, scaleanchor thisGroup[scaleanchor] = 1; } -exports.enforce = function(gd) { +exports.enforce = function enforceAxisConstraints(gd) { var fullLayout = gd._fullLayout; var constraintGroups = fullLayout._axisConstraintGroups || []; @@ -346,7 +346,7 @@ exports.enforce = function(gd) { // For use before autoranging, check if this axis was previously constrained // by domain but no longer is -exports.clean = function(gd, ax) { +exports.clean = function cleanConstraints(gd, ax) { if(ax._inputDomain) { var isConstrained = false; var axId = ax._id; diff --git a/src/plots/cartesian/graph_interact.js b/src/plots/cartesian/graph_interact.js index 030b14801c3..716fc1b120d 100644 --- a/src/plots/cartesian/graph_interact.js +++ b/src/plots/cartesian/graph_interact.js @@ -18,7 +18,7 @@ var setCursor = require('../../lib/setcursor'); var makeDragBox = require('./dragbox').makeDragBox; var DRAGGERSIZE = require('./constants').DRAGGERSIZE; -exports.initInteractions = function(gd) { +exports.initInteractions = function initInteractions(gd) { var fullLayout = gd._fullLayout; if(gd._context.staticPlot) { diff --git a/src/plots/cartesian/include_components.js b/src/plots/cartesian/include_components.js index 157666708e0..11f0b146782 100644 --- a/src/plots/cartesian/include_components.js +++ b/src/plots/cartesian/include_components.js @@ -23,8 +23,8 @@ var Lib = require('../../lib'); * @return {function}: with args layoutIn (gd.layout) and layoutOut (gd._fullLayout) * as expected of a component includeBasePlot method */ -module.exports = function(containerArrayName) { - return function(layoutIn, layoutOut) { +module.exports = function makeIncludeComponents(containerArrayName) { + return function includeComponents(layoutIn, layoutOut) { var array = layoutIn[containerArrayName]; if(!Array.isArray(array)) return; diff --git a/src/plots/cartesian/layout_defaults.js b/src/plots/cartesian/layout_defaults.js index a0ea93ada85..8a6f6235b10 100644 --- a/src/plots/cartesian/layout_defaults.js +++ b/src/plots/cartesian/layout_defaults.js @@ -33,7 +33,7 @@ function appendList(cont, k, item) { else cont[k] = [item]; } -module.exports = function(layoutIn, layoutOut, fullData) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { var ax2traces = {}; var xaCheater = {}; var xaNonCheater = {}; diff --git a/src/plots/cartesian/line_grid_defaults.js b/src/plots/cartesian/line_grid_defaults.js index 0ec1e49306f..1a107efa881 100644 --- a/src/plots/cartesian/line_grid_defaults.js +++ b/src/plots/cartesian/line_grid_defaults.js @@ -22,7 +22,7 @@ var Lib = require('../../lib'); * - noZeroLine {boolean} : don't coerce zeroline* attributes * - attributes {object} : attribute object associated with input containers */ -module.exports = function(containerIn, containerOut, coerce, opts) { +module.exports = function handleLineGridDefaults(containerIn, containerOut, coerce, opts) { opts = opts || {}; var dfltColor = opts.dfltColor; diff --git a/src/plots/cartesian/position_defaults.js b/src/plots/cartesian/position_defaults.js index 7768073178a..41a4ed24ec3 100644 --- a/src/plots/cartesian/position_defaults.js +++ b/src/plots/cartesian/position_defaults.js @@ -14,7 +14,7 @@ var isNumeric = require('fast-isnumeric'); var Lib = require('../../lib'); -module.exports = function(containerIn, containerOut, coerce, options) { +module.exports = function handlePositionDefaults(containerIn, containerOut, coerce, options) { var counterAxes = options.counterAxes || []; var overlayableAxes = options.overlayableAxes || []; var letter = options.letter; diff --git a/src/plots/cartesian/scale_zoom.js b/src/plots/cartesian/scale_zoom.js index 0c3309cfec3..cc74c3be0f1 100644 --- a/src/plots/cartesian/scale_zoom.js +++ b/src/plots/cartesian/scale_zoom.js @@ -11,7 +11,7 @@ var FROM_BL = require('../../constants/alignment').FROM_BL; -module.exports = function(ax, factor, centerFraction) { +module.exports = function scaleZoom(ax, factor, centerFraction) { if(centerFraction === undefined) { centerFraction = FROM_BL[ax.constraintoward || 'center']; } diff --git a/src/plots/cartesian/set_convert.js b/src/plots/cartesian/set_convert.js index 214e5296f0a..55bb4bdcb98 100644 --- a/src/plots/cartesian/set_convert.js +++ b/src/plots/cartesian/set_convert.js @@ -59,7 +59,7 @@ function isValidCategory(v) { * * also clears the autotick constraints ._minDtick, ._forceTick0 */ -module.exports = function(ax, fullLayout) { +module.exports = function setConvert(ax, fullLayout) { fullLayout = fullLayout || {}; var axId = (ax._id || 'x'); diff --git a/src/plots/cartesian/tick_label_defaults.js b/src/plots/cartesian/tick_label_defaults.js index b31621a8b70..5bbe72765fc 100644 --- a/src/plots/cartesian/tick_label_defaults.js +++ b/src/plots/cartesian/tick_label_defaults.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var layoutAttributes = require('./layout_attributes'); var handleArrayContainerDefaults = require('../array_container_defaults'); -module.exports = function(containerIn, containerOut, coerce, axType, options) { +module.exports = function handleTickLabelDefaults(containerIn, containerOut, coerce, axType, options) { var showAttrDflt = getShowAttrDflt(containerIn); var tickPrefix = coerce('tickprefix'); diff --git a/src/plots/cartesian/tick_mark_defaults.js b/src/plots/cartesian/tick_mark_defaults.js index fb44d6d0880..8667c708cd7 100644 --- a/src/plots/cartesian/tick_mark_defaults.js +++ b/src/plots/cartesian/tick_mark_defaults.js @@ -17,7 +17,7 @@ var layoutAttributes = require('./layout_attributes'); /** * options: inherits outerTicks from axes.handleAxisDefaults */ -module.exports = function(containerIn, containerOut, coerce, options) { +module.exports = function handleTickDefaults(containerIn, containerOut, coerce, options) { var tickLen = Lib.coerce2(containerIn, containerOut, layoutAttributes, 'ticklen'); var tickWidth = Lib.coerce2(containerIn, containerOut, layoutAttributes, 'tickwidth'); var tickColor = Lib.coerce2(containerIn, containerOut, layoutAttributes, 'tickcolor', containerOut.color); diff --git a/src/plots/cartesian/tick_value_defaults.js b/src/plots/cartesian/tick_value_defaults.js index 8f7307543c2..6f8262f0674 100644 --- a/src/plots/cartesian/tick_value_defaults.js +++ b/src/plots/cartesian/tick_value_defaults.js @@ -10,7 +10,7 @@ var cleanTicks = require('./clean_ticks'); -module.exports = function(containerIn, containerOut, coerce, axType) { +module.exports = function handleTickValueDefaults(containerIn, containerOut, coerce, axType) { var tickmode; if(containerIn.tickmode === 'array' && diff --git a/src/plots/cartesian/transition_axes.js b/src/plots/cartesian/transition_axes.js index c370436fc44..46bbdf704cb 100644 --- a/src/plots/cartesian/transition_axes.js +++ b/src/plots/cartesian/transition_axes.js @@ -30,7 +30,7 @@ var Axes = require('./axes'); * @param {object} transitionOpts * @param {function} makeOnCompleteCallback */ -module.exports = function(gd, edits, transitionOpts, makeOnCompleteCallback) { +module.exports = function transitionAxes(gd, edits, transitionOpts, makeOnCompleteCallback) { var fullLayout = gd._fullLayout; // special case for redraw:false Plotly.animate that relies on this diff --git a/src/plots/cartesian/type_defaults.js b/src/plots/cartesian/type_defaults.js index 1527e23cb3a..16237397bf8 100644 --- a/src/plots/cartesian/type_defaults.js +++ b/src/plots/cartesian/type_defaults.js @@ -15,7 +15,7 @@ var autoType = require('./axis_autotype'); * data: the plot data to use in choosing auto type * name: axis object name (ie 'xaxis') if one should be stored */ -module.exports = function(containerIn, containerOut, coerce, options) { +module.exports = function handleTypeDefaults(containerIn, containerOut, coerce, options) { var axType = coerce('type', (options.splomStash || {}).type); if(axType === '-') { diff --git a/src/plots/command.js b/src/plots/command.js index 08ca9ae0982..b04897b4cb4 100644 --- a/src/plots/command.js +++ b/src/plots/command.js @@ -67,7 +67,7 @@ exports.manageCommandObserver = function(gd, container, commandList, onchange) { // Build the cache: bindingValueHasChanged(gd, binding, ret.cache); - ret.check = function() { + ret.check = function check() { if(!enabled) return; var update = bindingValueHasChanged(gd, binding, ret.cache); @@ -117,11 +117,11 @@ exports.manageCommandObserver = function(gd, container, commandList, onchange) { ret.remove = function() {}; } - ret.disable = function() { + ret.disable = function disable() { enabled = false; }; - ret.enable = function() { + ret.enable = function enable() { enabled = true; }; diff --git a/src/plots/geo/geo.js b/src/plots/geo/geo.js index fec149bd596..c0aba22e870 100644 --- a/src/plots/geo/geo.js +++ b/src/plots/geo/geo.js @@ -64,7 +64,7 @@ function Geo(opts) { var proto = Geo.prototype; -module.exports = function(opts) { +module.exports = function createGeo(opts) { return new Geo(opts); }; diff --git a/src/plots/geo/layout_defaults.js b/src/plots/geo/layout_defaults.js index c6e1e1be1d6..34da1d42edf 100644 --- a/src/plots/geo/layout_defaults.js +++ b/src/plots/geo/layout_defaults.js @@ -15,7 +15,7 @@ var layoutAttributes = require('./layout_attributes'); var axesNames = constants.axesNames; -module.exports = function(layoutIn, layoutOut, fullData) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { handleSubplotDefaults(layoutIn, layoutOut, fullData, { type: 'geo', attributes: layoutAttributes, diff --git a/src/plots/get_data.js b/src/plots/get_data.js index b64133242cb..b543c2f75bb 100644 --- a/src/plots/get_data.js +++ b/src/plots/get_data.js @@ -96,7 +96,7 @@ exports.getModuleCalcData = function(calcdata, arg1) { * @return {array} list of trace objects. * */ -exports.getSubplotData = function(data, type, subplotId) { +exports.getSubplotData = function getSubplotData(data, type, subplotId) { if(!Registry.subplotsRegistry[type]) return []; var attr = Registry.subplotsRegistry[type].attr; diff --git a/src/plots/gl2d/index.js b/src/plots/gl2d/index.js index 89bc362bfeb..fe240901ef0 100644 --- a/src/plots/gl2d/index.js +++ b/src/plots/gl2d/index.js @@ -52,7 +52,7 @@ exports.baseLayoutAttrOverrides = overrideAll({ // dragmode: fxAttrs.dragmode }, 'plot', 'nested'); -exports.plot = function(gd) { +exports.plot = function plotGl2d(gd) { var fullLayout = gd._fullLayout; var fullData = gd._fullData; var subplotIds = fullLayout._subplots.gl2d; diff --git a/src/plots/gl3d/index.js b/src/plots/gl3d/index.js index 08a39c56ce8..55c390b7619 100644 --- a/src/plots/gl3d/index.js +++ b/src/plots/gl3d/index.js @@ -39,7 +39,7 @@ exports.baseLayoutAttrOverrides = overrideAll({ exports.supplyLayoutDefaults = require('./layout/defaults'); -exports.plot = function(gd) { +exports.plot = function plotGl3d(gd) { var fullLayout = gd._fullLayout; var fullData = gd._fullData; var sceneIds = fullLayout._subplots[GL3D]; @@ -138,7 +138,7 @@ exports.toSVG = function(gd) { }; // clean scene ids, 'scene1' -> 'scene' -exports.cleanId = function(id) { +exports.cleanId = function cleanId(id) { if(!id.match(/^scene[0-9]*$/)) return; var sceneNum = id.substr(5); diff --git a/src/plots/gl3d/layout/axis_defaults.js b/src/plots/gl3d/layout/axis_defaults.js index 5051663b92e..ff55bdad2e1 100644 --- a/src/plots/gl3d/layout/axis_defaults.js +++ b/src/plots/gl3d/layout/axis_defaults.js @@ -24,7 +24,7 @@ var axesNames = ['xaxis', 'yaxis', 'zaxis']; // that differ from other subplot types. var gridLightness = 100 * (204 - 0x44) / (255 - 0x44); -module.exports = function(layoutIn, layoutOut, options) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, options) { var containerIn, containerOut; function coerce(attr, dflt) { diff --git a/src/plots/gl3d/layout/defaults.js b/src/plots/gl3d/layout/defaults.js index 3bef447c12f..da9a5b2805a 100644 --- a/src/plots/gl3d/layout/defaults.js +++ b/src/plots/gl3d/layout/defaults.js @@ -20,7 +20,7 @@ var getSubplotData = require('../../get_data').getSubplotData; var GL3D = 'gl3d'; -module.exports = function(layoutIn, layoutOut, fullData) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { var hasNon3D = layoutOut._basePlotModules.length > 1; // some layout-wide attribute are used in all scenes diff --git a/src/plots/gl3d/scene.js b/src/plots/gl3d/scene.js index ec3be1691de..b15ef824713 100644 --- a/src/plots/gl3d/scene.js +++ b/src/plots/gl3d/scene.js @@ -756,13 +756,13 @@ function getLayoutCamera(camera) { } // get camera position in plotly coords from 'orbit-camera' coords -proto.getCamera = function() { +proto.getCamera = function getCamera() { this.glplot.camera.view.recalcMatrix(this.camera.view.lastT()); return getLayoutCamera(this.glplot.camera); }; // set camera position with a set of plotly coords -proto.setCamera = function(cameraData) { +proto.setCamera = function setCamera(cameraData) { this.glplot.camera.lookAt.apply(this, getOrbitCamera(cameraData)); var newOrtho = (cameraData.projection.type === 'orthographic'); @@ -790,7 +790,7 @@ proto.setCamera = function(cameraData) { }; // save camera to user layout (i.e. gd.layout) -proto.saveCamera = function(layout) { +proto.saveCamera = function saveCamera(layout) { var fullLayout = this.fullLayout; var cameraData = this.getCamera(); var cameraNestedProp = Lib.nestedProperty(layout, this.id + '.camera'); diff --git a/src/plots/gl3d/zip3.js b/src/plots/gl3d/zip3.js index b315ce46ebc..28a0b1b1d11 100644 --- a/src/plots/gl3d/zip3.js +++ b/src/plots/gl3d/zip3.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(x, y, z, len) { +module.exports = function zip3(x, y, z, len) { len = len || x.length; var result = new Array(len); diff --git a/src/plots/mapbox/convert_text_opts.js b/src/plots/mapbox/convert_text_opts.js index ba9f838491f..52b8e39fada 100644 --- a/src/plots/mapbox/convert_text_opts.js +++ b/src/plots/mapbox/convert_text_opts.js @@ -22,7 +22,7 @@ var Lib = require('../../lib'); * - anchor * - offset */ -module.exports = function(textposition, iconSize) { +module.exports = function convertTextOpts(textposition, iconSize) { var parts = textposition.split(' '); var vPos = parts[0]; var hPos = parts[1]; diff --git a/src/plots/mapbox/index.js b/src/plots/mapbox/index.js index 2524b1cfcf6..5614173550a 100644 --- a/src/plots/mapbox/index.js +++ b/src/plots/mapbox/index.js @@ -50,7 +50,7 @@ exports.layoutAttributes = require('./layout_attributes'); exports.supplyLayoutDefaults = require('./layout_defaults'); -exports.plot = function(gd) { +exports.plot = function plotMapbox(gd) { var fullLayout = gd._fullLayout; var calcData = gd.calcdata; var mapboxIds = fullLayout._subplots[MAPBOX]; diff --git a/src/plots/mapbox/layers.js b/src/plots/mapbox/layers.js index 708fe7d26e6..914b30ea3a6 100644 --- a/src/plots/mapbox/layers.js +++ b/src/plots/mapbox/layers.js @@ -32,7 +32,7 @@ function MapboxLayer(mapbox, index) { var proto = MapboxLayer.prototype; -proto.update = function(opts) { +proto.update = function update(opts) { if(!this.visible) { // IMPORTANT: must create source before layer to not cause errors this.updateSource(opts); @@ -120,7 +120,7 @@ proto.removeLayer = function() { } }; -proto.dispose = function() { +proto.dispose = function dispose() { var map = this.map; map.removeLayer(this.idLayer); map.removeSource(this.idSource); @@ -212,7 +212,7 @@ function convertSourceOpts(opts) { return sourceOpts; } -module.exports = function(mapbox, index, opts) { +module.exports = function createMapboxLayer(mapbox, index, opts) { var mapboxLayer = new MapboxLayer(mapbox, index); mapboxLayer.update(opts); diff --git a/src/plots/mapbox/layout_defaults.js b/src/plots/mapbox/layout_defaults.js index 6ac2f28563c..b9651e06ba5 100644 --- a/src/plots/mapbox/layout_defaults.js +++ b/src/plots/mapbox/layout_defaults.js @@ -16,7 +16,7 @@ var handleArrayContainerDefaults = require('../array_container_defaults'); var layoutAttributes = require('./layout_attributes'); -module.exports = function(layoutIn, layoutOut, fullData) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { handleSubplotDefaults(layoutIn, layoutOut, fullData, { type: 'mapbox', attributes: layoutAttributes, diff --git a/src/plots/mapbox/mapbox.js b/src/plots/mapbox/mapbox.js index a5036c71f23..12494985486 100644 --- a/src/plots/mapbox/mapbox.js +++ b/src/plots/mapbox/mapbox.js @@ -48,7 +48,7 @@ function Mapbox(opts) { var proto = Mapbox.prototype; -module.exports = function(opts) { +module.exports = function createMapbox(opts) { return new Mapbox(opts); }; diff --git a/src/plots/plots.js b/src/plots/plots.js index fc4eafc1558..3ac177d31bc 100644 --- a/src/plots/plots.js +++ b/src/plots/plots.js @@ -1463,7 +1463,7 @@ plots.supplyLayoutGlobalDefaults = function(layoutIn, layoutOut, formatObj) { )(layoutIn, layoutOut, coerce); }; -plots.plotAutoSize = function(gd, layout, fullLayout) { +plots.plotAutoSize = function plotAutoSize(gd, layout, fullLayout) { var context = gd._context || {}; var frameMargins = context.frameMargins; var newWidth; diff --git a/src/plots/polar/layout_defaults.js b/src/plots/polar/layout_defaults.js index ab928e455e8..6c7fb220dc6 100644 --- a/src/plots/polar/layout_defaults.js +++ b/src/plots/polar/layout_defaults.js @@ -218,7 +218,7 @@ function handleAxisTypeDefaults(axIn, axOut, coerce, subplotData, dataAttr) { return axOut.type; } -module.exports = function(layoutIn, layoutOut, fullData) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { handleSubplotDefaults(layoutIn, layoutOut, fullData, { type: constants.name, attributes: layoutAttributes, diff --git a/src/plots/polar/legacy/undo_manager.js b/src/plots/polar/legacy/undo_manager.js index ba2ec983007..f684bdb96a0 100644 --- a/src/plots/polar/legacy/undo_manager.js +++ b/src/plots/polar/legacy/undo_manager.js @@ -10,7 +10,7 @@ // Modified from https://github.com/ArthurClemens/Javascript-Undo-Manager // Copyright (c) 2010-2013 Arthur Clemens, arthur@visiblearea.com -module.exports = function() { +module.exports = function UndoManager() { var undoCommands = []; var index = -1; var isExecuting = false; diff --git a/src/plots/polar/polar.js b/src/plots/polar/polar.js index 19cbdefe27d..a6f33e2da6c 100644 --- a/src/plots/polar/polar.js +++ b/src/plots/polar/polar.js @@ -72,7 +72,7 @@ function Polar(gd, id) { var proto = Polar.prototype; -module.exports = function(gd, id) { +module.exports = function createPolar(gd, id) { return new Polar(gd, id); }; diff --git a/src/plots/polar/set_convert.js b/src/plots/polar/set_convert.js index 316e402377a..bbcc341d1da 100644 --- a/src/plots/polar/set_convert.js +++ b/src/plots/polar/set_convert.js @@ -46,7 +46,7 @@ var rad2deg = Lib.rad2deg; * * Then, 'g'eometric data is ready to be converted to (x,y). */ -module.exports = function(ax, polarLayout, fullLayout) { +module.exports = function setConvert(ax, polarLayout, fullLayout) { setConvertCartesian(ax, fullLayout); switch(ax._id) { diff --git a/src/plots/subplot_defaults.js b/src/plots/subplot_defaults.js index 9fa1ffea194..de02e8a5803 100644 --- a/src/plots/subplot_defaults.js +++ b/src/plots/subplot_defaults.js @@ -41,7 +41,7 @@ var handleDomainDefaults = require('./domain').defaults; * additional items needed by this function here as well * } */ -module.exports = function(layoutIn, layoutOut, fullData, opts) { +module.exports = function handleSubplotDefaults(layoutIn, layoutOut, fullData, opts) { var subplotType = opts.type; var subplotAttributes = opts.attributes; var handleDefaults = opts.handleDefaults; diff --git a/src/plots/ternary/index.js b/src/plots/ternary/index.js index 08910bdbbc0..0c6d16169eb 100644 --- a/src/plots/ternary/index.js +++ b/src/plots/ternary/index.js @@ -41,7 +41,7 @@ exports.layoutAttributes = require('./layout_attributes'); exports.supplyLayoutDefaults = require('./layout_defaults'); -exports.plot = function(gd) { +exports.plot = function plotTernary(gd) { var fullLayout = gd._fullLayout; var calcData = gd.calcdata; var ternaryIds = fullLayout._subplots[TERNARY]; diff --git a/src/plots/ternary/layout_defaults.js b/src/plots/ternary/layout_defaults.js index 06168788550..7ab47dee7ac 100644 --- a/src/plots/ternary/layout_defaults.js +++ b/src/plots/ternary/layout_defaults.js @@ -21,7 +21,7 @@ var layoutAttributes = require('./layout_attributes'); var axesNames = ['aaxis', 'baxis', 'caxis']; -module.exports = function(layoutIn, layoutOut, fullData) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { handleSubplotDefaults(layoutIn, layoutOut, fullData, { type: 'ternary', attributes: layoutAttributes, diff --git a/src/registry.js b/src/registry.js index 232e061fb1e..37e17595f0f 100644 --- a/src/registry.js +++ b/src/registry.js @@ -72,7 +72,7 @@ exports.collectableSubplotTypes = null; * - fn {function} : the api method called with Register.call(); * */ -exports.register = function(_modules) { +exports.register = function register(_modules) { exports.collectableSubplotTypes = null; if(!_modules) { diff --git a/src/snapshot/cloneplot.js b/src/snapshot/cloneplot.js index 038e1430980..239ad267dc2 100644 --- a/src/snapshot/cloneplot.js +++ b/src/snapshot/cloneplot.js @@ -57,7 +57,7 @@ function keyIsAxis(keyName) { } -module.exports = function(graphObj, options) { +module.exports = function clonePlot(graphObj, options) { // Polar plot compatibility if(graphObj.framework && graphObj.framework.isPolar) { graphObj = graphObj.framework.getConfig(); diff --git a/src/snapshot/tosvg.js b/src/snapshot/tosvg.js index 37d80f73eaf..507bab751fd 100644 --- a/src/snapshot/tosvg.js +++ b/src/snapshot/tosvg.js @@ -36,7 +36,7 @@ function xmlEntityEncode(str) { return str.replace(/&(?!\w+;|\#[0-9]+;| \#x[0-9A-F]+;)/g, '&'); } -module.exports = function(gd, format, scale) { +module.exports = function toSVG(gd, format, scale) { var fullLayout = gd._fullLayout; var svg = fullLayout._paper; var toppaper = fullLayout._toppaper; diff --git a/src/traces/bar/arrays_to_calcdata.js b/src/traces/bar/arrays_to_calcdata.js index 949ee80e5ad..a722f3dec04 100644 --- a/src/traces/bar/arrays_to_calcdata.js +++ b/src/traces/bar/arrays_to_calcdata.js @@ -11,7 +11,7 @@ var mergeArray = require('../../lib').mergeArray; // arrayOk attributes, merge them into calcdata array -module.exports = function(cd, trace) { +module.exports = function arraysToCalcdata(cd, trace) { for(var i = 0; i < cd.length; i++) cd[i].i = i; mergeArray(trace.text, cd, 'tx'); diff --git a/src/traces/bar/calc.js b/src/traces/bar/calc.js index ab9deb782ff..41af79b7b1c 100644 --- a/src/traces/bar/calc.js +++ b/src/traces/bar/calc.js @@ -14,7 +14,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); var arraysToCalcdata = require('./arrays_to_calcdata'); var calcSelection = require('../scatter/calc_selection'); -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var xa = Axes.getFromId(gd, trace.xaxis || 'x'); var ya = Axes.getFromId(gd, trace.yaxis || 'y'); var size, pos; diff --git a/src/traces/bar/plot.js b/src/traces/bar/plot.js index 0fdd3acb783..9466ce9a061 100644 --- a/src/traces/bar/plot.js +++ b/src/traces/bar/plot.js @@ -28,7 +28,7 @@ var style = require('./style'); // padding in pixels around text var TEXTPAD = 3; -module.exports = function(gd, plotinfo, cdModule, traceLayer) { +module.exports = function plot(gd, plotinfo, cdModule, traceLayer) { var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; var fullLayout = gd._fullLayout; diff --git a/src/traces/bar/select.js b/src/traces/bar/select.js index 522e4dd6347..5d277c95dd2 100644 --- a/src/traces/bar/select.js +++ b/src/traces/bar/select.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(searchInfo, selectionTester) { +module.exports = function selectPoints(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/bar/sieve.js b/src/traces/bar/sieve.js index 7b84f981717..d9490bd7a7a 100644 --- a/src/traces/bar/sieve.js +++ b/src/traces/bar/sieve.js @@ -66,7 +66,7 @@ function Sieve(traces, opts) { * @param {number} value * @returns {number} Previous bin value */ -Sieve.prototype.put = function(position, value) { +Sieve.prototype.put = function put(position, value) { var label = this.getLabel(position, value); var oldValue = this.bins[label] || 0; @@ -84,7 +84,7 @@ Sieve.prototype.put = function(position, value) { * (required if this.sepNegVal is true) * @returns {number} Current bin value */ -Sieve.prototype.get = function(position, value) { +Sieve.prototype.get = function put(position, value) { var label = this.getLabel(position, value); return this.bins[label] || 0; }; @@ -100,7 +100,7 @@ Sieve.prototype.get = function(position, value) { * (prefixed with a 'v' if value is negative and this.sepNegVal is * true; otherwise prefixed with '^') */ -Sieve.prototype.getLabel = function(position, value) { +Sieve.prototype.getLabel = function getLabel(position, value) { var prefix = (value < 0 && this.sepNegVal) ? 'v' : '^'; var label = (this.overlapNoMerge) ? position : diff --git a/src/traces/bar/style_defaults.js b/src/traces/bar/style_defaults.js index 4a8aea7c703..0fb9bcde988 100644 --- a/src/traces/bar/style_defaults.js +++ b/src/traces/bar/style_defaults.js @@ -12,7 +12,7 @@ var Color = require('../../components/color'); var hasColorscale = require('../../components/colorscale/helpers').hasColorscale; var colorscaleDefaults = require('../../components/colorscale/defaults'); -module.exports = function(traceIn, traceOut, coerce, defaultColor, layout) { +module.exports = function handleStyleDefaults(traceIn, traceOut, coerce, defaultColor, layout) { coerce('marker.color', defaultColor); if(hasColorscale(traceIn, 'marker')) { diff --git a/src/traces/barpolar/defaults.js b/src/traces/barpolar/defaults.js index 773dc61fc59..4265f46d7ab 100644 --- a/src/traces/barpolar/defaults.js +++ b/src/traces/barpolar/defaults.js @@ -14,7 +14,7 @@ var handleRThetaDefaults = require('../scatterpolar/defaults').handleRThetaDefau var handleStyleDefaults = require('../bar/style_defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/barpolar/hover.js b/src/traces/barpolar/hover.js index be8579012c9..2719f16725e 100644 --- a/src/traces/barpolar/hover.js +++ b/src/traces/barpolar/hover.js @@ -15,7 +15,7 @@ var fillHoverText = require('../scatter/fill_hover_text'); var makeHoverPointText = require('../scatterpolar/hover').makeHoverPointText; var isPtInsidePolygon = require('../../plots/polar/helpers').isPtInsidePolygon; -module.exports = function(pointData, xval, yval) { +module.exports = function hoverPoints(pointData, xval, yval) { var cd = pointData.cd; var trace = cd[0].trace; diff --git a/src/traces/barpolar/plot.js b/src/traces/barpolar/plot.js index 692cc85db27..a627c07cdfb 100644 --- a/src/traces/barpolar/plot.js +++ b/src/traces/barpolar/plot.js @@ -15,7 +15,7 @@ var Lib = require('../../lib'); var Drawing = require('../../components/drawing'); var helpers = require('../../plots/polar/helpers'); -module.exports = function(gd, subplot, cdbar) { +module.exports = function plot(gd, subplot, cdbar) { var xa = subplot.xaxis; var ya = subplot.yaxis; var radialAxis = subplot.radialAxis; diff --git a/src/traces/box/calc.js b/src/traces/box/calc.js index a30af4243f0..0e424c5223d 100644 --- a/src/traces/box/calc.js +++ b/src/traces/box/calc.js @@ -15,7 +15,7 @@ var _ = Lib._; var Axes = require('../../plots/cartesian/axes'); // outlier definition based on http://www.physics.csbsju.edu/stats/box2.html -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var fullLayout = gd._fullLayout; var xa = Axes.getFromId(gd, trace.xaxis || 'x'); var ya = Axes.getFromId(gd, trace.yaxis || 'y'); diff --git a/src/traces/box/event_data.js b/src/traces/box/event_data.js index 5c13fa11175..bd2171a5415 100644 --- a/src/traces/box/event_data.js +++ b/src/traces/box/event_data.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(out, pt) { +module.exports = function eventData(out, pt) { // Note: hoverOnBox property is needed for click-to-select // to ignore when a box was clicked. This is the reason box // implements this custom eventData function. diff --git a/src/traces/box/select.js b/src/traces/box/select.js index adddf7469fb..15c014ef10e 100644 --- a/src/traces/box/select.js +++ b/src/traces/box/select.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(searchInfo, selectionTester) { +module.exports = function selectPoints(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/candlestick/defaults.js b/src/traces/candlestick/defaults.js index b834a547608..f4e2f6d64a4 100644 --- a/src/traces/candlestick/defaults.js +++ b/src/traces/candlestick/defaults.js @@ -14,7 +14,7 @@ var Color = require('../../components/color'); var handleOHLC = require('../ohlc/ohlc_defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/carpet/ab_defaults.js b/src/traces/carpet/ab_defaults.js index 476472f27c9..ed037acdd58 100644 --- a/src/traces/carpet/ab_defaults.js +++ b/src/traces/carpet/ab_defaults.js @@ -11,7 +11,7 @@ var handleAxisDefaults = require('./axis_defaults'); var Template = require('../../plot_api/plot_template'); -module.exports = function(traceIn, traceOut, fullLayout, coerce, dfltColor) { +module.exports = function handleABDefaults(traceIn, traceOut, fullLayout, coerce, dfltColor) { var a = coerce('a'); if(!a) { diff --git a/src/traces/carpet/axis_defaults.js b/src/traces/carpet/axis_defaults.js index 7efb13e481d..063b43c1bc1 100644 --- a/src/traces/carpet/axis_defaults.js +++ b/src/traces/carpet/axis_defaults.js @@ -31,7 +31,7 @@ var autoType = require('../../plots/cartesian/axis_autotype'); * data: the plot data to use in choosing auto type * bgColor: the plot background color, to calculate default gridline colors */ -module.exports = function(containerIn, containerOut, options) { +module.exports = function handleAxisDefaults(containerIn, containerOut, options) { var letter = options.letter; var font = options.font || {}; var attributes = carpetAttrs[letter + 'axis']; diff --git a/src/traces/carpet/calc.js b/src/traces/carpet/calc.js index 81a7f14f733..6d488b7e279 100644 --- a/src/traces/carpet/calc.js +++ b/src/traces/carpet/calc.js @@ -20,7 +20,7 @@ var smoothFill2dArray = require('./smooth_fill_2d_array'); var convertColumnData = require('../heatmap/convert_column_xyz'); var setConvert = require('./set_convert'); -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var xa = Axes.getFromId(gd, trace.xaxis); var ya = Axes.getFromId(gd, trace.yaxis); var aax = trace.aaxis; diff --git a/src/traces/carpet/calc_clippath.js b/src/traces/carpet/calc_clippath.js index e9cfbc1d252..52a632414f2 100644 --- a/src/traces/carpet/calc_clippath.js +++ b/src/traces/carpet/calc_clippath.js @@ -9,7 +9,7 @@ 'use strict'; -module.exports = function(xctrl, yctrl, aax, bax) { +module.exports = function makeClipPath(xctrl, yctrl, aax, bax) { var i, x, y; var segments = []; diff --git a/src/traces/carpet/calc_gridlines.js b/src/traces/carpet/calc_gridlines.js index e79271f7052..7d4472e7a33 100644 --- a/src/traces/carpet/calc_gridlines.js +++ b/src/traces/carpet/calc_gridlines.js @@ -11,7 +11,7 @@ var Axes = require('../../plots/cartesian/axes'); var extendFlat = require('../../lib/extend').extendFlat; -module.exports = function(trace, axisLetter, crossAxisLetter) { +module.exports = function calcGridlines(trace, axisLetter, crossAxisLetter) { var i, j, j0; var eps, bounds, n1, n2, n, value, v; var j1, v0, v1, d; diff --git a/src/traces/carpet/calc_labels.js b/src/traces/carpet/calc_labels.js index dfb1043f5b3..514dd1f1231 100644 --- a/src/traces/carpet/calc_labels.js +++ b/src/traces/carpet/calc_labels.js @@ -11,7 +11,7 @@ var Axes = require('../../plots/cartesian/axes'); var extendFlat = require('../../lib/extend').extendFlat; -module.exports = function(trace, axis) { +module.exports = function calcLabels(trace, axis) { var i, tobj, prefix, suffix, gridline; var labels = axis._labels = []; diff --git a/src/traces/carpet/catmull_rom.js b/src/traces/carpet/catmull_rom.js index 98ec07cb198..93ffbb5140c 100644 --- a/src/traces/carpet/catmull_rom.js +++ b/src/traces/carpet/catmull_rom.js @@ -19,7 +19,7 @@ * math works out this way if you work through the bezier derivatives) */ var CatmullRomExp = 0.5; -module.exports = function(p0, p1, p2, smoothness) { +module.exports = function makeControlPoints(p0, p1, p2, smoothness) { var d1x = p0[0] - p1[0]; var d1y = p0[1] - p1[1]; var d2x = p2[0] - p1[0]; diff --git a/src/traces/carpet/compute_control_points.js b/src/traces/carpet/compute_control_points.js index 2afd6314a93..6198ceb5dbd 100644 --- a/src/traces/carpet/compute_control_points.js +++ b/src/traces/carpet/compute_control_points.js @@ -127,7 +127,7 @@ function inferCubicControlPoint(p0, p2, p3) { ]; } -module.exports = function(xe, ye, x, y, asmoothing, bsmoothing) { +module.exports = function computeControlPoints(xe, ye, x, y, asmoothing, bsmoothing) { var i, j, ie, je, xej, yej, xj, yj, cp, p1; // At this point, we know these dimensions are correct and representative of // the whole 2D arrays: diff --git a/src/traces/carpet/defaults.js b/src/traces/carpet/defaults.js index fc03f98091e..6ef9376d6fa 100644 --- a/src/traces/carpet/defaults.js +++ b/src/traces/carpet/defaults.js @@ -15,7 +15,7 @@ var handleABDefaults = require('./ab_defaults'); var attributes = require('./attributes'); var colorAttrs = require('../../components/color/attributes'); -module.exports = function(traceIn, traceOut, dfltColor, fullLayout) { +module.exports = function supplyDefaults(traceIn, traceOut, dfltColor, fullLayout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/carpet/makepath.js b/src/traces/carpet/makepath.js index dfc5d32c0d7..500ca4404b0 100644 --- a/src/traces/carpet/makepath.js +++ b/src/traces/carpet/makepath.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(xp, yp, isBicubic) { +module.exports = function makePath(xp, yp, isBicubic) { // Prevent d3 errors that would result otherwise: if(xp.length === 0) return ''; diff --git a/src/traces/carpet/map_1d_array.js b/src/traces/carpet/map_1d_array.js index b807bdf267d..3cd79d49337 100644 --- a/src/traces/carpet/map_1d_array.js +++ b/src/traces/carpet/map_1d_array.js @@ -15,7 +15,7 @@ var isArrayOrTypedArray = require('../../lib').isArrayOrTypedArray; * The output array is optional, but if provided, it will be reused without * reallocation to the extent possible. */ -module.exports = function(out, data, func) { +module.exports = function mapArray(out, data, func) { var i; if(!isArrayOrTypedArray(out)) { diff --git a/src/traces/carpet/orient_text.js b/src/traces/carpet/orient_text.js index ca7d8acce4f..73a13c93f0a 100644 --- a/src/traces/carpet/orient_text.js +++ b/src/traces/carpet/orient_text.js @@ -9,7 +9,7 @@ 'use strict'; -module.exports = function(trace, xaxis, yaxis, xy, dxy, refDxy) { +module.exports = function orientText(trace, xaxis, yaxis, xy, dxy, refDxy) { var dx = dxy[0] * trace.dpdx(xaxis); var dy = dxy[1] * trace.dpdy(yaxis); var flip = 1; diff --git a/src/traces/carpet/plot.js b/src/traces/carpet/plot.js index 344cb5da26c..8d3a5479c14 100644 --- a/src/traces/carpet/plot.js +++ b/src/traces/carpet/plot.js @@ -18,7 +18,7 @@ var svgTextUtils = require('../../lib/svg_text_utils'); var Lib = require('../../lib'); var alignmentConstants = require('../../constants/alignment'); -module.exports = function(gd, plotinfo, cdcarpet, carpetLayer) { +module.exports = function plot(gd, plotinfo, cdcarpet, carpetLayer) { var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; var fullLayout = gd._fullLayout; diff --git a/src/traces/carpet/set_convert.js b/src/traces/carpet/set_convert.js index 9c75d6e7faf..ded81ebcd6a 100644 --- a/src/traces/carpet/set_convert.js +++ b/src/traces/carpet/set_convert.js @@ -24,7 +24,7 @@ var createJDerivativeEvaluator = require('./create_j_derivative_evaluator'); * c: cartesian x-y coordinates * p: screen-space pixel coordinates */ -module.exports = function(trace) { +module.exports = function setConvert(trace) { var a = trace._a; var b = trace._b; var na = a.length; diff --git a/src/traces/carpet/smooth_fill_2d_array.js b/src/traces/carpet/smooth_fill_2d_array.js index baf70f6e5ce..54b2a04fe4f 100644 --- a/src/traces/carpet/smooth_fill_2d_array.js +++ b/src/traces/carpet/smooth_fill_2d_array.js @@ -22,7 +22,7 @@ var Lib = require('../../lib'); * - a: array such that a.length === data[0].length * - b: array such that b.length === data.length */ -module.exports = function(data, a, b) { +module.exports = function smoothFill2dArray(data, a, b) { var i, j, k; var ip = []; var jp = []; diff --git a/src/traces/carpet/smooth_fill_array.js b/src/traces/carpet/smooth_fill_array.js index df00de1c05b..c57eff95d9c 100644 --- a/src/traces/carpet/smooth_fill_array.js +++ b/src/traces/carpet/smooth_fill_array.js @@ -14,7 +14,7 @@ * makes this much simpler. Just loop over it and do the best we can to fill * the array. */ -module.exports = function(data) { +module.exports = function smoothFillArray(data) { var i, i0, i1; var n = data.length; diff --git a/src/traces/carpet/xy_defaults.js b/src/traces/carpet/xy_defaults.js index 433c15e32dd..947c1b096e9 100644 --- a/src/traces/carpet/xy_defaults.js +++ b/src/traces/carpet/xy_defaults.js @@ -11,7 +11,7 @@ var isArray1D = require('../../lib').isArray1D; -module.exports = function(traceIn, traceOut, coerce) { +module.exports = function handleXYDefaults(traceIn, traceOut, coerce) { var x = coerce('x'); var hasX = x && x.length; var y = coerce('y'); diff --git a/src/traces/choropleth/calc.js b/src/traces/choropleth/calc.js index 2d70a559089..fcaa55ebcbd 100644 --- a/src/traces/choropleth/calc.js +++ b/src/traces/choropleth/calc.js @@ -16,7 +16,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); var arraysToCalcdata = require('../scatter/arrays_to_calcdata'); var calcSelection = require('../scatter/calc_selection'); -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var len = trace._length; var calcTrace = new Array(len); diff --git a/src/traces/choropleth/defaults.js b/src/traces/choropleth/defaults.js index b9b9d67caa2..47d84b91ae0 100644 --- a/src/traces/choropleth/defaults.js +++ b/src/traces/choropleth/defaults.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/choropleth/event_data.js b/src/traces/choropleth/event_data.js index 7c9becd3163..1b7781944bc 100644 --- a/src/traces/choropleth/event_data.js +++ b/src/traces/choropleth/event_data.js @@ -9,7 +9,7 @@ 'use strict'; -module.exports = function(out, pt) { +module.exports = function eventData(out, pt) { out.location = pt.location; out.z = pt.z; diff --git a/src/traces/choropleth/hover.js b/src/traces/choropleth/hover.js index c73e3965e49..70211333f51 100644 --- a/src/traces/choropleth/hover.js +++ b/src/traces/choropleth/hover.js @@ -13,7 +13,7 @@ var Axes = require('../../plots/cartesian/axes'); var attributes = require('./attributes'); var fillHoverText = require('../scatter/fill_hover_text'); -module.exports = function(pointData, xval, yval) { +module.exports = function hoverPoints(pointData, xval, yval) { var cd = pointData.cd; var trace = cd[0].trace; var geo = pointData.subplot; diff --git a/src/traces/choropleth/plot.js b/src/traces/choropleth/plot.js index c6c6ecb7813..8a547af8a9a 100644 --- a/src/traces/choropleth/plot.js +++ b/src/traces/choropleth/plot.js @@ -17,7 +17,7 @@ var getTopojsonFeatures = require('../../lib/topojson_utils').getTopojsonFeature var locationToFeature = require('../../lib/geo_location_utils').locationToFeature; var style = require('./style').style; -module.exports = function(gd, geo, calcData) { +module.exports = function plot(gd, geo, calcData) { for(var i = 0; i < calcData.length; i++) { calcGeoJSON(calcData[i], geo.topojson); } diff --git a/src/traces/choropleth/select.js b/src/traces/choropleth/select.js index c2cfff5cd19..3cd34e21f93 100644 --- a/src/traces/choropleth/select.js +++ b/src/traces/choropleth/select.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(searchInfo, selectionTester) { +module.exports = function selectPoints(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/cone/calc.js b/src/traces/cone/calc.js index 91769d730fa..ac58b23a885 100644 --- a/src/traces/cone/calc.js +++ b/src/traces/cone/calc.js @@ -10,7 +10,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var u = trace.u; var v = trace.v; var w = trace.w; diff --git a/src/traces/cone/defaults.js b/src/traces/cone/defaults.js index 362ef4709e8..3b6f1d5fc91 100644 --- a/src/traces/cone/defaults.js +++ b/src/traces/cone/defaults.js @@ -14,7 +14,7 @@ var Lib = require('../../lib'); var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/contour/calc.js b/src/traces/contour/calc.js index ca7f3be5eba..5f16e8f312c 100644 --- a/src/traces/contour/calc.js +++ b/src/traces/contour/calc.js @@ -15,7 +15,7 @@ var setContours = require('./set_contours'); // most is the same as heatmap calc, then adjust it // though a few things inside heatmap calc still look for // contour maps, because the makeBoundArray calls are too entangled -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var cd = heatmapCalc(gd, trace); setContours(trace); return cd; diff --git a/src/traces/contour/colorbar.js b/src/traces/contour/colorbar.js index 9b01bdad120..0187ed5b7d1 100644 --- a/src/traces/contour/colorbar.js +++ b/src/traces/contour/colorbar.js @@ -15,7 +15,7 @@ var makeColorMap = require('./make_color_map'); var endPlus = require('./end_plus'); -module.exports = function(gd, cd) { +module.exports = function colorbar(gd, cd) { var trace = cd[0].trace; var cbId = 'cb' + trace.uid; diff --git a/src/traces/contour/constraint_defaults.js b/src/traces/contour/constraint_defaults.js index 098dfac16c1..9eba7a16534 100644 --- a/src/traces/contour/constraint_defaults.js +++ b/src/traces/contour/constraint_defaults.js @@ -20,7 +20,7 @@ var filterOps = require('../../constants/filter_ops'); var CONSTRAINT_REDUCTION = filterOps.CONSTRAINT_REDUCTION; var COMPARISON_OPS2 = filterOps.COMPARISON_OPS2; -module.exports = function(traceIn, traceOut, coerce, layout, defaultColor, opts) { +module.exports = function handleConstraintDefaults(traceIn, traceOut, coerce, layout, defaultColor, opts) { var contours = traceOut.contours; var showLines, lineColor, fillColor; diff --git a/src/traces/contour/contours_defaults.js b/src/traces/contour/contours_defaults.js index 6a757b02b5f..2b07b42215e 100644 --- a/src/traces/contour/contours_defaults.js +++ b/src/traces/contour/contours_defaults.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(traceIn, traceOut, coerce, coerce2) { +module.exports = function handleContourDefaults(traceIn, traceOut, coerce, coerce2) { var contourStart = coerce2('contours.start'); var contourEnd = coerce2('contours.end'); var missingEnd = (contourStart === false) || (contourEnd === false); diff --git a/src/traces/contour/defaults.js b/src/traces/contour/defaults.js index 04a9767d208..62c904c99a1 100644 --- a/src/traces/contour/defaults.js +++ b/src/traces/contour/defaults.js @@ -17,7 +17,7 @@ var handleStyleDefaults = require('./style_defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/contour/empty_pathinfo.js b/src/traces/contour/empty_pathinfo.js index 90f9126ad36..d53d7b23835 100644 --- a/src/traces/contour/empty_pathinfo.js +++ b/src/traces/contour/empty_pathinfo.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var constraintMapping = require('./constraint_mapping'); var endPlus = require('./end_plus'); -module.exports = function(contours, plotinfo, cd0) { +module.exports = function emptyPathinfo(contours, plotinfo, cd0) { var contoursFinal = (contours.type === 'constraint') ? constraintMapping[contours._operation](contours.value) : contours; diff --git a/src/traces/contour/end_plus.js b/src/traces/contour/end_plus.js index 7de74640f57..b2ea1b70ae2 100644 --- a/src/traces/contour/end_plus.js +++ b/src/traces/contour/end_plus.js @@ -13,6 +13,6 @@ * tiny helper to move the end of the contours a little to prevent * losing the last contour to rounding errors */ -module.exports = function(contours) { +module.exports = function endPlus(contours) { return contours.end + contours.size / 1e6; }; diff --git a/src/traces/contour/find_all_paths.js b/src/traces/contour/find_all_paths.js index f95f2026e33..f6104f28b6f 100644 --- a/src/traces/contour/find_all_paths.js +++ b/src/traces/contour/find_all_paths.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var constants = require('./constants'); -module.exports = function(pathinfo, xtol, ytol) { +module.exports = function findAllPaths(pathinfo, xtol, ytol) { var cnt, startLoc, i, diff --git a/src/traces/contour/hover.js b/src/traces/contour/hover.js index 799f8f870b3..aebc36e86eb 100644 --- a/src/traces/contour/hover.js +++ b/src/traces/contour/hover.js @@ -13,7 +13,7 @@ var Color = require('../../components/color'); var heatmapHoverPoints = require('../heatmap/hover'); -module.exports = function(pointData, xval, yval, hovermode, hoverLayer) { +module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLayer) { var hoverData = heatmapHoverPoints(pointData, xval, yval, hovermode, hoverLayer, true); if(hoverData) { diff --git a/src/traces/contour/label_defaults.js b/src/traces/contour/label_defaults.js index 07e05e779fd..f60601f7541 100644 --- a/src/traces/contour/label_defaults.js +++ b/src/traces/contour/label_defaults.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); -module.exports = function(coerce, layout, lineColor, opts) { +module.exports = function handleLabelDefaults(coerce, layout, lineColor, opts) { if(!opts) opts = {}; var showLabels = coerce('contours.showlabels'); if(showLabels) { diff --git a/src/traces/contour/make_color_map.js b/src/traces/contour/make_color_map.js index ad1c5ff0885..74c1ca90889 100644 --- a/src/traces/contour/make_color_map.js +++ b/src/traces/contour/make_color_map.js @@ -13,7 +13,7 @@ var d3 = require('d3'); var Colorscale = require('../../components/colorscale'); var endPlus = require('./end_plus'); -module.exports = function(trace) { +module.exports = function makeColorMap(trace) { var contours = trace.contours; var start = contours.start; var end = endPlus(contours); diff --git a/src/traces/contour/make_crossings.js b/src/traces/contour/make_crossings.js index f7a57c6c708..45b5f79ccd9 100644 --- a/src/traces/contour/make_crossings.js +++ b/src/traces/contour/make_crossings.js @@ -14,7 +14,7 @@ var constants = require('./constants'); // since we want to be exhaustive we'll check for contour crossings // at every intersection, rather than just following a path // TODO: shorten the inner loop to only the relevant levels -module.exports = function(pathinfo) { +module.exports = function makeCrossings(pathinfo) { var z = pathinfo[0].z; var m = z.length; var n = z[0].length; // we already made sure z isn't ragged in interp2d diff --git a/src/traces/contour/plot.js b/src/traces/contour/plot.js index d137e76727a..0411e864695 100644 --- a/src/traces/contour/plot.js +++ b/src/traces/contour/plot.js @@ -26,7 +26,7 @@ var closeBoundaries = require('./close_boundaries'); var constants = require('./constants'); var costConstants = constants.LABELOPTIMIZER; -exports.plot = function(gd, plotinfo, cdcontours, contourLayer) { +exports.plot = function plot(gd, plotinfo, cdcontours, contourLayer) { var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; diff --git a/src/traces/contour/set_contours.js b/src/traces/contour/set_contours.js index 9444d7aa2b2..0804413a4a3 100644 --- a/src/traces/contour/set_contours.js +++ b/src/traces/contour/set_contours.js @@ -13,7 +13,7 @@ var Axes = require('../../plots/cartesian/axes'); var Lib = require('../../lib'); -module.exports = function(trace) { +module.exports = function setContours(trace) { var contours = trace.contours; // check if we need to auto-choose contour levels diff --git a/src/traces/contour/style.js b/src/traces/contour/style.js index 6fa6282c518..af966873b3f 100644 --- a/src/traces/contour/style.js +++ b/src/traces/contour/style.js @@ -17,7 +17,7 @@ var heatmapStyle = require('../heatmap/style'); var makeColorMap = require('./make_color_map'); -module.exports = function(gd) { +module.exports = function style(gd) { var contours = d3.select(gd).selectAll('g.contour'); contours.style('opacity', function(d) { diff --git a/src/traces/contour/style_defaults.js b/src/traces/contour/style_defaults.js index 7c3f3f37e06..a89f05af40a 100644 --- a/src/traces/contour/style_defaults.js +++ b/src/traces/contour/style_defaults.js @@ -13,7 +13,7 @@ var colorscaleDefaults = require('../../components/colorscale/defaults'); var handleLabelDefaults = require('./label_defaults'); -module.exports = function(traceIn, traceOut, coerce, layout, opts) { +module.exports = function handleStyleDefaults(traceIn, traceOut, coerce, layout, opts) { var coloring = coerce('contours.coloring'); var showLines; diff --git a/src/traces/contourcarpet/calc.js b/src/traces/contourcarpet/calc.js index f09810c44a9..07d5919ab34 100644 --- a/src/traces/contourcarpet/calc.js +++ b/src/traces/contourcarpet/calc.js @@ -23,7 +23,7 @@ var setContours = require('../contour/set_contours'); // most is the same as heatmap calc, then adjust it // though a few things inside heatmap calc still look for // contour maps, because the makeBoundArray calls are too entangled -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var carpet = trace._carpetTrace = lookupCarpet(gd, trace); if(!carpet || !carpet.visible || carpet.visible === 'legendonly') return; diff --git a/src/traces/contourcarpet/defaults.js b/src/traces/contourcarpet/defaults.js index 76bfc1863aa..671b9eb3e7a 100644 --- a/src/traces/contourcarpet/defaults.js +++ b/src/traces/contourcarpet/defaults.js @@ -17,7 +17,7 @@ var handleConstraintDefaults = require('../contour/constraint_defaults'); var handleContoursDefaults = require('../contour/contours_defaults'); var handleStyleDefaults = require('../contour/style_defaults'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/contourcarpet/join_all_paths.js b/src/traces/contourcarpet/join_all_paths.js index eb741deef26..6aa1653cde9 100644 --- a/src/traces/contourcarpet/join_all_paths.js +++ b/src/traces/contourcarpet/join_all_paths.js @@ -12,7 +12,7 @@ var Drawing = require('../../components/drawing'); var axisAlignedLine = require('../carpet/axis_aligned_line'); var Lib = require('../../lib'); -module.exports = function(trace, pi, perimeter, ab2p, carpet, carpetcd, xa, ya) { +module.exports = function joinAllPaths(trace, pi, perimeter, ab2p, carpet, carpetcd, xa, ya) { var i; var fullpath = ''; diff --git a/src/traces/contourcarpet/map_pathinfo.js b/src/traces/contourcarpet/map_pathinfo.js index 3f9bfdf2612..16278d1c364 100644 --- a/src/traces/contourcarpet/map_pathinfo.js +++ b/src/traces/contourcarpet/map_pathinfo.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(pathinfo, map) { +module.exports = function mapPathinfo(pathinfo, map) { var i, j, k, pi, pedgepaths, ppaths, pedgepath, ppath, path; for(i = 0; i < pathinfo.length; i++) { diff --git a/src/traces/contourcarpet/plot.js b/src/traces/contourcarpet/plot.js index 06e02d2dcba..97b9813d7c5 100644 --- a/src/traces/contourcarpet/plot.js +++ b/src/traces/contourcarpet/plot.js @@ -25,7 +25,7 @@ var mapPathinfo = require('./map_pathinfo'); var lookupCarpet = require('../carpet/lookup_carpetid'); var closeBoundaries = require('../contour/close_boundaries'); -module.exports = function(gd, plotinfo, cdcontours, contourcarpetLayer) { +module.exports = function plot(gd, plotinfo, cdcontours, contourcarpetLayer) { var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; diff --git a/src/traces/heatmap/calc.js b/src/traces/heatmap/calc.js index 408d57bb99b..f86bb23ed37 100644 --- a/src/traces/heatmap/calc.js +++ b/src/traces/heatmap/calc.js @@ -22,7 +22,7 @@ var findEmpties = require('./find_empties'); var makeBoundArray = require('./make_bound_array'); -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { // prepare the raw data // run makeCalcdata on x and y even for heatmaps, in case of category mappings var xa = Axes.getFromId(gd, trace.xaxis || 'x'); diff --git a/src/traces/heatmap/clean_2d_array.js b/src/traces/heatmap/clean_2d_array.js index 8c1f31cab54..74d6fa84db4 100644 --- a/src/traces/heatmap/clean_2d_array.js +++ b/src/traces/heatmap/clean_2d_array.js @@ -10,7 +10,7 @@ var isNumeric = require('fast-isnumeric'); -module.exports = function(zOld, transpose) { +module.exports = function clean2dArray(zOld, transpose) { var rowlen, collen, getCollen, old2new, i, j; function cleanZvalue(v) { diff --git a/src/traces/heatmap/convert_column_xyz.js b/src/traces/heatmap/convert_column_xyz.js index 0960fefb5c2..ace8224f877 100644 --- a/src/traces/heatmap/convert_column_xyz.js +++ b/src/traces/heatmap/convert_column_xyz.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function(trace, ax1, ax2, var1Name, var2Name, arrayVarNames) { +module.exports = function convertColumnData(trace, ax1, ax2, var1Name, var2Name, arrayVarNames) { var colLen = trace._length; var col1 = ax1.makeCalcdata(trace, var1Name); var col2 = ax2.makeCalcdata(trace, var2Name); diff --git a/src/traces/heatmap/defaults.js b/src/traces/heatmap/defaults.js index 4d7b531a8a6..a245af88d95 100644 --- a/src/traces/heatmap/defaults.js +++ b/src/traces/heatmap/defaults.js @@ -17,7 +17,7 @@ var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/heatmap/find_empties.js b/src/traces/heatmap/find_empties.js index c97dcaa2126..43e010e5dce 100644 --- a/src/traces/heatmap/find_empties.js +++ b/src/traces/heatmap/find_empties.js @@ -17,7 +17,7 @@ var maxRowLength = require('../../lib').maxRowLength; * if no neighbors exist, we iteratively look for neighbors that HAVE * neighbors, and add a fractional neighborCount */ -module.exports = function(z) { +module.exports = function findEmpties(z) { var empties = []; var neighborHash = {}; var noNeighborList = []; diff --git a/src/traces/heatmap/hover.js b/src/traces/heatmap/hover.js index 498340b35ab..cfc2e72f0c2 100644 --- a/src/traces/heatmap/hover.js +++ b/src/traces/heatmap/hover.js @@ -13,7 +13,7 @@ var Fx = require('../../components/fx'); var Lib = require('../../lib'); var Axes = require('../../plots/cartesian/axes'); -module.exports = function(pointData, xval, yval, hovermode, hoverLayer, contour) { +module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLayer, contour) { var cd0 = pointData.cd[0]; var trace = cd0.trace; var xa = pointData.xa; diff --git a/src/traces/heatmap/interp2d.js b/src/traces/heatmap/interp2d.js index dc17272813a..a3a5e231989 100644 --- a/src/traces/heatmap/interp2d.js +++ b/src/traces/heatmap/interp2d.js @@ -35,7 +35,7 @@ function correctionOvershoot(maxFractionalChange) { * of neighbors that are *not* missing. Assumed to be sorted from most to * least neighbors, as produced by heatmap/find_empties. */ -module.exports = function(z, emptyPoints) { +module.exports = function interp2d(z, emptyPoints) { var maxFractionalChange = 1; var i; diff --git a/src/traces/heatmap/make_bound_array.js b/src/traces/heatmap/make_bound_array.js index f587ecc6f7d..6a020ae44dc 100644 --- a/src/traces/heatmap/make_bound_array.js +++ b/src/traces/heatmap/make_bound_array.js @@ -11,7 +11,7 @@ var Registry = require('../../registry'); var isArrayOrTypedArray = require('../../lib').isArrayOrTypedArray; -module.exports = function(trace, arrayIn, v0In, dvIn, numbricks, ax) { +module.exports = function makeBoundArray(trace, arrayIn, v0In, dvIn, numbricks, ax) { var arrayOut = []; var isContour = Registry.traceIs(trace, 'contour'); var isHist = Registry.traceIs(trace, 'histogram'); diff --git a/src/traces/heatmap/style.js b/src/traces/heatmap/style.js index 05cc5ec344f..3e902b13b0d 100644 --- a/src/traces/heatmap/style.js +++ b/src/traces/heatmap/style.js @@ -11,7 +11,7 @@ var d3 = require('d3'); -module.exports = function(gd) { +module.exports = function style(gd) { d3.select(gd).selectAll('.hm image') .style('opacity', function(d) { return d.trace.opacity; diff --git a/src/traces/heatmap/style_defaults.js b/src/traces/heatmap/style_defaults.js index d769a4a3ff8..49d00e63764 100644 --- a/src/traces/heatmap/style_defaults.js +++ b/src/traces/heatmap/style_defaults.js @@ -9,7 +9,7 @@ 'use strict'; -module.exports = function(traceIn, traceOut, coerce) { +module.exports = function handleStyleDefaults(traceIn, traceOut, coerce) { var zsmooth = coerce('zsmooth'); if(zsmooth === false) { // ensure that xgap and ygap are coerced only when zsmooth allows them to have an effect. diff --git a/src/traces/heatmap/xyz_defaults.js b/src/traces/heatmap/xyz_defaults.js index ba604066deb..d84de5861db 100644 --- a/src/traces/heatmap/xyz_defaults.js +++ b/src/traces/heatmap/xyz_defaults.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var Registry = require('../../registry'); -module.exports = function(traceIn, traceOut, coerce, layout, xName, yName) { +module.exports = function handleXYZDefaults(traceIn, traceOut, coerce, layout, xName, yName) { var z = coerce('z'); xName = xName || 'x'; yName = yName || 'y'; diff --git a/src/traces/histogram/average.js b/src/traces/histogram/average.js index dae8d8d709f..c52617eef0f 100644 --- a/src/traces/histogram/average.js +++ b/src/traces/histogram/average.js @@ -10,7 +10,7 @@ 'use strict'; -module.exports = function(size, counts) { +module.exports = function doAvg(size, counts) { var nMax = size.length; var total = 0; for(var i = 0; i < nMax; i++) { diff --git a/src/traces/histogram/bin_attributes.js b/src/traces/histogram/bin_attributes.js index 832474e8337..33c2a1b475d 100644 --- a/src/traces/histogram/bin_attributes.js +++ b/src/traces/histogram/bin_attributes.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(axLetter, match) { +module.exports = function makeBinAttrs(axLetter, match) { return { start: { valType: 'any', // for date axes diff --git a/src/traces/histogram/bin_label_vals.js b/src/traces/histogram/bin_label_vals.js index f63c9530250..c6422ff62a9 100644 --- a/src/traces/histogram/bin_label_vals.js +++ b/src/traces/histogram/bin_label_vals.js @@ -30,7 +30,7 @@ var tickIncrement = require('../../plots/cartesian/axes').tickIncrement; * @return {function(v, isRightEdge)}: * find the start (isRightEdge is falsy) or end (truthy) label value for a bin edge `v` */ -module.exports = function(leftGap, rightGap, binEdges, pa, calendar) { +module.exports = function getBinSpanLabelRound(leftGap, rightGap, binEdges, pa, calendar) { // the rounding digit is the largest digit that changes in *all* of 4 regions: // - inside the rightGap before binEdges[0] (shifted 10% to the left) // - inside the leftGap after binEdges[0] (expanded by 10% of rightGap on each end) diff --git a/src/traces/histogram/calc.js b/src/traces/histogram/calc.js index 4de1d5f3be3..c4388db82e2 100644 --- a/src/traces/histogram/calc.js +++ b/src/traces/histogram/calc.js @@ -20,7 +20,7 @@ var normFunctions = require('./norm_functions'); var doAvg = require('./average'); var getBinSpanLabelRound = require('./bin_label_vals'); -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { // ignore as much processing as possible (and including in autorange) if not visible if(trace.visible !== true) return; diff --git a/src/traces/histogram/cross_trace_defaults.js b/src/traces/histogram/cross_trace_defaults.js index 47c4e7aaf58..0a7663cc43d 100644 --- a/src/traces/histogram/cross_trace_defaults.js +++ b/src/traces/histogram/cross_trace_defaults.js @@ -31,7 +31,7 @@ var BINATTRS = { }; // handle bin attrs and relink auto-determined values so fullData is complete -module.exports = function(fullData, fullLayout) { +module.exports = function crossTraceDefaults(fullData, fullLayout) { var allBinOpts = fullLayout._histogramBinOpts = {}; var isOverlay = fullLayout.barmode === 'overlay'; var i, j, traceOut, traceIn, binDirection, group, binOpts; diff --git a/src/traces/histogram/defaults.js b/src/traces/histogram/defaults.js index a1cbfeeebde..6a79d02e5ca 100644 --- a/src/traces/histogram/defaults.js +++ b/src/traces/histogram/defaults.js @@ -15,7 +15,7 @@ var Color = require('../../components/color'); var handleStyleDefaults = require('../bar/style_defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/histogram/event_data.js b/src/traces/histogram/event_data.js index 06e4f9a779e..ab5ac4f41a3 100644 --- a/src/traces/histogram/event_data.js +++ b/src/traces/histogram/event_data.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(out, pt, trace, cd, pointNumber) { +module.exports = function eventData(out, pt, trace, cd, pointNumber) { // standard cartesian event data out.x = 'xVal' in pt ? pt.xVal : pt.x; out.y = 'yVal' in pt ? pt.yVal : pt.y; diff --git a/src/traces/histogram/hover.js b/src/traces/histogram/hover.js index 45bd610076e..78990ef98ba 100644 --- a/src/traces/histogram/hover.js +++ b/src/traces/histogram/hover.js @@ -12,7 +12,7 @@ var barHover = require('../bar/hover').hoverPoints; var hoverLabelText = require('../../plots/cartesian/axes').hoverLabelText; -module.exports = function(pointData, xval, yval, hovermode) { +module.exports = function hoverPoints(pointData, xval, yval, hovermode) { var pts = barHover(pointData, xval, yval, hovermode); if(!pts) return; diff --git a/src/traces/histogram2d/calc.js b/src/traces/histogram2d/calc.js index d92c59dffd1..4ca78cee96c 100644 --- a/src/traces/histogram2d/calc.js +++ b/src/traces/histogram2d/calc.js @@ -18,7 +18,7 @@ var doAvg = require('../histogram/average'); var getBinSpanLabelRound = require('../histogram/bin_label_vals'); -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var xa = Axes.getFromId(gd, trace.xaxis || 'x'); var x = trace.x ? xa.makeCalcdata(trace, 'x') : []; var ya = Axes.getFromId(gd, trace.yaxis || 'y'); diff --git a/src/traces/histogram2d/cross_trace_defaults.js b/src/traces/histogram2d/cross_trace_defaults.js index c677a77c7c2..24b78826a0b 100644 --- a/src/traces/histogram2d/cross_trace_defaults.js +++ b/src/traces/histogram2d/cross_trace_defaults.js @@ -23,7 +23,7 @@ var BINDIRECTIONS = ['x', 'y']; // Handle bin attrs and relink auto-determined values so fullData is complete // does not have cross-trace coupling, but moved out here so we have axis types // and relinked trace._autoBin -module.exports = function(fullData, fullLayout) { +module.exports = function crossTraceDefaults(fullData, fullLayout) { var i, j, traceOut, binDirection; function coerce(attr) { diff --git a/src/traces/histogram2d/defaults.js b/src/traces/histogram2d/defaults.js index f8aa93fb9a0..3f0ea3f206c 100644 --- a/src/traces/histogram2d/defaults.js +++ b/src/traces/histogram2d/defaults.js @@ -17,7 +17,7 @@ var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/histogram2d/hover.js b/src/traces/histogram2d/hover.js index a470412df91..ee9d8c657b6 100644 --- a/src/traces/histogram2d/hover.js +++ b/src/traces/histogram2d/hover.js @@ -12,7 +12,7 @@ var heatmapHover = require('../heatmap/hover'); var hoverLabelText = require('../../plots/cartesian/axes').hoverLabelText; -module.exports = function(pointData, xval, yval, hovermode, hoverLayer, contour) { +module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLayer, contour) { var pts = heatmapHover(pointData, xval, yval, hovermode, hoverLayer, contour); if(!pts) return; diff --git a/src/traces/histogram2d/sample_defaults.js b/src/traces/histogram2d/sample_defaults.js index ba0d1c71ec4..9c685c9b04f 100644 --- a/src/traces/histogram2d/sample_defaults.js +++ b/src/traces/histogram2d/sample_defaults.js @@ -11,7 +11,7 @@ var Registry = require('../../registry'); var Lib = require('../../lib'); -module.exports = function(traceIn, traceOut, coerce, layout) { +module.exports = function handleSampleDefaults(traceIn, traceOut, coerce, layout) { var x = coerce('x'); var y = coerce('y'); var xlen = Lib.minRowLength(x); diff --git a/src/traces/histogram2dcontour/defaults.js b/src/traces/histogram2dcontour/defaults.js index f05b0ce3c8e..a4792f149f7 100644 --- a/src/traces/histogram2dcontour/defaults.js +++ b/src/traces/histogram2dcontour/defaults.js @@ -17,7 +17,7 @@ var handleStyleDefaults = require('../contour/style_defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/isosurface/calc.js b/src/traces/isosurface/calc.js index 4cbdfcbb414..1c428c2ccc9 100644 --- a/src/traces/isosurface/calc.js +++ b/src/traces/isosurface/calc.js @@ -10,7 +10,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { trace._len = Math.min(trace.x.length, trace.y.length, trace.z.length, trace.value.length); var min = Infinity; diff --git a/src/traces/mesh3d/calc.js b/src/traces/mesh3d/calc.js index 8a299273d67..92b6a14d13d 100644 --- a/src/traces/mesh3d/calc.js +++ b/src/traces/mesh3d/calc.js @@ -10,7 +10,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { if(trace.intensity) { colorscaleCalc(gd, trace, { vals: trace.intensity, diff --git a/src/traces/mesh3d/defaults.js b/src/traces/mesh3d/defaults.js index 0673b3631e4..d4b5c6fcb89 100644 --- a/src/traces/mesh3d/defaults.js +++ b/src/traces/mesh3d/defaults.js @@ -14,7 +14,7 @@ var Lib = require('../../lib'); var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/ohlc/defaults.js b/src/traces/ohlc/defaults.js index 95f63dc861a..32723023ba4 100644 --- a/src/traces/ohlc/defaults.js +++ b/src/traces/ohlc/defaults.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var handleOHLC = require('./ohlc_defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/ohlc/ohlc_defaults.js b/src/traces/ohlc/ohlc_defaults.js index 765a7f1b502..a15bed6d30a 100644 --- a/src/traces/ohlc/ohlc_defaults.js +++ b/src/traces/ohlc/ohlc_defaults.js @@ -11,7 +11,7 @@ var Registry = require('../../registry'); var Lib = require('../../lib'); -module.exports = function(traceIn, traceOut, coerce, layout) { +module.exports = function handleOHLC(traceIn, traceOut, coerce, layout) { var x = coerce('x'); var open = coerce('open'); var high = coerce('high'); diff --git a/src/traces/ohlc/plot.js b/src/traces/ohlc/plot.js index 5575bb87bf4..80ef9dc048b 100644 --- a/src/traces/ohlc/plot.js +++ b/src/traces/ohlc/plot.js @@ -12,7 +12,7 @@ var d3 = require('d3'); var Lib = require('../../lib'); -module.exports = function(gd, plotinfo, cdOHLC, ohlcLayer) { +module.exports = function plot(gd, plotinfo, cdOHLC, ohlcLayer) { var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; diff --git a/src/traces/ohlc/select.js b/src/traces/ohlc/select.js index e4be427e52e..770a187977e 100644 --- a/src/traces/ohlc/select.js +++ b/src/traces/ohlc/select.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(searchInfo, selectionTester) { +module.exports = function selectPoints(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/ohlc/style.js b/src/traces/ohlc/style.js index 8c46ccb6eda..a708d108b1f 100644 --- a/src/traces/ohlc/style.js +++ b/src/traces/ohlc/style.js @@ -12,7 +12,7 @@ var d3 = require('d3'); var Drawing = require('../../components/drawing'); var Color = require('../../components/color'); -module.exports = function(gd, cd) { +module.exports = function style(gd, cd) { var s = cd ? cd[0].node3 : d3.select(gd).selectAll('g.ohlclayer').selectAll('g.trace'); s.style('opacity', function(d) { diff --git a/src/traces/parcats/calc.js b/src/traces/parcats/calc.js index 03b0b2c3a02..9310e922040 100644 --- a/src/traces/parcats/calc.js +++ b/src/traces/parcats/calc.js @@ -25,7 +25,7 @@ var Lib = require('../../lib'); * @param {Object} trace * @return {Array.} */ -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var visibleDims = Lib.filterVisible(trace.dimensions); if(visibleDims.length === 0) return []; diff --git a/src/traces/parcats/defaults.js b/src/traces/parcats/defaults.js index 7dd769b4c8c..a4edf1d82ba 100644 --- a/src/traces/parcats/defaults.js +++ b/src/traces/parcats/defaults.js @@ -74,7 +74,7 @@ function dimensionDefaults(dimensionIn, dimensionOut) { } } -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/parcats/plot.js b/src/traces/parcats/plot.js index 4e2412b436d..a8730fe0643 100644 --- a/src/traces/parcats/plot.js +++ b/src/traces/parcats/plot.js @@ -17,7 +17,7 @@ var parcats = require('./parcats'); * @param {Object} graphDiv * @param {Array.} parcatsModels */ -module.exports = function(graphDiv, parcatsModels, transitionOpts, makeOnCompleteCallback) { +module.exports = function plot(graphDiv, parcatsModels, transitionOpts, makeOnCompleteCallback) { var fullLayout = graphDiv._fullLayout; var svg = fullLayout._paper; var size = fullLayout._size; diff --git a/src/traces/parcoords/axisbrush.js b/src/traces/parcoords/axisbrush.js index af8afa36e2f..e84c53c4438 100644 --- a/src/traces/parcoords/axisbrush.js +++ b/src/traces/parcoords/axisbrush.js @@ -429,7 +429,7 @@ function brushClear(brush) { } function axisBrushMoved(callback) { - return function(dimension) { + return function axisBrushMoved(dimension) { var brush = dimension.brush; var extent = getBrushExtent(brush); var newExtent = extent.slice(); diff --git a/src/traces/parcoords/calc.js b/src/traces/parcoords/calc.js index b6b2e5c2039..8dbdb84d156 100644 --- a/src/traces/parcoords/calc.js +++ b/src/traces/parcoords/calc.js @@ -13,7 +13,7 @@ var calcColorscale = require('../../components/colorscale/calc'); var Lib = require('../../lib'); var wrap = require('../../lib/gup').wrap; -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { for(var i = 0; i < trace.dimensions.length; i++) { trace.dimensions[i].values = convertTypedArray(trace.dimensions[i].values); } diff --git a/src/traces/parcoords/defaults.js b/src/traces/parcoords/defaults.js index 432bf2522d7..5d96dd4c8e4 100644 --- a/src/traces/parcoords/defaults.js +++ b/src/traces/parcoords/defaults.js @@ -63,7 +63,7 @@ function dimensionDefaults(dimensionIn, dimensionOut) { } } -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/parcoords/plot.js b/src/traces/parcoords/plot.js index 4d716ee41ea..4a30b185fa3 100644 --- a/src/traces/parcoords/plot.js +++ b/src/traces/parcoords/plot.js @@ -11,7 +11,7 @@ var parcoords = require('./parcoords'); var prepareRegl = require('../../lib/prepare_regl'); -module.exports = function(gd, cdparcoords) { +module.exports = function plot(gd, cdparcoords) { var fullLayout = gd._fullLayout; var svg = fullLayout._toppaper; var root = fullLayout._paperdiv; @@ -97,7 +97,7 @@ module.exports = function(gd, cdparcoords) { } function sorter(orig) { - return function(d1, d2) { + return function sorter(d1, d2) { var i1 = newIdx(visibleIndices, orig, d1); var i2 = newIdx(visibleIndices, orig, d2); return i1 - i2; diff --git a/src/traces/pie/calc.js b/src/traces/pie/calc.js index dd6cd243e65..f918f51ba30 100644 --- a/src/traces/pie/calc.js +++ b/src/traces/pie/calc.js @@ -112,7 +112,7 @@ function calc(gd, trace) { } function makePullColorFn(colorMap) { - return function(color, id) { + return function pullColor(color, id) { if(!color) return false; color = tinycolor(color); diff --git a/src/traces/pie/defaults.js b/src/traces/pie/defaults.js index 2bda60aad90..52aea7bfc7b 100644 --- a/src/traces/pie/defaults.js +++ b/src/traces/pie/defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var attributes = require('./attributes'); var handleDomainDefaults = require('../../plots/domain').defaults; -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/pie/event_data.js b/src/traces/pie/event_data.js index 22e5aaf11a3..2583a24628d 100644 --- a/src/traces/pie/event_data.js +++ b/src/traces/pie/event_data.js @@ -15,7 +15,7 @@ var appendArrayMultiPointValues = require('../../components/fx/helpers').appendA // Note: like other eventData routines, this creates the data for hover/unhover/click events // but it has a different API and goes through a totally different pathway. // So to ensure it doesn't get misused, it's not attached to the Pie module. -module.exports = function(pt, trace) { +module.exports = function eventData(pt, trace) { var out = { curveNumber: trace.index, pointNumbers: pt.pts, diff --git a/src/traces/pie/helpers.js b/src/traces/pie/helpers.js index 785009d7e31..719a385d704 100644 --- a/src/traces/pie/helpers.js +++ b/src/traces/pie/helpers.js @@ -10,7 +10,7 @@ var Lib = require('../../lib'); -exports.formatPiePercent = function(v, separators) { +exports.formatPiePercent = function formatPiePercent(v, separators) { var vRounded = (v * 100).toPrecision(3); if(vRounded.lastIndexOf('.') !== -1) { vRounded = vRounded.replace(/[.]?0+$/, ''); @@ -18,7 +18,7 @@ exports.formatPiePercent = function(v, separators) { return Lib.numSeparate(vRounded, separators) + '%'; }; -exports.formatPieValue = function(v, separators) { +exports.formatPieValue = function formatPieValue(v, separators) { var vRounded = v.toPrecision(10); if(vRounded.lastIndexOf('.') !== -1) { vRounded = vRounded.replace(/[.]?0+$/, ''); @@ -26,7 +26,7 @@ exports.formatPieValue = function(v, separators) { return Lib.numSeparate(vRounded, separators); }; -exports.getFirstFilled = function(array, indices) { +exports.getFirstFilled = function getFirstFilled(array, indices) { if(!Array.isArray(array)) return; for(var i = 0; i < indices.length; i++) { var v = array[indices[i]]; @@ -34,7 +34,7 @@ exports.getFirstFilled = function(array, indices) { } }; -exports.castOption = function(item, indices) { +exports.castOption = function castOption(item, indices) { if(Array.isArray(item)) return exports.getFirstFilled(item, indices); else if(item) return item; }; diff --git a/src/traces/pie/layout_defaults.js b/src/traces/pie/layout_defaults.js index 45f34fea769..a38ef5890e2 100644 --- a/src/traces/pie/layout_defaults.js +++ b/src/traces/pie/layout_defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var layoutAttributes = require('./layout_attributes'); -module.exports = function(layoutIn, layoutOut) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) { function coerce(attr, dflt) { return Lib.coerce(layoutIn, layoutOut, layoutAttributes, attr, dflt); } diff --git a/src/traces/pie/style.js b/src/traces/pie/style.js index 4bc3bb89d60..86b1e46cc0b 100644 --- a/src/traces/pie/style.js +++ b/src/traces/pie/style.js @@ -12,7 +12,7 @@ var d3 = require('d3'); var styleOne = require('./style_one'); -module.exports = function(gd) { +module.exports = function style(gd) { gd._fullLayout._pielayer.selectAll('.trace').each(function(cd) { var cd0 = cd[0]; var trace = cd0.trace; diff --git a/src/traces/pie/style_one.js b/src/traces/pie/style_one.js index cd6078178e4..c0bd60d367f 100644 --- a/src/traces/pie/style_one.js +++ b/src/traces/pie/style_one.js @@ -11,7 +11,7 @@ var Color = require('../../components/color'); var castOption = require('./helpers').castOption; -module.exports = function(s, pt, trace) { +module.exports = function styleOne(s, pt, trace) { var line = trace.marker.line; var lineColor = castOption(line.color, pt.pts) || Color.defaultLine; var lineWidth = castOption(line.width, pt.pts) || 0; diff --git a/src/traces/pointcloud/defaults.js b/src/traces/pointcloud/defaults.js index ca18f80e2d9..ffab33e9a64 100644 --- a/src/traces/pointcloud/defaults.js +++ b/src/traces/pointcloud/defaults.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/sankey/calc.js b/src/traces/sankey/calc.js index b1953935b7f..319eb8de82d 100644 --- a/src/traces/sankey/calc.js +++ b/src/traces/sankey/calc.js @@ -168,7 +168,7 @@ function circularityPresent(nodeLen, sources, targets) { }); } -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var result = convertToD3Sankey(trace); return wrap({ diff --git a/src/traces/sankey/defaults.js b/src/traces/sankey/defaults.js index 19fb36d9cf3..a82706c3cb4 100644 --- a/src/traces/sankey/defaults.js +++ b/src/traces/sankey/defaults.js @@ -17,7 +17,7 @@ var handleHoverLabelDefaults = require('../../components/fx/hoverlabel_defaults' var Template = require('../../plot_api/plot_template'); var handleArrayContainerDefaults = require('../../plots/array_container_defaults'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/sankey/plot.js b/src/traces/sankey/plot.js index 9fe89dfd7cd..efca619c727 100644 --- a/src/traces/sankey/plot.js +++ b/src/traces/sankey/plot.js @@ -122,7 +122,7 @@ function castHoverOption(trace, attr) { return Array.isArray(val) ? false : val; } -module.exports = function(gd, calcData) { +module.exports = function plot(gd, calcData) { var fullLayout = gd._fullLayout; var svg = fullLayout._paper; var size = fullLayout._size; diff --git a/src/traces/sankey/render.js b/src/traces/sankey/render.js index e7a0117273b..4cf93a539fc 100644 --- a/src/traces/sankey/render.js +++ b/src/traces/sankey/render.js @@ -722,7 +722,7 @@ function startForce(sankeyNode, sankeyLink, d, forceKey, gd) { } function snappingForce(sankeyNode, forceKey, nodes, d) { - return function() { + return function _snappingForce() { var maxVelocity = 0; for(var i = 0; i < nodes.length; i++) { var n = nodes[i]; diff --git a/src/traces/sankey/select.js b/src/traces/sankey/select.js index e78e33d690e..f1f6d3beb11 100644 --- a/src/traces/sankey/select.js +++ b/src/traces/sankey/select.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(searchInfo, selectionTester) { +module.exports = function selectPoints(searchInfo, selectionTester) { var cd = searchInfo.cd; var selection = []; var fullData = cd[0].trace; diff --git a/src/traces/scatter/arrays_to_calcdata.js b/src/traces/scatter/arrays_to_calcdata.js index 441b3ea2ee7..ee83c3aac31 100644 --- a/src/traces/scatter/arrays_to_calcdata.js +++ b/src/traces/scatter/arrays_to_calcdata.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); // arrayOk attributes, merge them into calcdata array -module.exports = function(cd, trace) { +module.exports = function arraysToCalcdata(cd, trace) { // so each point knows which index it originally came from for(var i = 0; i < cd.length; i++) cd[i].i = i; diff --git a/src/traces/scatter/calc_selection.js b/src/traces/scatter/calc_selection.js index 3f3b050277d..80d2d99061c 100644 --- a/src/traces/scatter/calc_selection.js +++ b/src/traces/scatter/calc_selection.js @@ -10,7 +10,7 @@ var Lib = require('../../lib'); -module.exports = function(cd, trace) { +module.exports = function calcSelection(cd, trace) { if(Lib.isArrayOrTypedArray(trace.selectedpoints)) { Lib.tagSelected(cd, trace); } diff --git a/src/traces/scatter/colorscale_calc.js b/src/traces/scatter/colorscale_calc.js index 6edad1c07ad..d103dd09fee 100644 --- a/src/traces/scatter/colorscale_calc.js +++ b/src/traces/scatter/colorscale_calc.js @@ -13,7 +13,7 @@ var calcColorscale = require('../../components/colorscale/calc'); var subTypes = require('./subtypes'); -module.exports = function(gd, trace) { +module.exports = function calcMarkerColorscale(gd, trace) { if(subTypes.hasLines(trace) && hasColorscale(trace, 'line')) { calcColorscale(gd, trace, { vals: trace.line.color, diff --git a/src/traces/scatter/cross_trace_calc.js b/src/traces/scatter/cross_trace_calc.js index c6f93034128..47ac386e9da 100644 --- a/src/traces/scatter/cross_trace_calc.js +++ b/src/traces/scatter/cross_trace_calc.js @@ -16,7 +16,7 @@ var calc = require('./calc'); * runs per subplot, and can handle multiple stacking groups */ -module.exports = function(gd, plotinfo) { +module.exports = function crossTraceCalc(gd, plotinfo) { var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; var subplot = xa._id + ya._id; diff --git a/src/traces/scatter/cross_trace_defaults.js b/src/traces/scatter/cross_trace_defaults.js index c9a6b553769..f51f5d73b8c 100644 --- a/src/traces/scatter/cross_trace_defaults.js +++ b/src/traces/scatter/cross_trace_defaults.js @@ -11,7 +11,7 @@ // remove opacity for any trace that has a fill or is filled to -module.exports = function(fullData) { +module.exports = function crossTraceDefaults(fullData) { for(var i = 0; i < fullData.length; i++) { var tracei = fullData[i]; if(tracei.type !== 'scatter') continue; diff --git a/src/traces/scatter/defaults.js b/src/traces/scatter/defaults.js index 546a03fee40..3ff337d0e57 100644 --- a/src/traces/scatter/defaults.js +++ b/src/traces/scatter/defaults.js @@ -22,7 +22,7 @@ var handleLineShapeDefaults = require('./line_shape_defaults'); var handleTextDefaults = require('./text_defaults'); var handleFillColorDefaults = require('./fillcolor_defaults'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scatter/fill_hover_text.js b/src/traces/scatter/fill_hover_text.js index dc970ea1e9a..ca925844e8e 100644 --- a/src/traces/scatter/fill_hover_text.js +++ b/src/traces/scatter/fill_hover_text.js @@ -23,7 +23,7 @@ var Lib = require('../../lib'); * @param {object} trace * @param {object || array} contOut (mutated here) */ -module.exports = function(calcPt, trace, contOut) { +module.exports = function fillHoverText(calcPt, trace, contOut) { var fill = Array.isArray(contOut) ? function(v) { contOut.push(v); } : function(v) { contOut.text = v; }; diff --git a/src/traces/scatter/fillcolor_defaults.js b/src/traces/scatter/fillcolor_defaults.js index 67ec341fd0f..f3d8cd49c3e 100644 --- a/src/traces/scatter/fillcolor_defaults.js +++ b/src/traces/scatter/fillcolor_defaults.js @@ -12,7 +12,7 @@ var Color = require('../../components/color'); var isArrayOrTypedArray = require('../../lib').isArrayOrTypedArray; -module.exports = function(traceIn, traceOut, defaultColor, coerce) { +module.exports = function fillColorDefaults(traceIn, traceOut, defaultColor, coerce) { var inheritColorFromMarker = false; if(traceOut.marker) { diff --git a/src/traces/scatter/get_trace_color.js b/src/traces/scatter/get_trace_color.js index 79435f07848..b51014641a3 100644 --- a/src/traces/scatter/get_trace_color.js +++ b/src/traces/scatter/get_trace_color.js @@ -13,7 +13,7 @@ var Color = require('../../components/color'); var subtypes = require('./subtypes'); -module.exports = function(trace, di) { +module.exports = function getTraceColor(trace, di) { var lc, tc; // TODO: text modes diff --git a/src/traces/scatter/hover.js b/src/traces/scatter/hover.js index 7176abcce04..f75f5308552 100644 --- a/src/traces/scatter/hover.js +++ b/src/traces/scatter/hover.js @@ -15,7 +15,7 @@ var getTraceColor = require('./get_trace_color'); var Color = require('../../components/color'); var fillHoverText = require('./fill_hover_text'); -module.exports = function(pointData, xval, yval, hovermode) { +module.exports = function hoverPoints(pointData, xval, yval, hovermode) { var cd = pointData.cd; var trace = cd[0].trace; var xa = pointData.xa; diff --git a/src/traces/scatter/line_defaults.js b/src/traces/scatter/line_defaults.js index e2a3b6645e1..4139af84d5f 100644 --- a/src/traces/scatter/line_defaults.js +++ b/src/traces/scatter/line_defaults.js @@ -12,7 +12,7 @@ var isArrayOrTypedArray = require('../../lib').isArrayOrTypedArray; var hasColorscale = require('../../components/colorscale/helpers').hasColorscale; var colorscaleDefaults = require('../../components/colorscale/defaults'); -module.exports = function(traceIn, traceOut, defaultColor, layout, coerce, opts) { +module.exports = function lineDefaults(traceIn, traceOut, defaultColor, layout, coerce, opts) { var markerColor = (traceIn.marker || {}).color; coerce('line.color', defaultColor); diff --git a/src/traces/scatter/line_points.js b/src/traces/scatter/line_points.js index 4cd9c08e849..2943f2673bb 100644 --- a/src/traces/scatter/line_points.js +++ b/src/traces/scatter/line_points.js @@ -20,7 +20,7 @@ var constrain = Lib.constrain; var constants = require('./constants'); -module.exports = function(d, opts) { +module.exports = function linePoints(d, opts) { var xa = opts.xaxis; var ya = opts.yaxis; var xLog = xa.type === 'log'; diff --git a/src/traces/scatter/line_shape_defaults.js b/src/traces/scatter/line_shape_defaults.js index 0eb36aa04d8..e4e34e6d3a4 100644 --- a/src/traces/scatter/line_shape_defaults.js +++ b/src/traces/scatter/line_shape_defaults.js @@ -11,7 +11,7 @@ // common to 'scatter' and 'scatterternary' -module.exports = function(traceIn, traceOut, coerce) { +module.exports = function handleLineShapeDefaults(traceIn, traceOut, coerce) { var shape = coerce('line.shape'); if(shape === 'spline') coerce('line.smoothing'); }; diff --git a/src/traces/scatter/link_traces.js b/src/traces/scatter/link_traces.js index 2d048f7d6f5..00dd070d907 100644 --- a/src/traces/scatter/link_traces.js +++ b/src/traces/scatter/link_traces.js @@ -10,7 +10,7 @@ var LINKEDFILLS = {tonextx: 1, tonexty: 1, tonext: 1}; -module.exports = function(gd, plotinfo, cdscatter) { +module.exports = function linkTraces(gd, plotinfo, cdscatter) { var trace, i, group, prevtrace, groupIndex; // first sort traces to keep stacks & filled-together groups together diff --git a/src/traces/scatter/make_bubble_size_func.js b/src/traces/scatter/make_bubble_size_func.js index d5536b8f62a..9263cd9151f 100644 --- a/src/traces/scatter/make_bubble_size_func.js +++ b/src/traces/scatter/make_bubble_size_func.js @@ -14,7 +14,7 @@ var isNumeric = require('fast-isnumeric'); // used in the drawing step for 'scatter' and 'scattegeo' and // in the convert step for 'scatter3d' -module.exports = function(trace) { +module.exports = function makeBubbleSizeFn(trace) { var marker = trace.marker; var sizeRef = marker.sizeref || 1; var sizeMin = marker.sizemin || 0; diff --git a/src/traces/scatter/marker_defaults.js b/src/traces/scatter/marker_defaults.js index 1626c888265..7c894777ff9 100644 --- a/src/traces/scatter/marker_defaults.js +++ b/src/traces/scatter/marker_defaults.js @@ -20,7 +20,7 @@ var subTypes = require('./subtypes'); * gradient: caller supports gradients * noSelect: caller does not support selected/unselected attribute containers */ -module.exports = function(traceIn, traceOut, defaultColor, layout, coerce, opts) { +module.exports = function markerDefaults(traceIn, traceOut, defaultColor, layout, coerce, opts) { var isBubble = subTypes.isBubble(traceIn); var lineColor = (traceIn.line || {}).color; var defaultMLC; diff --git a/src/traces/scatter/plot.js b/src/traces/scatter/plot.js index f1446ae3fb3..f0713e03eb8 100644 --- a/src/traces/scatter/plot.js +++ b/src/traces/scatter/plot.js @@ -22,7 +22,7 @@ var linePoints = require('./line_points'); var linkTraces = require('./link_traces'); var polygonTester = require('../../lib/polygon').tester; -module.exports = function(gd, plotinfo, cdscatter, scatterLayer, transitionOpts, makeOnCompleteCallback) { +module.exports = function plot(gd, plotinfo, cdscatter, scatterLayer, transitionOpts, makeOnCompleteCallback) { var join, onComplete; // If transition config is provided, then it is only a partial replot and traces not diff --git a/src/traces/scatter/select.js b/src/traces/scatter/select.js index a966ab5ef38..820f13846a3 100644 --- a/src/traces/scatter/select.js +++ b/src/traces/scatter/select.js @@ -11,7 +11,7 @@ var subtypes = require('./subtypes'); -module.exports = function(searchInfo, selectionTester) { +module.exports = function selectPoints(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/scatter/stack_defaults.js b/src/traces/scatter/stack_defaults.js index 6c8a79dc768..1668be2e1ce 100644 --- a/src/traces/scatter/stack_defaults.js +++ b/src/traces/scatter/stack_defaults.js @@ -10,7 +10,7 @@ var perStackAttrs = ['orientation', 'groupnorm', 'stackgaps']; -module.exports = function(traceIn, traceOut, layout, coerce) { +module.exports = function handleStackDefaults(traceIn, traceOut, layout, coerce) { var stackOpts = layout._scatterStackOpts; var stackGroup = coerce('stackgroup'); diff --git a/src/traces/scatter/xy_defaults.js b/src/traces/scatter/xy_defaults.js index 51c7a63a559..d6b09fbd69a 100644 --- a/src/traces/scatter/xy_defaults.js +++ b/src/traces/scatter/xy_defaults.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var Registry = require('../../registry'); -module.exports = function(traceIn, traceOut, layout, coerce) { +module.exports = function handleXYDefaults(traceIn, traceOut, layout, coerce) { var x = coerce('x'); var y = coerce('y'); var len; diff --git a/src/traces/scatter3d/calc.js b/src/traces/scatter3d/calc.js index 96e4db0608d..35bfdbbdf2b 100644 --- a/src/traces/scatter3d/calc.js +++ b/src/traces/scatter3d/calc.js @@ -16,7 +16,7 @@ var calcColorscale = require('../scatter/colorscale_calc'); * calcdata the way Scatter.plot does, so that legends and * popovers know what to do with them. */ -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var cd = [{x: false, y: false, trace: trace, t: {}}]; arraysToCalcdata(cd, trace); diff --git a/src/traces/scatter3d/defaults.js b/src/traces/scatter3d/defaults.js index e4bf44102b8..14de88e49ad 100644 --- a/src/traces/scatter3d/defaults.js +++ b/src/traces/scatter3d/defaults.js @@ -19,7 +19,7 @@ var handleTextDefaults = require('../scatter/text_defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scattercarpet/calc.js b/src/traces/scattercarpet/calc.js index 0fa2b1f44f8..372c0a653d4 100644 --- a/src/traces/scattercarpet/calc.js +++ b/src/traces/scattercarpet/calc.js @@ -17,7 +17,7 @@ var calcSelection = require('../scatter/calc_selection'); var calcMarkerSize = require('../scatter/calc').calcMarkerSize; var lookupCarpet = require('../carpet/lookup_carpetid'); -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var carpet = trace._carpetTrace = lookupCarpet(gd, trace); if(!carpet || !carpet.visible || carpet.visible === 'legendonly') return; var i; diff --git a/src/traces/scattercarpet/defaults.js b/src/traces/scattercarpet/defaults.js index f31a3dec551..cea51be903d 100644 --- a/src/traces/scattercarpet/defaults.js +++ b/src/traces/scattercarpet/defaults.js @@ -21,7 +21,7 @@ var handleFillColorDefaults = require('../scatter/fillcolor_defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scattercarpet/event_data.js b/src/traces/scattercarpet/event_data.js index 1314918fcb9..7cb05de5ded 100644 --- a/src/traces/scattercarpet/event_data.js +++ b/src/traces/scattercarpet/event_data.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(out, pt, trace, cd, pointNumber) { +module.exports = function eventData(out, pt, trace, cd, pointNumber) { var cdi = cd[pointNumber]; out.a = cdi.a; diff --git a/src/traces/scattercarpet/hover.js b/src/traces/scattercarpet/hover.js index d1b6a31f05f..3f71bd0fbaf 100644 --- a/src/traces/scattercarpet/hover.js +++ b/src/traces/scattercarpet/hover.js @@ -11,7 +11,7 @@ var scatterHover = require('../scatter/hover'); var fillHoverText = require('../scatter/fill_hover_text'); -module.exports = function(pointData, xval, yval, hovermode) { +module.exports = function hoverPoints(pointData, xval, yval, hovermode) { var scatterPointData = scatterHover(pointData, xval, yval, hovermode); if(!scatterPointData || scatterPointData[0].index === false) return; diff --git a/src/traces/scattercarpet/plot.js b/src/traces/scattercarpet/plot.js index fcf9cdf42dc..8cce9fcb98b 100644 --- a/src/traces/scattercarpet/plot.js +++ b/src/traces/scattercarpet/plot.js @@ -13,7 +13,7 @@ var scatterPlot = require('../scatter/plot'); var Axes = require('../../plots/cartesian/axes'); var Drawing = require('../../components/drawing'); -module.exports = function(gd, plotinfoproxy, data, layer) { +module.exports = function plot(gd, plotinfoproxy, data, layer) { var i, trace, node; var carpet = data[0][0].carpet; diff --git a/src/traces/scattergeo/calc.js b/src/traces/scattergeo/calc.js index 282fa31e36d..537b0562307 100644 --- a/src/traces/scattergeo/calc.js +++ b/src/traces/scattergeo/calc.js @@ -18,7 +18,7 @@ var calcSelection = require('../scatter/calc_selection'); var _ = require('../../lib')._; -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var hasLocationData = Array.isArray(trace.locations); var len = hasLocationData ? trace.locations.length : trace._length; var calcTrace = new Array(len); diff --git a/src/traces/scattergeo/defaults.js b/src/traces/scattergeo/defaults.js index 0b985d48ed7..d2b51fbfeb2 100644 --- a/src/traces/scattergeo/defaults.js +++ b/src/traces/scattergeo/defaults.js @@ -20,7 +20,7 @@ var handleFillColorDefaults = require('../scatter/fillcolor_defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scattergeo/event_data.js b/src/traces/scattergeo/event_data.js index 1f63be50b0f..f52decf21ef 100644 --- a/src/traces/scattergeo/event_data.js +++ b/src/traces/scattergeo/event_data.js @@ -10,7 +10,7 @@ 'use strict'; -module.exports = function(out, pt) { +module.exports = function eventData(out, pt) { out.lon = pt.lon; out.lat = pt.lat; out.location = pt.loc ? pt.loc : null; diff --git a/src/traces/scattergeo/hover.js b/src/traces/scattergeo/hover.js index cbfaf760bc1..5aa9ed50c4b 100644 --- a/src/traces/scattergeo/hover.js +++ b/src/traces/scattergeo/hover.js @@ -17,7 +17,7 @@ var getTraceColor = require('../scatter/get_trace_color'); var fillHoverText = require('../scatter/fill_hover_text'); var attributes = require('./attributes'); -module.exports = function(pointData, xval, yval) { +module.exports = function hoverPoints(pointData, xval, yval) { var cd = pointData.cd; var trace = cd[0].trace; var xa = pointData.xa; diff --git a/src/traces/scattergeo/plot.js b/src/traces/scattergeo/plot.js index eeb194cbfed..aa73745c55b 100644 --- a/src/traces/scattergeo/plot.js +++ b/src/traces/scattergeo/plot.js @@ -19,7 +19,7 @@ var geoJsonUtils = require('../../lib/geojson_utils'); var subTypes = require('../scatter/subtypes'); var style = require('./style'); -module.exports = function(gd, geo, calcData) { +module.exports = function plot(gd, geo, calcData) { for(var i = 0; i < calcData.length; i++) { calcGeoJSON(calcData[i], geo.topojson); } diff --git a/src/traces/scattergeo/select.js b/src/traces/scattergeo/select.js index 86a9c2711c7..299b05765b0 100644 --- a/src/traces/scattergeo/select.js +++ b/src/traces/scattergeo/select.js @@ -11,7 +11,7 @@ var subtypes = require('../scatter/subtypes'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function(searchInfo, selectionTester) { +module.exports = function selectPoints(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/scattergeo/style.js b/src/traces/scattergeo/style.js index 509cafc7f75..14b13840136 100644 --- a/src/traces/scattergeo/style.js +++ b/src/traces/scattergeo/style.js @@ -16,7 +16,7 @@ var scatterStyle = require('../scatter/style'); var stylePoints = scatterStyle.stylePoints; var styleText = scatterStyle.styleText; -module.exports = function(gd, calcTrace) { +module.exports = function style(gd, calcTrace) { if(calcTrace) styleTrace(gd, calcTrace); }; diff --git a/src/traces/scattergl/defaults.js b/src/traces/scattergl/defaults.js index a4fb2fbccf4..82a05c4e52f 100644 --- a/src/traces/scattergl/defaults.js +++ b/src/traces/scattergl/defaults.js @@ -20,7 +20,7 @@ var handleLineDefaults = require('../scatter/line_defaults'); var handleFillColorDefaults = require('../scatter/fillcolor_defaults'); var handleTextDefaults = require('../scatter/text_defaults'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scattergl/index.js b/src/traces/scattergl/index.js index b2e083e1ea0..407348c588f 100644 --- a/src/traces/scattergl/index.js +++ b/src/traces/scattergl/index.js @@ -231,14 +231,14 @@ function sceneUpdate(gd, subplot) { if(!subplot._scene) { scene = subplot._scene = {}; - scene.init = function() { + scene.init = function init() { Lib.extendFlat(scene, initOpts, resetOpts); }; scene.init(); // apply new option to all regl components (used on drag) - scene.update = function(opt) { + scene.update = function update(opt) { var opts = Lib.repeat(opt, scene.count); if(scene.fill2d) scene.fill2d.update(opts); @@ -254,7 +254,7 @@ function sceneUpdate(gd, subplot) { }; // draw traces in proper order - scene.draw = function() { + scene.draw = function draw() { var count = scene.count; var fill2d = scene.fill2d; var error2d = scene.error2d; @@ -293,7 +293,7 @@ function sceneUpdate(gd, subplot) { }; // remove scene resources - scene.destroy = function() { + scene.destroy = function destroy() { if(scene.fill2d && scene.fill2d.destroy) scene.fill2d.destroy(); if(scene.scatter2d && scene.scatter2d.destroy) scene.scatter2d.destroy(); if(scene.error2d && scene.error2d.destroy) scene.error2d.destroy(); diff --git a/src/traces/scattermapbox/convert.js b/src/traces/scattermapbox/convert.js index 941973f4164..5dbc94ced6a 100644 --- a/src/traces/scattermapbox/convert.js +++ b/src/traces/scattermapbox/convert.js @@ -20,7 +20,7 @@ var makeBubbleSizeFn = require('../scatter/make_bubble_size_func'); var subTypes = require('../scatter/subtypes'); var convertTextOpts = require('../../plots/mapbox/convert_text_opts'); -module.exports = function(calcTrace) { +module.exports = function convert(calcTrace) { var trace = calcTrace[0].trace; var isVisible = (trace.visible === true); diff --git a/src/traces/scattermapbox/defaults.js b/src/traces/scattermapbox/defaults.js index afcaee732c9..f3b5b6d084f 100644 --- a/src/traces/scattermapbox/defaults.js +++ b/src/traces/scattermapbox/defaults.js @@ -17,7 +17,7 @@ var handleTextDefaults = require('../scatter/text_defaults'); var handleFillColorDefaults = require('../scatter/fillcolor_defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scattermapbox/event_data.js b/src/traces/scattermapbox/event_data.js index f3f8cd12a94..de17a9e9c78 100644 --- a/src/traces/scattermapbox/event_data.js +++ b/src/traces/scattermapbox/event_data.js @@ -10,7 +10,7 @@ 'use strict'; -module.exports = function(out, pt) { +module.exports = function eventData(out, pt) { out.lon = pt.lon; out.lat = pt.lat; diff --git a/src/traces/scattermapbox/hover.js b/src/traces/scattermapbox/hover.js index efd148bff0a..b1134016b9a 100644 --- a/src/traces/scattermapbox/hover.js +++ b/src/traces/scattermapbox/hover.js @@ -15,7 +15,7 @@ var getTraceColor = require('../scatter/get_trace_color'); var fillHoverText = require('../scatter/fill_hover_text'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function(pointData, xval, yval) { +module.exports = function hoverPoints(pointData, xval, yval) { var cd = pointData.cd; var trace = cd[0].trace; var xa = pointData.xa; diff --git a/src/traces/scattermapbox/plot.js b/src/traces/scattermapbox/plot.js index 75884204137..ac32b587ace 100644 --- a/src/traces/scattermapbox/plot.js +++ b/src/traces/scattermapbox/plot.js @@ -60,7 +60,7 @@ proto.addLayer = function(k, opts) { }); }; -proto.update = function(calcTrace) { +proto.update = function update(calcTrace) { var subplot = this.subplot; var optsAll = convert(calcTrace); @@ -80,7 +80,7 @@ proto.update = function(calcTrace) { calcTrace[0].trace._glTrace = this; }; -proto.dispose = function() { +proto.dispose = function dispose() { var map = this.subplot.map; for(var i = 0; i < this.order.length; i++) { @@ -90,7 +90,7 @@ proto.dispose = function() { } }; -module.exports = function(subplot, calcTrace) { +module.exports = function createScatterMapbox(subplot, calcTrace) { var trace = calcTrace[0].trace; var scatterMapbox = new ScatterMapbox(subplot, trace.uid); var optsAll = convert(calcTrace); diff --git a/src/traces/scattermapbox/select.js b/src/traces/scattermapbox/select.js index 3392fd63c73..29dba6ee3d0 100644 --- a/src/traces/scattermapbox/select.js +++ b/src/traces/scattermapbox/select.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var subtypes = require('../scatter/subtypes'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function(searchInfo, selectionTester) { +module.exports = function selectPoints(searchInfo, selectionTester) { var cd = searchInfo.cd; var xa = searchInfo.xaxis; var ya = searchInfo.yaxis; diff --git a/src/traces/scatterpolar/calc.js b/src/traces/scatterpolar/calc.js index f4d1f500456..5338adcf1e1 100644 --- a/src/traces/scatterpolar/calc.js +++ b/src/traces/scatterpolar/calc.js @@ -19,7 +19,7 @@ var arraysToCalcdata = require('../scatter/arrays_to_calcdata'); var calcSelection = require('../scatter/calc_selection'); var calcMarkerSize = require('../scatter/calc').calcMarkerSize; -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var fullLayout = gd._fullLayout; var subplotId = trace.subplot; var radialAxis = fullLayout[subplotId].radialaxis; diff --git a/src/traces/scatterpolar/plot.js b/src/traces/scatterpolar/plot.js index 54c78e6e04a..9125627a5a5 100644 --- a/src/traces/scatterpolar/plot.js +++ b/src/traces/scatterpolar/plot.js @@ -11,7 +11,7 @@ var scatterPlot = require('../scatter/plot'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function(gd, subplot, moduleCalcData) { +module.exports = function plot(gd, subplot, moduleCalcData) { var mlayer = subplot.layers.frontplot.select('g.scatterlayer'); var plotinfo = { diff --git a/src/traces/scatterpolargl/defaults.js b/src/traces/scatterpolargl/defaults.js index 94005b62ce6..3f534d7a207 100644 --- a/src/traces/scatterpolargl/defaults.js +++ b/src/traces/scatterpolargl/defaults.js @@ -20,7 +20,7 @@ var PTS_LINESONLY = require('../scatter/constants').PTS_LINESONLY; var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scatterternary/calc.js b/src/traces/scatterternary/calc.js index 7544f6d04b9..471802e7b44 100644 --- a/src/traces/scatterternary/calc.js +++ b/src/traces/scatterternary/calc.js @@ -19,7 +19,7 @@ var calcMarkerSize = require('../scatter/calc').calcMarkerSize; var dataArrays = ['a', 'b', 'c']; var arraysToFill = {a: ['b', 'c'], b: ['a', 'c'], c: ['a', 'b']}; -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var ternary = gd._fullLayout[trace.subplot]; var displaySum = ternary.sum; var normSum = trace.sum || displaySum; diff --git a/src/traces/scatterternary/defaults.js b/src/traces/scatterternary/defaults.js index f8bcbf761b5..920df2a0317 100644 --- a/src/traces/scatterternary/defaults.js +++ b/src/traces/scatterternary/defaults.js @@ -22,7 +22,7 @@ var handleFillColorDefaults = require('../scatter/fillcolor_defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/scatterternary/event_data.js b/src/traces/scatterternary/event_data.js index bcd3d35353c..ab46f69625f 100644 --- a/src/traces/scatterternary/event_data.js +++ b/src/traces/scatterternary/event_data.js @@ -8,7 +8,7 @@ 'use strict'; -module.exports = function(out, pt, trace, cd, pointNumber) { +module.exports = function eventData(out, pt, trace, cd, pointNumber) { if(pt.xa) out.xaxis = pt.xa; if(pt.ya) out.yaxis = pt.ya; diff --git a/src/traces/scatterternary/hover.js b/src/traces/scatterternary/hover.js index ed510eac055..eaf0ad26421 100644 --- a/src/traces/scatterternary/hover.js +++ b/src/traces/scatterternary/hover.js @@ -13,7 +13,7 @@ var scatterHover = require('../scatter/hover'); var Axes = require('../../plots/cartesian/axes'); -module.exports = function(pointData, xval, yval, hovermode) { +module.exports = function hoverPoints(pointData, xval, yval, hovermode) { var scatterPointData = scatterHover(pointData, xval, yval, hovermode); if(!scatterPointData || scatterPointData[0].index === false) return; diff --git a/src/traces/scatterternary/plot.js b/src/traces/scatterternary/plot.js index d9486885ca9..06cd8642195 100644 --- a/src/traces/scatterternary/plot.js +++ b/src/traces/scatterternary/plot.js @@ -11,7 +11,7 @@ var scatterPlot = require('../scatter/plot'); -module.exports = function(gd, ternary, moduleCalcData) { +module.exports = function plot(gd, ternary, moduleCalcData) { var plotContainer = ternary.plotContainer; // remove all nodes inside the scatter layer diff --git a/src/traces/splom/defaults.js b/src/traces/splom/defaults.js index 9b302b137dd..9e7846d99e7 100644 --- a/src/traces/splom/defaults.js +++ b/src/traces/splom/defaults.js @@ -17,7 +17,7 @@ var handleMarkerDefaults = require('../scatter/marker_defaults'); var mergeLength = require('../parcoords/merge_length'); var OPEN_RE = /-open/; -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/splom/index.js b/src/traces/splom/index.js index dc8755746ec..557c4427fdb 100644 --- a/src/traces/splom/index.js +++ b/src/traces/splom/index.js @@ -138,7 +138,7 @@ function sceneUpdate(gd, trace) { if(!scene) { scene = splomScenes[uid] = Lib.extendFlat({}, reset, first); - scene.draw = function() { + scene.draw = function draw() { if(scene.matrix && scene.matrix.draw) { if(scene.selectBatch) { scene.matrix.draw(scene.unselectBatch, scene.selectBatch); @@ -151,7 +151,7 @@ function sceneUpdate(gd, trace) { }; // remove scene resources - scene.destroy = function() { + scene.destroy = function destroy() { if(scene.matrix && scene.matrix.destroy) { scene.matrix.destroy(); } diff --git a/src/traces/streamtube/calc.js b/src/traces/streamtube/calc.js index 62d5e151af8..9a38f09c89d 100644 --- a/src/traces/streamtube/calc.js +++ b/src/traces/streamtube/calc.js @@ -10,7 +10,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var i; var u = trace.u; diff --git a/src/traces/streamtube/defaults.js b/src/traces/streamtube/defaults.js index 9a7b89fc8a5..f118a41f665 100644 --- a/src/traces/streamtube/defaults.js +++ b/src/traces/streamtube/defaults.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/sunburst/defaults.js b/src/traces/sunburst/defaults.js index 91324ee6fd4..bea2a98da84 100644 --- a/src/traces/sunburst/defaults.js +++ b/src/traces/sunburst/defaults.js @@ -14,7 +14,7 @@ var handleDomainDefaults = require('../../plots/domain').defaults; var coerceFont = Lib.coerceFont; -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/sunburst/layout_defaults.js b/src/traces/sunburst/layout_defaults.js index a710afa0eda..d54c3bc6919 100644 --- a/src/traces/sunburst/layout_defaults.js +++ b/src/traces/sunburst/layout_defaults.js @@ -11,7 +11,7 @@ var Lib = require('../../lib'); var layoutAttributes = require('./layout_attributes'); -module.exports = function(layoutIn, layoutOut) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) { function coerce(attr, dflt) { return Lib.coerce(layoutIn, layoutOut, layoutAttributes, attr, dflt); } diff --git a/src/traces/surface/calc.js b/src/traces/surface/calc.js index 39b319177b1..49d2b819196 100644 --- a/src/traces/surface/calc.js +++ b/src/traces/surface/calc.js @@ -13,7 +13,7 @@ var colorscaleCalc = require('../../components/colorscale/calc'); // Compute auto-z and autocolorscale if applicable -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { if(trace.surfacecolor) { colorscaleCalc(gd, trace, { vals: trace.surfacecolor, diff --git a/src/traces/surface/defaults.js b/src/traces/surface/defaults.js index ac59bb6e35c..980d32014bb 100644 --- a/src/traces/surface/defaults.js +++ b/src/traces/surface/defaults.js @@ -14,7 +14,7 @@ var Lib = require('../../lib'); var colorscaleDefaults = require('../../components/colorscale/defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { var i, j; function coerce(attr, dflt) { diff --git a/src/traces/table/calc.js b/src/traces/table/calc.js index 1e88c4a2672..9a30db8f96c 100644 --- a/src/traces/table/calc.js +++ b/src/traces/table/calc.js @@ -10,7 +10,7 @@ var wrap = require('../../lib/gup').wrap; -module.exports = function() { +module.exports = function calc() { // we don't actually need to include the trace here, since that will be added // by Plots.doCalcdata, and that's all we actually need later. return wrap({}); diff --git a/src/traces/table/data_preparation_helper.js b/src/traces/table/data_preparation_helper.js index a61d635c285..271a8424be7 100644 --- a/src/traces/table/data_preparation_helper.js +++ b/src/traces/table/data_preparation_helper.js @@ -13,7 +13,7 @@ var extendFlat = require('../../lib/extend').extendFlat; var isNumeric = require('fast-isnumeric'); // pure functions, don't alter but passes on `gd` and parts of `trace` without deep copying -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var cellsValues = squareStringMatrix(trace.cells.values); var slicer = function(a) { return a.slice(trace.header.values.length, a.length); diff --git a/src/traces/table/defaults.js b/src/traces/table/defaults.js index 8cad6dc9e9a..95b3d91b8a3 100644 --- a/src/traces/table/defaults.js +++ b/src/traces/table/defaults.js @@ -24,7 +24,7 @@ function defaultColumnOrder(traceOut, coerce) { coerce('columnorder', oneStepped); } -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/table/plot.js b/src/traces/table/plot.js index 92bb07a0228..10ade457bf5 100644 --- a/src/traces/table/plot.js +++ b/src/traces/table/plot.js @@ -19,7 +19,7 @@ var prepareData = require('./data_preparation_helper'); var splitData = require('./data_split_helpers'); var Color = require('../../components/color'); -module.exports = function(gd, wrappedTraceHolders) { +module.exports = function plot(gd, wrappedTraceHolders) { var dynamic = !gd._context.staticPlot; var table = gd._fullLayout._paper.selectAll('.' + c.cn.table) @@ -714,7 +714,7 @@ function updateBlockYPosition(gd, cellsColumnBlock, tableControlView) { } function makeDragRow(gd, allTableControlView, optionalMultiplier, optionalPosition) { - return function(eventD) { + return function dragRow(eventD) { // may come from whichever DOM event target: drag, wheel, bar... eventD corresponds to event target var d = eventD.calcdata ? eventD.calcdata : eventD; var tableControlView = allTableControlView.filter(function(dd) {return d.key === dd.key;}); @@ -747,7 +747,7 @@ function conditionalPanelRerender(gd, tableControlView, cellsColumnBlock, pages, } function wrapTextMaker(columnBlock, element, tableControlView, gd) { - return function() { + return function wrapText() { var cellTextHolder = d3.select(element.parentNode); cellTextHolder .each(function(d) { @@ -790,7 +790,7 @@ function wrapTextMaker(columnBlock, element, tableControlView, gd) { } function updateYPositionMaker(columnBlock, element, tableControlView, gd, d) { - return function() { + return function updateYPosition() { if(d.settledY) return; var cellTextHolder = d3.select(element.parentNode); var l = getBlock(d); diff --git a/src/traces/violin/calc.js b/src/traces/violin/calc.js index f08eb881170..fc5308aa1d0 100644 --- a/src/traces/violin/calc.js +++ b/src/traces/violin/calc.js @@ -14,7 +14,7 @@ var boxCalc = require('../box/calc'); var helpers = require('./helpers'); var BADNUM = require('../../constants/numerical').BADNUM; -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var cd = boxCalc(gd, trace); if(cd[0].t.empty) return cd; diff --git a/src/traces/violin/cross_trace_calc.js b/src/traces/violin/cross_trace_calc.js index 8da03b6801b..2463233faf2 100644 --- a/src/traces/violin/cross_trace_calc.js +++ b/src/traces/violin/cross_trace_calc.js @@ -11,7 +11,7 @@ var setPositionOffset = require('../box/cross_trace_calc').setPositionOffset; var orientations = ['v', 'h']; -module.exports = function(gd, plotinfo) { +module.exports = function crossTraceCalc(gd, plotinfo) { var calcdata = gd.calcdata; var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; diff --git a/src/traces/violin/defaults.js b/src/traces/violin/defaults.js index 641d6f84af2..0a0fa8d1a73 100644 --- a/src/traces/violin/defaults.js +++ b/src/traces/violin/defaults.js @@ -14,7 +14,7 @@ var Color = require('../../components/color'); var boxDefaults = require('../box/defaults'); var attributes = require('./attributes'); -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/violin/hover.js b/src/traces/violin/hover.js index b2a28c897f2..184e41744c7 100644 --- a/src/traces/violin/hover.js +++ b/src/traces/violin/hover.js @@ -13,7 +13,7 @@ var Axes = require('../../plots/cartesian/axes'); var boxHoverPoints = require('../box/hover'); var helpers = require('./helpers'); -module.exports = function(pointData, xval, yval, hovermode, hoverLayer) { +module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLayer) { var cd = pointData.cd; var trace = cd[0].trace; var hoveron = trace.hoveron; diff --git a/src/traces/violin/layout_defaults.js b/src/traces/violin/layout_defaults.js index 4af78efbad5..0bfde91ccaf 100644 --- a/src/traces/violin/layout_defaults.js +++ b/src/traces/violin/layout_defaults.js @@ -12,7 +12,7 @@ var Lib = require('../../lib'); var layoutAttributes = require('./layout_attributes'); var boxLayoutDefaults = require('../box/layout_defaults'); -module.exports = function(layoutIn, layoutOut, fullData) { +module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) { function coerce(attr, dflt) { return Lib.coerce(layoutIn, layoutOut, layoutAttributes, attr, dflt); } diff --git a/src/traces/violin/plot.js b/src/traces/violin/plot.js index 110204b0b63..1b1b7a148c2 100644 --- a/src/traces/violin/plot.js +++ b/src/traces/violin/plot.js @@ -16,7 +16,7 @@ var boxPlot = require('../box/plot'); var linePoints = require('../scatter/line_points'); var helpers = require('./helpers'); -module.exports = function(gd, plotinfo, cdViolins, violinLayer) { +module.exports = function plot(gd, plotinfo, cdViolins, violinLayer) { var fullLayout = gd._fullLayout; var xa = plotinfo.xaxis; var ya = plotinfo.yaxis; diff --git a/src/traces/violin/style.js b/src/traces/violin/style.js index 5e9addc3e6f..6863dc78dab 100644 --- a/src/traces/violin/style.js +++ b/src/traces/violin/style.js @@ -12,7 +12,7 @@ var d3 = require('d3'); var Color = require('../../components/color'); var stylePoints = require('../scatter/style').stylePoints; -module.exports = function(gd, cd) { +module.exports = function style(gd, cd) { var s = cd ? cd[0].node3 : d3.select(gd).selectAll('g.trace.violins'); s.style('opacity', function(d) { return d[0].trace.opacity; }); diff --git a/src/traces/volume/defaults.js b/src/traces/volume/defaults.js index 1505718a188..dd88ded3257 100644 --- a/src/traces/volume/defaults.js +++ b/src/traces/volume/defaults.js @@ -28,7 +28,7 @@ function createWave(n, minOpacity) { return arr; } -module.exports = function(traceIn, traceOut, defaultColor, layout) { +module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout) { function coerce(attr, dflt) { return Lib.coerce(traceIn, traceOut, attributes, attr, dflt); } diff --git a/src/traces/waterfall/calc.js b/src/traces/waterfall/calc.js index 799e87536ef..a5c9bcf0d98 100644 --- a/src/traces/waterfall/calc.js +++ b/src/traces/waterfall/calc.js @@ -21,7 +21,7 @@ function isTotal(a) { return (a === 't' || a === 'total'); } -module.exports = function(gd, trace) { +module.exports = function calc(gd, trace) { var xa = Axes.getFromId(gd, trace.xaxis || 'x'); var ya = Axes.getFromId(gd, trace.yaxis || 'y'); var size, pos; diff --git a/src/traces/waterfall/cross_trace_calc.js b/src/traces/waterfall/cross_trace_calc.js index 4f2322e4dae..229b4792215 100644 --- a/src/traces/waterfall/cross_trace_calc.js +++ b/src/traces/waterfall/cross_trace_calc.js @@ -10,7 +10,7 @@ var setGroupPositions = require('../bar/cross_trace_calc').setGroupPositions; -module.exports = function(gd, plotinfo) { +module.exports = function crossTraceCalc(gd, plotinfo) { var fullLayout = gd._fullLayout; var fullData = gd._fullData; var calcdata = gd.calcdata; diff --git a/src/traces/waterfall/hover.js b/src/traces/waterfall/hover.js index 709fcf64750..f3bbe18ce83 100644 --- a/src/traces/waterfall/hover.js +++ b/src/traces/waterfall/hover.js @@ -17,7 +17,7 @@ var DIRSYMBOL = { decreasing: '▼' }; -module.exports = function(pointData, xval, yval, hovermode) { +module.exports = function hoverPoints(pointData, xval, yval, hovermode) { var point = hoverOnBars(pointData, xval, yval, hovermode); if(!point) return; diff --git a/src/traces/waterfall/plot.js b/src/traces/waterfall/plot.js index e138af25317..8c604727010 100644 --- a/src/traces/waterfall/plot.js +++ b/src/traces/waterfall/plot.js @@ -13,7 +13,7 @@ var Lib = require('../../lib'); var Drawing = require('../../components/drawing'); var barPlot = require('../bar/plot'); -module.exports = function(gd, plotinfo, cdModule, traceLayer) { +module.exports = function plot(gd, plotinfo, cdModule, traceLayer) { barPlot(gd, plotinfo, cdModule, traceLayer); plotConnectors(gd, plotinfo, cdModule, traceLayer); }; diff --git a/tasks/util/browserify_wrapper.js b/tasks/util/browserify_wrapper.js index 8e3ff152e31..7a4e49113b4 100644 --- a/tasks/util/browserify_wrapper.js +++ b/tasks/util/browserify_wrapper.js @@ -28,7 +28,7 @@ var strictD3 = require('./strict_d3'); * * Logs basename of bundle when completed. */ -module.exports = function(pathToIndex, pathToBundle, opts, cb) { +module.exports = function _bundle(pathToIndex, pathToBundle, opts, cb) { opts = opts || {}; var pathToMinBundle = opts.pathToMinBundle; diff --git a/tasks/util/make_schema.js b/tasks/util/make_schema.js index e95b069f774..6b3537ff829 100644 --- a/tasks/util/make_schema.js +++ b/tasks/util/make_schema.js @@ -2,7 +2,7 @@ var fs = require('fs'); var path = require('path'); var JSDOM = require('jsdom').JSDOM; -module.exports = function(plotlyPath, schemaPath) { +module.exports = function makeSchema(plotlyPath, schemaPath) { return function() { var plotlyjsCode = fs.readFileSync(plotlyPath, 'utf-8'); diff --git a/tasks/util/pull_css.js b/tasks/util/pull_css.js index c22b3a8ff8f..6ac0fc4aa13 100644 --- a/tasks/util/pull_css.js +++ b/tasks/util/pull_css.js @@ -1,7 +1,7 @@ var fs = require('fs'); -module.exports = function(data, pathOut) { +module.exports = function pullCSS(data, pathOut) { var rules = {}; data.split(/\s*\}\s*/).forEach(function(chunk) { diff --git a/tasks/util/pull_font_svg.js b/tasks/util/pull_font_svg.js index d9a11564f5f..f0a38d0dded 100644 --- a/tasks/util/pull_font_svg.js +++ b/tasks/util/pull_font_svg.js @@ -4,7 +4,7 @@ var xml2js = require('xml2js'); var parser = new xml2js.Parser(); var builder = new xml2js.Builder({ headless: true, rootName: 'svg', renderOpts: {'newline': ''}}); -module.exports = function(data, pathOut) { +module.exports = function pullFontSVG(data, pathOut) { parser.parseString(data, function(err, result) { if(err) throw err; diff --git a/tasks/util/update_version.js b/tasks/util/update_version.js index 254f69be5d1..96e36e16d49 100644 --- a/tasks/util/update_version.js +++ b/tasks/util/update_version.js @@ -5,7 +5,7 @@ var falafel = require('falafel'); var pkg = require('../../package.json'); -module.exports = function(pathToFile) { +module.exports = function updateVersion(pathToFile) { fs.readFile(pathToFile, 'utf-8', function(err, code) { var out = falafel(code, function(node) { if(isVersionNode(node)) node.update('\'' + pkg.version + '\''); diff --git a/tasks/util/watchified_bundle.js b/tasks/util/watchified_bundle.js index 56d4afc52c6..05fb07c9526 100644 --- a/tasks/util/watchified_bundle.js +++ b/tasks/util/watchified_bundle.js @@ -18,7 +18,7 @@ var strictD3 = require('./strict_d3'); * @param {function} onFirstBundleCallback executed when first bundle is completed * */ -module.exports = function(onFirstBundleCallback) { +module.exports = function makeWatchifiedBundle(onFirstBundleCallback) { var b = browserify(constants.pathToPlotlyIndex, { debug: true, standalone: 'Plotly', diff --git a/tasks/util/wrap_locale.js b/tasks/util/wrap_locale.js index fe939d100c0..ddad20ba313 100644 --- a/tasks/util/wrap_locale.js +++ b/tasks/util/wrap_locale.js @@ -18,7 +18,7 @@ var moduleMarker = 'module.exports = '; * * Logs basename of bundle when completed. */ -module.exports = function(pathToInput, pathToOutput) { +module.exports = function wrapLocale(pathToInput, pathToOutput) { fs.readFile(pathToInput, 'utf8', function(err, data) { var moduleStart = data.indexOf(moduleMarker) + moduleMarker.length; var moduleEnd = data.indexOf(';', moduleStart); diff --git a/test/image/assets/get_image_paths.js b/test/image/assets/get_image_paths.js index 12ec47e7199..915bce2c2c0 100644 --- a/test/image/assets/get_image_paths.js +++ b/test/image/assets/get_image_paths.js @@ -14,7 +14,7 @@ var DEFAULT_FORMAT = 'png'; * test * diff */ -module.exports = function(mockName, format) { +module.exports = function getImagePaths(mockName, format) { format = format || DEFAULT_FORMAT; return { diff --git a/test/image/assets/get_image_request_options.js b/test/image/assets/get_image_request_options.js index 522b42a8236..82589f76d16 100644 --- a/test/image/assets/get_image_request_options.js +++ b/test/image/assets/get_image_request_options.js @@ -13,7 +13,7 @@ var DEFAULT_SCALE = 1; * scale (optional): scale of generated image * url (optional): URL of image server */ -module.exports = function(specs) { +module.exports = function getRequestOpts(specs) { var pathToMock = path.join(constants.pathToTestImageMocks, specs.mockName) + '.json'; var figure = require(pathToMock); diff --git a/test/image/assets/get_mock_list.js b/test/image/assets/get_mock_list.js index c7e325a8762..e0f4b39a147 100644 --- a/test/image/assets/get_mock_list.js +++ b/test/image/assets/get_mock_list.js @@ -10,7 +10,7 @@ var constants = require('../../../tasks/util/constants'); * @param {string} pattern * @return {array} */ -module.exports = function(pattern) { +module.exports = function getMocks(pattern) { // defaults to 'all' pattern = pattern || '*'; diff --git a/test/jasmine/assets/check_component.js b/test/jasmine/assets/check_component.js index 644d8622ac3..dfc2decc2a8 100644 --- a/test/jasmine/assets/check_component.js +++ b/test/jasmine/assets/check_component.js @@ -8,7 +8,7 @@ var destroyGraphDiv = require('../assets/destroy_graph_div'); * expects bar, scatter3d, filter, and calendars to be registered * but the test is that they may have been registered in any order */ -module.exports = function(Plotly) { +module.exports = function checkComponent(Plotly) { describe('core (svg 2d, scatter) and registered (bar) traces and transforms', function() { var gd; diff --git a/test/jasmine/assets/check_event_data.js b/test/jasmine/assets/check_event_data.js index d17a0ed1c81..8280491f53e 100644 --- a/test/jasmine/assets/check_event_data.js +++ b/test/jasmine/assets/check_event_data.js @@ -7,7 +7,7 @@ var hover = require('../assets/hover'); 'use strict'; -module.exports = function(mock, x, y, additionalFields) { +module.exports = function checkEventData(mock, x, y, additionalFields) { var mockCopy = Lib.extendDeep({}, mock); var gd; diff --git a/test/jasmine/assets/check_overlap.js b/test/jasmine/assets/check_overlap.js index 073f0f1e624..023ab70ae45 100644 --- a/test/jasmine/assets/check_overlap.js +++ b/test/jasmine/assets/check_overlap.js @@ -7,7 +7,7 @@ function compare(baseRects, compareRects) { baseRects.bottom > compareRects.top; } -module.exports = function(base, elements) { +module.exports = function checkOverlap(base, elements) { var baseRects = base.getBoundingClientRect(); // handle array as second argument diff --git a/test/jasmine/assets/click.js b/test/jasmine/assets/click.js index c5472bf1c91..1cf16e80da9 100644 --- a/test/jasmine/assets/click.js +++ b/test/jasmine/assets/click.js @@ -24,7 +24,7 @@ var Lib = require('../../../src/lib'); * @param {array(2)} opts.slop - shift [x, y] between mousedown and mouseup. * Just for testing purposes, to simulate a sloppy click */ -module.exports = function(x, y, optsIn) { +module.exports = function click(x, y, optsIn) { var opts = Lib.extendFlat({}, optsIn || {}); var button = opts.button || 0; if(button && button !== 2) throw new Error('unsupported button: ' + button); diff --git a/test/jasmine/assets/create_graph_div.js b/test/jasmine/assets/create_graph_div.js index 2c7a21c5486..9791d46018c 100644 --- a/test/jasmine/assets/create_graph_div.js +++ b/test/jasmine/assets/create_graph_div.js @@ -1,6 +1,6 @@ 'use strict'; -module.exports = function() { +module.exports = function createGraphDiv() { var gd = document.createElement('div'); gd.id = 'graph'; document.body.appendChild(gd); diff --git a/test/jasmine/assets/custom_matchers.js b/test/jasmine/assets/custom_matchers.js index ca02b9c953b..f1d877d8d51 100644 --- a/test/jasmine/assets/custom_matchers.js +++ b/test/jasmine/assets/custom_matchers.js @@ -204,7 +204,7 @@ function assert2DArray(actual, expected, testFn) { } function makeIsCloseFn(precision) { - return function(actual, expected) { + return function isClose(actual, expected) { if(isNumeric(actual) && isNumeric(expected)) { return Math.abs(actual - expected) < precision; } @@ -216,7 +216,7 @@ function makeIsCloseFn(precision) { } function makeIsWithinFn(tolerance) { - return function(actual, expected) { + return function isWithin(actual, expected) { if(isNumeric(actual) && isNumeric(expected)) { return Math.abs(actual - expected) < tolerance; } diff --git a/test/jasmine/assets/delay.js b/test/jasmine/assets/delay.js index 04bffbed374..5e7d8cbf26f 100644 --- a/test/jasmine/assets/delay.js +++ b/test/jasmine/assets/delay.js @@ -10,7 +10,7 @@ * * delay(50)().then(...); */ -module.exports = function(duration) { +module.exports = function delay(duration) { return function(value) { return new Promise(function(resolve) { setTimeout(function() { diff --git a/test/jasmine/assets/destroy_graph_div.js b/test/jasmine/assets/destroy_graph_div.js index 61892695548..a1bd18b9741 100644 --- a/test/jasmine/assets/destroy_graph_div.js +++ b/test/jasmine/assets/destroy_graph_div.js @@ -1,6 +1,6 @@ 'use strict'; -module.exports = function() { +module.exports = function destroyGraphDiv() { var gd = document.getElementById('graph'); if(gd) document.body.removeChild(gd); diff --git a/test/jasmine/assets/double_click.js b/test/jasmine/assets/double_click.js index 637234d8df8..222ecd7e5a4 100644 --- a/test/jasmine/assets/double_click.js +++ b/test/jasmine/assets/double_click.js @@ -11,7 +11,7 @@ var DBLCLICKDELAY = require('../../../src/constants/interactions').DBLCLICKDELAY * to specify modifier keys. See `click` function * for more info. */ -module.exports = function(x, y, clickOpts) { +module.exports = function doubleClick(x, y, clickOpts) { if(typeof x === 'object') { var coords = getNodeCoords(x, y); x = coords.x; diff --git a/test/jasmine/assets/fail_test.js b/test/jasmine/assets/fail_test.js index 094b37f1a9b..32cb8a178f9 100644 --- a/test/jasmine/assets/fail_test.js +++ b/test/jasmine/assets/fail_test.js @@ -17,7 +17,7 @@ * * See ./with_setup_teardown.js for a different example. */ -module.exports = function(error) { +module.exports = function failTest(error) { if(error === undefined) { expect(error).not.toBeUndefined(); } else { diff --git a/test/jasmine/assets/get_bbox.js b/test/jasmine/assets/get_bbox.js index f0fb7a8869c..04064ad35f5 100644 --- a/test/jasmine/assets/get_bbox.js +++ b/test/jasmine/assets/get_bbox.js @@ -6,7 +6,7 @@ var ATTRS = ['x', 'y', 'width', 'height']; // In-house implementation of SVG getBBox that takes clip paths into account -module.exports = function(element) { +module.exports = function getBBox(element) { var elementBBox = element.getBBox(); var s = d3.select(element); diff --git a/test/jasmine/assets/get_client_position.js b/test/jasmine/assets/get_client_position.js index 697bfb57a82..f9a45cf36a3 100644 --- a/test/jasmine/assets/get_client_position.js +++ b/test/jasmine/assets/get_client_position.js @@ -1,4 +1,4 @@ -module.exports = function(selector, index) { +module.exports = function getClientPosition(selector, index) { index = index || 0; var selection = document.querySelectorAll(selector); diff --git a/test/jasmine/assets/get_rect_center.js b/test/jasmine/assets/get_rect_center.js index ea5911e3e4b..1117383354b 100644 --- a/test/jasmine/assets/get_rect_center.js +++ b/test/jasmine/assets/get_rect_center.js @@ -7,7 +7,7 @@ * * @param {rect} rect svg node */ -module.exports = function(rect) { +module.exports = function getRectCenter(rect) { var corners = getRectScreenCoords(rect); return [ diff --git a/test/jasmine/assets/hover.js b/test/jasmine/assets/hover.js index e32fd1a047a..0efa6fbb13f 100644 --- a/test/jasmine/assets/hover.js +++ b/test/jasmine/assets/hover.js @@ -1,5 +1,5 @@ var mouseEvent = require('./mouse_event'); -module.exports = function(x, y) { +module.exports = function hover(x, y) { mouseEvent('mousemove', x, y); }; diff --git a/test/jasmine/assets/modebar_button.js b/test/jasmine/assets/modebar_button.js index be937c15f32..ba3c1182461 100644 --- a/test/jasmine/assets/modebar_button.js +++ b/test/jasmine/assets/modebar_button.js @@ -3,7 +3,7 @@ var d3 = require('d3'); var modeBarButtons = require('../../../src/components/modebar/buttons'); -module.exports = function(modeBar, name) { +module.exports = function selectButton(modeBar, name) { var button = {}; var title = modeBarButtons[name].title; diff --git a/test/jasmine/assets/supply_defaults.js b/test/jasmine/assets/supply_defaults.js index f6f0339a95c..28bba9b870f 100644 --- a/test/jasmine/assets/supply_defaults.js +++ b/test/jasmine/assets/supply_defaults.js @@ -9,7 +9,7 @@ var Plotly = require('@lib'); /** * supplyDefaults that fills in necessary _context */ -module.exports = function(gd) { +module.exports = function supplyDefaults(gd) { if(!gd._context) gd._context = {}; if(!gd._context.locale) gd._context.locale = 'en'; if(!gd._context.locales) gd._context.locales = {}; diff --git a/test/jasmine/assets/timed_click.js b/test/jasmine/assets/timed_click.js index 0d62d9d186a..f9f4036673c 100644 --- a/test/jasmine/assets/timed_click.js +++ b/test/jasmine/assets/timed_click.js @@ -1,6 +1,6 @@ var mouseEvent = require('./mouse_event'); -module.exports = function(x, y) { +module.exports = function click(x, y) { mouseEvent('mousemove', x, y, {buttons: 0}); window.setTimeout(function() { diff --git a/test/jasmine/assets/transitions.js b/test/jasmine/assets/transitions.js index 26a03e5f3b1..cf1be579d51 100644 --- a/test/jasmine/assets/transitions.js +++ b/test/jasmine/assets/transitions.js @@ -5,7 +5,7 @@ * a sequence of indices such that you efficiently execute each transition * from any state to any other state. */ -module.exports = function(n) { +module.exports = function transitions(n) { var out = [0]; var nextStates = []; var i; diff --git a/test/jasmine/assets/unpolyfill.js b/test/jasmine/assets/unpolyfill.js index d90ec6ec98a..15bf14ff3a8 100644 --- a/test/jasmine/assets/unpolyfill.js +++ b/test/jasmine/assets/unpolyfill.js @@ -11,7 +11,7 @@ configurable: true, enumerable: true, writable: true, - value: function() { + value: function remove() { throw Error([ 'test/jasmine/assets/unpolyfill.js error: calling ChildNode.remove()', 'which is not available in IE.' @@ -23,7 +23,7 @@ configurable: true, enumerable: true, writable: true, - value: function() { + value: function remove() { throw Error([ 'test/jasmine/assets/unpolyfill.js error: calling ChildNode.prepend()', 'which is not available in IE.' From 3b088b9e6f94f7cd7c3d012bc989cbbd59ae1e4c Mon Sep 17 00:00:00 2001 From: archmoj Date: Thu, 18 Apr 2019 20:52:28 -0400 Subject: [PATCH 4/5] replace with func-name-matching lint rule --- .eslintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index 349e641a9e8..8356cf8d107 100644 --- a/.eslintrc +++ b/.eslintrc @@ -71,6 +71,6 @@ "no-console": [0], "no-unused-labels": [2], "no-useless-escape": [0], - "func-names": ["error", "never"] + "func-name-matching": ["error", "always"] } } From 6d1609ab38cf50845d72b3ed7716072020bfc75f Mon Sep 17 00:00:00 2001 From: archmoj Date: Thu, 18 Apr 2019 21:04:15 -0400 Subject: [PATCH 5/5] apply func-name-matching lint rule --- src/components/dragelement/unhover.js | 2 +- src/components/fx/helpers.js | 2 +- src/components/updatemenus/scrollbox.js | 6 +++--- src/lib/index.js | 2 +- src/lib/polygon.js | 4 ++-- src/plots/cartesian/constraints.js | 4 ++-- src/plots/gl2d/index.js | 2 +- src/plots/gl3d/index.js | 2 +- src/plots/mapbox/index.js | 2 +- src/plots/ternary/index.js | 2 +- src/traces/bar/sieve.js | 2 +- test/jasmine/assets/unpolyfill.js | 4 ++-- 12 files changed, 17 insertions(+), 17 deletions(-) diff --git a/src/components/dragelement/unhover.js b/src/components/dragelement/unhover.js index 34b51720032..ec4b4cd0ef7 100644 --- a/src/components/dragelement/unhover.js +++ b/src/components/dragelement/unhover.js @@ -32,7 +32,7 @@ unhover.wrapped = function(gd, evt, subplot) { // remove hover effects on mouse out, and emit unhover event -unhover.raw = function unhoverRaw(gd, evt) { +unhover.raw = function raw(gd, evt) { var fullLayout = gd._fullLayout; var oldhoverdata = gd._hoverdata; diff --git a/src/components/fx/helpers.js b/src/components/fx/helpers.js index ef1db6bfc06..96fa741aad2 100644 --- a/src/components/fx/helpers.js +++ b/src/components/fx/helpers.js @@ -18,7 +18,7 @@ exports.getSubplot = function getSubplot(trace) { // is trace in given list of subplots? // does handle splom case -exports.isTraceInSubplots = function isTraceInSubplot(trace, subplots) { +exports.isTraceInSubplots = function isTraceInSubplots(trace, subplots) { if(trace.type === 'splom') { var xaxes = trace.xaxes || []; var yaxes = trace.yaxes || []; diff --git a/src/components/updatemenus/scrollbox.js b/src/components/updatemenus/scrollbox.js index d43b2516608..96b92ad40c0 100644 --- a/src/components/updatemenus/scrollbox.js +++ b/src/components/updatemenus/scrollbox.js @@ -347,7 +347,7 @@ ScrollBox.prototype.disable = function disable() { * * @method */ -ScrollBox.prototype._onBoxDrag = function onBarDrag() { +ScrollBox.prototype._onBoxDrag = function _onBoxDrag() { var translateX = this.translateX; var translateY = this.translateY; @@ -367,7 +367,7 @@ ScrollBox.prototype._onBoxDrag = function onBarDrag() { * * @method */ -ScrollBox.prototype._onBoxWheel = function onBarWheel() { +ScrollBox.prototype._onBoxWheel = function _onBoxWheel() { var translateX = this.translateX; var translateY = this.translateY; @@ -387,7 +387,7 @@ ScrollBox.prototype._onBoxWheel = function onBarWheel() { * * @method */ -ScrollBox.prototype._onBarDrag = function onBarDrag() { +ScrollBox.prototype._onBarDrag = function _onBarDrag() { var translateX = this.translateX; var translateY = this.translateY; diff --git a/src/lib/index.js b/src/lib/index.js index 772ff06f34b..7a650690a02 100644 --- a/src/lib/index.js +++ b/src/lib/index.js @@ -153,7 +153,7 @@ lib.pushUnique = require('./push_unique'); lib.cleanNumber = require('./clean_number'); -lib.ensureNumber = function num(v) { +lib.ensureNumber = function ensureNumber(v) { if(!isNumeric(v)) return BADNUM; v = Number(v); if(v < -FP_SAFE || v > FP_SAFE) return BADNUM; diff --git a/src/lib/polygon.js b/src/lib/polygon.js index ee28750d2fe..8cd837d1688 100644 --- a/src/lib/polygon.js +++ b/src/lib/polygon.js @@ -181,7 +181,7 @@ polygon.tester = function tester(ptsIn) { * before the line counts as bent * @returns boolean: true means this segment is bent, false means straight */ -var isBent = polygon.isSegmentBent = function isBent(pts, start, end, tolerance) { +polygon.isSegmentBent = function isSegmentBent(pts, start, end, tolerance) { var startPt = pts[start]; var segment = [pts[end][0] - startPt[0], pts[end][1] - startPt[1]]; var segmentSquared = dot(segment, segment); @@ -226,7 +226,7 @@ polygon.filter = function filter(pts, tolerance) { ptsFiltered.splice(doneFilteredIndex + 1); for(var i = iLast + 1; i < pts.length; i++) { - if(i === pts.length - 1 || isBent(pts, iLast, i + 1, tolerance)) { + if(i === pts.length - 1 || polygon.isSegmentBent(pts, iLast, i + 1, tolerance)) { ptsFiltered.push(pts[i]); if(ptsFiltered.length < prevFilterLen - 2) { doneRawIndex = i; diff --git a/src/plots/cartesian/constraints.js b/src/plots/cartesian/constraints.js index a6d31d3dd8f..cc3a7cedf90 100644 --- a/src/plots/cartesian/constraints.js +++ b/src/plots/cartesian/constraints.js @@ -188,7 +188,7 @@ function updateConstraintGroups(constraintGroups, thisGroup, thisID, scaleanchor thisGroup[scaleanchor] = 1; } -exports.enforce = function enforceAxisConstraints(gd) { +exports.enforce = function enforce(gd) { var fullLayout = gd._fullLayout; var constraintGroups = fullLayout._axisConstraintGroups || []; @@ -346,7 +346,7 @@ exports.enforce = function enforceAxisConstraints(gd) { // For use before autoranging, check if this axis was previously constrained // by domain but no longer is -exports.clean = function cleanConstraints(gd, ax) { +exports.clean = function clean(gd, ax) { if(ax._inputDomain) { var isConstrained = false; var axId = ax._id; diff --git a/src/plots/gl2d/index.js b/src/plots/gl2d/index.js index fe240901ef0..d7b57c9d5a8 100644 --- a/src/plots/gl2d/index.js +++ b/src/plots/gl2d/index.js @@ -52,7 +52,7 @@ exports.baseLayoutAttrOverrides = overrideAll({ // dragmode: fxAttrs.dragmode }, 'plot', 'nested'); -exports.plot = function plotGl2d(gd) { +exports.plot = function plot(gd) { var fullLayout = gd._fullLayout; var fullData = gd._fullData; var subplotIds = fullLayout._subplots.gl2d; diff --git a/src/plots/gl3d/index.js b/src/plots/gl3d/index.js index 55c390b7619..80a98ca2b9f 100644 --- a/src/plots/gl3d/index.js +++ b/src/plots/gl3d/index.js @@ -39,7 +39,7 @@ exports.baseLayoutAttrOverrides = overrideAll({ exports.supplyLayoutDefaults = require('./layout/defaults'); -exports.plot = function plotGl3d(gd) { +exports.plot = function plot(gd) { var fullLayout = gd._fullLayout; var fullData = gd._fullData; var sceneIds = fullLayout._subplots[GL3D]; diff --git a/src/plots/mapbox/index.js b/src/plots/mapbox/index.js index 5614173550a..3e910f1c3d3 100644 --- a/src/plots/mapbox/index.js +++ b/src/plots/mapbox/index.js @@ -50,7 +50,7 @@ exports.layoutAttributes = require('./layout_attributes'); exports.supplyLayoutDefaults = require('./layout_defaults'); -exports.plot = function plotMapbox(gd) { +exports.plot = function plot(gd) { var fullLayout = gd._fullLayout; var calcData = gd.calcdata; var mapboxIds = fullLayout._subplots[MAPBOX]; diff --git a/src/plots/ternary/index.js b/src/plots/ternary/index.js index 0c6d16169eb..a3656e4a9a6 100644 --- a/src/plots/ternary/index.js +++ b/src/plots/ternary/index.js @@ -41,7 +41,7 @@ exports.layoutAttributes = require('./layout_attributes'); exports.supplyLayoutDefaults = require('./layout_defaults'); -exports.plot = function plotTernary(gd) { +exports.plot = function plot(gd) { var fullLayout = gd._fullLayout; var calcData = gd.calcdata; var ternaryIds = fullLayout._subplots[TERNARY]; diff --git a/src/traces/bar/sieve.js b/src/traces/bar/sieve.js index d9490bd7a7a..3593365da6e 100644 --- a/src/traces/bar/sieve.js +++ b/src/traces/bar/sieve.js @@ -84,7 +84,7 @@ Sieve.prototype.put = function put(position, value) { * (required if this.sepNegVal is true) * @returns {number} Current bin value */ -Sieve.prototype.get = function put(position, value) { +Sieve.prototype.get = function get(position, value) { var label = this.getLabel(position, value); return this.bins[label] || 0; }; diff --git a/test/jasmine/assets/unpolyfill.js b/test/jasmine/assets/unpolyfill.js index 15bf14ff3a8..d90ec6ec98a 100644 --- a/test/jasmine/assets/unpolyfill.js +++ b/test/jasmine/assets/unpolyfill.js @@ -11,7 +11,7 @@ configurable: true, enumerable: true, writable: true, - value: function remove() { + value: function() { throw Error([ 'test/jasmine/assets/unpolyfill.js error: calling ChildNode.remove()', 'which is not available in IE.' @@ -23,7 +23,7 @@ configurable: true, enumerable: true, writable: true, - value: function remove() { + value: function() { throw Error([ 'test/jasmine/assets/unpolyfill.js error: calling ChildNode.prepend()', 'which is not available in IE.'