From 2b788ef9f8dfab83177089b05bed32f420234d1b Mon Sep 17 00:00:00 2001 From: Robert Monfera Date: Wed, 15 Mar 2017 14:57:01 +0100 Subject: [PATCH] Have regl object (that's attached to the canvas element) garbage collected --- src/traces/parcoords/base_plot.js | 1 - src/traces/parcoords/parcoords.js | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/traces/parcoords/base_plot.js b/src/traces/parcoords/base_plot.js index 1005cb44b09..5ff67e92649 100644 --- a/src/traces/parcoords/base_plot.js +++ b/src/traces/parcoords/base_plot.js @@ -61,7 +61,6 @@ exports.toSVG = function(gd) { }); } - imageRoot.selectAll('*').remove(); canvases.each(canvasToImage); // Chrome / Safari bug workaround - browser apparently loses connection to the defined pattern diff --git a/src/traces/parcoords/parcoords.js b/src/traces/parcoords/parcoords.js index f13b7e673de..13250c8a074 100644 --- a/src/traces/parcoords/parcoords.js +++ b/src/traces/parcoords/parcoords.js @@ -278,11 +278,11 @@ module.exports = function(root, svg, styledData, layout, callbacks) { .map(model.bind(0, layout)) .map(viewModel); + root.selectAll('.parcoords-line-layers').remove(); + var parcoordsLineLayers = root.selectAll('.parcoords-line-layers') .data(vm, keyFun); - parcoordsLineLayers.exit().remove(); - parcoordsLineLayers.enter() .insert('div', '.' + svg.attr('class').split(' ').join(' .')) // not hardcoding .main-svg .classed('parcoords-line-layers', true)