From 73f2f676392afa8fcb9ab94fdb9d40217d3048d7 Mon Sep 17 00:00:00 2001 From: Robert Monfera Date: Mon, 6 Mar 2017 22:03:12 +0100 Subject: [PATCH 1/2] Parcoords incremental rendering off by one error fix --- src/traces/parcoords/lines.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/traces/parcoords/lines.js b/src/traces/parcoords/lines.js index db5a5f8d652..92776dabf0a 100644 --- a/src/traces/parcoords/lines.js +++ b/src/traces/parcoords/lines.js @@ -67,7 +67,7 @@ function renderBlock(regl, glAes, renderState, blockLineCount, sampleCount, item glAes(item); - if((blockNumber + 1) * blockLineCount + count < sampleCount) { + if(blockNumber * blockLineCount + count < sampleCount) { renderState.currentRafs[rafKey] = window.requestAnimationFrame(function() { render(blockNumber + 1); }); From d25872f8da79db5b43849b2be05a48590c5850b2 Mon Sep 17 00:00:00 2001 From: Robert Monfera Date: Mon, 6 Mar 2017 22:39:40 +0100 Subject: [PATCH 2/2] Parcoords incremental rendering fix - test case --- .../image/baselines/gl2d_parcoords_blocks.png | Bin 0 -> 12262 bytes test/image/mocks/gl2d_parcoords_blocks.json | 25 ++++++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 test/image/baselines/gl2d_parcoords_blocks.png create mode 100644 test/image/mocks/gl2d_parcoords_blocks.json diff --git a/test/image/baselines/gl2d_parcoords_blocks.png b/test/image/baselines/gl2d_parcoords_blocks.png new file mode 100644 index 0000000000000000000000000000000000000000..895d3895be9d5fc419bfe05fb18aef7a86f0ad05 GIT binary patch literal 12262 zcmeHt`8(9#-~Si}nKvy&S=%g$vBofAQViLbELkJj8GFJs6e<~sB1`ry5weajB_vsg zEJLQqGBWmkyN~zvxv%eiUElxU`@Mf~T`zOa>zvnlu8-&AJf9fqW7yev*&q-IySCPK zV+e$SAN)OMWd^^5MvY&CK+Zt4uU|F2XFH!BvTAm-Zb3->SqZk*R7Aur`uaZk#r(lAJxy|LpN@Ct;# zAHs!)e&T{)BeY|~Ga=x?kkJsr#$*B^9TB@^1ZN#Qp8LBIoWmo>lKq3odxSmXqce z?1OjaYi4)G4^&k)M*UX7!<%Z4VRaiD8~>iGEHK5n@;1SoU(L}$4-H?C5)4$e$2VIQ zXZ|GF48NE1YDlju8s;FAg(l z$FT5UE{f$->=O+6d$r@0WR5}TZ_Y6kf0bPATxtEx+Mr#5b4J*!F6B9ik=xM%EgP4*ew5_MbzhNl{SYu`MqKUFnJvsA+z8}end;OD)PDe`&GuY7npb2} zAW~oWK5X87b;SL>@PZbP?Y*9DRS zcD@tTLSB{0=hr-h-F2-KNk%l>QjA^h0&b&z^^eqpU_PptoKVF zNsP0NJM^5E7#{LOoSMG5ZLm|{f|YlJM%d2!JaZQ~)m6K#Z{{<p zcIGi5^g2M>3nI(6 zO598vt`;dKABwCfUCD3i`t6`fl2JXR3co@MriQb;SSh<-hA}@I zFYP5AOK;ft$z)+}6L52R0oaW};I;9suAmpY{c>wWI&p5MQ*m7POmbL>b)D>RY>7qr zIi+)Ncl%|GPTmo1e2V8x7#|ks3R!5th^G4+8@t;bY!6y_2LUBu-hO(>k`NK2d@e7k zm8P`{tU?&Yv}SD8Z?{J?uLSBPzYx|rF|@m!)TC>_(x$fWQ{VA3^yA2rLYu@}5I51> zK-354Zhb__gVh|Na=hIARTtwR6#PhwqC;sBfW3OIzO=p>8kB7#Q|x^lZ<#i(tdAT6WTWP zeRpx&A`Q+DD_RI!2sz@?A93*4Sxu*DvqkDgcut`3bjAbRa(Nyx=e3fb$b8emKE;N& zIQ=D2-VBwq+GoMSU!{{O?`m8jr(^e)b-=0i{ve;ci{V^Mk3WJPjlS7Bg;lj=9U<_#vo=G2ZiXX5FJg$dg9q2NC8)r2s?}hQe+V(=ouSK*_Z)R zaNe^mHw&!-hSz2YMpp#l- z`(zDt(TXmGKi^{*rtxT7`Dxa*XebgYKsmwI^hcio`HJ`LIKr+LdwV%1gQn9|)?Ch2 zA$)t05^Dq@L=tEiA;r%|yMXln4@md_d{H+6k9WYqW%rJ;!!q&VPzWL1 z!i5by0`P#z7s}3pa7hCkAae|^2Oghagiyb(UXusFff>BT?2vU4Jjw#myv99_f*O(l z(kMVntR1kLA3Rt*j2cE50jD#fDb+>{n*v>zA)*Cq^$U$UZTx<^%kbB!^_9F|tnw4gmn4{TyfpeIG zxS^O*{- z9~!o#J6C>O3!;CE$*S5T%O-F*a(jI~b(h>B)ug+(y_N$a)&)D!TdT&4N_#clqH%BP zSCRcDF7Z*3EGk=PAkSO90gxEyW+*+X&#DrgB3QLB%_z(Yzj0Ob;h(` zjRpINbXv*xLLTgOgvdcq1G|e+4OD}q9j5D7KR=|JyW84f%K&M!MH!>gDj^?Qjx4fX z_e9Su!f}`dkNav$BF^JiDsYNtI?eJSR924;Mp1am-*PsTVE9*tYZz-{qJqc$48eMP z(~Uw1!HN->^qZ}qD>u`edW@R6<|CMz&-Z6REf@N{R=l}}etm_pV3~N$7(`*Z!!X%E z73eR4s8?IhpA1^R z27*^X!gynG(}ZI{_{9`M0ctU!1wt6*fnYLkTQa;FW5Hg{w&IFNL@6hJpu8hKWW-MX zVWhIkzY|Ay3Fmsb;4uZq7L+iUu}C$7>6Maz5(s~~`pIs+@B|fApCHt1yhQBfC!D&H zPYpR-o?f{~IdVJtyc8U)o>dAdu3jY0hgsediP4g-`VpNn(=j||A3c$O0UVrgf|`rs zp$Nc9CLU=;2$2kN+AepZaoZ!{!Np3j!jOUimBBn`BFTTRYOOAoL!|5zN1L7#1o*cN z1VbdZ|Get|TP2R&<(vHAr;Lf3%rxb5;KW1UCDAr#ou#5Y<1B_oeA>6QhfRdC$GE+9{$XX5!Y{-r9hDPV{ce(LI}m@&3Xx# zz0??iM6|3?A(Q-YjdN2?r?B`h2dQ{6#ytsidUYdEap)H- z_YD#79WyhWNY$)~?Jlh|Sql9vrTI5>IG?}XE=jj$QGj5X@+n-I+TlA<`rKFaP+oP= z*h@q9(dRA1hJMu^mtw-IqYJd#B$G0GU7gt;@HLH@-n!BN#uxjlA$o9?)#G2+vZrr& zycTo~evC$Xk@d@sp;FMSPypW=^$DMdfJ_|x1 z-Ed{N@zk!SjEU?JIih||+1bXIxF676yq&aN($T>Ah7k!(vf;|S!_dzzkTCH|GE?_& zuWM0ADPKqAI8nyo0SA?pKhOx@r_sYSV=7Rij*lu1H+AR1!M_2!0kX^~h9)8&{nc-t zk~KYZ^|lM!={4!=s{DIMPk-gwWh+Jf@7)ai;q?f3PfG-~kqpoO&ejQSQ}jm?eMYb% zQ+?iD_hhOWuuP>y3AA}kw*E|_Kt?G2-oL}&NO|LFOAa2usI3ER@TJ_EE;GraJWw+_$O3e+DL*-ozflNf%q zNok_BpBboUwisd~mB^(`GiYz?S6!B6h-=>z@vIZ3c6ie_We%4>Y)hbp;H`l*&BMX0 zcO=+51#5KeXLV2+xSgK&Pr`t6n1^y_zSnSsrW4T#HD6ZWv?T?q0!7^}RtF-oX@vI- ze(t?ma51ypR-yoN)y7Np^2&ToCYKc_8Bfkfo{|>?=;@v3XOgvy_MP$y>2^#oWo`0Yb~E`0e;#}3I)g8Fx;@*S`)cP- zcU<^!_h)0)>CfJru_Hs=;CS3`A)eeBUbi%2$ZbgCm8Wkglku@jus4P{ip!5zr@#)T zU!j$jkDN@3X&rx%3VkEb-q%kX1#98<#nLfaO`etR*ABP2c!yy`;>&J-?ZPgiwIY5X z&|05Ah<-CTdX=Ktr0@mAfFyOEGtReP3K;2*|M6@)@%8nn=xh3QT}RU$f&1&3&WJ6Z z3Davko@w@QDA1dB7QDybr>JQ7OYRFT2R)}Mfer<)ziS8497B$fFq$KZT-#0mbVIRn z{9W#?AFQO~r_3-6zC6h>=O1xdSi9Ewi7TH=p+Bw&8@)eQ;(rLTDSV2(4`vndUKuJ0 z9BR9ZeU)>Isl~UgMi`LL0-6|l?6*HG<(-7;wtsm{pKI2K^#OCcy#2i$G6(7}8qR~r z721ninT<%r=@kgx`Z!V4>^;Umvd&LBjx;l8;FgrnFvK!MSJVqr1fFs!Y=zPrcf3*n zIFr0p`B=a4*Fj%%cSGY?n6V8GexuUo&_iD+!=>w~)>4h)+SakcvzQa985DNKQ8bTT zsEp@mZG2)zbM(;#uNUgpdk>+G>A>?UjSk-{%q!oTP)?nJFb^cP(LDWI! zc@EU0b^f8~S9^596x^0+3U1JNo3>x?DL2NoSR+7*)+F#>EIb7gLj*7Dk+ce(+ve~d zGvU+Bqm%q}5it}pP3#9etu&|$&eRTJG^3{y3@6Oc^V~I^h zVGPLXn-S+8UvP(%mVSQ|^3V zvv-vcoA7)>J->jdb!Vp{wzkZO_kVWI|H@7^S zI1RRNO@;ceb=keFZdb30WMfenPEXqQPB2K+ow9ekZ3$wx=dMDh{{HyUD&@fqlKW__sIvon1o5z}pkjmb%q>7f$Dhne}CKhQ+tvgAhDl z?mF}16Ub#WKI*csGrY`WX*23+DU&XDV(I%`Kb|n>v-8<%FVEKqd7=1=bT8$6RKc5M z$I|(zrWWSrJT_}JXY**pks_^m1sjXBCF_mZY&Eh#ev#VHFRXYDksWW6Ww6bTMbT>= zZ(q8JFF07Ar#t7vBx>RYAI7wJ_*wsQ+So7?DHEd&-XVy1esE+!iV(PgrN|Ns7e0(V zIM_R6ZsZ^Ahi(sd<1~xS-y?1+Ns=n@D@hG{(C72#R(zhlrIFn3$zwX;E=tQo{%BAVtft+B#oKT?%6$(svO=QuY|tJaI-H&OkKKIe|KJ6Y4$w`rp#jhILI9G@(lXDGUxVc4C{qbHE!`>p9ZSFs26M>^~pUU z@xodR;EReGf$sdWYjm8)$_j&qK4KWftG^?Q5-x`j?BgLw`j_HuZO3+KCseC1E~aJL zA&ZFoskQw4%d4^By5j6E+7aMy<2Rk}n`_V=H<~+RDP5ZCUgLcN96|hD{MhJbqaq+l zQ0tlF5iu$uNxy&7F-fWPI1dp6}!obKQ0 zZO=aEf-2y!1V4BWW@)Z(>Mt&ZncpP++eqqq4p}y=Yb}*xCt3~ic4;aX$jT(`Cbx}* z&W<3$O}ybsk3hoHsgwrODgHs^{g+iTOIEV_-+?qpHe~2(LuQ>x`vPt`<`pGQ8#P`Z zf6PyMjdDFh-xW?}O{>00%14Wa@Vt0Qx|{SVUi!;YXHB&N&aZMdR{<>GNdXH;>*gm; zz1WkB4T5FthKBvsTwamx#Z!L#@b)_RZ!|~}L1Tg*m;`J%o=f%OPiXu`_wm3{M*Xdy zjORPHj0l2+b4ikD61g+uG(M#h z*s&F1e!nIrHWRzAEi*<~H<+S|#znwNApIlfvLSPL{efhKtweza+9SO{mfU?xOV_u^ z@d)3Tf5G|8Awa0}97!ujdcJL)2BtEd`CHdd-qS8I^-`1YidTpPNdG-f3`C1##3F1P zwfYjDRQ(5^fTiy$nzLxJ;n~_%tLdBX4$2 zfFWD=YhXrzDw`oO^J%^#xxiHyXWnetuTU>U{%AcLuH*Pgz5P)C0%4H0Dct8jU9D3y zFCy_wti-Xn+=Y*t3SnEzR)!HJaG?BGTjJ={7Q=vy&%>TWf0>>V3`%{w7jUMy>J{qf zWuI@Pr17+JM^}I^(^f6<2=3Bu)u-EmGPb8TD-P(4SJG6&wk5@y%_6~e^`SffB zN#N1ZV9fp1-5l4EN>_Qu)_+Dm2FuL@*3Q2}vZjan>0ynM=G~6-mE#e89v;B=%S8Mc zqL?^%5RIfWV`DQOdm9wZ=! zWq`tA5Wpn_t4G1j0GYG~bk{-6{Jkxt5M*LfVW)IwhNkmClV|iEPr82(o$@GGY2cTl z=!QZS5S7=!P5iLNtZ%sQPT$pbGh_N@^`3c4tdQE9C=P)e38Du1z2qdaiB#jjnDusy#H`~cVV0A0+`@(j+cy@uO&;iNzEj@DoM!pqZf}~BA7C~$`ay*C6ju)p{T6#v z_@H|BW!38T@7EDeuY#i%hM&SaG9FDmmHu6XL|$`R4*m5xQr_ts*R5)g(`$gImzGao z_z(7xofY)-JH$RO3gO67f@yWk=w+m`gx1R_?LgoV|ct`qHZTGf`no-Zmcjse_<&VuJpb<_iY#qHhU z!Ct9@y&liE(4^J~jR*k(YDt~3t)=bv3m6?5Xt^d_r)Bez`ewj?(Ux&GCoC|xQHZW_ z@Ns9o?P90|;%4y9y}wwdlxlWlAM9r!H5al~V5>6Q9;0clY$re10}$qi@_Ea9Mt^|yQexx`$q2;x=JIE!GF%$eO zwoufI9*H}(_+Nr6>RXZnne9tpz4T)+7shAuts>Q09QtZ$3Kx%gpbhUP%p+RwzBvm5 zwBx12f<~_q{=EKi4B--O+*;B@UocIf6n}oKWr(ENvbk<$__X8*@KCcY2{avAO5`h_ ze;D#bx*;ika)MDdA9E!G;M}sChhLAdgSmW=?m$F&Zp+#{=10Gt`n6n`iz4_0MKprV z?B@6Yz-(;dXsrPd6tjWk(a^Vna^A5R=(0Y4a2eeKeRTXhl<0Tu7#X;w2~#R%mq$5p;RWbp#T< zQhs@ZQ#}0dJHzzqcly4uxj4$R(^iKinyE3K2+ImVXw{=kYdB^0hKLf=$NbubmO}ae zT)@>YUW!r$g;z{9SPf5{j!3M5>$QE`f2|;ESy{Re=`lTHg0gDzoIc^m4;CB9hXlaM z12EB`Tlw|L6}SMn%|=?P_f6EeBwD~jH;^l$vSz32)U3^M=PbVw zt?5ZCH4~6Jo?JdmLGH%*fY14EJUR7kz3qReDyzZ{TY)!%l5NS;v z%p%}5ZI0Dx<;jb0Elg|xbK$X7oaLwO>=p6nk1q&;ERDW?1ZyqDom!uq&9A#G>pI7a zRB(j9(^s#<>9jpj0;#jM<05JIGd7rs`q$xGzNpG?ZSId3e)#i2JMyb;3=Bi@iMT%Av*O&GAp8K|S(GoLUdT%@apD79QkAL$}@a|Lf3+aI^DtgTJtm_=O5$=K#tT98O-EXe0MzU2|QY zY`;aF43cuH=dZI_R~e$83bo;Nc6RXPsxn6l9$87|do@JvD zV8_3Hj)c2@OT1X=F)T|Pd~cUWXHz{y>$!R+w-Z!OyylAMFeXlmI1W#_C`VPQ1R{-L zPatW}qB@eK3XX7!^z`NFxb|dTy%q2QHgliBjm24^tUZRW+0*=`TcGnqwpzY~Sto@5 z(s1<=z?%E=2T#W5612fxp5Fc%xU;=b)G<+E-rM$DZ)AQ5C=Z!X9V`&zAiUR}bS>ae zFt-m$+W`Y!MTRR1F*Wp4sY@_!UVtk!eNQSd1FD$DR@N0`m>TKM>F9Tm&4<~rwtp>V zI$cw^!f^zQYx=><2(UZK`K}>dONCmux{zrKP|CY&bvUb|Jq+O>O5OoAULB>}vP?lH zzenbDb8ZPqJ;#uBk@zXn-|B7d*w%Lx zIJ2=azL7i8wJCpI$=7KoaaHQcpGnsd&EGY%7Uk6-J#^iG_pEuf`G==eE5?5t7!93r zkrf&+qt(m;4iAi%62(bG?t<%lapK(}i)TO|TwznQ`A)`KuH%iR1$X;1HSCL=Y) zGS+L3veDVqrF*ZY$gQAOp{9V^+tOY{M#NL^Py5Eag9J}lau*}XCu?Xu44@{PFa}KC zoeGMK<#RA2@8TS#B^j~(wcEM8`wT$2K$l;ezq}TQyZG;7ka> zdyyO~PU(&K=J}*M_SUK{+tvq4HUPdsK7eMby!3^Wfxq-uL?8$oACHl=$(OA9Mc}=; zlIGkAs(K?)5d_}pO0s^AjAJVVX-$UBgV=cQYfBSw4@5TPmiN6hq)&FH!!b~qxn&}#$!JVP zZAWhWx@Ax(&NfYe@GW>^rFb?EC2~ZZ8Kl2VW*Rfcw2QFKXmGIgnkb-$+U5Jt>mM6#f~nUia3$p^D2MZL-;v3zoc%WqP15t% z&ZMuT>+k;*S5xGvi&~~=lCsOsmb3%kIuim#1gXu z5Wuzq15yG0VdmbSkn)kQ-(OpCC#wct9{zZ3(=*2;)dARvRU_Q6hU(uPU~=hc(s~ge zd9{v?6FG>l?%oaC@qDYtM>z!1ps?ufu(26$41$YPq>gq&kRsoryg?}`zj1_r>~pWm z`xI`)>Wgg>g|z(-XkVv=vJ{QGj)$z;T8A!SY!^c-uOz^)4Yzc5znG zdH2)^@Ee}6lbJ_{YVlF;BdwWQvd^dg->kJ5+ODj8?6}YEGtbLWiHsVY&jIy4xzOz0 zRV(u^T0f-5Nj?oT#&t+6Rm=UpTF&-l*AogMp}=k8{}AXz1gV-Na_RMa_A6)%3Q;3a z@Q?LQ=V`g>!>ZS45N1)0^x%%wdsf0FvMB9Z+z~B@(dQdO&iW1F{MurR1c0xSofxW5 zDr}7rwnKW4PUOv7j|n@)1rk+luD0ckM^v~69M&t{pu~g{id%%A=j}W&`3nbNQQ15N z6qniFsg3|Eg_N@Oz&xx4Z!*2Okfp%$>4l6E`d4M|AL=*nF{BK*CuE`%#n9$uy#kk* z$akW-uS#*T9?mFAc?WMAcF-I-21sO3565taw||y)y_D?cDi);33B95$2{gG~yJ)4T z`S-AjZSI36(!FxwTGDHD$AsCgZ$Vv$H!A=cm`18{lX~4vM?SM)YvBGrqAvQ)#LcXqcSA%qw<>^KX6tNq+ag|ek`v5tH}-*;E;=`K7{7cB7rRkVfw zA#yfOg;pxvh#VQ{hw*0A3nZZg_?lpUPC6Zm5db&6AjQVp6LUDtGwvs7CvZ-@DQ@l) zHKx%+zrpEp@?k?4hH9;Qphv2*N|*f^1WcN$66Q#U(cGU5{m$J$AG^6Rs^Do39|{bm zAbIW&@jHLmO4;^A4JJ>3lhupBTq^2)%4?s}HTs+CJ|>>jaz06ezB)0JyyJ&)@cX>e*ClnCeg=j(VtQWxy$e$j!1OB0w-4XZt0^?v&c%hNl-Q{El4gMHC@_CqB z*}AF0;A0CTFzpp2>}zD~Y9YDbAeCvkLf!M18>0XL+ykI$kK@lvXPDrXsY8uA1+EkX z@>3<>X}6q*?F}g@@@)&6Psy3N;1f?1p{qyuQeh&=Ztm)O0W#r)u7w|uO&zmAE(o<@ z$ZzrZ5GJM5;eYi={vgdTAw7p4d-kOIbWkx2o(S%6j}hNOY(D3kEI2d$xR51+okFva z;+55z4k)g7oJzrZtqJ2oAjC8Gmh)L*#H8TT##1RWBYW2j!HwR!lMpJYc3; zJWW4xm};ir(so~Nmi0D}+4|HA!=a9)d*hX4f{JU`>1a>Rn@j?bHnauU#Nkg!Ayj`D z^UGDJHp6EjI=2lLx66_qx=5#76|LW4!d_rIP~k=aP^9xpBFnE^CF#w*-$znVL5NrZ zRJHLh4~Dxz5*li{QH}{8Eo?T*f>-Wt|EOuyID}9PjLbbleux4ARoP^bSiv7Era#Of z7&-(H$JqIis#O3Ud-{t^X1{P6R6_Ol_n9-}d5Yc(dNpp{C4x3L*ZtkCO6)K76d6b6 ze{V`s_b~Toh6iU}A8bicb|nBh34)R?_ALG<6_=hpO-&(8bP2da6-#V&hu;4MG z&L&H%I%FpHi9EBNFX3n3f##34V@PPp@eyg*GUn}JlSIFY?fqOg3!+gjBNc));;QJp zaJTzSx;3wqMHwCd9zo(%in~^r@slJq(3<+J`jXkZOrMF?UShypA!vlF1kHJUDVN=M zi{jq6-$aK=?00(O5S`S8b`8W~4pILIozJG~Qiz*V&S>K#2#O3lFbo@O0jutmO z6A0EE5@_AcL_Y-WF1&Y`jl-ekmmt(Hbm=J;7;i2FPd+2}oQ>p25n zVSXKMnu-1kc$0F}v#qP)%%JN<{_8)vP?&=`gj9~*Y~iuf#lal@e0$j**IF#)_4$$) z47b0MK?av>dMY97xgCi5XZp&sxwWEyT>&JEEb|5yvV1wW*sLVG;LUwD(8g1ycb2A8 zry0wu5vQ_#s$r>>&wuk*G?{FmriYrZG)c|xeQXT^7(1;a)%3VS^!a1uuq?NrmCtag zo|ER*@pp;?72TYR8!sM{k^}8Gat+n4>{Qk-?nX08(`na0j}0n4;D@F54_bHF##j;{ zdU~=g<?`L0}~=vGK>i;@rY941fQ>)ep7k7nHkV^ zoNEi?YFh`Ve^Gu*eDTo!`qJE1`>@GQmAh$oxnp)R!N5yyZGj+}#TI$VB%8%^6W*+OLM+J=9#s(L0Q=Y%>Vy$%w5k2b;VO=uxu7 zo#7KZRt5I!Uw7~|%(MirbS^Uvqr(eNLa^D@JP8k>oyL&={lx!Qq