From d3f1ba258cd8a6efd35f36ead870d1bd912b2a1e Mon Sep 17 00:00:00 2001 From: Ricky Reusser Date: Fri, 14 Oct 2016 10:53:36 -0400 Subject: [PATCH 1/2] Add note directing to pretest --- test/image/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/image/README.md b/test/image/README.md index 8938f2e3927..a16cf4caa37 100644 --- a/test/image/README.md +++ b/test/image/README.md @@ -1,6 +1,6 @@ # plotly.js image testing -Test plotly.js with Plotly's image testing docker container. +Test plotly.js with Plotly's image testing docker container. Before starting, don't forget to [set up your testing environment with `npm run pretest`](https://github.com/plotly/plotly.js/blob/master/CONTRIBUTING.md#development). Requirements: - `docker` | [installation guidelines][docker-install] From ddf3abaebb04d456852947d601711d9f11145bf8 Mon Sep 17 00:00:00 2001 From: Ricky Reusser Date: Fri, 14 Oct 2016 11:18:48 -0400 Subject: [PATCH 2/2] Modify pretest comment --- test/image/README.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/test/image/README.md b/test/image/README.md index a16cf4caa37..16ebfbfa881 100644 --- a/test/image/README.md +++ b/test/image/README.md @@ -1,6 +1,6 @@ # plotly.js image testing -Test plotly.js with Plotly's image testing docker container. Before starting, don't forget to [set up your testing environment with `npm run pretest`](https://github.com/plotly/plotly.js/blob/master/CONTRIBUTING.md#development). +Test plotly.js with Plotly's image testing docker container. Requirements: - `docker` | [installation guidelines][docker-install] @@ -57,6 +57,12 @@ The image testing docker container allows plotly.js developers to ([B](#b-run-image-export-tests)) run image export tests and ([C](#c-generate-or-update-existing-baseline-image)) generate baseline images. +Before starting, don't forget to [set up your testing environment](https://github.com/plotly/plotly.js/blob/master/CONTRIBUTING.md#development): + +```bash +$ npm run pretest +``` + **IMPORTANT:** the image tests scripts do **not** bundle the source files before running the image tests. We recommend running `npm run watch` or `npm start` in a separate tab to ensure that the most up-to-date code is used.