Skip to content

Make range selector active button color settable #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
VeraZab opened this issue Jul 28, 2016 · 5 comments · Fixed by #796
Closed

Make range selector active button color settable #790

VeraZab opened this issue Jul 28, 2016 · 5 comments · Fixed by #796
Assignees
@etpinard
Labels
feature something new
Milestone
v1.16.0

Comments

@VeraZab
Copy link

VeraZab commented Jul 28, 2016

It appears that I cannot change the background color of the 'all' rangeslider button.
Is this the intended behavior?
http://codepen.io/veraz/pen/XKYLoQ?editors=0010#anon-login
@etpinard
Copy link
Contributor

confirmed.

@etpinard etpinard self-assigned this Jul 28, 2016
@etpinard etpinard added the bug something broken label Jul 28, 2016
@etpinard etpinard changed the title change color of the {step: 'all'} rangeslider button change color of the {step: 'all'} range selector button Jul 28, 2016
@etpinard etpinard added this to the v1.16.0 milestone Jul 28, 2016
@etpinard
Copy link
Contributor

Oops. In fact, yes, the active button colour cannot be modified at the moment. See here it is always set via a constant.

Changing this to type: feature. But, this will still part of 1.16.0.

@etpinard etpinard added feature something new and removed bug something broken labels Jul 28, 2016
@etpinard
Copy link
Contributor

@VeraZab do you have a preference for the attribute name? Should it be:

  • rangeselector.activebgcolor or
  • rangeselector.bgcoloractive or
  • rangeselector.activecolor

??

(cc @cldougl @chriddyp )

@cldougl
Copy link
Member

cldougl commented Jul 28, 2016

I think I like rangeselector.activebgcolor the best

@etpinard etpinard changed the title change color of the {step: 'all'} range selector button Make range selector active button color settable Jul 29, 2016
@etpinard etpinard mentioned this issue Jul 29, 2016
Merged
4 tasks
@mmehrle
Copy link

mmehrle commented Mar 27, 2021

Five years later this answer actually helped me in python ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
feature something new
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging a pull request may close this issue.

Configurable range selector active color plotly/plotly.js
4 participants
@cldougl @VeraZab @etpinard @mmehrle