Skip to content

Should we expose a high-level bundler module / CLI ? #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
etpinard opened this issue Jul 22, 2016 · 4 comments
Closed

Should we expose a high-level bundler module / CLI ? #768

etpinard opened this issue Jul 22, 2016 · 4 comments

Comments

@etpinard
Copy link
Contributor

.. so that users (not familiar with browserify or webpack) could make easily make their own custom plotly.js bundle. See discussion starting from #740 (comment)

@rreusser
Copy link
Contributor

Could just move the _bundle function to an export of a standalone repo. So then plotly.js requires plotly.js-bundler as a dev dependency. Does plotly.js-bundler require plotly.js as a dependency? (which wouldn't actually need a circular require, but it's still a little weird.)

@etpinard
Copy link
Contributor Author

Does plotly.js-bundler require plotly.js as a dependency? (which wouldn't actually need a circular require, but it's still a little weird.)

I don't think so. We could make the default path to the plotly.js index require.resolve('plotly.js') while letting users set their own path.

If we go along that path, we should move the compress_attributes transform to this new repo and add a watchify-powered --watch option.

@etpinard
Copy link
Contributor Author

Closing.

Between our partial "dist" npm packages (added in #2670) and our building instructions, I don't see this happening.

@etpinard
Copy link
Contributor Author

Also referencing #1584 which applies our compress attribute transform by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants