Skip to content

Upgrade to mapbox-gl 0.21.0 #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mithrandi opened this issue Jul 20, 2016 · 3 comments · Fixed by #867
Closed

Upgrade to mapbox-gl 0.21.0 #756

mithrandi opened this issue Jul 20, 2016 · 3 comments · Fixed by #867
Labels
bug something broken
Milestone

Comments

@mithrandi
Copy link

mithrandi commented Jul 20, 2016

Currently, the dependency is on mapbox-gl^0.18.0; unfortunately, there are some problematic transitive dependencies of this version, resulting in a UNMET PEER DEPENDENCY browserify@>= 5 problem (which causes npm shrinkwrap to fail) as well as a deprecation warning from mapbox-gl-js-supported which has been renamed to mapbox-gl-supported.

Would it be possible to update the mapbox-gl version?

@etpinard
Copy link
Contributor

Thanks for the headsup!

I tried bumping the mapbox-gl version but it made one our image test fail. Not sure if it's a new bug in mapbox-gl or a wrong implementation of their API on our part.

Further investigation is needed. Hopefully for before releasing plotly.js v1.16.0.

@etpinard etpinard added bug something broken type: maintenance labels Jul 20, 2016
@etpinard etpinard added this to the v1.17.0 milestone Aug 8, 2016
@etpinard
Copy link
Contributor

Quick update: upgrading mapbox-gl will be a little trickier than I thought. The latest version removed mapboxgl.GeoJSONSource() and a few more methods that we're currently using. I'm still hoping to have mapbox-gl 0.22.x in plotly.js 1.17.0

@etpinard
Copy link
Contributor

Progress on the bump-mapbox branch.

Waiting for a response to mapbox/mapbox-gl-js#3032 before continuing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants