Skip to content

npm run citest-jasmine fails locally #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
etpinard opened this issue Jun 20, 2016 · 3 comments · Fixed by #1211
Closed

npm run citest-jasmine fails locally #666

etpinard opened this issue Jun 20, 2016 · 3 comments · Fixed by #1211

Comments

@etpinard
Copy link
Contributor

Looks like npm run citest-jasmine is calibrated for CircleCI only.

Off 3c85d9e

image

I suspect that these issues are related to the browser window size. The failing tests should go away once we add a window-size flag in the karma.ciconf.js file like we currently do in the (local) karma.conf.js.

Moreover, perhaps we should merge the two karma conf files into one and use the CirlcleCI environment variable to set up CI specific flags.

@alexcjohnson
Copy link
Collaborator

Locally I see a default body margin of 8px. I'd rather just set this to 0, then the pixel positions we have to use for mouse events will make more sense anyway. I'll try to address this in my working branch.

@etpinard
Copy link
Contributor Author

etpinard commented Jun 23, 2016

@rreusser off v1.14.0:

Firefox 42.0.0 (Mac OS X 10.11.0) mapbox plots should be able to relayout FAILED
    Expected 80,100,904,270 to be close to 80,100,908,270.

and

Firefox 42.0.0 (Mac OS X 10.11.0) hover on fill should always show one label in the right place FAILED
    Expected 254.27499999999998 to be close to 249.175, -1, 'trace 2:x'.
    assertLabelsCorrect/</<@/var/folders/5s/mm8_jrls0zd34zkb1z71xb940000gp/T/3e5f6eaff748734ec0be007b7921fd04.browserify:152118:17 <- tests/hover_label_test.js:673:0

@rreusser
Copy link
Contributor

rreusser commented Jun 23, 2016

Failed tests:

  • tests/hover_label_test.js:673:0
  • tests/mapbox_test.js:361:0

Commit: b6fc59d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants