-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
npm run citest-jasmine fails locally #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Locally I see a default body margin of 8px. I'd rather just set this to 0, then the pixel positions we have to use for mouse events will make more sense anyway. I'll try to address this in my working branch. |
@rreusser off
and
|
Failed tests:
Commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like
npm run citest-jasmine
is calibrated for CircleCI only.Off 3c85d9e
I suspect that these issues are related to the browser window size. The failing tests should go away once we add a
window-size
flag in thekarma.ciconf.js
file like we currently do in the (local)karma.conf.js
.Moreover, perhaps we should merge the two karma conf files into one and use the CirlcleCI environment variable to set up CI specific flags.
The text was updated successfully, but these errors were encountered: