Skip to content

New layout.legend xref and yref features don't default to container but to paper #6611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeorgeFlorian opened this issue May 24, 2023 · 2 comments

Comments

@GeorgeFlorian
Copy link

I've seen the PR: #6589 and I got excited for this new feature because I don't need to calculate legend positioning for each view size.

But on this line here: 5c94e46#diff-5da3ec3a0416c8572b65cf31fe31dbc248f8791065a6749405076431efea1179R173 it says dflt: 'container', with I guess is default value: "container" ?

But on this pen: https://codepen.io/hannahker/pen/wvEZZvN , if you comment "xref": "container", or "yref": "container", or replace the values with paper you can see that the default ref is container.

Is this intended or not ?

@archmoj
Copy link
Contributor

archmoj commented May 24, 2023

cc: @hannahker

@hannahker
Copy link
Contributor

@GeorgeFlorian yes, it is intended for both xref and yref to default to paper. The commit you've linked was updated. you can see the final attribute definition here: https://github.com/plotly/plotly.js/pull/6589/files#diff-5da3ec3a0416c8572b65cf31fe31dbc248f8791065a6749405076431efea1179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants