Skip to content

Histograms nbinsx and nbinsy descriptions are wrong #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yankev opened this issue Jun 7, 2016 · 2 comments
Closed

Histograms nbinsx and nbinsy descriptions are wrong #614

yankev opened this issue Jun 7, 2016 · 2 comments
Labels
bug something broken

Comments

@yankev
Copy link
Contributor

yankev commented Jun 7, 2016

Example:
After setting the nbinsx parameter to 20, the number of bins showing is 15. Also tried with other values for nbinsx, and results vary.

https://jsfiddle.net/2k0q2yg8/

@etpinard
Copy link
Contributor

etpinard commented Jun 8, 2016

Ha. That's a description bug.

nbinx doesn't directly set the number of bins but the maximum number of bins allowed by the autobin algorithm. The autobin algorithm attempts to keep the bin size nice.

The old plot.ly workspace got this right:

image

i.e. that Max # X bin row.

For fully custom bin sizes, you should use xbins.start, xbins.end, xbins.size.

Changing the issue accordingly.

@etpinard etpinard changed the title Histograms aren't showing the correct number of bars Histograms nbinsx and nbinsy descriptions are wrong Jun 8, 2016
@etpinard etpinard added the bug something broken label Jun 8, 2016
@etpinard
Copy link
Contributor

etpinard commented Jun 8, 2016

@yankev wanna try to make PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

2 participants