Skip to content

Plot sizing issue in 1.58.0 release #5314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmbarry86 opened this issue Dec 4, 2020 · 4 comments · Fixed by #5315
Closed

Plot sizing issue in 1.58.0 release #5314

dmbarry86 opened this issue Dec 4, 2020 · 4 comments · Fixed by #5315
Assignees
Labels
bug something broken regression this used to work

Comments

@dmbarry86
Copy link

The 1.58.0 release yesterday has changed (broken) some sizing behaviour we have in bullet charts. It appears that heights are not correct.

In releases prior to 1.58.0 we had a plot which looked like this:
image

When updating to 1.58.0 the same plot code now looks like this:
image

We are specifying widths and heights in the layout but it seems like they are not being adhered to in 1.58.0.

I have created a codepen which demonstrates the issue. In the codepen, if you change the plotly import version from 1.58.0 to a prior version, e.g. 1.57.0 then you will see the expected behaviour.
https://codepen.io/dmbarry86/pen/qBabyNa

@archmoj archmoj added bug something broken regression this used to work labels Dec 4, 2020
@archmoj archmoj self-assigned this Dec 4, 2020
@archmoj
Copy link
Contributor

archmoj commented Dec 4, 2020

Thanks for the report and clear codepen.
It could be also replicated even without react.
So here is the minimal codepen.

@dmbarry86
Copy link
Author

Thanks for the quick fix @archmoj. I have just tested 1.58.1 release and can confirm the issue is now resolved 👌

@archmoj
Copy link
Contributor

archmoj commented Dec 4, 2020

Thanks for the quick fix @archmoj. I have just tested 1.58.1 release and can confirm the issue is now resolved

dmbarry86
Thanks for your report and clear codepen!
AS a side note I noticed you added axis to the trace but it is not used as it should be in gauge object similar to https://github.com/plotly/plotly.js/blob/master/test/image/mocks/automargin-narrow-indicator.json

@dmbarry86
Copy link
Author

Thanks for the quick fix @archmoj. I have just tested 1.58.1 release and can confirm the issue is now resolved

dmbarry86
Thanks for your report and clear codepen!
AS a side note I noticed you added axis to the trace but it is not used as it should be in gauge object similar to https://github.com/plotly/plotly.js/blob/master/test/image/mocks/automargin-narrow-indicator.json

Thanks for pointing that out. I have just double checked our actual component code and axis is correctly part of the gauge object. Whilst stripping down our component code in to a codepen example I think axis got misplaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken regression this used to work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants