Skip to content

Not enough pad for tickangle -90 on the left side or with tickangle 90 on the right side #5301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
archmoj opened this issue Nov 24, 2020 · 4 comments · Fixed by #5275
Closed

Not enough pad for tickangle -90 on the left side or with tickangle 90 on the right side #5301

archmoj opened this issue Nov 24, 2020 · 4 comments · Fixed by #5275
Assignees
@archmoj
Labels
bug something broken
Milestone
v1.58.0

Comments

@archmoj
Copy link
Contributor

archmoj commented Nov 24, 2020

codepen
@archmoj archmoj added the bug something broken label Nov 24, 2020
@archmoj archmoj added this to the v1.58.0 milestone Nov 24, 2020
@archmoj archmoj self-assigned this Nov 24, 2020
@archmoj
Copy link
Contributor Author

archmoj commented Nov 24, 2020

This would be fixed in #5275.

@archmoj
Copy link
Contributor Author

archmoj commented Nov 24, 2020

Here:

plotly.js/src/plots/cartesian/axes.js

Line 2594 in f7baf5d

ff = Math.abs(ax.tickangle) === 90 ? 0.5 : 0;

instead of 0.5 here for those particular tickangle and side pairs, one should use CAP_SHIFT.

@archmoj archmoj mentioned this issue Nov 25, 2020
Merged
@archmoj
Copy link
Contributor Author

archmoj commented Nov 26, 2020

Also encountered a similar issue on the x-axis which is now addressed in #5275.

@archmoj
Copy link
Contributor Author

archmoj commented Nov 26, 2020

Also encountered a similar issue on the x-axis which is now addressed in #5275.

Codepen illustrating the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archmoj archmoj

Labels
bug something broken
Projects
None yet
Milestone
v1.58.0
Development

Successfully merging a pull request may close this issue.

Implement ticklabelposition for cartesian subplots and colorbars plotly/plotly.js
1 participant
@archmoj