Skip to content

should increase autorange pad for long inside ticks #5264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
archmoj opened this issue Nov 11, 2020 · 5 comments
Closed

should increase autorange pad for long inside ticks #5264

archmoj opened this issue Nov 11, 2020 · 5 comments

Comments

@archmoj
Copy link
Contributor

archmoj commented Nov 11, 2020

codepen

@nicolaskruchten
Copy link
Contributor

We can log a bug here but I'm OK not working on this just now.

@alexcjohnson
Copy link
Collaborator

I don't think this should be the default behavior. When we give folks the ability to customize the padding they can do it manually. cc #1876

@archmoj
Copy link
Contributor Author

archmoj commented Nov 11, 2020

This conflicts with #5186. Namely when both ticks and ticklabelposition are set to inside.

@alexcjohnson
Copy link
Collaborator

I don't see that as a conflict - labels should by default not overlap the data, so when those are inside the padding should increase enough for the labels and any space between the labels and the axis (ie where the ticks are). But if you've asked for inside ticks without inside labels, there are plenty of cases where the ticks overlapping the data is what you want - heatmaps, lines going to the edge, etc.

@archmoj
Copy link
Contributor Author

archmoj commented Nov 11, 2020

Thanks for the clarification. So I'll only address this for the case of "inside" ticklabelposition without touching the default behaviour for other "inside" ticks.

@archmoj archmoj closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants