Skip to content

Encountered two full labels using ticklabelmode: 'period' #5071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
archmoj opened this issue Aug 12, 2020 · 1 comment
Closed

Encountered two full labels using ticklabelmode: 'period' #5071

archmoj opened this issue Aug 12, 2020 · 1 comment
Assignees
Labels
bug something broken

Comments

@archmoj
Copy link
Contributor

archmoj commented Aug 12, 2020

testing this out this seems to introduce a (much more minor) bug with regular non-reversed axes when the tick corresponding to the first tick label is just out-of-range, we get the full 2-line label twice:

Screen Shot 2020-08-11 at 5 56 06 PM

It'd be nice to include jasmine tests for ^^ both forward and reversed, with the original range shifted in something like 6-hour increments - so ranges:

['2019-12-29', '2020-01-04']
['2019-12-29 06', '2020-01-04 06']
['2019-12-29 12', '2020-01-04 12']
['2019-12-29 18', '2020-01-04 18']
['2020-01-04 18', '2019-12-29 18']
['2020-01-04 12', '2019-12-29 12']
['2020-01-04 06', '2019-12-29 06']
['2020-01-04', '2019-12-29']

And just check that the tick text we get in each case is as expected. Something like that should cover all the related cases, I'd think.

Originally posted by @alexcjohnson in #5060 (comment)

@archmoj archmoj added the bug something broken label Aug 12, 2020
@archmoj archmoj self-assigned this Aug 12, 2020
@archmoj
Copy link
Contributor Author

archmoj commented Aug 13, 2020

Fixed by 9399031.

@archmoj archmoj closed this as completed Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

1 participant