Skip to content

Base attribute bug #5057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skrobec opened this issue Aug 10, 2020 · 4 comments · Fixed by #5061
Closed

Base attribute bug #5057

skrobec opened this issue Aug 10, 2020 · 4 comments · Fixed by #5061
Assignees
Labels
bug something broken

Comments

@skrobec
Copy link

skrobec commented Aug 10, 2020

I have tried to make simple timeline with the help of base attribute. Run into problem with low x values. If x is lower than 10000 ms, plot breaks as seen in example. With values higher than 10s, plot works as expected. Possible bug, thanks for help or maybe explanation if i am doing something wrong.

Codepen - https://codepen.io/kristi-n-krob-nek/pen/dyMoKNJ

Also tried to look for similar issue before posting, but found nothing close to this problem.

@nicolaskruchten nicolaskruchten added the bug something broken label Aug 10, 2020
@nicolaskruchten
Copy link
Contributor

This has been reported in Plotly.py as well, plotly/plotly.py#2658

Indeed this seems like a bug.

@archmoj
Copy link
Contributor

archmoj commented Aug 10, 2020

The problem appears within the range of positive and negative 10000 ms.
@skrobec Could you please confirm?

@archmoj archmoj self-assigned this Aug 10, 2020
@archmoj
Copy link
Contributor

archmoj commented Aug 10, 2020

After some investigation, the issue appears not to be related to bars and bases.
Instead the way the dates are handled is rather confusing.
Please see this demo.
Should we handle case of 2000 as 2000 years or 2000 milliseconds?

@skrobec
Copy link
Author

skrobec commented Aug 11, 2020

The problem appears within the range of positive and negative 10000 ms.
@skrobec Could you please confirm?

Yes, so it seems.

After some investigation, the issue appears not to be related to bars and bases.
Instead the way the dates are handled is rather confusing.
Please see this demo.
Should we handle case of 2000 as 2000 years or 2000 milliseconds?

It would make sense that number type should be taken as milliseconds. Years and other types should be specified as string in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants