Skip to content

3d camera reset after react #5005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolaskruchten opened this issue Jul 21, 2020 · 8 comments
Open

3d camera reset after react #5005

nicolaskruchten opened this issue Jul 21, 2020 · 8 comments
Assignees
Labels
bug something broken P3 backlog regression this used to work

Comments

@nicolaskruchten
Copy link
Contributor

nicolaskruchten commented Jul 21, 2020

This one has a very specific replication path from this pen: https://codepen.io/nicolaskruchten/pen/NWxoWGR?editors=0010

  1. newPlot@0
  2. react@1 (this is the critical step to get the figure into the broken state)
  3. do turntable interaction via drag
  4. click on "zoom" modebar icon: the turntable interaction is undone!

Alternate path:

  1. newPlot@0
  2. react@1 (this is the critical step to get the figure into the broken state)
  3. click on "zoom" modebar icon and zoom a bit via drag
  4. click on "turntable" modebar icon: the zoom interaction is undone!
@nicolaskruchten nicolaskruchten added the bug something broken label Jul 21, 2020
@nicolaskruchten
Copy link
Contributor Author

Related to #5004 ? same pen... with uirevision set.

@archmoj archmoj added the regression this used to work label Jul 21, 2020
@archmoj
Copy link
Contributor

archmoj commented Jul 21, 2020

This one is a regression since v1.51.0 and the side effect of #4292.

@nicolaskruchten
Copy link
Contributor Author

Even in 1.50.0 it doesn't behave particularly well... it's easy to get into situations where clicking among the modebar buttons changes the zoom level.

@archmoj
Copy link
Contributor

archmoj commented Jul 22, 2020

Even in 1.50.0 it doesn't behave particularly well... it's easy to get into situations where clicking among the modebar buttons changes the zoom level.

@nicolaskruchten thanks for investigating that using v1.50.0.
Concerning replicating the original issue, would you please keep the version in the original pen at 1.54.6?
Thank you.

@nicolaskruchten
Copy link
Contributor Author

Sorry, I didn't fork! I've pinned the pen to -latest

@nicolaskruchten
Copy link
Contributor Author

this seems to be the case even switching from zoom to pan and back

@archmoj archmoj self-assigned this Jul 29, 2020
@archmoj
Copy link
Contributor

archmoj commented Jul 29, 2020

Seems related to undefined initial camera position.

@archmoj
Copy link
Contributor

archmoj commented Jul 29, 2020

This is very strange bug. The fix works in the dashboard but not in a codepen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken P3 backlog regression this used to work
Projects
None yet
Development

No branches or pull requests

3 participants