Skip to content

heatmapgl does not coerce its own attributes #4945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
archmoj opened this issue Jun 24, 2020 · 1 comment · Fixed by #4950
Closed

heatmapgl does not coerce its own attributes #4945

archmoj opened this issue Jun 24, 2020 · 1 comment · Fixed by #4950
Assignees
@archmoj
Labels
bug something broken

Comments

@archmoj
Copy link
Contributor

archmoj commented Jun 24, 2020

The heatmapgl trace needs its own default function.
Right now it uses heatmap default and attributes.
As a result attributes e.g. zsmooth, xgap, connectgaps, hoverongaps, and more get into gd._fullData.
@archmoj archmoj added the bug something broken label Jun 24, 2020
@archmoj archmoj self-assigned this Jun 24, 2020
@archmoj
Copy link
Contributor Author

archmoj commented Jun 24, 2020

This is a bug we need to fix before #4924. Whereas the default smoothing of heatmapgl is similar to fast, zsmooth is actually set to false!

@archmoj archmoj mentioned this issue Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archmoj archmoj

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix heatmapgl supplyDefaults plotly/plotly.js
1 participant
@archmoj