Skip to content

The preprocess is broken. #4863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cy6eria opened this issue May 25, 2020 · 3 comments
Closed

The preprocess is broken. #4863

cy6eria opened this issue May 25, 2020 · 3 comments

Comments

@cy6eria
Copy link
Contributor

cy6eria commented May 25, 2020

Problem: The npm run preprocess fails with message: "TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Object".
OS: Mac OS 10.15.4
Node: 14.2.0
Version: With HEAD on 5010b80.

The cause of the problem is in the tasks/util/update_version.js The falafel package returns an Object, but fs.writeFile expect string, Buffer, TypedArray or DataView.

@archmoj
Copy link
Contributor

archmoj commented May 25, 2020

That may be related to the node version. Have you tried using node 12 instead?

@cy6eria
Copy link
Contributor Author

cy6eria commented May 25, 2020

@archmoj hi, i almost sure that it is. I tested with 12.16.3 and it works. I've created a simple fix and it doesn't affect the script on 12.16.3, but works with 14.2.0.

@gvwilson
Copy link
Contributor

Hi - we are trying to tidy up the stale issues and PRs in Plotly's public repositories so that we can focus on things that are still important to our community. Since this one has been sitting for several years, I'm going to close it; if it is still a concern, please add a comment letting us know what recent version of our software you've checked it with so that I can reopen it and add it to our backlog. Thanks for your help - @gvwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants