Skip to content

spike lines do not appear when spikedistance #4626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
antoinerg opened this issue Mar 11, 2020 · 8 comments · Fixed by #4637
Closed

spike lines do not appear when spikedistance #4626

antoinerg opened this issue Mar 11, 2020 · 8 comments · Fixed by #4637
Labels
bug something broken

Comments

@antoinerg
Copy link
Contributor

antoinerg commented Mar 11, 2020

At least in some traces: https://codepen.io/antoinerg/pen/BaNYJve

To be clear, this test will fail: 9d1325c

Affects traces:

  • bar
  • ohlc
@antoinerg antoinerg added the bug something broken label Mar 11, 2020
@etpinard
Copy link
Contributor

Duplicate of #3805 ?

@etpinard
Copy link
Contributor

etpinard commented Mar 11, 2020

This problem probably affects all traces that use Fx.inbox to determine which element getting hovered on.

@antoinerg
Copy link
Contributor Author

Here's a potential fix for the current issue: pr-unified-hoverlabel...fix-spikeline-infinity

I'm not sure yet whether it also fixes #3805. I will have to test.

@antoinerg
Copy link
Contributor Author

It looks like it does fix issue #3805 as well:
Before: https://codepen.io/anon/pen/eoPXJE
After: https://codepen.io/antoinerg/pen/ExjQQYw

@etpinard
Copy link
Contributor

Right, that makes things work for spikedistance: -1, but what about for arbitrary spike distances?

@etpinard
Copy link
Contributor

(getting the -1 case fixed would still be a major step forward though 😄 )

@antoinerg
Copy link
Contributor Author

Right, that makes things work for spikedistance: -1, but what about for arbitrary spike distances?

Those already work don't they?

@antoinerg antoinerg changed the title spike lines do not appear when spikedistance set to -1 on bar traces spike lines do not appear when spikedistance Mar 12, 2020
@antoinerg
Copy link
Contributor Author

Closing in favor of #3805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants