Skip to content

Grouped legend alignment issue from 1.50 #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjordan84 opened this issue Nov 6, 2019 · 9 comments
Open

Grouped legend alignment issue from 1.50 #4336

mjordan84 opened this issue Nov 6, 2019 · 9 comments
Labels
bug something broken P3 backlog

Comments

@mjordan84
Copy link

Hi,

I've been using plotly.js for a few month now (great work by the way) and noticed that since 1.50 legend groups are no longer aligned. As you can see in the attached example the 5th group is not aligned with the 2nd.
Is this an expected behaviour?

Example:
https://codepen.io/mjordan84/pen/LYYdeog

Thanks,
Marc

@archmoj
Copy link
Contributor

archmoj commented Nov 6, 2019

Possibly related to #4160.

@etpinard
Copy link
Contributor

That's correct, the behaviour changed after #4160 (released in v1.50.0).

I didn't intend to change it (see pre-1.50.0 behaviour here: https://codepen.io/etpinard/pen/abbXKpM), but I can't say which behaviour is better. What do you think @mjordan84 and @archmoj ?

That said, a breaking change is a breaking change, so I'll tag this as type: bug. If some people like the current (post v1.50.0) behaviour better, maybe we should think about adding a new grouped legend option.

This ticket is somewhat related to #960

@etpinard etpinard added the bug something broken label Nov 19, 2019
@etpinard
Copy link
Contributor

current:

image

pre v1.50.0

image

@mjordan84
Copy link
Author

@etpinard as you said both seems valid. The new behaviour is a bit more problematic when only the first Item of each legend group is visible.
image

@etpinard
Copy link
Contributor

The new behaviour is a bit more problematic when only the first Item of each legend group is visible.

You mean when all but the first trace of each group has showlegend: false?

@mjordan84
Copy link
Author

Yes @etpinard , when the first element of each group has showlegend: true then the rest set to false in that group.
https://codepen.io/mjordan84/pen/GRRzXoz

@nicolaskruchten nicolaskruchten added this to the v1.5x.0 milestone May 12, 2020
@gvwilson
Copy link
Contributor

Hi - we are trying to tidy up the stale issues and PRs in Plotly's public repositories so that we can focus on things that are still important to our community. Since this one has been sitting for several years, I'm going to close it; if it is still a concern, please add a comment letting us know what recent version of our software you've checked it with so that I can reopen it and add it to our backlog. Thanks for your help - @gvwilson

@mjordan84
Copy link
Author

The issue is still present in the latest version.

@gvwilson
Copy link
Contributor

Thanks @mjordan84 - I'll reopen it and try to get it into our backlog

@gvwilson gvwilson reopened this Jun 18, 2024
@gvwilson gvwilson self-assigned this Jun 18, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added the P3 backlog label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken P3 backlog
Projects
None yet
Development

No branches or pull requests

5 participants