Skip to content

Problem with marker.line.width arrays containing scientific number strings #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
archmoj opened this issue Jul 17, 2019 · 5 comments · Fixed by #4063
Closed

Problem with marker.line.width arrays containing scientific number strings #4057

archmoj opened this issue Jul 17, 2019 · 5 comments · Fixed by #4063
Labels
bug something broken

Comments

@archmoj
Copy link
Contributor

archmoj commented Jul 17, 2019 •
edited
Loading

Scientific numbers in marker.line.width arrays may cause bar plot to fill the rest of plot in black!
Codepen.
@archmoj archmoj changed the title Hover problem with marker.line.width arrays containing scientific number strings Problem with marker.line.width arrays containing scientific number strings Jul 17, 2019
@etpinard
Copy link
Contributor

Good eye. Replacing "1e1" with 1e1 gives the correct result: https://codepen.io/etpinard/pen/KOPYJo?editors=0010

I wonder what we do elsewhere with exponent-notation inside strings (e.g. "1e1"). Do they even pass isNumeric?

@etpinard etpinard added the bug something broken label Jul 17, 2019
@archmoj
Copy link
Contributor Author

archmoj commented Jul 17, 2019

It is pretty strange. Only happens with bar and not with histogram, funnel or waterfall.
This might be a better codepen to illustrate the issue.

@archmoj
Copy link
Contributor Author

archmoj commented Jul 17, 2019

A regression may be involved here since 1.29.0:
Codepen.

@archmoj archmoj mentioned this issue Jul 17, 2019
Merged
@etpinard
Copy link
Contributor

@archmoj wanna close this one too?

@archmoj
Copy link
Contributor Author

archmoj commented Jul 18, 2019

No. In respect to #4056 (comment) let's keep that open until we apply similar fixes (already applied for bars) for other traces.

@archmoj archmoj mentioned this issue Jul 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filter numbers during calc step plotly/plotly.js
2 participants
@etpinard @archmoj