Skip to content

Zero numbers are neither plotted nor included in hover on sunburst and pie text #3843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
archmoj opened this issue May 8, 2019 · 3 comments · Fixed by #3847
Closed

Zero numbers are neither plotted nor included in hover on sunburst and pie text #3843

archmoj opened this issue May 8, 2019 · 3 comments · Fixed by #3847
Assignees
@archmoj
Labels
bug something broken
Milestone
v1.48.0

Comments

@archmoj
Copy link
Contributor

archmoj commented May 8, 2019

Codepen.
@archmoj archmoj added the bug something broken label May 8, 2019
@archmoj archmoj self-assigned this May 8, 2019
@etpinard
Copy link
Contributor

etpinard commented May 8, 2019

Could you check sunburst too?

@archmoj
Copy link
Contributor Author

archmoj commented May 8, 2019

Confirmed sunburst has the same issue. It looks like we may have similar issue in hover.
And what about the case of true? Should true be displayed? If so why not false?
Please refer to this codepen as an example.

@etpinard
Copy link
Contributor

etpinard commented May 8, 2019

Should true be displayed?

yes

If so why not false?

The only falsy value we should (and currently do) display is 0.

@archmoj archmoj changed the title Pie textinfo is not printed when text is a zero number Pie & sunburst textinfo & hovertext are not printed when text is a zero number May 9, 2019
@archmoj archmoj added this to the v1.48.0 milestone May 9, 2019
@archmoj archmoj mentioned this issue May 9, 2019
Merged
@archmoj archmoj changed the title Pie & sunburst textinfo & hovertext are not printed when text is a zero number Zero numbers are neither plotted nor included in hover on sunburst and pie text May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archmoj archmoj

Labels
bug something broken
Projects
None yet
Milestone
v1.48.0
Development

Successfully merging a pull request may close this issue.

Display zero number in pie and sunburst text and hover plotly/plotly.js
2 participants
@etpinard @archmoj