Skip to content

Refactor plot_api exports #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
archmoj opened this issue Apr 22, 2019 · 0 comments · Fixed by #3808
Closed

Refactor plot_api exports #3799

archmoj opened this issue Apr 22, 2019 · 0 comments · Fixed by #3808

Comments

@archmoj
Copy link
Contributor

archmoj commented Apr 22, 2019

plot_api function calls & exports are a bit unclear. We should spend some time refactoring the export to have something like this:

module.exports = {
    animate: animate,
    addFrames: addFrames,
    deleteFrames: deleteFrames,

    addTraces: addTraces,
    deleteTraces: deleteTraces,
    extendTraces: extendTraces,
    moveTraces: moveTraces,
    prependTraces: prependTraces,

    newPlot: newPlot,
    plot: plot,
    purge: purge,

    react: react,
    redraw: redraw,
    relayout: relayout,
    restyle: restyle,

    setPlotConfig: setPlotConfig,

    update: update,

    _guiRelayout: guiEdit(relayout),
    _guiRestyle: guiEdit(restyle),
    _guiUpdate: guiEdit(update),

    _storeDirectGUIEdit: _storeDirectGUIEdit
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant