Skip to content

Waterfall connector.line.color not in _fullData #3784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolaskruchten opened this issue Apr 17, 2019 · 2 comments · Fixed by #3788
Closed

Waterfall connector.line.color not in _fullData #3784

nicolaskruchten opened this issue Apr 17, 2019 · 2 comments · Fixed by #3788
Assignees
@archmoj
Labels
bug something broken

Comments

@nicolaskruchten
Copy link
Contributor

The reason there's no connector-line-color widget appearing in the RCE is that that attr isn't getting coerced (or something!) and hence not appearing in _fullData:

image
@etpinard
Copy link
Contributor

@archmoj do all connectors have the same default line color?

@etpinard
Copy link
Contributor

If so, turning

plotly.js/src/traces/waterfall/attributes.js

Line 97 in 424c686

color: lineAttrs.color,

into

line: extendFlat({}, lineAttr.color, {dflt: Color.defaultLine},

should do the trick.

@etpinard etpinard added the bug something broken label Apr 17, 2019
@archmoj archmoj mentioned this issue Apr 17, 2019
Merged
@archmoj archmoj self-assigned this Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archmoj archmoj

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Waterfall connector.line.color coerce and default fixup plotly/plotly.js
3 participants
@nicolaskruchten @etpinard @archmoj