Skip to content

bargap in barmode=relative #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolaskruchten opened this issue Mar 19, 2019 · 2 comments
Closed

bargap in barmode=relative #3649

nicolaskruchten opened this issue Mar 19, 2019 · 2 comments
Assignees
Labels
bug something broken
Milestone

Comments

@nicolaskruchten
Copy link
Contributor

If I make a multi-trace histogram with barmode set to "relative", I would expect the bargap to stay 0, like it does in "stack".

Per @alexcjohnson:

We should really coerce barmode first, then invoke this logic only for barmode !== 'group'. And of course update it when bar stackgroup becomes a thing…

@nicolaskruchten nicolaskruchten added the bug something broken label Mar 19, 2019
@etpinard etpinard added this to the v1.46.0 milestone Mar 19, 2019
@etpinard
Copy link
Contributor

@antoinerg would you be interested in taking this one at some point this week?

@antoinerg antoinerg self-assigned this Mar 19, 2019
@nicolaskruchten
Copy link
Contributor Author

This was the link @etpinard dropped into Slack about where in the code it's happening:

coerce('bargap', (shouldBeGapless && !gappedAnyway) ? 0 : 0.2);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

3 participants