Skip to content

Sankey nodes jump on dragging #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexcjohnson opened this issue Feb 21, 2019 · 2 comments
Closed

Sankey nodes jump on dragging #3563

alexcjohnson opened this issue Feb 21, 2019 · 2 comments
Labels
bug something broken regression this used to work

Comments

@alexcjohnson
Copy link
Collaborator

When you drag a sankey node, on first mouse move it jumps vertically (or horizontally if the diagram is horizontal). Bug exists on master but not in the latest release 1.44.4
sankey-drag-jump
cc @antoinerg

@alexcjohnson alexcjohnson added bug something broken regression this used to work labels Feb 21, 2019
@antoinerg
Copy link
Contributor

antoinerg commented Feb 21, 2019

Thank you @alexcjohnson for reporting this issue. It has to do with a change of coordinates that is done prior to running the force simulation on drag.

However, I think I resolved this issue at some point. Did you run npm i before starting your devtools? I can't reproduce the issue on my machine right now.

@alexcjohnson
Copy link
Collaborator Author

I first saw this in the codepen you posted this morning https://codepen.io/antoinerg/pen/MLxjmB and then pulled master and npm i on my mac to confirm it wasn't just whatever branch that is. I see it on all my browsers - Chrome, FF, Safari.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken regression this used to work
Projects
None yet
Development

No branches or pull requests

2 participants