Skip to content

Vertical modebars with wrapped buttons don't honor modebar.bgcolor #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
antoinerg opened this issue Jan 30, 2019 · 3 comments
Closed

Vertical modebars with wrapped buttons don't honor modebar.bgcolor #3499

antoinerg opened this issue Jan 30, 2019 · 3 comments
Assignees
@antoinerg

Comments

@antoinerg
Copy link
Contributor

As shown in this Codepen: https://codepen.io/anon/pen/KJawXR
@antoinerg antoinerg self-assigned this Jan 30, 2019
@antoinerg
Copy link
Contributor Author

The reason we hit this issue is that all modern browsers do not respect the spec and do not grow the width of flex containers that wrap in column mode.

This was referenced Jan 31, 2019
Closed
Merged
@etpinard
Copy link
Contributor

@antoinerg this one got fixed in #3500 too, right?

@antoinerg
Copy link
Contributor Author

Yes it did! In #3500 we now style the background color of the button groups instead of the parent container which does not grow its width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoinerg antoinerg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antoinerg @etpinard