Skip to content

Plotly.react always redraw if a config option is provided #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
antoinerg opened this issue Oct 18, 2018 · 0 comments
Closed

Plotly.react always redraw if a config option is provided #3121

antoinerg opened this issue Oct 18, 2018 · 0 comments

Comments

@antoinerg
Copy link
Contributor

Running tests in plot_api_test.js result in Test plot api @noCIdep Plotly.react can redraw "airfoil" with no changes as a noop (svg mocks) FAILED.

The culprit is in PR #3090 which introduces new private attributes into _context. Because diffConfig does not ignore those, Plotly.react always redraw.
@antoinerg antoinerg changed the title Plotly.react redraws regardless if a config option is present Plotly.react always redraw if a config option is provided Oct 18, 2018
@antoinerg antoinerg mentioned this issue Oct 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@antoinerg