Skip to content

make date autoformatting (duplicate 2nd line omission) configurable #3108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cldougl opened this issue Oct 15, 2018 · 5 comments
Closed

make date autoformatting (duplicate 2nd line omission) configurable #3108

cldougl opened this issue Oct 15, 2018 · 5 comments
Labels
feature something new

Comments

@cldougl
Copy link
Member

cldougl commented Oct 15, 2018

When using properly formatted dates in the default format the second line is automatically omitted after the first tick if it doesn’t change.

  • it would be useful if this behaviour was configurable
  • it would be useful if this behaviour worked when tickformat is applied as well.
@markzolotoy
Copy link

Yes, very useful. It is absolutely critical for international applications.

@alexcjohnson alexcjohnson added the feature something new label Oct 16, 2018
@alexcjohnson
Copy link
Collaborator

@markzolotoy interesting, can you say more about why this becomes more important internationally? I agree that it's a useful feature, but the implication of your comment is that the labels are actually wrong, or unintelligible perhaps, with automatic duplicate pruning in other languages/calendars?

@markzolotoy
Copy link

markzolotoy commented Oct 16, 2018

When using default date formatting which for US dates it is working in that way. But try to achieve the same for any foreign date such as French or Chinese. Since our app. allows our customers flip between languages it is critical that it looks and feels exactly the same in every language.

@stringfellow
Copy link

stringfellow commented Nov 15, 2018

Another use case for this is one I have - I'd like to show the weekday in that date format part, which is very important for my use case, but I also don't want that to be repeated on every time tick. I think the line that causes this is:

return formatTime(x, tr) + '\n' + modDateFormat(extraFormat.dayMonthYear, x, formatter, calendar);

Would be very grateful for some way to customise or work around this (even if a workaround is to somehow override the dayMonthYear format...?)

@gvwilson
Copy link
Contributor

Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

No branches or pull requests

5 participants