Skip to content

Template issues #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 3 tasks
chriddyp opened this issue Sep 27, 2018 · 5 comments
Closed
2 of 3 tasks

Template issues #3055

chriddyp opened this issue Sep 27, 2018 · 5 comments
Labels
bug something broken

Comments

@chriddyp
Copy link
Member

chriddyp commented Sep 27, 2018

@etpinard etpinard added the bug something broken label Sep 27, 2018
@etpinard
Copy link
Contributor

Potentially related to: #3032

@etpinard
Copy link
Contributor

etpinard commented Oct 10, 2018

Some info:

Parcoords line colors:

The template propagates fine during react, the problem happens during the parcoords update. We can replicate this bug using restyle and relayout: https://codepen.io/etpinard/pen/YJVrKm


Carpet grid colors:

No bug here (I think). You' need to include startlinecolor and endlinecolor or color in your template: e.g. https://codepen.io/etpinard/pen/ZqKXOo?editors=1010


Polar grid lines:

This line:

// Note: does not need template propagation, since coerceAxis is still
// based on the subplot-wide coerce function. Though it may be more
// efficient to make a new coerce function, then we *would* need to
// propagate the template.
var axOut = contOut[axName] = {};

is off. In fact, we do need to propagate the template so that the attributes that use coerce2 can reach into _template. This should be an easy fix, PR incoming.

@jonmmease
Copy link
Contributor

So I've been able to get the carpet grid colors working in the carpet trace directly, but they don't seem to be coming through from the data portion of the template.

https://codepen.io/jonmmease/pen/NOjyya

Does my template data specification here look right?

@etpinard
Copy link
Contributor

Good 👁️ @jonmmease , fixed in #3095

@etpinard
Copy link
Contributor

All the "real" template issues listed here have been resolved.

The parcoords problems are now in -> #3101

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

3 participants