Skip to content

no variable shadowing #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexcjohnson opened this issue Sep 17, 2018 · 1 comment
Closed

no variable shadowing #3020

alexcjohnson opened this issue Sep 17, 2018 · 1 comment

Comments

@alexcjohnson
Copy link
Collaborator

consider enabling https://eslint.org/docs/rules/no-shadow - can save us from some very confusing bugs.

As @etpinard mentions in #3017:

That would require some work though, as no-shadow fails in more than 500 times in our codebase.

@etpinard
Copy link
Contributor

Now in -> #3162 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants