You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't know whether the string manipulations here are a meaningful contribution to the performance... but this could all be simplified a bit (indexOf & .substr instead of a regex & .replace, no .trim) if we could omit the space before the word scale. It seems to work fine in my browsers, though in principle it's not supposed to be allowed: "The individual transform definitions are separated by whitespace and/or a comma."
Alternatively, we could imagine stashing the pre-scaled transform as perhaps a data-initialtransform attribute on each element and avoid all this processing...
Not necessary, just a possibility if you think there would be a benefit.
which I replied:
I haven't benchmarked this particular block yet, but I know that Drawing.setTextPointsScale is 4-5 times slower than this routine here Drawing.setPointGroupScale. Spending time on making these routines faster would help improve scroll performance.
The text was updated successfully, but these errors were encountered:
When playing around with alternatives to regex .replace and .trim, we'll need to test them out in different browsers (all the way to IE9). I can imagine browsers not handling svg transform lists the exact same way.
Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson
Follow-up on #2623 and more precisely from @alexcjohnson 's #2623 (comment)
which I replied:
The text was updated successfully, but these errors were encountered: