Skip to content

Changing locale does not update mode bar buttons labels #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fhurta opened this issue Mar 20, 2018 · 4 comments · Fixed by #2592
Closed

Changing locale does not update mode bar buttons labels #2484

fhurta opened this issue Mar 20, 2018 · 4 comments · Fixed by #2592
Labels
bug something broken

Comments

@fhurta
Copy link
Contributor

fhurta commented Mar 20, 2018

I created pen initially in German - the buttons titles and dates on X-axis appears in German. Then changed the locale to English. The date format on X-axis updated but the buttons still contain the German texts.

https://codepen.io/exavier/pen/gegOmV?editors=1010

@etpinard
Copy link
Contributor

Hmm. I think I got it to work: https://codepen.io/etpinard/pen/RMKmoZ

@fhurta
Copy link
Contributor Author

fhurta commented Mar 20, 2018

Does it work for you? I tried in Chrome and Firefox (current versions) now and it still does not work.
The names on X-axis are updated but hovering over buttons, I still see german titles (e.g. Lassoauswahl for Lasso selection).

@etpinard
Copy link
Contributor

Ha, now I see it. Thanks!

@etpinard etpinard added the bug something broken label Mar 20, 2018
@alexcjohnson
Copy link
Collaborator

Plotly.plot should not be used on a plot with existing data - its behavior is weird: it adds the new data to the existing traces and ignores layout. I guess it does update config but this method should be considered deprecated.

If you meant to not change the plot, Plotly.newPlot does work as expected. Plotly.react however, which is really the only other approved way to change config, does not work correctly - it shows the same behavior as Plotly.plot - so I'll take that as the item to fix here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants