Skip to content

Make sure all our deps use the same glslify version #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
etpinard opened this issue Feb 1, 2018 · 6 comments
Closed

Make sure all our deps use the same glslify version #2321

etpinard opened this issue Feb 1, 2018 · 6 comments

Comments

@etpinard
Copy link
Contributor

etpinard commented Feb 1, 2018

This is a mess:

image
This was referenced Feb 2, 2018
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Closed
@etpinard
Copy link
Contributor Author

etpinard commented Feb 2, 2018

Hold on. Can you update our package-lock.json file before closing this?

@dy dy mentioned this issue Feb 2, 2018
Merged
@dy
Copy link
Contributor

dy commented Feb 2, 2018

@etpinard oh, I ignore package-lock.json. I can set it up though, but it will take a while.

@etpinard
Copy link
Contributor Author

etpinard commented Feb 2, 2018

@dfcreative it might be a good idea to spend time setting node8/npm5. If you don't this might lead to headaches down the road.

@dy
Copy link
Contributor

dy commented Feb 2, 2018

@etpinard done

@etpinard
Copy link
Contributor Author

etpinard commented Feb 2, 2018

that was fast!

@dy
Copy link
Contributor

dy commented Feb 2, 2018 •
edited
Loading

@etpinard I already have that installed, it is due to package-lock.json issues there was no way but disabling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dy @etpinard