Pie chart supply defaults generates empty marker.colors array

[bpostlethwaite]

Offending (?) line of code

plotly.js/src/traces/pie/defaults.js

Line 38 in 599dff9

if(!Array.isArray(colors)) traceOut.marker.colors = [];

This results in marker.colors being return by findArrayAttributes even though marker.colors is not in the user data. See https://codepen.io/bpostlethwaite/pen/dJozzo for an example.

This is seemingly inconsistent with standard fullData behaviour.

[alexcjohnson]

Possible other cases to worry about:

$ ag "dflt: \[\]"
traces/sankey/attributes.js
103:            dflt: [],
161:            dflt: [],
198:            dflt: [],
204:            dflt: [],
209:            dflt: [],

traces/ohlc/attributes.js
67:        dflt: [],
74:        dflt: [],
81:        dflt: [],
88:        dflt: [],

traces/parcoords/attributes.js
125:            dflt: [],

traces/table/attributes.js
72:            dflt: [],
83:            dflt: [],
152:            dflt: [],
163:            dflt: [],

transforms/groupby.js
32:        dflt: [],

A lot of these cases the trace wouldn't make sense without the attribute but... then what's the point of filling in an empty array?

[etpinard]

Alternatively, maybe we should skip over empty arrays here.

[alexcjohnson]

skip over empty arrays

Worries me a bit, empty arrays can, in some cases, be different from non-arrays or missing values.

[etpinard]

This appears fixed in 1.34.0 (most likely by the Plotly.react push)

compared to in 1.33.1:

Closing.