Skip to content

Lasso/select to not raise an error on choropleth if one of the traces is invisible #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
monfera opened this issue Oct 18, 2017 · 1 comment
Closed

Lasso/select to not raise an error on choropleth if one of the traces is invisible #2103

monfera opened this issue Oct 18, 2017 · 1 comment
Assignees
@monfera
Labels
bug something broken

Comments

@monfera
Copy link
Contributor

monfera commented Oct 18, 2017 •
edited
Loading

node3 in choropleth/select.js is undefined in this case, preventing lasso or box select from working. PR with fix: #2099

In the past, non-visible traces on choropleth were rare, but crossfilter adds an initially empty, therefore defaulting to non-visible layer to choropleth so the first lasso/select fails right away.
@monfera monfera self-assigned this Oct 18, 2017
@monfera monfera added the bug something broken label Oct 18, 2017
@monfera monfera changed the title Lasso/select to not raise an error if one of the traces is invisible Lasso/select to not raise an error on choropleth if one of the traces is invisible Oct 18, 2017
@monfera
Copy link
Contributor Author

monfera commented Oct 19, 2017

Fixed by #2099

@monfera monfera closed this as completed Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monfera monfera

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@monfera