-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Sankey nodeAlign? #1938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
cc @monfera |
@etpinard please tell me when to schedule it: Some of our PRs to upstream |
Definitively not a high priority for now, unless @jackparmer thinks otherwise. |
Yeah, no customers on my radar who are asking about this. Probably shelve for now. |
would be great to have this option! when visualizing process flows, it makes no sense that the terminal nodes are all on the right of the viz (as for those which did not pass the whole process, they should not be on the same level as all the nodes which did). |
Would be a very welcome addition indeed :) |
@harisbal How much control do you want to have over the position of the nodes. Would it be convenient if you could specify the |
@antoinerg controlling doesn't sound like a bad idea indeed. What I was thinking though is being able to control the number of "vertical" groups if that makes sense. For instance in the following example |
@harisbal thank you for the link showing how to use ranksets. This is a really handy feature when one wants to order their sankey data according to a temporal layout - for example when plotting the evolution of communities that appear and disappear over time. |
@JeroenSchmidt that;s exactly the issue I'm facing, where I try to depict some temporal data (often disappearing between nodes). |
@JeroenSchmidt @harisbal Thank you for reminding me of the need for this worthwhile feature. In the meantime, PR #3583 (set to be released in |
I endorse how interesting this feature would be. |
@antoinerg are there any updates on plans for specifying number of columns and ordering of nodes within those columns? |
I'm interested in this as well. What I would like to be able to is have 'terminal nodes' in the middle (i.e. some data flows end in the middle while other's flow through to the end and/or break down into further subgroups.) |
@antoinerg any update or trick to implement this? i want to put the terminal nodes by levels (aligned to left instead to right) it's bad to show this kind of things in production... thanks so much for help! |
This feature should not be hard to implement since it is supported in our dependencies. I started a branch a while ago https://github.com/plotly/plotly.js/compare/sankey2-node-align that shows what needs to be done. After resolving the conflicts, it might be good to go. I don't have the time to work on this at the moment but I can revisit later of help someone make a PR. |
Do we have any update on this feature? Are we looking to work on this soon? This is a good feature, and already available in our dependency. |
No one from the Plotly team is working on this at the moment but we’d be happy to accept a PR if someone wants to take Antoine’s work over the finish line :) |
@nicolaskruchten I would love to contribute, let me see how can i get that updated. |
This issue has been tagged with A community PR for this feature would certainly be welcome, but our experience is deeper features like this are difficult to complete without the Plotly maintainers leading the effort. Sponsorship range: $5k-$10k What Sponsorship includes:
Please include the link to this issue when contacting us to discuss. |
Bump on this issue? \ |
Hi everyone, I saw an 'align' property was added in plotly v5.19.0 to solve this issue. Unfortunately I can't make it work. I can try any of the 4 values ['center', 'right', 'left', 'justify'], but nothing will change. I tried with the same example as in the plotly sankey tutorial. I have the latest plotly version v5.19.0 Thank you for your help |
Same, tutorial examples in v5.19.0 are ignoring node alignment values. x and y values for nodes appear to also be ignored (EDIT: It looks like if y=0, the values are ignored, but non-zero y works). Thank you for the help--love the Sankey option! |
Curious if there are any plans to merge the more recent
d3-sankey
support for node alignment (from this commit, June 13 of this year) into your fork? It's a really useful feature that I'd love to be able to use with your great wrapper.The text was updated successfully, but these errors were encountered: