Remove Math.sign #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

alexcjohnson opened this issue Jun 9, 2017 · 1 comment

Assignees

Labels

bug

Collaborator

alexcjohnson commented Jun 9, 2017

Math.sign is not supported in IE, even IE11. Currently we only seem to have this in gl2d/camera
https://github.com/plotly/plotly.js/blob/master/src/plots/gl2d/camera.js#L134
https://github.com/plotly/plotly.js/blob/master/src/plots/gl2d/camera.js#L152

We should remove these and include Math.sign (any other IE quirks?) in our syntax tests.

The text was updated successfully, but these errors were encountered:

alexcjohnson added the bug label

alexcjohnson self-assigned this

alexcjohnson mentioned this issue

No innerHTML and pseudo-html cleanup #1792

Merged

2 tasks

Collaborator Author

alexcjohnson commented Jun 19, 2017

fixed by #1792

alexcjohnson closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment