Skip to content

Don't make a request for geo topojson layers when no layers are visible #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
collioud opened this issue Jun 2, 2017 · 4 comments
Closed
Labels
community community contribution feature something new

Comments

@collioud
Copy link

collioud commented Jun 2, 2017

Hello,

I noticed that when creating a scatter geo plot, the file https://cdn.plot.ly/world_110m.json seem to be automatically requested.

Is there an option to block this call, since I mostly plot sky maps (no need for continents, etc.) ?

Thanks!
Arnaud

@etpinard
Copy link
Contributor

etpinard commented Jun 2, 2017

I mostly plot sky maps

Well that's not what scattegeo was designed to do.

Maybe we should add a scattersky trace type 😆

@collioud
Copy link
Author

collioud commented Jun 2, 2017

☺ why not?

More seriously, it is similar to plot positions on Earth and sky positions: Right Ascension is longitude and Declination is latitude. I can provide a codepen if you are interested...

Cheers

@etpinard
Copy link
Contributor

etpinard commented Jun 2, 2017

I can provide a codepen if you are interested...

Sure, that would be nice 😄


More seriously, we could add a clause so that this block is skipped when all the geo show* attributes are set to false.

This won't be a priority for us for the foreseeable future, but we'll review community PR (maybe from you, if up for a challenge) that implement this feature.

@etpinard etpinard added community community contribution feature something new labels Jun 2, 2017
@collioud
Copy link
Author

collioud commented Jun 3, 2017

Here is a (quick and dirty) codepen example:
https://codepen.io/anon/pen/rwNvvd?editors=0010
If you look carefully, you could even recognize few constellations. For example, the "W" of Cassiopeia :
https://codepen.io/anon/pen/QgWrzg?editors=0010


I have no experience in preparing PR, so if I write this one, I will need some help...

@etpinard etpinard changed the title Scatter geo and world_110m.json Don't make a request for geo topojson layers when no layers are visible Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new
Projects
None yet
Development

No branches or pull requests

2 participants