-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Decreased show/hide trace performance #1623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for posting. This is probably a side effect of #1432 |
This perf decrease in indeed a side-effect of #1432 where we added double click interactions on legend items. @MarvinGee #1432 was first released in This perf 📉 is due to this To mitigate the problem, we could add a config option to disable double-click interactions on legend items which would remove that Fixing the problem will be a little trickier. We can't make double-clicks first call the single-click I get the feeling that we should drop those legend double click interactions in @rpaskowitz @alexcjohnson any thoughts on this? |
I find some of the hover behaviour and the checkmark not going away but the series just becoming faded a bit weird, but here's an example of how Richshaw does it - http://code.shutterstock.com/rickshaw/examples/legend.html The checkmarks control series visibility in the way that a single click does in Plotly, while clicking on the series name causes just that series to be shown. Another pattern I've seen, but can't find an example of offhand is to show an 'Only' button beside or on a series, normally tied to a hover event. |
I like the idea of an "only" button that appears on hover - perhaps an 👁 icon at the right edge of the label? I don't think that would need to wait for v2, as no functionality would disappear, we'd just turn a doubleclick into a more specific single-click. It would also make this feature more discoverable 🎉 |
Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson |
Hello,
I upgraded my plotly version from 1.16.0 to 1.25.0. With this update the delay when showing or hiding a trace got noticably longer. I tried to reproduce the issue in this codepen. When changing the plotly version from 1.16.0 to 1.25.0 in the html part the difference becomes apparent, when showing or hiding a trace.
1.16.0 feels very responsive, almost instant, whereas 1.25.0 has a very noticable lag.
The text was updated successfully, but these errors were encountered: