Skip to content

plotly is using __proto__ which slows down the script?! #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcinwojciechowski opened this issue Mar 6, 2017 · 1 comment
Closed

Comments

@marcinwojciechowski
Copy link

Hello,
I have found that in FF browser i got a warning telling:
"mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create"

When I search the net what does that means I have found this stackoverflow ticket: http://stackoverflow.com/questions/23807805/why-is-mutating-the-prototype-of-an-object-bad-for-performance

Can you say something about that? Does it really impact the performance?

Best regards,
Marcin

@rreusser
Copy link
Contributor

rreusser commented Mar 6, 2017

It appears to be a d3 3.x issue which I would hazard to guess is aggressively worded to encourage "best practices". I'd be surprised if it actually has much of an effect except in very pathological cases. At any rate, there will be no fix for d3 3.x, so I don't think there's anything to be done about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants