You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you zoom into a choropleth (say for example http://localhost:3000/devtools/test_dashboard/#geo_country-names) and hover on a region that goes off the edge, the hover label can get lost. Here's one where you just see the bottom of the Russia label (and if I zoom in a little more it disappears entirely):
The label should get pushed down onto the plot, like we do with regular cartesian types:
One thing that may help a bit: the hover labels don't need to be clipped to the same viewport as the plot: the tip of the arrow should be constrained to that viewport, but the rest of the label can go outside (as long as the whole thing stays withingd)
The text was updated successfully, but these errors were encountered:
the hover labels don't need to be clipped to the same viewport as the plot
Yeah. That would be a nice improvement to start. Choropleth hover labels should be drawn in the <g infolayer> node. While at it, we should 🔪 that useless <div geo-container>:
and put the geo nodes in the main <svg>.
Down the road, to better handle edge cases, we should consider extending the hoveron: 'fill' hover placement algo to geo polygons.
If you zoom into a choropleth (say for example http://localhost:3000/devtools/test_dashboard/#geo_country-names) and hover on a region that goes off the edge, the hover label can get lost. Here's one where you just see the bottom of the Russia label (and if I zoom in a little more it disappears entirely):

The label should get pushed down onto the plot, like we do with regular cartesian types:

One thing that may help a bit: the hover labels don't need to be clipped to the same viewport as the plot: the tip of the arrow should be constrained to that viewport, but the rest of the label can go outside (as long as the whole thing stays within
gd
)The text was updated successfully, but these errors were encountered: