-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Can't use any bundlers other than browserify #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
plotly.js is a heavy user of browserify transforms, not just glslify. Adapting the build tasks to other build systems won't be easy. May I ask, in what context are you trying to build plotly.js? If you can't make the switch to browserify, maybe you should consider including plotly.js in a separate I hope this helps. |
I'm using webpack, since I have a lot of other things (e.g. loaders for babel, Elm, SASS) that I use with it and make a lot of use of the features there. Besides existing webpack loader work, there's some personal preference and other reasons why I don't want to use browserify. I also ran into a problem with trying to just bundle the |
@justinwoo See #14, |
@Hypercubed, ya, as far as i can tell that last line (dist/plotly.js:83327) is the only thing that limits use with requirejs. with a shim, i get what appears to be a good plotly object. i get the nasty error though. |
I'd also kindly suggest that d3 be removed from the bundle. I believe many of use will already have a copy of d3 installed, an additional copy in the bundle is redundant. Of course documentation would need to be clear that d3 should be added as a peer. |
This will not happen I'm afraid. We chose to have an all-in-one bundle for simplicity and robustness (as d3 in notoriously bad at following semver). Note that |
Fixed in See webpack example: https://gist.github.com/etpinard/f3d44dab330785368534 |
A |
There are a host of issues that have been discussed on other projects with
glslify
locking down bundling to only browserify.Shame since it looks like a normal module we can bundle with anything we want 😢
I don't know enough about this issue to propose a fix, but hopefully someone knows enough about this and make swapping out the browserify-specific easy.
The text was updated successfully, but these errors were encountered: