-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Passive Event Listener Support #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
How serious of an effect does this have? Looks like this should be a pretty easy PR to make. Maybe you could give a shot and we'll test out the performance benefits. cc @dfcreative |
+1 for this, i am experiencing some scrolling issues with multiple scatter plots. After 700 dots it becomes a bit problematic to have a smooth scroll, in chromium and firefox at least. |
Do we ship mobile support already? If we merge touch enabling PRs it is probable that scroll may have to be disabled. I would test that along with full mobile support. |
Any feedback on this? I'm "interlocking" chart xaxis ranges using the range selector and the scrolling performance is really bad. |
Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson |
It looks like plotly is binding event listeners to the wheel event here. From what I have read, this can seriously impact scrolling performance. I'm not sure about your compatibility targeting but I believe it should be possible to make this a passive event listener and improve performance while still maintaining compatibility for browsers that do not support this.
If you think this is a good idea I would be happy to submit a pull request.
The text was updated successfully, but these errors were encountered: