Skip to content

Re-look-up slider position when the options change #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rreusser opened this issue Dec 7, 2016 · 1 comment
Closed

Re-look-up slider position when the options change #1234

rreusser opened this issue Dec 7, 2016 · 1 comment
Labels
bug something broken feature something new

Comments

@rreusser
Copy link
Contributor

rreusser commented Dec 7, 2016

Imagine slider steps 1, 2, 3, 4, 5. 3 is active. Step 2 is removed. You were on the third step, now you're on the second. Since we track active by index, the slider no longer reflects the correct state.

#1233 partially addressed similar concerns so that nothing breaks, but fixing this would be a nice cosmetic addition. The only downside is whether it means a full scan on every update, which starts to feel like one more straw on the camel's back with full scans on every update.

@gvwilson
Copy link
Contributor

gvwilson commented Jun 6, 2024

Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson

@gvwilson gvwilson closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken feature something new
Projects
None yet
Development

No branches or pull requests

2 participants