Skip to content

Cast frame labels to strings everywhere they're used #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rreusser opened this issue Dec 6, 2016 · 3 comments
Closed

Cast frame labels to strings everywhere they're used #1224

rreusser opened this issue Dec 6, 2016 · 3 comments
Labels
bug something broken

Comments

@rreusser
Copy link
Contributor

rreusser commented Dec 6, 2016

Numbers keep sneaking through as valid frame labels or animate arguments, which then cause animations to totally fail. They should be cast to strings on some sort of supplydefault step, otherwise we should cast them to strings every time they're used.

Until then, a note to avoid integer labels, cc: @Kully @jp and… @empet ? is that the right callout?

@rreusser rreusser added the bug something broken label Dec 6, 2016
@etpinard
Copy link
Contributor

etpinard commented Feb 8, 2017

@rreusser was this completed in #1236?

@rreusser
Copy link
Contributor Author

rreusser commented Feb 8, 2017

Ah yes, I believe so. I think it's working fine. That PR was the day after this, so looks like a stray unclosed issue. 👍

@etpinard
Copy link
Contributor

etpinard commented Feb 8, 2017

Great. Thanks. Closing.

@etpinard etpinard closed this as completed Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

2 participants