Skip to content

Filter-transformed data not displaying markers correctly #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rreusser opened this issue Oct 11, 2016 · 2 comments
Closed

Filter-transformed data not displaying markers correctly #1027

rreusser opened this issue Oct 11, 2016 · 2 comments
Labels
bug something broken

Comments

@rreusser
Copy link
Contributor

rreusser commented Oct 11, 2016

Seen on current master branch. Live example: http://codepen.io/rsreusser/pen/GjdxLL?editors=0010

Given this trace:

[{
  x: [1, 2, 3],
  y: [1, 2, 4],
  ids: ['a', 'a', 'a'],
  transforms: [{
    type: 'filter',
    filtersrc: 'ids',
    operation: '{}',
    value: ['a']
  }]
}]

I'd expect it to show markers at all three points. It only shows one marker. I'm not missing or confusing something, am I?

screen shot 2016-10-11 at 13 29 32

@rreusser rreusser added the bug something broken label Oct 11, 2016
@rreusser rreusser changed the title Filter-transformed data not displaying correctly Filter-transformed data not displaying markers correctly Oct 11, 2016
@rreusser
Copy link
Contributor Author

Reason is obvious in hindsight: ids is equivalent to a d3 key property. The ids aren't unique, so it only draws one point.

@rreusser
Copy link
Contributor Author

Closing this in favor of moving remaining discussion to #1028.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

1 participant